[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 5: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. IMPALA-7923: DecimalValue should be marked as p

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 5: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 5: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 5: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 5: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Verified-1 Build failed: https://jenkins.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I was a little scared since Q1 is a decimal-inten

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 4: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I did the test on parquet/none/none, scale factor

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-06 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I'm in the process of loading the tables for TPCH

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: Code-Review+2 (1 comment) GOod point about fixin

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: Code-Review+1 (1 comment) lgtm I am also inter

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I think scale factor 2 might be too small to get

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I run single node perf tests on TPCH with scale f

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. Patch Set 3: I took a quick pass and this seems fine in concep

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16134 ) Change subject: IMPALA-7923: DecimalValue should be marked as packed .. IMPALA-7923: DecimalValue should be marked as packed IMPALA-7473

[Impala-ASF-CR] IMPALA-7923: DecimalValue should be marked as packed

2020-07-01 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16134 Change subject: IMPALA-7923: DecimalValue should be marked as packed .. IMPALA-7923: DecimalValue should be marked as packed IMPALA-747