[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r47428935 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -469,13 +495,13 @@ class Word2VecModel private[spark] ( this(Word

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r47428877 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -77,6 +77,19 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-12158] [SparkR] [SQL] Fix 'sample' func...

2015-12-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-164118736 Thank you, everyone! : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-12258] [SQL] passing null into ScalaUDF...

2015-12-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10266#discussion_r47428568 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala --- @@ -1029,24 +1029,27 @@ case class ScalaUDF( /

[GitHub] spark pull request: [SPARK-9003] [MLlib] Add mapActive{Pairs,Value...

2015-12-11 Thread yanboliang
Github user yanboliang closed the pull request at: https://github.com/apache/spark/pull/7357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11574][Core] Add metrics StatsD sink

2015-12-11 Thread xflin
Github user xflin commented on the pull request: https://github.com/apache/spark/pull/9518#issuecomment-164114988 StatsdSink unit tests have been added. I've also tested the patch on a spark v1.5.2 deployment with datadog agent installed. Datadog agent contains a (slightly en

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164113472 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164113471 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164113454 **[Test build #47609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47609/consoleFull)** for PR 10273 at commit [`9320bf8`](https://g

[GitHub] spark pull request: [SPARK-12158] [SparkR] [SQL] Fix 'sample' func...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-11978] [ML] Move dataset_example.py to ...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9957 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-12217] [ML] Document invalid handling f...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164112268 **[Test build #47609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47609/consoleFull)** for PR 10273 at commit [`9320bf8`](https://gi

[GitHub] spark pull request: [SPARK-12153][MLlib]add support of arbitrary l...

2015-12-11 Thread ygcao
Github user ygcao commented on the pull request: https://github.com/apache/spark/pull/10152#issuecomment-164112022 update codes: 1. passed lint-scala check by adding spaces and cut comment line lengths 2. removed distance functions as we discussed, including the existing zombie

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-11 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/10268#issuecomment-16490 LGTM except minor issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-11 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10268#discussion_r47427436 --- Diff: python/pyspark/ml/tuning.py --- @@ -151,9 +154,11 @@ def __init__(self, estimator=None, estimatorParamMaps=None, evaluator=None, numF

[GitHub] spark pull request: [SPARK-9690][ML][PYTHON] pyspark CrossValidato...

2015-12-11 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/10268#discussion_r47427431 --- Diff: python/pyspark/ml/tuning.py --- @@ -129,9 +130,11 @@ class CrossValidator(Estimator): numFolds = Param(Params._dummy(), "numFolds", "num

[GitHub] spark pull request: [SPARK-11978] [ML] Move dataset_example.py to ...

2015-12-11 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/9957#issuecomment-164110737 @jkbradley Would you mind to check the merging status of this PR? I did not found it merging into master. Thanks! --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12158] [SparkR] [SQL] Fix 'sample' func...

2015-12-11 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-164110535 Sorry @gatorsmile -- I missed this PR for a couple of days. LGTM. Merging this to master and `branch-1.6`. Regarding whether this will make 1.6 release, it depends on

[GitHub] spark pull request: [SPARK-12300][SQL][PYSPARK] fix schmea inferan...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10275#issuecomment-164110412 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12300][SQL][PYSPARK] fix schmea inferan...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10275#issuecomment-164110404 **[Test build #47608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47608/consoleFull)** for PR 10275 at commit [`6e463fd`](https://g

[GitHub] spark pull request: [SPARK-12300][SQL][PYSPARK] fix schmea inferan...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10275#issuecomment-164110414 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

2015-12-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164110300 I see. However, for 1.6, we still need to support Akka RPC. Is it possible to get the client address from `ActorRef`? --- If your project is set up for it, you can re

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

2015-12-11 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10201#issuecomment-164110115 @felixcheung Was there a migration guide entry for `withColumn` changing in Scala / Python. If so, we can also add one to a SparkR migration guide. At a high level, ad

[GitHub] spark pull request: [SPARK-12300][SQL][PYSPARK] fix schmea inferan...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10275#issuecomment-164109994 **[Test build #47608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47608/consoleFull)** for PR 10275 at commit [`6e463fd`](https://gi

[GitHub] spark pull request: [SPARK-12300][SQL][PYSPARK] fix schmea inferan...

2015-12-11 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/10275 [SPARK-12300][SQL][PYSPARK] fix schmea inferance on local collections Current schema inference for local python collections halts as soon as there are no NullTypes. This is different than when we s

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10272#issuecomment-164108452 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10272#issuecomment-164108453 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10272#issuecomment-164108430 **[Test build #47606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47606/consoleFull)** for PR 10272 at commit [`ddb26da`](https://g

[GitHub] spark pull request: [SPARK-12267][Core]Store the remote RpcEnv add...

2015-12-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10261#issuecomment-164107825 > I saw your following comment...But I don't get it. That's because we took opposite approaches. Your PR's approach is "if this connection says the sender addres

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164107812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164107811 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164107677 **[Test build #47607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47607/consoleFull)** for PR 10273 at commit [`d93c55a`](https://g

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/10273#discussion_r47426529 --- Diff: examples/src/main/java/org/apache/spark/examples/BasicAuthFilter.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/10273#discussion_r47426522 --- Diff: examples/src/main/java/org/apache/spark/examples/BasicAuthFilter.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10274#issuecomment-164106136 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-12302][EXAMPLES] Example for basic auth...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10273#issuecomment-164105914 **[Test build #47607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47607/consoleFull)** for PR 10273 at commit [`d93c55a`](https://gi

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2015-12-11 Thread iyounus
GitHub user iyounus opened a pull request: https://github.com/apache/spark/pull/10274 [SPARK-12230][ML] WeightedLeastSquares.fit() should handle division by zero properly if standard deviation of target variable is zero. This fixes the behavior of WeightedLeastSquars.fit() when the

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10272#issuecomment-164105692 **[Test build #47606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47606/consoleFull)** for PR 10272 at commit [`ddb26da`](https://gi

[GitHub] spark pull request: [SPARK-12302] Example for basic authentication...

2015-12-11 Thread Lewuathe
GitHub user Lewuathe opened a pull request: https://github.com/apache/spark/pull/10273 [SPARK-12302] Example for basic authentication filter used by spark.u… …i.filters Although `spark.ui.filters` configuration uses simple servlet filter, it is often difficult to unders

[GitHub] spark pull request: [SPARK-9578] [ML] Stemmer feature transformer

2015-12-11 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/10272 [SPARK-9578] [ML] Stemmer feature transformer jira: https://issues.apache.org/jira/browse/SPARK-9578 Classical Porter stemmer, which is implemented referring to scalanlp/chalk * [[http

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164105183 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164105185 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164105160 **[Test build #47605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47605/consoleFull)** for PR 9936 at commit [`5b4c500`](https://git

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164104527 **[Test build #47605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47605/consoleFull)** for PR 9936 at commit [`5b4c500`](https://gith

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10271#issuecomment-164104457 Thanks! Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11504][SQL] API audit for distributeBy ...

2015-12-11 Thread ankurdave
Github user ankurdave commented on a diff in the pull request: https://github.com/apache/spark/pull/9470#discussion_r47425842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -620,6 +608,32 @@ class DataFrame private[sql]( } /** +

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10271#issuecomment-164103776 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10271#issuecomment-164103777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10271#issuecomment-164103738 **[Test build #47603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47603/consoleFull)** for PR 10271 at commit [`d9f8c25`](https://g

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164103662 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164103622 **[Test build #47604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47604/consoleFull)** for PR 9936 at commit [`3b02d4e`](https://gith

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164103661 **[Test build #47604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47604/consoleFull)** for PR 9936 at commit [`3b02d4e`](https://git

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164103663 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11938][ML] Expose numFeatures in all ML...

2015-12-11 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/9936#issuecomment-164102964 @yanboliang I made test code to avoid recreation of datasets. Could you check again please? --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-12276][Core] Prevent RejectedExecutionE...

2015-12-11 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10267#issuecomment-164100820 I am not sure if that patch solves this problem. As there is still the bug [reported](http://stackoverflow.com/questions/34065209/java-util-concurrent-rejectedexecutionex

[GitHub] spark pull request: [SPARK-12276][Core] Prevent RejectedExecutionE...

2015-12-11 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/10267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-11978] [ML] Move dataset_example.py to ...

2015-12-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9957#issuecomment-164096401 I don't have any comments; it LGTM I ran it locally, and it worked fine. Merging with master and branch-1.6 Thanks for the PR! --- If your projec

[GitHub] spark pull request: [SPARK-11497] [MLlib] [Python] PySpark RowMatr...

2015-12-11 Thread dusenberrymw
Github user dusenberrymw commented on the pull request: https://github.com/apache/spark/pull/9458#issuecomment-164095361 Great, thanks @jkbradley! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11978] [ML] Move dataset_example.py to ...

2015-12-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9957#issuecomment-164095322 Reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [RFC] Add type-safe config keys to SparkConf.

2015-12-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-164094852 > IIRC there was a similar patch you wrote a while ago that was shot down for some reason Yes. That patch tried to centralize all config key definitions in `Sp

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

2015-12-11 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/10201#issuecomment-164094104 SQL and MLlib have a "Migration guide" section, perhaps something like that? http://spark.apache.org/docs/latest/sql-programming-guide.html#migration-guide In f

[GitHub] spark pull request: [SPARK-12276][Core] Prevent RejectedExecutionE...

2015-12-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10267#issuecomment-164092733 Yes, I forgot about that patch. This should not be a problem anymore, and this isn't the correct fix even if it is. @viirya would you mind closing this? --- If your

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10271#issuecomment-164092361 **[Test build #47603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47603/consoleFull)** for PR 10271 at commit [`d9f8c25`](https://gi

[GitHub] spark pull request: [SPARK-12298][SQL] Fix infinite loop in DataFr...

2015-12-11 Thread ankurdave
GitHub user ankurdave opened a pull request: https://github.com/apache/spark/pull/10271 [SPARK-12298][SQL] Fix infinite loop in DataFrame.sortWithinPartitions Modifies the String overload to call the Column overload and ensures this is called in a test. You can merge this pull requ

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164089518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164089519 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164089453 **[Test build #47602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47602/consoleFull)** for PR 10269 at commit [`e96556e`](https://g

[GitHub] spark pull request: [SPARK-12213] [SQL] use multiple partitions fo...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10228#issuecomment-164089027 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12213] [SQL] use multiple partitions fo...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10228#issuecomment-164089106 **[Test build #2212 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2212/consoleFull)** for PR 10228 at commit [`71e0b1c`](https://

[GitHub] spark pull request: [SPARK-12213] [SQL] use multiple partitions fo...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10228#issuecomment-164089028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12213] [SQL] use multiple partitions fo...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10228#issuecomment-164088946 **[Test build #47601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47601/consoleFull)** for PR 10228 at commit [`71e0b1c`](https://g

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-11 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/10265#discussion_r47421414 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -364,7 +364,7 @@ private[sql] abstract class SparkStrate

[GitHub] spark pull request: [SPARK-12273][STREAMING] Make Spark Streaming ...

2015-12-11 Thread proflin
Github user proflin commented on the pull request: https://github.com/apache/spark/pull/10264#issuecomment-164087083 Thanks @zsxwing for reviewing so soon :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-11 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/10265#issuecomment-164086130 The failure seems not related to this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164085630 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12213] [SQL] use multiple partitions fo...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10228#issuecomment-164085613 **[Test build #2211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2211/consoleFull)** for PR 10228 at commit [`740e725`](https://

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164085631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12281][Core]Fix a race condition when r...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10269#issuecomment-164085553 **[Test build #47593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47593/consoleFull)** for PR 10269 at commit [`bedaead`](https://g

[GitHub] spark pull request: SPARK-12105 - SPARK-SQL add convenient show fu...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10130#issuecomment-164085089 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: SPARK-12105 - SPARK-SQL add convenient show fu...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10130#issuecomment-164085087 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-12105 - SPARK-SQL add convenient show fu...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10130#issuecomment-164084957 **[Test build #47594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47594/consoleFull)** for PR 10130 at commit [`219d75c`](https://g

[GitHub] spark pull request: [SPARK-1537] [YARN] [WiP] Add history provider...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5423#issuecomment-164084776 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-1537] [YARN] [WiP] Add history provider...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5423#issuecomment-164084775 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-1537] [YARN] [WiP] Add history provider...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5423#issuecomment-164084728 **[Test build #47596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47596/consoleFull)** for PR 5423 at commit [`e134e29`](https://git

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-164084086 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-164084088 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-164083850 **[Test build #47595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47595/consoleFull)** for PR 8744 at commit [`fe0c7b7`](https://git

[GitHub] spark pull request: [SPARK-12158] [SparkR] [SQL] Fix 'sample' func...

2015-12-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10160#issuecomment-164082851 @shivaram Will it be merged before the release of 1.6? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10215#issuecomment-164081626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10215#issuecomment-164081631 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10215#issuecomment-164081248 **[Test build #47597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47597/consoleFull)** for PR 10215 at commit [`48e049b`](https://g

[GitHub] spark pull request: [SPARK-12217] [ML] Document invalid handling f...

2015-12-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10257#issuecomment-164081063 Merging with master and branch-1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-11608][MLLIB][DOC] Added migration guid...

2015-12-11 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10235#issuecomment-164080820 CC @thunterdb Could you please check this? The content should be OK since @mengxr verified it previously. --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-11 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/10247#discussion_r47417343 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/rows.scala --- @@ -211,6 +211,18 @@ class GenericRowWithSchema(values: Arra

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-11 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/10247#discussion_r47417301 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala --- @@ -325,6 +341,14 @@ trait Row extends Serializable { def getAs[T](i: Int): T

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10265#issuecomment-164074635 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10265#issuecomment-164074632 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12275][SQL] No plan for BroadcastHint i...

2015-12-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10265#issuecomment-164074515 **[Test build #47592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47592/consoleFull)** for PR 10265 at commit [`1b8d570`](https://g

  1   2   3   4   >