Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21416
LGTM (I didn't look that carefully though)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional command
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21416
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3656/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21416
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user xdcjie commented on the issue:
https://github.com/apache/spark/pull/21447
@maropu I updated the commet. In summary, with this pr can reduce the time
of scan and assemble data. In our scenario, the relation(table) have 700
columns.
---
--
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21416
@rxin I simplified the test cases as you suggested. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21416
**[Test build #91242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91242/testReport)**
for PR 21416 at commit
[`fed2846`](https://github.com/apache/spark/commit/fe
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r191317978
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala ---
@@ -392,9 +396,97 @@ class ColumnExpressionSuite extends QueryTest wit
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r191317980
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala ---
@@ -392,9 +396,97 @@ class ColumnExpressionSuite extends QueryTest wit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21442#discussion_r191314972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -219,7 +219,14 @@ object ReorderAssociativeOperat
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21442#discussion_r191314675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -219,7 +219,14 @@ object ReorderAssociativeOperat
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21436
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21436#discussion_r191313872
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -1021,21 +1021,33 @@ object SparkSession extends Logging {
/**
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21436
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21443
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3655/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21443
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21447
Could you add explain result differences with/without this pr in the
description?
---
-
To unsubscribe, e-mail: reviews-unsubscr.
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21447#discussion_r191312085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -338,6 +338,17 @@ class AstBuilder(conf: SQLConf) extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21447
@gatorsmile Can you trigger this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21443
**[Test build #91241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91241/testReport)**
for PR 21443 at commit
[`29e6485`](https://github.com/apache/spark/commit/29
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21447
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21447
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user xdcjie opened a pull request:
https://github.com/apache/spark/pull/21447
[SPARK-24339][SQL]Add project for transform/map/reduce sql to prune column
## What changes were proposed in this pull request?
Transform query do not have Project Node, so that it will scan
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21378#discussion_r191310691
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -418,17 +417,33 @@ private
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21409
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91237/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21409
**[Test build #91237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91237/testReport)**
for PR 21409 at commit
[`8ffba61`](https://github.com/apache/spark/commit/8
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r191306678
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala ---
@@ -392,9 +396,97 @@ class ColumnExpressionSuite extends QueryTest with
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21416#discussion_r191306654
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala ---
@@ -392,9 +396,97 @@ class ColumnExpressionSuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21443#discussion_r191306683
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
---
@@ -151,7 +152,7 @@ object RewriteDistinct
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21443#discussion_r191306423
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -687,4 +687,12 @@ class DataFrameAggregateSuite extends QueryTest
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21437
cc @ueshin @HyukjinKwon @BryanCutler
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18717
The target of this ticket is 2.4?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21438
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91234/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21438
**[Test build #91234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91234/testReport)**
for PR 21438 at commit
[`eb87d2d`](https://github.com/apache/spark/commit/e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21443
cc @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21443#discussion_r191302814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
---
@@ -151,7 +152,7 @@ object RewriteDist
Github user LiangchangZ commented on the issue:
https://github.com/apache/spark/pull/21445
> Looks like the patch is needed only with #21353 #21332 #21293 as of now,
right? If then please
> state the condition in JIRA issue description as well as PR's description
so that we don't
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21409#discussion_r191302688
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DataSourceWriteBenchmark.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licen
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21446
Thank you for review and merging, @HyukjinKwon . Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apa
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21443#discussion_r191302155
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -687,4 +687,12 @@ class DataFrameAggregateSuite extends Query
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21409#discussion_r191302141
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DataSourceWriteBenchmark.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licen
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r191299100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -523,6 +523,8 @@ case class JsonToStructs(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r191298921
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -523,6 +523,8 @@ case class JsonToStructs(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21439#discussion_r191298844
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -523,6 +523,8 @@ case class JsonToStructs(
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21439
Can we also accept primitive arrays in `to_json`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21409#discussion_r191297180
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/DataSourceWriteBenchmark.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
ing
MBP:~/src/ssuchter-spark% echo $REVISION
1d8a265d13
MBP:~/src/ssuchter-spark% echo $DATE
20180528
MBP:~/src/ssuchter-spark% ./dev/make-distribution.sh --name
${DATE}-${REVISION} --tgz -DzincPort=${ZINC_PORT} -Phadoop-2.7 -Pkubernetes
-Pkinesis-asl -Phive -Phive-th
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21370
@viirya @gatorsmile @ueshin @felixcheung @HyukjinKwon
The refactor about generating html code out of `Dataset.scala` was done in
94f3414. Please help to check whether it is appropriate when
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3654/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21426
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3653/
Tes
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/21445
```
Looks like the patch is needed only with #21353 #21332 #21293 as of now,
right?
```
@HeartSaVioR Yes, sorry for the late explanation. The background is we are
running POC based
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21426
**[Test build #91240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91240/testReport)**
for PR 21426 at commit
[`f015e0d`](https://github.com/apache/spark/commit/f0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #91239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91239/testReport)**
for PR 13599 at commit
[`44500fc`](https://github.com/apache/spark/commit/44
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21420
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21420
Thanks @HyukjinKwon !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21420
Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13599
(Oops, the test failure was legitimate.)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional co
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21437
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13599
Actually lets also loop in @ifilonenko who's been thinking about similar
things but with more of a K8s bent.
---
-
To unsubscrib
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21437
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91233/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21437
**[Test build #91233 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91233/testReport)**
for PR 21437 at commit
[`b9d8dd3`](https://github.com/apache/spark/commit/b
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/13599
It's certainly closer, I haven't had a chance to take a look super recently
(been focused on the PySpark K8s integration). I'm still hesitant about this
merged as-is from a skim through, but maybe a
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21446
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21444
@mozammal mind closing this please?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional command
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21446
Merged to master and branch-2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #91238 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91238/testReport)**
for PR 13599 at commit
[`d9a5f00`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91238/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3652/
Tes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #91238 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91238/testReport)**
for PR 13599 at commit
[`d9a5f00`](https://github.com/apache/spark/commit/d9
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21446
Yea, I was facing this problem too. Thanks for fixing this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13599
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21409
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3651/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21409
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3522/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3522/
---
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3650/
Tes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21409
**[Test build #91237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91237/testReport)**
for PR 21409 at commit
[`8ffba61`](https://github.com/apache/spark/commit/8f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91236/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
**[Test build #91236 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91236/testReport)**
for PR 20697 at commit
[`1d8a265`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91235/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3649/
Tes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #91235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91235/testReport)**
for PR 13599 at commit
[`d9a5f00`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
**[Test build #91236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91236/testReport)**
for PR 20697 at commit
[`1d8a265`](https://github.com/apache/spark/commit/1d
Github user ssuchter commented on the issue:
https://github.com/apache/spark/pull/20697
Fixed the bug. @mccheah I'd appreciate your eyes on commit 1d8a265, for
both correctness and style. (I haven't used Scala before this project, so I'm
very not confidence in the best way to do thing
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13599
**[Test build #91235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91235/testReport)**
for PR 13599 at commit
[`d9a5f00`](https://github.com/apache/spark/commit/d9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21438
**[Test build #91234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91234/testReport)**
for PR 21438 at commit
[`eb87d2d`](https://github.com/apache/spark/commit/eb
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21438#discussion_r191285757
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
---
@@ -159,7 +159,7 @@ class SQLAppStatusListener(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21438
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21446
Thank you for reviewing, @felixcheung and @HeartSaVioR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21288#discussion_r191283013
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -131,211 +132,214 @@ object FilterPushdownBe
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21378#discussion_r191271894
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -418,17 +417,34 @@ private
1 - 100 of 307 matches
Mail list logo
