Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22014
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21118#discussion_r208472316
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceReader.java
---
@@ -76,5 +76,5 @@
* If this method fails (by th
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22014
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21939
> We are already not testing all the combinations and at least I manually
test other combinations locally. For the minimum PyArrow upgrade for Spark
itself in the code base, wouldn't we better mak
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208469262
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21027#discussion_r208468846
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala ---
@@ -63,6 +63,8 @@ private[spark] abstract class RestSubmissionServ
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21027#discussion_r208468697
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala
---
@@ -50,6 +50,24 @@ private[spark] class Mesos
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208468677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected[
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21027#discussion_r208468594
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala ---
@@ -331,3 +345,15 @@ private class ErrorServlet extends RestServle
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21027#discussion_r208468305
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionServer.scala ---
@@ -63,6 +63,8 @@ private[spark] abstract class RestSubmissionServ
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208468429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[s
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21027#discussion_r208467704
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -160,7 +161,10 @@ trait MesosSch
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21939
Upping PyArrow to 0.10.0 sounds fine to me within the Jenkins environment
considering 2.4.0 is being close.
We are already not testing all the combinations and at least I manually
test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94402/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22014
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208466779
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[sq
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22014
**[Test build #94402 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94402/testReport)**
for PR 22014 at commit
[`b9c11d5`](https://github.com/apache/spark/commit/b
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21118#discussion_r208466428
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceReader.java
---
@@ -76,5 +76,5 @@
* If this method fails (by
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94403/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21733
**[Test build #94403 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94403/testReport)**
for PR 21733 at commit
[`e0ee04a`](https://github.com/apache/spark/commit/e
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21939
SGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21952
do we have the same regression for parquet? wondering if the regression
comes from the `FileFormat` framework.
---
-
To unsubs
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/22022
Merged to branch 2.2, please close this PR @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For ad
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21027
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208462120
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22033
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> just for clarification, so now .. there no outstanding bugs, some tests
are ignored per #21320 (comment) and left comments were mostly addressed. Did i
understand correctly?
The ignored t
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22033
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/21939
@shaneknapp I think we would be better off just upping the minimum version
of arrow to 0.10.0 here since it's pretty involved to get a test matrix up and
running and the project is still in a fa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94408/testReport)**
for PR 21889 at commit
[`23d03fb`](https://github.com/apache/spark/commit/23
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208460288
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208460101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected[
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94406/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21889
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94406 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94406/testReport)**
for PR 21889 at commit
[`23d03fb`](https://github.com/apache/spark/commit/2
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208459585
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208459448
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208459011
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected[
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22022
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22022
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94401/
Test PASSed.
---
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208458861
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[sq
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208458789
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected[
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22022
**[Test build #94401 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94401/testReport)**
for PR 22022 at commit
[`16233d1`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94399/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22033
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
just for clarification, so now .. there no outstanding bugs, some tests are
ignored per https://github.com/apache/spark/pull/21320#issuecomment-406353694
and left comments were mostly addressed.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22033
**[Test build #94399 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94399/testReport)**
for PR 22033 at commit
[`d248773`](https://github.com/apache/spark/commit/d
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208457801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21939
**[Test build #94407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94407/testReport)**
for PR 21939 at commit
[`0652617`](https://github.com/apache/spark/commit/06
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21939
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1935/
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208456902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21939
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208456164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22034
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22034
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22034
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user LantaoJin opened a pull request:
https://github.com/apache/spark/pull/22034
[SPARK-25054][CORE] Enable MetricsServlet sink for Executor
## What changes were proposed in this pull request?
The MetricsServlet sink is added by default as a sink in the master. But
t
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208453178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -403,20 +415,29 @@ class RelationalGroupedDataset protected[
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94396/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21845
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21845
**[Test build #94396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94396/testReport)**
for PR 21845 at commit
[`08b4ebe`](https://github.com/apache/spark/commit/0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21977#discussion_r208449418
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/AggregateInPandasExec.scala
---
@@ -137,13 +135,12 @@ case class AggregateInPandasEx
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22030#discussion_r208451663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[sq
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
See https://github.com/apache/spark/pull/21320#issuecomment-406353694 for
@gatorsmile's request to move the changes to `ParquetReadSupport.scala` to
another PR.
There was another, unrelated
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94397/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21608
**[Test build #94397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94397/testReport)**
for PR 21608 at commit
[`70eddc8`](https://github.com/apache/spark/commit/7
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
@HyukjinKwon Thanks for looking into this. It is based on the comment and
discussion here
https://github.com/apache/spark/pull/21193#discussion_r186627099.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
That comment is before
https://github.com/apache/spark/pull/21889#issuecomment-408330791. I am okay in
general but want to be clear if I'm ignoring his decision or not.
---
--
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
>> but @gatorsmile wants to review it in a follow-on PR.
> Where did he say it after the comment above?
It was my interpretation of this comment:
https://github.com/apache/spark/pu
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
> but @gatorsmile wants to review it in a follow-on PR.
I need a confirmation from @gatorsmile. I don't want to ignore his decision
here in
> Just FYI, we are unable to merge it
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21889
**[Test build #94406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94406/testReport)**
for PR 21889 at commit
[`23d03fb`](https://github.com/apache/spark/commit/23
Github user ajacques commented on the issue:
https://github.com/apache/spark/pull/21889
@HyukjinKwon Looks like most of your comments have been already addressed,
but I've gone ahead and made a few more tweaks to help this get merged. Please
let me know if any blocking comments have b
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
> but @gatorsmile wants to review it in a follow-on PR.
Where did he say it after the comment above?
Also why don't you address my comments if you're going to push more changes
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22029
Is there a clear definition for the expected behavior? I tried postgre
before, it returns null for things like `(x, y) = (a, null)`, but throws
analysis error for things like `(x, (y, z)) = (a, (n
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/21889
> Assuming from #21889 (comment), we shouldn't have any identified bug
here. What kind of bugs left to be fixed?
That bug was address by b50ddb4. We still need to fix the bug underlying
the
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/21889#discussion_r208446828
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -0,0 +1,205 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22013
**[Test build #94405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94405/testReport)**
for PR 22013 at commit
[`150a6a5`](https://github.com/apache/spark/commit/15
Github user codeatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r20844
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -181,4 +187,46 @@ class HigherOrder
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22032
**[Test build #94400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94400/testReport)**
for PR 22032 at commit
[`e76cd81`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22032
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94400/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22032
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r208444793
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -442,3 +442,91 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r208444629
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2117,6 +2117,65 @@ class DataFrameFunctionsSuite extends QueryTe
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r208445048
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -442,3 +442,91 @@ case class ArrayAggregat
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r208445494
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2117,6 +2117,65 @@ class DataFrameFunctionsSuite extends QueryTe
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22027
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22027
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22013
**[Test build #94404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94404/testReport)**
for PR 22013 at commit
[`5806ac4`](https://github.com/apache/spark/commit/58
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21520
@viirya ~ I was just trying to read the PRs. Would you please mind if I ask
where is the "Based on previous discussion" ?
---
--
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21977
Does this work by setting some container configs? Maybe we can apply this
to k8s later, cc @liyinan926
---
-
To unsubscribe, e
Github user sddyljsx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r208441135
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SmallDataSortBenchmark.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to t
Github user sddyljsx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r208441067
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SmallDataSortBenchmark.scala
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to t
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208440273
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
---
@@ -93,21 +81,17 @@ case class DataSourceV
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
Assuming from
https://github.com/apache/spark/pull/21889#issuecomment-408330791, we shouldn't
have any identified bug here. What kind of bugs left to be fixed?
---
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21889
Can we address the comments I left on that PR too? Looks that's the only
way to get through this? FWIW, since
https://github.com/apache/spark/commit/51bee7aca13451167fa3e701fcd60f023eae5e61
is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208439973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
---
@@ -39,52 +36,43 @@ case class DataSourceV
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208439720
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
---
@@ -51,18 +58,19 @@ class DataSourceRDD[T: ClassT
1 - 100 of 684 matches
Mail list logo