[GitHub] spark pull request #22177: [SPARK-25119][Web UI] stages in wrong order withi...

2018-08-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22177#discussion_r212134229 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -18,18 +18,18 @@ package org.apache.spark.ui.jobs import java.util

[GitHub] spark issue #22188: [SPARK-25164][SQL] Avoid rebuilding column and path list...

2018-08-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22188 LGTM. Will leave here for a bit to see if anyone else comments... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22191 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95125/ Test FAILed. ---

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22191 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22191 **[Test build #95125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95125/testReport)** for PR 22191 at commit [`eec0ad0`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22191 **[Test build #95125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95125/testReport)** for PR 22191 at commit [`eec0ad0`](https://github.com/apache/spark/commit/ee

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22191 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22191 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22191: [SPARK-25204][SS] Fix race in rate source test.

2018-08-22 Thread jose-torres
GitHub user jose-torres opened a pull request: https://github.com/apache/spark/pull/22191 [SPARK-25204][SS] Fix race in rate source test. ## What changes were proposed in this pull request? Fix a race in the rate source tests. We need a better way of testing restart behavio

[GitHub] spark issue #22188: [SPARK-25164][SQL] Avoid rebuilding column and path list...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22188 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95118/ Test PASSed. ---

[GitHub] spark issue #22188: [SPARK-25164][SQL] Avoid rebuilding column and path list...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22188 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22188: [SPARK-25164][SQL] Avoid rebuilding column and path list...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22188 **[Test build #95118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95118/testReport)** for PR 22188 at commit [`697de21`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212126595 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -51,7 +57,13 @@ private[

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95117/ Test PASSed. ---

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22187 **[Test build #95117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95117/testReport)** for PR 22187 at commit [`0626de7`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22190 **[Test build #95124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95124/testReport)** for PR 22190 at commit [`6dbc6e0`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95124/ Test FAILed. ---

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22157 **[Test build #4285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4285/testReport)** for PR 22157 at commit [`9afdac6`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

2018-08-22 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22190#discussion_r212121224 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/MicroBatchWriteSupport.scala --- @@ -18,27 +18,38 @@ package org.apa

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22190 **[Test build #95124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95124/testReport)** for PR 22190 at commit [`6dbc6e0`](https://github.com/apache/spark/commit/6d

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2462/

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

2018-08-22 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22190#discussion_r212120878 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/BatchPartitionOverwriteSupport.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95123/ Test FAILed. ---

[GitHub] spark issue #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write API.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22190 **[Test build #95123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95123/testReport)** for PR 22190 at commit [`e3fcc83`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

2018-08-22 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22190#discussion_r212120411 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/BatchPartitionOverwriteSupport.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

2018-08-22 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22190#discussion_r212119716 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/BatchOverwriteSupport.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request #22190: [SPARK-25188][SQL] Add WriteConfig to v2 write AP...

2018-08-22 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22190#discussion_r212118021 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -279,10 +277,7 @@ private[kafka010] class Ka

[GitHub] spark issue #22190: SPARK-25188: Add WriteConfig to v2 write API.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22190 **[Test build #95123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95123/testReport)** for PR 22190 at commit [`e3fcc83`](https://github.com/apache/spark/commit/e3

[GitHub] spark issue #22190: SPARK-25188: Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22190: SPARK-25188: Add WriteConfig to v2 write API.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22190 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2461/

[GitHub] spark pull request #22190: SPARK-25188: Add WriteConfig to v2 write API.

2018-08-22 Thread rdblue
GitHub user rdblue opened a pull request: https://github.com/apache/spark/pull/22190 SPARK-25188: Add WriteConfig to v2 write API. ## What changes were proposed in this pull request? This updates the v2 write path to a similar structure as the v2 read path. Individual write

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/22187 So the new solution now is to directly ship the `StructType` object as a reference object. Why not? ;-) I'm +1 on shipping the object directly instead of generating code to recreate it on th

[GitHub] spark pull request #22181: [SPARK-25163][SQL] Fix flaky test: o.a.s.util.col...

2018-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22181 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22181: [SPARK-25163][SQL] Fix flaky test: o.a.s.util.collection...

2018-08-22 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/22181 LGTM. Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21330 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21330: [SPARK-22234] Support distinct window functions

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2460/

[GitHub] spark issue #21332: [SPARK-24236][SS] Continuous replacement for ShuffleExch...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21332 **[Test build #95122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95122/testReport)** for PR 21332 at commit [`06c6cfb`](https://github.com/apache/spark/commit/06

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22157 cc @gatorsmile and @cloud-fan . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22160: Revert "[SPARK-24418][BUILD] Upgrade Scala to 2.1...

2018-08-22 Thread dbtsai
Github user dbtsai closed the pull request at: https://github.com/apache/spark/pull/22160 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22160: Revert "[SPARK-24418][BUILD] Upgrade Scala to 2.11.12 an...

2018-08-22 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22160 Closed this PR since we're in favor of https://github.com/apache/spark/pull/21749 --- - To unsubscribe, e-mail: reviews-unsubscr.

[GitHub] spark issue #22177: [SPARK-25119][Web UI] stages in wrong order within job p...

2018-08-22 Thread yunjzhang
Github user yunjzhang commented on the issue: https://github.com/apache/spark/pull/22177 my fault, just fixed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #21749: [SPARK-24785] [SHELL] Making sure REPL prints Spark UI i...

2018-08-22 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21749 @srowen It does work, and I have used it for my development recently. You should be able to build with my branch to test it out. I was trying to merge two source trees yesterday, and I realized I nee

[GitHub] spark issue #22174: [SPARK-22779][SQL] Fallback config defaults should behav...

2018-08-22 Thread GregOwen
Github user GregOwen commented on the issue: https://github.com/apache/spark/pull/22174 Closing this for now since it seems like this might break existing workflows --- - To unsubscribe, e-mail: reviews-unsubscr...@s

[GitHub] spark pull request #22174: [SPARK-22779][SQL] Fallback config defaults shoul...

2018-08-22 Thread GregOwen
Github user GregOwen closed the pull request at: https://github.com/apache/spark/pull/22174 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread raofu
Github user raofu commented on the issue: https://github.com/apache/spark/pull/22157 @dongjoon-hyun, thanks lot for the pointers! I've update the PR description. Please let me know if there is any other information you'd like me to add. --- -

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95111/ Test PASSed. ---

[GitHub] spark issue #22177: [SPARK-25199][Web UI] stages in wrong order within job p...

2018-08-22 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22177 Probably you put wrong JIRA in the title. `SPARK-25199` -> `SPARK-25119` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22171 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22171: [SPARK-25177][SQL] When dataframe decimal type column ha...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22171 **[Test build #95111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95111/testReport)** for PR 22171 at commit [`97de5d8`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22157 Jenkins is usually retriggered when it detects the change. Maybe, it seems to be busy. - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/SparkPullRequestBui

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22157 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-22 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 Not sure what is up with the build here; worked with mvn locally. Possibly my use of a java 8 lamda-expression as the hook? --- --

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22136 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22136 **[Test build #95120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95120/testReport)** for PR 22136 at commit [`a211d51`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22136 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95120/ Test PASSed. ---

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-22 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22112 > Without making shuffle output order repeatable, we do not have a way to properly fix this. Perhaps I'm missing it, but you are saying shuffle here, but just shuffle itself can't fix thi

[GitHub] spark issue #22157: [SPARK-25126][SQL] Avoid creating Reader for all orc fil...

2018-08-22 Thread raofu
Github user raofu commented on the issue: https://github.com/apache/spark/pull/22157 @dongjoon-hyun Title updated. Thanks for adding the test coverage! I've merged your commit. Can you help kick off another Jenkins run? I don't think I have the permission to do it. ---

[GitHub] spark issue #22063: [WIP][SPARK-25044][SQL] Address translation of LMF closu...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22063 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2459/

[GitHub] spark issue #22063: [WIP][SPARK-25044][SQL] Address translation of LMF closu...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22063 **[Test build #95121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95121/testReport)** for PR 22063 at commit [`09c3a3b`](https://github.com/apache/spark/commit/09

[GitHub] spark issue #22063: [WIP][SPARK-25044][SQL] Address translation of LMF closu...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22063 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22136 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2458/

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22136 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22185: [SPARK-25127] DataSourceV2: Remove SupportsPushDownCatal...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22185 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95110/ Test PASSed. ---

[GitHub] spark issue #22185: [SPARK-25127] DataSourceV2: Remove SupportsPushDownCatal...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22185 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22136 **[Test build #95120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95120/testReport)** for PR 22136 at commit [`a211d51`](https://github.com/apache/spark/commit/a2

[GitHub] spark issue #22185: [SPARK-25127] DataSourceV2: Remove SupportsPushDownCatal...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22185 **[Test build #95110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95110/testReport)** for PR 22185 at commit [`3c4115d`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSi...

2018-08-22 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/22136#discussion_r212088986 --- Diff: python/pyspark/ml/tests.py --- @@ -844,6 +844,28 @@ def test_string_indexer_from_labels(self): .select(model_default.getOrDefau

[GitHub] spark issue #22157: [SPARK-25126] Avoid creating Reader for all orc files

2018-08-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22157 Thank you for pinging me, @srowen . @raofu Instead of changing the existing test coverage, we had better add additional test cases which all files are corrupted. --- ---

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22187 **[Test build #95119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95119/testReport)** for PR 22187 at commit [`86c9c5b`](https://github.com/apache/spark/commit/86

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2457/

[GitHub] spark issue #22187: [SPARK-25178][SQL] change the generated code of the keyS...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22187 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21977: SPARK-25004: Add spark.executor.pyspark.memory limit.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21977 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #21977: SPARK-25004: Add spark.executor.pyspark.memory limit.

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21977 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95108/ Test FAILed. ---

[GitHub] spark issue #21977: SPARK-25004: Add spark.executor.pyspark.memory limit.

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21977 **[Test build #95108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95108/testReport)** for PR 21977 at commit [`505f2eb`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21334: [SPARK-24345][SQL]Improve ParseError stop location when ...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21334 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22182: [SPARK-25184][SS] Fixed race condition in StreamE...

2018-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22182 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20637: [SPARK-23466][SQL] Remove redundant null checks in gener...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20637 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20637: [SPARK-23466][SQL] Remove redundant null checks in gener...

2018-08-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20637 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95109/ Test PASSed. ---

[GitHub] spark issue #20637: [SPARK-23466][SQL] Remove redundant null checks in gener...

2018-08-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20637 **[Test build #95109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95109/testReport)** for PR 20637 at commit [`34a4f7b`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22112: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-08-22 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/22112 Catching up on discussion ... @cloud-fan > shuffled RDD will never be deterministic unless the shuffle key is the entire record and key ordering is specified. Let me rephrase t

[GitHub] spark pull request #22121: [SPARK-25133][SQL][Doc]Avro data source guide

2018-08-22 Thread dhruve
Github user dhruve commented on a diff in the pull request: https://github.com/apache/spark/pull/22121#discussion_r212075677 --- Diff: docs/avro-data-source-guide.md --- @@ -0,0 +1,377 @@ +--- +layout: global +title: Apache Avro Data Source Guide +--- + +* Th

[GitHub] spark pull request #22187: [SPARK-25178][SQL] change the generated code of t...

2018-08-22 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22187#discussion_r212075572 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -44,31 +44,19 @@ class RowBasedHashMapGenera

[GitHub] spark issue #22177: [SPARK-25199][Web UI] stages in wrong order within job p...

2018-08-22 Thread yunjzhang
Github user yunjzhang commented on the issue: https://github.com/apache/spark/pull/22177 thanks for the suggestion, just rename the PR. before fix ![image](https://user-images.githubusercontent.com/27383592/44485113-7fdbee80-a604-11e8-8587-c7f1ae559549.png) after fix

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-22 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22176 Yes, this is better than what we had, but maybe it can be better still. --- - To unsubscribe, e-mail: reviews-unsubscr...@spa

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212072262 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -81,9 +97,9 @@ privat

[GitHub] spark issue #22176: [SPARK-25181][CORE] Limit Thread Pool size in BlockManag...

2018-08-22 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/22176 @markhamstra That's a good point. However, since this is just following our current codes if you check the usages of `newDaemonCachedThreadPool`, and the changes here should be safe considering how

[GitHub] spark issue #21749: [SPARK-24785] [SHELL] Making sure REPL prints Spark UI i...

2018-08-22 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21749 Talked with @zsxwing . We do not need to revert the version bump, as long as this PR does not introduce a new regression. BTW, merging to the RC branches should be treated as backporting

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212070807 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -81,9 +97,9 @@ privat

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212069991 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -96,3 +112,25 @@ priv

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212068833 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala --- @@ -74,8 +74,15 @@ private[spark] object Cons

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212069720 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -16,11 +16,17 @@

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-22 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r212068140 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala --- @@ -0,0 +1,51 @@ +/*

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-08-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r212070669 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +161,17 @@ public TransportChannelHandler initia

[GitHub] spark pull request #22136: [SPARK-25124][ML]VectorSizeHint setSize and getSi...

2018-08-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/22136#discussion_r212069129 --- Diff: python/pyspark/ml/tests.py --- @@ -844,6 +844,28 @@ def test_string_indexer_from_labels(self): .select(model_default.getOrDefau

[GitHub] spark pull request #22187: [SPARK-25178][SQL] change the generated code of t...

2018-08-22 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22187#discussion_r212062744 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -44,31 +44,19 @@ class RowBasedHashMapGener

[GitHub] spark pull request #22187: [SPARK-25178][SQL] change the generated code of t...

2018-08-22 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22187#discussion_r212062022 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -44,31 +44,19 @@ class RowBasedHashMapGener

<    1   2   3   4   5   6   7   >