[GitHub] spark issue #22897: [SPARK-25875][k8s] Merge code to set up driver command i...

2018-10-30 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22897 Please take a look at the parent bug before commenting on this patch in isolation: https://issues.apache.org/jira/browse/SPARK-25874 ---

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22896 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22896 **[Test build #98275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98275/testReport)** for PR 22896 at commit [`f0fea61`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #22897: [SPARK-25875][k8s] Merge code to set up driver co...

2018-10-30 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/22897 [SPARK-25875][k8s] Merge code to set up driver command into a single step. Right now there are 3 different classes dealing with building the driver command to run inside the pod, one for each "bi

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98275/ Test PASSed. ---

[GitHub] spark issue #22880: [SPARK-25407][SQL] Ensure we pass a compatible pruned sc...

2018-10-30 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22880 I can confirm that this fixes https://issues.apache.org/jira/browse/SPARK-25879 cc @cloud-fan @gatorsmile Thanks. ---

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22896 **[Test build #98275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98275/testReport)** for PR 22896 at commit [`f0fea61`](https://github.com/apache/spark/commit/f0

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4634/

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22896 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22896: [SPARKR]found some extra whitespace in the R tests

2018-10-30 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22896 i am confused, though, as to why this wasn't caught during the PR that added this file: https://github.com/apache/spark/pull/22455 on the centos workers, there was an error message in

[GitHub] spark pull request #22896: found some extra whitespace in the R tests

2018-10-30 Thread shaneknapp
GitHub user shaneknapp opened a pull request: https://github.com/apache/spark/pull/22896 found some extra whitespace in the R tests ## What changes were proposed in this pull request? during my ubuntu-port testing, i found some extra whitespace that for some reason wasn't g

[GitHub] spark issue #22818: [SPARK-25827][CORE] Allocate arrays smaller than Int.Max...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22818 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22818: [SPARK-25827][CORE] Allocate arrays smaller than Int.Max...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22818 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4633/

[GitHub] spark pull request #22617: [SPARK-25484][SQL][TEST] Refactor ExternalAppendO...

2018-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22617#discussion_r229419433 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/ExternalAppendOnlyUnsafeRowArrayBenchmark.scala --- @@ -68,9 +100,7 @@ object Extern

[GitHub] spark pull request #22771: [SPARK-25773][Core]Cancel zombie tasks in a resul...

2018-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22771 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98268/ Test PASSed. ---

[GitHub] spark issue #22818: [SPARK-25827][CORE] Allocate arrays smaller than Int.Max...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22818 **[Test build #98274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98274/testReport)** for PR 22818 at commit [`3d77303`](https://github.com/apache/spark/commit/3d

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22713: [SPARK-25691][SQL] Use semantic equality in AliasViewChi...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22713 **[Test build #98268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98268/testReport)** for PR 22713 at commit [`0e49e91`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-30 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/22771 Thanks! Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #22771: [SPARK-25773][Core]Cancel zombie tasks in a result stage...

2018-10-30 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/22771 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark pull request #22881: [SPARK-25855][CORE] Don't use erasure coding for ...

2018-10-30 Thread xiao-chen
Github user xiao-chen commented on a diff in the pull request: https://github.com/apache/spark/pull/22881#discussion_r229403073 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -471,4 +473,42 @@ object SparkHadoopUtil { hadoopConf.set(ke

[GitHub] spark issue #22805: [SPARK-25809][K8S][TEST] New K8S integration testing bac...

2018-10-30 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22805 Did a bunch more testing on our internal K8S clusters today after rebasing this onto master. I am now happy that this is ready for final review and merging so I have removed the `[WIP]` tag --- --

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229400780 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala --- @@ -42,6 +42,9 @@ private[spar

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229399189 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala ---

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229395036 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala ---

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229394011 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/data-populator-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the A

[GitHub] spark issue #22849: [SPARK-25852][Core] we should filter the workOffers with...

2018-10-30 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/22849 It may happen that a busy executor is marked as lost and later it re-register to the driver, in that case currently we call `makeOffers()` and that will add the executor into `TaskSchedulerImpl.

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229391389 --- Diff: bin/docker-image-tool.sh --- @@ -53,7 +53,7 @@ function build { # contain a lot of duplicated jars with the main Spark directory. In a

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4632/

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4632/ --- --

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229389845 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/data-populator-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the A

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98273/ Test PASSed. ---

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98273/testReport)** for PR 22146 at commit [`3707e6a`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22849: [SPARK-25852][Core] we should filter the workOffers with...

2018-10-30 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/22849 What do you mean by "better performance" ? If that means we can spend less time on `TaskSchedulerImpl.resourceOffers()` then I agree it's true, but AFAIK it's never reported this can be a bottle

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229386227 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/data-populator-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the A

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4632/ ---

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22146 **[Test build #98273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98273/testReport)** for PR 22146 at commit [`3707e6a`](https://github.com/apache/spark/commit/37

[GitHub] spark pull request #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks t...

2018-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22845 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22845 Thank you, @heary-cao . Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22895: [SPARK-25886][SQL][Minor] Improve error message of `Fail...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22895 **[Test build #98272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98272/testReport)** for PR 22895 at commit [`4982e35`](https://github.com/apache/spark/commit/49

[GitHub] spark issue #22895: [SPARK-25886][SQL][Minor] Improve error message of `Fail...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22895 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4631/

[GitHub] spark issue #22895: [SPARK-25886][SQL][Minor] Improve error message of `Fail...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22895 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22844 Since this is JSON benchmark, could you merge this, @HyukjinKwon ? :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spa

[GitHub] spark pull request #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks ...

2018-10-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22844#discussion_r229376327 --- Diff: sql/core/benchmarks/JSONBenchmarks-results.txt --- @@ -0,0 +1,33 @@ +===

[GitHub] spark pull request #22895: [SPARK-25886][SQL] Improve error message of `Fail...

2018-10-30 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22895 [SPARK-25886][SQL] Improve error message of `FailureSafeParser` and `from_avro` in FAILFAST mode ## What changes were proposed in this pull request? Currently in `FailureSafeParser`

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229373938 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/nn-deployment.yml --- @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Softwa

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229372458 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/data-populator-service.yml --- @@ -0,0 +1,33 @@ +# +# Licensed to the Apac

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229373845 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/kerberos-test.yml --- @@ -0,0 +1,43 @@ +# +# Licensed to the Apache Softwa

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229372327 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/data-populator-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the A

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229370867 --- Diff: dev/make-distribution.sh --- @@ -191,7 +191,8 @@ fi # Only create and copy the dockerfiles directory if the kubernetes artifacts were buil

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229371556 --- Diff: resource-managers/kubernetes/docker/src/test/scripts/populate-data.sh --- @@ -0,0 +1,42 @@ +#!/usr/bin/env bash +# +# Licensed to t

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229370525 --- Diff: bin/docker-image-tool.sh --- @@ -53,7 +53,7 @@ function build { # contain a lot of duplicated jars with the main Spark directory. In a

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229373633 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/kerberos-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the Apache

[GitHub] spark pull request #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integr...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22608#discussion_r229373205 --- Diff: resource-managers/kubernetes/integration-tests/kerberos-yml/dn1-deployment.yml --- @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Softw

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22881 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22881 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4630/

[GitHub] spark pull request #22884: [SPARK-23429][CORE][FOLLOWUP] MetricGetter should...

2018-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22884 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22881 **[Test build #98271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98271/testReport)** for PR 22881 at commit [`0a54c7d`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22881 **[Test build #98271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98271/testReport)** for PR 22881 at commit [`0a54c7d`](https://github.com/apache/spark/commit/0a

[GitHub] spark issue #22884: [SPARK-23429][CORE][FOLLOWUP] MetricGetter should rename...

2018-10-30 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22884 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r229367166 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala --- @@ -74,8 +74,16 @@ private[spark] object Constan

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-10-30 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r229367415 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -16,11 +16,17 @@ *

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22881 **[Test build #4398 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4398/testReport)** for PR 22881 at commit [`bb12e39`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229366533 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/cloud/KubeConfigBackend.scala --

[GitHub] spark pull request #22805: [WIP][SPARK-25809][K8S][TEST] New K8S integration...

2018-10-30 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22805#discussion_r229367224 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala ---

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22881 **[Test build #4398 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4398/testReport)** for PR 22881 at commit [`bb12e39`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPredicates ...

2018-10-30 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/17520 @gatorsmile Sure Sean. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-10-30 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r229363078 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,959 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPredicates ...

2018-10-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17520 @dilipbiswal Could you take this over? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22778: [SPARK-25784][SQL] Infer filters from constraints...

2018-10-30 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22778#discussion_r229362181 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -171,10 +171,13 @@ abstract class Optimizer(sessio

[GitHub] spark pull request #22778: [SPARK-25784][SQL] Infer filters from constraints...

2018-10-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22778#discussion_r229361802 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -171,10 +171,13 @@ abstract class Optimizer(session

[GitHub] spark issue #22624: [SPARK-23781][CORE] Merge token renewer functionality in...

2018-10-30 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22624 any more comments @ifilonenko @skonto ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #22778: [SPARK-25784][SQL] Infer filters from constraints...

2018-10-30 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22778#discussion_r229356678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -171,10 +171,13 @@ abstract class Optimizer(session

[GitHub] spark issue #22788: [SPARK-25769][SQL]escape nested columns by backtick each...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22788 **[Test build #98270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98270/testReport)** for PR 22788 at commit [`7ff2696`](https://github.com/apache/spark/commit/7f

[GitHub] spark issue #22788: [SPARK-25769][SQL]escape nested columns by backtick each...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22788 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22788: [SPARK-25769][SQL]escape nested columns by backtick each...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22788 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4629/

[GitHub] spark pull request #22788: [SPARK-25769][SQL]escape nested columns by backti...

2018-10-30 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/22788#discussion_r229354247 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2856,6 +2856,21 @@ class SQLQuerySuite extends QueryTest with SharedSQ

[GitHub] spark issue #22881: [SPARK-25855][CORE] Don't use erasure coding for event l...

2018-10-30 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22881 jenkins, retest this please known flaky: https://issues.apache.org/jira/browse/SPARK-24285 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22844 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98266/ Test PASSed. ---

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22892 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98269/ Test PASSed. ---

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22852 **[Test build #98269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98269/testReport)** for PR 22852 at commit [`ebf4789`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #22892: [SPARK-25884][SQL] Add TBLPROPERTIES and COMMENT, and us...

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22892 **[Test build #98266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98266/testReport)** for PR 22892 at commit [`1cc1657`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22844 Lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-30 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229328064 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1374,4 +1377,182 @@ class AvroSuite extends QueryTest with Share

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-30 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229329920 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1374,4 +1377,182 @@ class AvroSuite extends QueryTest with Share

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-30 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229326520 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroEncoder.scala --- @@ -0,0 +1,534 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-30 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229332500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1617,6 +1617,58 @@ case class InitializeJav

[GitHub] spark pull request #22878: [SPARK-25789][SQL] Support for Dataset of Avro

2018-10-30 Thread bdrillard
Github user bdrillard commented on a diff in the pull request: https://github.com/apache/spark/pull/22878#discussion_r229323278 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroEncoder.scala --- @@ -0,0 +1,534 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4628/

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22852 added sections to the resource manager sections. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark issue #22852: [SPARK-25023] Clarify Spark security documentation

2018-10-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22852 **[Test build #98269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98269/testReport)** for PR 22852 at commit [`ebf4789`](https://github.com/apache/spark/commit/eb

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-30 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22755 thanks @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

<    1   2   3   4   5   >