[GitHub] [spark] dongjoon-hyun commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871976333 Thank you, @gengliangwang ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
SparkQA commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871976287 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44995/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871974830 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44994/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33167: [SPARK-35963][SQL] Rename TimestampWithoutTZType to TimestampNTZType

2021-06-30 Thread GitBox
SparkQA commented on pull request #33167: URL: https://github.com/apache/spark/pull/33167#issuecomment-871973681 **[Test build #140494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140494/testReport)** for PR 33167 at commit [`f197b73`](https://github.com

[GitHub] [spark] gengliangwang commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
gengliangwang commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871973068 +1, late LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871972433 **[Test build #140493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140493/testReport)** for PR 31517 at commit [`34d31fd`](https://github.com

[GitHub] [spark] gengliangwang opened a new pull request #33167: [SPARK-35963][SQL] Rename TimestampWithoutTZType to TimestampNTZType

2021-06-30 Thread GitBox
gengliangwang opened a new pull request #33167: URL: https://github.com/apache/spark/pull/33167 ### What changes were proposed in this pull request? Rename TimestampWithoutTZType to TimestampNTZType ### Why are the changes needed? The time name of `TimestampW

[GitHub] [spark] SparkQA commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2021-06-30 Thread GitBox
SparkQA commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871971809 **[Test build #140489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140489/testReport)** for PR 29326 at commit [`d5e8ff8`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871971844 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140489/ -- This

[GitHub] [spark] SparkQA commented on pull request #33070: [SPARK-35551][SQL] Handle the COUNT bug for lateral subqueries

2021-06-30 Thread GitBox
SparkQA commented on pull request #33070: URL: https://github.com/apache/spark/pull/33070#issuecomment-871971729 **[Test build #140492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140492/testReport)** for PR 33070 at commit [`a74a7c5`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871971508 Thank you so much, @HyukjinKwon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon closed pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
HyukjinKwon closed pull request #33166: URL: https://github.com/apache/spark/pull/33166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-un

[GitHub] [spark] HyukjinKwon commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871971272 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] AmplabJenkins commented on pull request #33093: [SPARK-35897][SS] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33093: URL: https://github.com/apache/spark/pull/33093#issuecomment-871971040 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140488/ -- This

[GitHub] [spark] SparkQA commented on pull request #33093: [SPARK-35897][SS] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
SparkQA commented on pull request #33093: URL: https://github.com/apache/spark/pull/33093#issuecomment-871971002 **[Test build #140488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140488/testReport)** for PR 33093 at commit [`e2234a8`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871967290 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140486/ -

[GitHub] [spark] SparkQA commented on pull request #32787: [SPARK-35618][SQL] Resolve star expressions in subqueries using outer query plans

2021-06-30 Thread GitBox
SparkQA commented on pull request #32787: URL: https://github.com/apache/spark/pull/32787#issuecomment-871969800 **[Test build #140491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140491/testReport)** for PR 32787 at commit [`0346d3b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
SparkQA commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871969612 **[Test build #140490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140490/testReport)** for PR 33166 at commit [`bd75c77`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32832: [SPARK-35686][SQL] Not allow using auto-generated alias when creating view

2021-06-30 Thread GitBox
SparkQA commented on pull request #32832: URL: https://github.com/apache/spark/pull/32832#issuecomment-871968715 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44996/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2021-06-30 Thread GitBox
SparkQA commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-871968320 **[Test build #140489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140489/testReport)** for PR 29326 at commit [`d5e8ff8`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33093: [SPARK-35897][SS] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
SparkQA commented on pull request #33093: URL: https://github.com/apache/spark/pull/33093#issuecomment-871967459 **[Test build #140488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140488/testReport)** for PR 33093 at commit [`e2234a8`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871966976 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140479/ -

[GitHub] [spark] SparkQA commented on pull request #33160: [SPARK-35959][BUILD] Add a new Maven profile "no-shaded-hadoop-client" for older Hadoop 3.x versions

2021-06-30 Thread GitBox
SparkQA commented on pull request #33160: URL: https://github.com/apache/spark/pull/33160#issuecomment-871967458 **[Test build #140487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140487/testReport)** for PR 33160 at commit [`37130a9`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33158: [SPARK-35888][SQL][FOLLOWUP] Return partition specs for all the shuffles

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33158: URL: https://github.com/apache/spark/pull/33158#issuecomment-871966979 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140474/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871966977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871967290 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140486/ -- This

[GitHub] [spark] dongjoon-hyun closed pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
dongjoon-hyun closed pull request #33166: URL: https://github.com/apache/spark/pull/33166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-

[GitHub] [spark] AmplabJenkins commented on pull request #33158: [SPARK-35888][SQL][FOLLOWUP] Return partition specs for all the shuffles

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33158: URL: https://github.com/apache/spark/pull/33158#issuecomment-871966979 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140474/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871966976 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140479/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871966977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] allisonwang-db commented on a change in pull request #32787: [SPARK-35618][SQL] Resolve star expressions in subqueries using outer query plans

2021-06-30 Thread GitBox
allisonwang-db commented on a change in pull request #32787: URL: https://github.com/apache/spark/pull/32787#discussion_r662017168 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ## @@ -807,4 +807,48 @@ class AnalysisEr

[GitHub] [spark] dongjoon-hyun commented on pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33166: URL: https://github.com/apache/spark/pull/33166#issuecomment-871962210 cc @srowen , @HyukjinKwon , @gengliangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [spark] dongjoon-hyun opened a new pull request #33166: [SPARK-35962][DOCS] Deprecate old Java 8 versions prior to 8u201

2021-06-30 Thread GitBox
dongjoon-hyun opened a new pull request #33166: URL: https://github.com/apache/spark/pull/33166 ### What changes were proposed in this pull request? This PR aims to deprecate old Java 8 versions prior to 8u201. ### Why are the changes needed? This is a preparation of usi

[GitHub] [spark] allisonwang-db commented on a change in pull request #32787: [SPARK-35618][SQL] Resolve star expressions in subqueries using outer query plans

2021-06-30 Thread GitBox
allisonwang-db commented on a change in pull request #32787: URL: https://github.com/apache/spark/pull/32787#discussion_r662013726 ## File path: sql/core/src/test/resources/sql-tests/results/join-lateral.sql.out ## @@ -80,6 +80,46 @@ struct 1 2 0 3 +-- !qu

[GitHub] [spark] SparkQA removed a comment on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871889034 **[Test build #140479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140479/testReport)** for PR 33163 at commit [`4a27d68`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871959359 **[Test build #140479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140479/testReport)** for PR 33163 at commit [`4a27d68`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871957487 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44997/ -- This

[GitHub] [spark] cxzl25 commented on pull request #33114: [SPARK-35913][SQL] Create hive permanent function with owner name

2021-06-30 Thread GitBox
cxzl25 commented on pull request #33114: URL: https://github.com/apache/spark/pull/33114#issuecomment-871956723 > Is it difficult to add some tests for this change? The fix itself seems fine to me. I checked some codes, because `HiveClientImpl` does not expose Hive native client, an

[GitHub] [spark] SparkQA removed a comment on pull request #33158: [SPARK-35888][SQL][FOLLOWUP] Return partition specs for all the shuffles

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33158: URL: https://github.com/apache/spark/pull/33158#issuecomment-871845187 **[Test build #140474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140474/testReport)** for PR 33158 at commit [`b8a0362`](https://gi

[GitHub] [spark] dongjoon-hyun commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871955004 Thank you for the confirmation, @sunchao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #33158: [SPARK-35888][SQL][FOLLOWUP] Return partition specs for all the shuffles

2021-06-30 Thread GitBox
SparkQA commented on pull request #33158: URL: https://github.com/apache/spark/pull/33158#issuecomment-871954871 **[Test build #140474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140474/testReport)** for PR 33158 at commit [`b8a0362`](https://github.co

[GitHub] [spark] sunchao commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
sunchao commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871953664 Thanks @dongjoon-hyun for pinging. Yes I think it's a good idea to keep the curator (and zookeeper?) version in sync with what come from Hadoop, similar to #28897. -- This is

[GitHub] [spark] Ngone51 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
Ngone51 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r662003768 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void sendMergedBlock

[GitHub] [spark] HeartSaVioR commented on pull request #31700: [SPARK-34183][SS] DataSource V2: Support required distribution and ordering in SS

2021-06-30 Thread GitBox
HeartSaVioR commented on pull request #31700: URL: https://github.com/apache/spark/pull/31700#issuecomment-871950154 Sorry I forgot this one. Given the fact that we don't have streaming plans and there's no plan to address this, I'm +1 to make existing micro-batch plan to allow distributio

[GitHub] [spark] sunchao commented on pull request #31700: [SPARK-34183][SS] DataSource V2: Support required distribution and ordering in SS

2021-06-30 Thread GitBox
sunchao commented on pull request #31700: URL: https://github.com/apache/spark/pull/31700#issuecomment-871946711 > I guess the primary discussion spot is here. I understand the streaming plans may not be ready. If so, I propose to just extend the existing micro-batch plans with the distrib

[GitHub] [spark] SparkQA removed a comment on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871938662 **[Test build #140485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140485/testReport)** for PR 32365 at commit [`ab09ff5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871944516 **[Test build #140485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140485/testReport)** for PR 32365 at commit [`ab09ff5`](https://github.co

[GitHub] [spark] ulysses-you commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
ulysses-you commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871941978 thank you all ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871938662 **[Test build #140485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140485/testReport)** for PR 32365 at commit [`ab09ff5`](https://github.com

[GitHub] [spark] cloud-fan closed pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
cloud-fan closed pull request #33165: URL: https://github.com/apache/spark/pull/33165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsu

[GitHub] [spark] cloud-fan commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
cloud-fan commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871938652 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937797 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44993/

[GitHub] [spark] SparkQA commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937786 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44993/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937797 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44993/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871519792 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] SparkQA commented on pull request #32832: [SPARK-35686][SQL] Not allow using auto-generated alias when creating view

2021-06-30 Thread GitBox
SparkQA commented on pull request #32832: URL: https://github.com/apache/spark/pull/32832#issuecomment-871937014 **[Test build #140484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140484/testReport)** for PR 32832 at commit [`da3998c`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
SparkQA commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871936855 **[Test build #140483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140483/testReport)** for PR 33157 at commit [`8a274c4`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936789 Looks good 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871936763 **[Test build #140482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140482/testReport)** for PR 33164 at commit [`ec89069`](https://github.com

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936677 > Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. > After branch cut, I'll try to switch the default to Scala 2.13 in master branch. >

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun edited a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936074 Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. After branch cut, I'll try to switch the default to Scala 2.13 in `master` branch

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871936166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140470/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44989/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871936161 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44991/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871936164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44992/

[GitHub] [spark] cloud-fan commented on a change in pull request #32832: [SPARK-35686][SQL] Not allow using auto-generated alias when creating view

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #32832: URL: https://github.com/apache/spark/pull/32832#discussion_r661988654 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -910,4 +910,45 @@ abstract class SQLViewSuite extends Que

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988603 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; Review comment: Moved

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988526 ## File path: core/src/main/java/org/apache/spark/SparkThrowable.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988466 ## File path: core/src/main/scala/org/apache/spark/SparkError.scala ## @@ -1,83 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936226 > Take your time, @LuciferYang . This should target Apache Spark 3.3 because Apache Spark 3.2 branch cut is July 1st. > > There are some busy cases today, we'll try to

[GitHub] [spark] AmplabJenkins commented on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871936166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140470/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871936164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44992/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871936161 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44991/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44989/ -- T

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988355 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; + +import java.io.*; +import

[GitHub] [spark] dongjoon-hyun commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936074 Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. After branch cut, I'll try to switch the default to Scala 2.13 in `master` branch. Of

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661987917 ## File path: core/src/main/java/org/apache/spark/SparkThrowable.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871935280 @dongjoon-hyun A question unrelated to this pr, do we have plans to make Scala 2.13 as default? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] LuciferYang removed a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871932774 ok ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [spark] LuciferYang commented on a change in pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on a change in pull request #31517: URL: https://github.com/apache/spark/pull/31517#discussion_r661986787 ## File path: common/network-shuffle/pom.xml ## @@ -58,6 +58,14 @@ slf4j-api provided + + com.github.ben-manes.caffeine +

[GitHub] [spark] SparkQA commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871933838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44989/ -- This is an automated message from the A

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871932774 ok ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871928722 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44992/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871928100 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44991/ -- This is an automated message from the A

[GitHub] [spark] dongjoon-hyun commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871927557 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [spark] dongjoon-hyun commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871927449 cc @sunchao since @nirousseau wrote the following in the JIRA. > Spark 3.2.0 aims to support Hadoop 3.3.1 ; this Hadoop release bundles the following shared libraries :

[GitHub] [spark] dongjoon-hyun commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871924006 Take your time, @LuciferYang . This should target Apache Spark 3.3 because Apache Spark 3.2 branch cut is July 1st. > There are some busy cases today, we'll try to fix t

[GitHub] [spark] SparkQA removed a comment on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871821101 **[Test build #140470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140470/testReport)** for PR 33038 at commit [`36cdeab`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
SparkQA commented on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871923225 **[Test build #140470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140470/testReport)** for PR 33038 at commit [`36cdeab`](https://github.co

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
HyukjinKwon edited a comment on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871912905 Shouldn't it fail instead of setting it as `0` or `null`? I feel like the handling should be done somewhere in `JacksonParser`. -- This is an automated message from

[GitHub] [spark] linhongliu-db commented on a change in pull request #32831: [SPARK-35685][SQL] Prompt recreating the view when there is an incompatible schema issue

2021-06-30 Thread GitBox
linhongliu-db commented on a change in pull request #32831: URL: https://github.com/apache/spark/pull/32831#discussion_r661975979 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -846,6 +846,30 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33146: URL: https://github.com/apache/spark/pull/33146#discussion_r661973792 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -406,19 +406,21 @@ abstract class CastBase extends

[GitHub] [spark] venkata91 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
venkata91 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661972672 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void sendMergedBlo

[GitHub] [spark] venkata91 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
venkata91 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661972672 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void sendMergedBlo

[GitHub] [spark] ulysses-you commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
ulysses-you commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871915784 cc @wangyum @cloud-fan @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [spark] SparkQA commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871915423 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44989/ -- This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871912905 Shouldn't it fail instead of setting it as `0`? I feel like the handling should be done somewhere in `JacksonParser`. -- This is an automated message from the Apache Git S

[GitHub] [spark] Ngone51 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
Ngone51 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661965448 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void sendMergedBlock

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871912023 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44992/ -- This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun commented on pull request #33070: [SPARK-35551][SQL] Handle the COUNT bug for lateral subqueries

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33070: URL: https://github.com/apache/spark/pull/33070#issuecomment-871911950 Gentle ping, @allisonwang-db . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   3   4   5   6   7   8   >