Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r76102697
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
---
@@ -21,26 +21,26 @@ import org.apache.hadoop.conf.Configur
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r76016944
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
---
@@ -21,26 +21,26 @@ import org.apache.hadoop.conf.Configura
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r76016337
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
---
@@ -21,26 +21,26 @@ import org.apache.hadoop.conf.Configura
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75986531
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
---
@@ -21,26 +21,26 @@ import org.apache.hadoop.conf.Configur
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75974295
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
---
@@ -21,26 +21,26 @@ import org.apache.hadoop.conf.Configura
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75963484
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCata
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75858056
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCatal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75857364
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala ---
@@ -31,7 +31,7 @@ class HiveDataFrameSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75813864
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -51,7 +51,8 @@ class MetastoreDataSourcesSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75813871
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -266,7 +266,7 @@ class ShowCreateTableSuite extends QueryTes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75813839
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -378,10 +378,9 @@ object SetMetastoreURLTest extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75813787
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala ---
@@ -31,7 +31,7 @@ class HiveDataFrameSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75813591
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCata
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75812578
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -51,7 +51,8 @@ class MetastoreDataSourcesSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75812586
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -266,7 +266,7 @@ class ShowCreateTableSuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75812566
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -378,10 +378,9 @@ object SetMetastoreURLTest extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75812417
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala ---
@@ -31,7 +31,7 @@ class HiveDataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75812142
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCatal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75810819
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75807732
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75806381
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75804665
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75804066
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75800807
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75800677
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCata
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75799684
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -41,13 +42,20 @@ import org.apache.spark.sql.types.{DataType,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75791305
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75791279
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -139,12 +139,9 @@ private[hive] class TestHiveSparkSession(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75790997
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -40,6 +40,15 @@ abstract class ExternalCatal
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14757#discussion_r75790947
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -41,13 +42,20 @@ import org.apache.spark.sql.types.{DataType,
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14757
[SPARK-17190] [SQL] Removal of HiveSharedState
### What changes were proposed in this pull request?
Since `HiveClient` is used to interact with the Hive metastore, it should
be hidden in `Hi
32 matches
Mail list logo
