[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r100174684 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -892,21 +892,58 @@ private[spark] class HiveExternalCatalog(

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r100038960 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala --- @@ -481,4 +484,30 @@ class PartitionProviderCom

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r18693 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala --- @@ -481,4 +484,30 @@ class PartitionProviderCompat

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r9328 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -892,21 +892,59 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r8413 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -892,21 +892,59 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r99981498 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -892,21 +892,61 @@ private[spark] class HiveExternalCatalog(co

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16837#discussion_r99980560 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -892,21 +892,61 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #16837: [SPARK-19359][SQL] renaming partition should not ...

2017-02-07 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16837 [SPARK-19359][SQL] renaming partition should not leave useless directories ## What changes were proposed in this pull request? when we rename a nested path, different file systems have di