Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17052
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r104651490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Source.scala
---
@@ -57,10 +60,31 @@ trait Source {
def getBatch(start:
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r104281176
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -31,6 +31,8 @@ abstract class LogicalPlan extend
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r103384682
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -989,7 +989,8 @@ class FileStreamSourceSuite extends
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r103385145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -231,8 +231,9 @@ abstract class SparkStrategies extends
Quer
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r103385054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1119,11 +1119,16 @@ case class DecimalAggregates(con
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r102922775
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -393,6 +393,17 @@ case class PreprocessTableInsertion(conf
Github user uncleGen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17052#discussion_r102922659
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -535,7 +535,8 @@ case class Range(
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/17052
[SPARK-19690][SS] Join a streaming DataFrame with a batch DataFrame which
has an aggregation may not work
## What changes were proposed in this pull request?
`StatefulAggregationStrategy`