Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18918
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18918#discussion_r151533419
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2029,4 +2029,13 @@ class DataFrameSuite extends QueryTest with
Shared
GitHub user heary-cao reopened a pull request:
https://github.com/apache/spark/pull/18918
[SPARK-21707][SQL]Improvement a special case for non-deterministic filters
in optimizer
## What changes were proposed in this pull request?
Currently, Did a lot of special handling for
Github user heary-cao closed the pull request at:
https://github.com/apache/spark/pull/18918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18918#discussion_r132921051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -522,6 +522,8 @@ object ColumnPruning extends Rule[Logi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18918#discussion_r132919858
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ColumnPruningSuite.scala
---
@@ -360,5 +360,34 @@ class ColumnPruningSuite ext
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18918#discussion_r132902343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -522,6 +522,8 @@ object ColumnPruning extends Rule[L
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18918#discussion_r132891196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -522,6 +522,8 @@ object ColumnPruning extends Rule[Logi