Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18956
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137681045
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137680999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137678987
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerSICheckerSuite.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137679007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType <:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137613115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -64,6 +64,14 @@ abstract class RuleExecutor[TreeType
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137611075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -93,6 +101,13 @@ abstract class RuleExecutor[TreeTyp
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137610235
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerSICheckerSuite.scala
---
@@ -0,0 +1,60 @@
+/*
+ * License
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r137609405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -93,6 +101,13 @@ abstract class RuleExecutor[TreeTyp
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r133360995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -37,6 +37,12 @@ import org.apache.spark.sql.types._
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18956#discussion_r133360047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -37,6 +37,12 @@ import org.apache.spark.sql.types._
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/18956
[SPARK-21726][SQL] Check for structural integrity of the plan in Optimzer
in test mode.
## What changes were proposed in this pull request?
We have many optimization rules now in `Optimzer`
12 matches
Mail list logo