Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20450
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165245334
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int rowId) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165242689
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165242471
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165242508
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarMap.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165242401
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -530,7 +530,7 @@ public int putByteArray(int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165067849
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int rowId) {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165231647
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarMap.java ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165231132
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165230542
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -530,7 +530,7 @@ public int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r165098764
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -215,10 +215,18 @@ public final ColumnarRow getStruct(int rowId) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r164997996
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -761,6 +761,43 @@ class ColumnarBatchSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r164996133
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -761,6 +761,43 @@ class ColumnarBatchSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r164995018
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -761,6 +761,43 @@ class ColumnarBatchSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r164993656
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -761,6 +761,43 @@ class ColumnarBatchSuite
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20450#discussion_r164986589
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -761,6 +761,43 @@ class ColumnarBatchSuite
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20450
[SPARK-23280][SQL] add map type support to ColumnVector
## What changes were proposed in this pull request?
Fill the last missing piece of `ColumnVector`: the map type support.
17 matches
Mail list logo