Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22932
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232444034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcOutputWriter.scala
---
@@ -36,11 +37,17 @@ private[orc] class Orc
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232443802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcOutputWriter.scala
---
@@ -36,11 +37,17 @@ private[orc] class OrcOut
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232430599
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -274,6 +278,15 @@ private[orc] class OrcOutputWriter(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232428893
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -274,6 +278,15 @@ private[orc] class OrcOutputWriter(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232428173
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcOutputWriter.scala
---
@@ -36,11 +41,17 @@ private[orc] class Orc
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232424657
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -274,6 +278,15 @@ private[orc] class OrcOutputWriter(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r232424626
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcOutputWriter.scala
---
@@ -36,11 +41,17 @@ private[orc] class OrcOut
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r231791191
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r231777190
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-08
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r231775619
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r231775020
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-08
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230610261
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -44,4 +44,13 @@ package object sql {
type Strategy = SparkStrategy
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230604337
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/package.scala ---
@@ -44,4 +44,13 @@ package object sql {
type Strategy = SparkStrategy
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230564513
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230563752
--- Diff:
sql/core/src/test/resources/sql-tests/results/describe-part-after-analyze.sql.out
---
@@ -93,7 +93,7 @@ Partition Values [ds=2017-08-
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22932#discussion_r230547020
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -314,6 +316,21 @@ abstract class OrcSuit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22932
[SPARK-25102][SQL] Write Spark version to ORC/Parquet file metadata
## What changes were proposed in this pull request?
Currently, Spark writes Spark version number into Hive Table pr
18 matches
Mail list logo