[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...

2017-09-06 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/19143 [SPARK-21932][SQL]Remove package name similar 'logical.Join' to 'Join' in JoinSelection ## What changes were proposed in this pull request? this PR to fix two problems: 1. simila

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19111 **[Test build #81444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81444/testReport)** for PR 19111 at commit [`5d156be`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19136 **[Test build #81441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81441/testReport)** for PR 19136 at commit [`a824d44`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19124 **[Test build #81443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81443/testReport)** for PR 19124 at commit [`46847f8`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19124 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81443/ Test FAILed. ---

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19111 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #81442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81442/testReport)** for PR 12646 at commit [`8a9adea`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19136 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81441/ Test FAILed. ---

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19124 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19136: [DO NOT MERGE][SPARK-15689][SQL] data source v2

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19136 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81442/ Test FAILed. ---

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19111 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81444/ Test FAILed. ---

[GitHub] spark issue #19020: [SPARK-3181] [ML] Implement huber loss for LinearRegress...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19020 big vote for python and R :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19134 re kafka -https://github.com/apache/spark/pull/19134#issuecomment-327180847 - pretty sure that is still needed for DStream - just as any API we shouldn't just remove it in point releases... --

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19134 I see @felixcheung . Since we have a solution to turn off Python Kafka unit test as mentioned by @vanzin , so it is fine to just mark as deprecated, not remove the code. Another thing is

[GitHub] spark issue #19137: [SPARK-21924][Docs] Update structured streaming programm...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19137 Merged to master/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19124 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark pull request #19128: Merge pull request #1 from apache/master

2017-09-06 Thread sphinx-jiang
Github user sphinx-jiang closed the pull request at: https://github.com/apache/spark/pull/19128 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.o

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19111 ah? ``` [error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-r ; process was terminated by signal 9 Attempting to post to Github... ``` ---

[GitHub] spark pull request #19128: Merge pull request #1 from apache/master

2017-09-06 Thread sphinx-jiang
Github user sphinx-jiang closed the pull request at: https://github.com/apache/spark/pull/19128 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.o

[GitHub] spark pull request #19128: Merge pull request #1 from apache/master

2017-09-06 Thread sphinx-jiang
GitHub user sphinx-jiang reopened a pull request: https://github.com/apache/spark/pull/19128 Merge pull request #1 from apache/master 9.5 update ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was thi

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19111 jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19142 I don't think this is worthwhile. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark pull request #19137: [SPARK-21924][Docs] Update structured streaming p...

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19137 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19111 **[Test build #81446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81446/testReport)** for PR 19111 at commit [`5d156be`](https://github.com/apache/spark/commit/5d

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19124 **[Test build #81445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81445/testReport)** for PR 19124 at commit [`46847f8`](https://github.com/apache/spark/commit/46

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19131 **[Test build #3913 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3913/testReport)** for PR 19131 at commit [`e7ce4e5`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19126 @marktab you can either close this or reopen vs branch-2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19131 **[Test build #3913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3913/testReport)** for PR 19131 at commit [`e7ce4e5`](https://github.com/apache/spark/commit/

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81447/testReport)** for PR 19130 at commit [`047578e`](https://github.com/apache/spark/commit/04

[GitHub] spark pull request #19144: Modify the title, 'Records' instead of 'Input Siz...

2017-09-06 Thread guoxiaolongzte
GitHub user guoxiaolongzte opened a pull request: https://github.com/apache/spark/pull/19144 Modify the title, 'Records' instead of 'Input Size' ## What changes were proposed in this pull request? Spark Streaming is processing data should be record, so the title should be 'Recor

[GitHub] spark issue #19144: Modify the title, 'Records' instead of 'Input Size'

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19144 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19144: Modify the title, 'Records' instead of 'Input Size'

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19144 I get it, but I don't think we use the "Records" terminology consistently in Spark, so not sure this is a worthwhile change. ---

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19131 What about other components, here you only fixed sql and core module. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #19141: [SPARK-21384] [YARN] Spark 2.2 + YARN without spark.yarn...

2017-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19141 Can you please describe your usage scenario and steps to reproduce your issue, from my understanding. Did you configure your default FS to a local FS? --- ---

[GitHub] spark issue #19141: [SPARK-21384] [YARN] Spark 2.2 + YARN without spark.yarn...

2017-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19141 Also looks like this is not a Spark 2.2 issue, would you please fix the PR title be more accurate about the problem? --- - To

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19131 wait, I'm still looking for it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-m

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81448/testReport)** for PR 18975 at commit [`e9c88b5`](https://github.com/apache/spark/commit/e9

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19131 Personally I'm not fond of such fix, this will break lots of existing PRs and force them to rebase again. Usually this could be addressed when fixing other issues. IMHO I don't encourage such PRs.

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81448/testReport)** for PR 18975 at commit [`e9c88b5`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81448/ Test FAILed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-06 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r137195530 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala --- @@ -142,7 +142,7 @@ private[v1] object AllStagesResource {

[GitHub] spark issue #19144: Modify the title, 'Records' instead of 'Input Size'

2017-09-06 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19144 StreamInputInfo data structure: case class StreamInputInfo( inputStreamId: Int, **numRecords: Long**, metadata: Map[String, Any] = Map.empty) { require(numRecords >= 0, "numR

[GitHub] spark issue #18991: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2017-09-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18991 Maybe, this seems not a scope on Apache Spark 2.3.0 because it's a debut of Apache ORC 1.4.0. I'll close this PR. Thank you all for giving advice on this PR. --- ---

[GitHub] spark issue #19142: When the number of attempting to restart receiver greate...

2017-09-06 Thread liuxianjiao
Github user liuxianjiao commented on the issue: https://github.com/apache/spark/pull/19142 @srowen Thanks for your reply!We can let users know the theory of the restart of receiver by this PR.To be honest,the 'else' was redundancy,so I improve it by logtrace. To say the least,if

[GitHub] spark pull request #18991: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2017-09-06 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/18991 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81449/testReport)** for PR 18975 at commit [`62370fd`](https://github.com/apache/spark/commit/62

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19111 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81446/ Test PASSed. ---

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19111 **[Test build #81446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81446/testReport)** for PR 19111 at commit [`5d156be`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #19111: [SPARK-21801][SPARKR][TEST] set random seed for predicta...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19111 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81449/ Test FAILed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81449/testReport)** for PR 18975 at commit [`62370fd`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #19145: add logic to test whether the complete container ...

2017-09-06 Thread klion26
GitHub user klion26 opened a pull request: https://github.com/apache/spark/pull/19145 add logic to test whether the complete container has been completed before ## What changes were proposed in this pull request? Add logic to test whether the complete container has been repo

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19144: [UI][Streaming]Modify the title, 'Records' instead of 'I...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19144 Actually yeah I see lots of that in the user-facing docs. OK, it's reasonable. Are you sure it's a # of records? --- - To unsubsc

[GitHub] spark issue #19145: add logic to test whether the complete container has bee...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19145 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19145: add logic to test whether the complete container has bee...

2017-09-06 Thread klion26
Github user klion26 commented on the issue: https://github.com/apache/spark/pull/19145 create a issue https://issues.apache.org/jira/browse/SPARK-21933 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o

[GitHub] spark issue #19144: [UI][Streaming]Modify the title, 'Records' instead of 'I...

2017-09-06 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19144 I can be sure. I tested streaming on kafka and streaming on sql .Are both records. --- - To unsubscribe, e-mail: reviews-

[GitHub] spark issue #19131: [MINOR][SQL]remove unuse import class

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19131 I'm neutral. Once in a while a cleanup seems helpful, not all the time. I am a little more receptive to people without much contribution history. But yeah I do not want to review things like this reg

[GitHub] spark issue #17383: [SPARK-3165][MLlib] DecisionTree use sparsity in data

2017-09-06 Thread facaiy
Github user facaiy commented on the issue: https://github.com/apache/spark/pull/17383 Thank you for comment. Very good question, at least for me, the answer to both questions is no. In most case, we feed dense raw data into tree model. However, if large dimensions required,

[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...

2017-09-06 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/19143 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 Leave a comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 @srowen Actually, I think this one makes sense. Because the two open test cases are tested, we connect the Cartesian product and the broadcast nested loop join. When we understand the two connecti

[GitHub] spark pull request #19143: [SPARK-21932][SQL]Remove package name similar 'lo...

2017-09-06 Thread heary-cao
GitHub user heary-cao reopened a pull request: https://github.com/apache/spark/pull/19143 [SPARK-21932][SQL]Remove package name similar 'logical.Join' to 'Join' in JoinSelection ## What changes were proposed in this pull request? this PR to fix two problems: 1. simi

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-06 Thread caneGuy
Github user caneGuy commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r137214624 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala --- @@ -142,7 +142,7 @@ private[v1] object AllStagesResource {

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19143 You haven't actually added tests, and that's not all this PR does. At the least, this doesn't match the intent you describe, and should be closed. I'd back up and describe the test you want in the JI

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 okay, do you mean I need to change the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137224595 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -661,6 +666,10 @@ case class StructsToJson(

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19124 **[Test build #81445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81445/testReport)** for PR 19124 at commit [`46847f8`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137224911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -640,6 +644,7 @@ case class StructsToJson(

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19124 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81445/ Test PASSed. ---

[GitHub] spark issue #19124: [SPARK-21912][SQL] ORC/Parquet table should not create i...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19124 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137225157 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -640,6 +644,7 @@ case class StructsToJson(

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137226222 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137226390 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137226892 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227713 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227592 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -22,24 +22,44 @@ import java.io.Writer import co

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227883 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -193,14 +213,27 @@ private[sql] class JacksonGenerato

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227920 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -193,14 +213,27 @@ private[sql] class JacksonGenerato

[GitHub] spark pull request #18875: [SPARK-21513][SQL] Allow UDF to_json support conv...

2017-09-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r137227950 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -193,14 +213,27 @@ private[sql] class JacksonGenerato

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19130 **[Test build #81447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81447/testReport)** for PR 19130 at commit [`047578e`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19130 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81447/ Test PASSed. ---

[GitHub] spark pull request #19146: [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle...

2017-09-06 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/19146 [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle-maven-plugin and scalastyle as well in POM and SparkBuild.scala ## What changes were proposed in this pull request? This PR proposes t

[GitHub] spark issue #19146: [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle-maven-...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19146 **[Test build #81450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81450/testReport)** for PR 19146 at commit [`0b4fba9`](https://github.com/apache/spark/commit/0b

[GitHub] spark issue #19146: [SPARK-21903][BUILD][FOLLOWUP] Upgrade scalastyle-maven-...

2017-09-06 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19146 @srowen, I am sorry. While investigating https://issues.apache.org/jira/browse/SPARK-21927 but I just realised I made a mistake here, though, it looks picking up the correct version for now. Thi

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-06 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81451/testReport)** for PR 18865 at commit [`ea5a447`](https://github.com/apache/spark/commit/ea

[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

2017-09-06 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r137235013 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/InitialPosition.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to t

[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

2017-09-06 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r137237166 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/InitialPosition.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to t

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-06 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r137238007 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala --- @@ -142,7 +142,7 @@ private[v1] object AllStagesResource {

[GitHub] spark pull request #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with...

2017-09-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18538#discussion_r137242127 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with...

2017-09-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18538#discussion_r137239906 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala --- @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Sof

[GitHub] spark pull request #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with...

2017-09-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18538#discussion_r137175816 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala --- @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Sof

[GitHub] spark pull request #18538: [SPARK-14516][ML] Adding ClusteringEvaluator with...

2017-09-06 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18538#discussion_r137178833 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala --- @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Sof

  1   2   3   4   5   6   >