Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84331 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84331/testReport)**
for PR 19813 at commit
[`57a9fb7`](https://github.com/apache/spark/commit/57
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84330/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19714
**[Test build #84329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84329/testReport)**
for PR 19714 at commit
[`2db4104`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84330/testReport)**
for PR 19813 at commit
[`fd87e9b`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19714
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84329/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19714
**[Test build #84332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84332/testReport)**
for PR 19714 at commit
[`45bc32f`](https://github.com/apache/spark/commit/45
GitHub user kellyzly opened a pull request:
https://github.com/apache/spark/pull/19854
SPARK-22660:Use position() and limit() to fix ambiguity issue in scalâ¦
â¦a-2.12 and JDK9
## What changes were proposed in this pull request?
(Please fill in changes proposed in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19854
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19853
No, this can't possibly be committed. Please close this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For ad
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19854
**[Test build #4001 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4001/testReport)**
for PR 19854 at commit
[`fb30b90`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19854
**[Test build #4001 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4001/testReport)**
for PR 19854 at commit
[`fb30b90`](https://github.com/apache/spark/commit/
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
@HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix,
which never made it to Scala 2.11. Instead of copy-pasting the original
discussion, let me link the [original
PR](https
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154012613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154012714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19811
@cloud-fan yes, I have the same opinion and I'd suggest the same thing
(https://github.com/apache/spark/pull/19811#discussion_r153647477), at least at
the beginning. Then if we find smarter way yo
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19811
I think that it is good to have a loop to mainly reduce the byte code size
and to reduce constant pool entries.
```
int[] ints = new int[32768];
ints[0] = 1;
ints[1] = 1;
...
in
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154013620
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154014248
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154010888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -168,6 +166,21 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154012855
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -168,6 +166,21 @@ class CodegenContext {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154014568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -203,18 +271,47 @@ class CodegenContext {
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19811
I'm afraid this style initialization
```scala
int[] ints = new int[1001];
ints[0] = 3;
ints[1] = 1;
ints[2] = 5;
...
```
produces too many bytecodes.
---
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154015991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -203,18 +271,47 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154016387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19855
[SPARK-22662] [SQL] Failed to prune columns after rewriting predicate
subquery
## What changes were proposed in this pull request?
As a simple example:
```
spark-sql> create table ba
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19855
**[Test build #84333 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84333/testReport)**
for PR 19855 at commit
[`1f9fccf`](https://github.com/apache/spark/commit/1f
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154018089
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154019031
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154019257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -168,6 +166,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154019399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -168,6 +166,21 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154020585
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -168,6 +166,21 @@ class CodegenContext {
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19840#discussion_r154028953
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -57,9 +57,14 @@ private[spark] abstract class BasePythonRunner[IN, O
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19840
cc @cloud-fan @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19805
**[Test build #84334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84334/testReport)**
for PR 19805 at commit
[`c743c34`](https://github.com/apache/spark/commit/c7
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19851#discussion_r154027755
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -50,14 +52,24 @@ class HiveExternalCatalogVer
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19851#discussion_r154029237
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -50,14 +52,24 @@ class HiveExternalCatalogVer
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19851#discussion_r154027519
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
---
@@ -50,14 +52,24 @@ class HiveExternalCatalogVer
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154030837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19852
Please update the title `[SPARK-22655][PySpark] Throw exception rather than
exit silently in PythonRunner when Spark session is stopped`
---
---
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154029577
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverKubernetesCredentialsStep.scala
---
@@ -0,0 +1,244
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154022151
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154016042
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesClientFactory.scala
---
@@ -0,0 +1,104 @@
+/*
+ * L
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154029412
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverKubernetesCredentialsStep.scala
---
@@ -0,0 +1,244
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19811
I think we should do optimization incrementally. From
```
private int a;
private int b;
private int c;
...
a = 3;
b = 1;
c = 5;
...
```
to
```
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19852#discussion_r154035525
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -319,7 +319,7 @@ private[spark] abstract class BasePythonRunner[IN, OU
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r154036405
--- Diff: python/pyspark/sql/types.py ---
@@ -1108,19 +1109,33 @@ def _has_nulltype(dt):
return isinstance(dt, NullType)
-def _m
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19847
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19840#discussion_r154037304
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -57,9 +57,14 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19811
I 100% agree with @cloud-fan. Moreover, SPARK-6 addresses the
additional constant pool entries generated by adding many methods. Even though
using a for loop in general has advantages, it is br
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19847
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84335/testReport)**
for PR 19792 at commit
[`2240a42`](https://github.com/apache/spark/commit/22
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19842
Since the benchmark shows negligible overhead for normal cases, I'm merging
it to master, thanks!
---
-
To unsubscribe, e-mail
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154038847
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19842
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19840
Should we set the `pythonExec` during the initialization of `SparkContext`
at
[context.py#L191](https://github.com/yaooqinn/spark/blob/8ff5663fe9a32eae79c8ee6bc310409170a8da64/python/pyspark/context.
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154041356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r154041665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -177,11 +190,67 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19813
**[Test build #84331 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84331/testReport)**
for PR 19813 at commit
[`57a9fb7`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84331/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84335/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84335/testReport)**
for PR 19792 at commit
[`2240a42`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19714
**[Test build #84332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84332/testReport)**
for PR 19714 at commit
[`45bc32f`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19714
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19714
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84332/
Test PASSed.
---
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/spark/pull/19856
[SPARK-22664] The logs about "Connected to Zookeeper" in
ReliableKafkaReceiver.scala are in wrong position
[https://issues.apache.org/jira/browse/SPARK-22664](https://issues.apache.org/jira/br
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19856
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19842#discussion_r154045805
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
---
@@ -387,20 +389,108 @@ object ColumnarBatchBench
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19831
If CBO enabled, the [`outputRowCount ==
0`](https://github.com/apache/spark/pull/19831#L67), the
[`getOutputSize`](https://github.com/apache/spark/pull/19831#L60) is 1,
`sizeInBytes` is 1 and this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19855
**[Test build #84333 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84333/testReport)**
for PR 19855 at commit
[`1f9fccf`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19855
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84333/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19855
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84336/testReport)**
for PR 19811 at commit
[`56ccc53`](https://github.com/apache/spark/commit/56
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19805
**[Test build #84334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84334/testReport)**
for PR 19805 at commit
[`c743c34`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19805
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84334/
Test PASSed.
---
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19855
cc @cloud-fan @gatorsmile @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19811
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84336/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84336/testReport)**
for PR 19811 at commit
[`56ccc53`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19797
**[Test build #84337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84337/testReport)**
for PR 19797 at commit
[`a455ac3`](https://github.com/apache/spark/commit/a4
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/19831#discussion_r154069687
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -418,7 +418,7 @@ private[hive] class HiveClientImpl(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154071162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -110,17 +108,21 @@ private [sql] object G
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154071513
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +846,11 @@ class CastSuite extends SparkFun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154071572
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala
---
@@ -164,6 +165,12 @@ class ComplexTypesSuite ex
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19797
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r154072747
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends Spar
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154073872
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +846,11 @@ class CastSuite extends SparkFunSui
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154074153
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154074197
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.sql.cat
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19797
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19856
You shouldn't create a JIRA for items like this, where the description is
the same as the PR. I wouldn't move the initial log, as creating the Consumer
is part of connecting. It won't matter much. Bu
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19828
**[Test build #84338 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84338/testReport)**
for PR 19828 at commit
[`67ca139`](https://github.com/apache/spark/commit/67
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84339/testReport)**
for PR 19811 at commit
[`bb6d3a3`](https://github.com/apache/spark/commit/bb
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #84340 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84340/testReport)**
for PR 19222 at commit
[`2ca374e`](https://github.com/apache/spark/commit/2c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19797
**[Test build #84341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84341/testReport)**
for PR 19797 at commit
[`747e215`](https://github.com/apache/spark/commit/74
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19811
**[Test build #84339 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84339/testReport)**
for PR 19811 at commit
[`bb6d3a3`](https://github.com/apache/spark/commit/b
1 - 100 of 395 matches
Mail list logo
