[rtc-linux] Re: [PATCH v2] rtc: ds1307: convert driver to regmap

2017-05-25 Thread Alexandre Belloni
hardware could test as > well. > > Signed-off-by: Heiner Kallweit > --- > v2: > - rebased on top of latest rtc tree > --- > drivers/rtc/rtc-ds1307.c | 603 > +-- > 1 file changed, 221 insertions(+), 382 deletions(-) > Applied

[rtc-linux] Re: [Patch] rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ

2017-05-30 Thread Alexandre Belloni
ds1307_can_wakeup_device)) { > irq_handler = mcp794xx_irq; > want_irq = true; > } I applied it now but it didn't applied cleanly. Can you check tomorrow's linux-next? Thanks! -- Alexandre Belloni, Free Electr

[rtc-linux] Re: [PATCH 0/4] rtc: m41t80: improve SQW support

2017-05-30 Thread Alexandre Belloni
: m41t80: remove sqw sysfs entry > rtc: m41t80: add clock provider support > > drivers/rtc/rtc-m41t80.c | 251 > +-- > 1 file changed, 175 insertions(+), 76 deletions(-) > All applied now, I had to rebase the last patch on top of v4.12-

[rtc-linux] Re: [PATCH] rtc: ds1307: Add support for Epson RX8130CE

2017-05-30 Thread Alexandre Belloni
r linux-next because this driver now uses regmap for the register accesses. Thanks! > Signed-off-by: Marek Vasut > Cc: Alexandre Belloni > Cc: Arnd Bergmann > Cc: Felipe Balbi > Cc: Nishanth Menon > Cc: Tony Lindgren > ---

[rtc-linux] Re: [PATCH] rtc/tpo: Handle disabled TPO in opal_get_tpo_time()

2017-05-31 Thread Alexandre Belloni
rning -ENOENT > in such a case. This signals generic rtc that no alarm is set and it > bails out from the alarm initialization flow without reporting the > above error. > > Signed-off-by: Vaibhav Jain > Reported-by: Steve Best > --- > drivers/rtc/rtc-opal.c | 10

[rtc-linux] Re: [PATCH] drivers/rtc/interface.c: Validate alarm-time before handling rollover

2017-05-31 Thread Alexandre Belloni
fter > filling up the missing datetime components and if rtc_valid_tm() still > reports it to be invalid then bails out of the function without > handling the rollover. > > Reported-by: Steve Best > Signed-off-by: Vaibhav Jain > --- > drivers/rtc/interface.c | 9 - &

[rtc-linux] Re: [PATCH 12/29] rtc.txt: standardize document format

2017-05-31 Thread Alexandre Belloni
phinx: > > - adjust identation of the titles; > - mark a table as such; > - don't capitalize chapter names. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/rtc.txt | 44 +++- > 1 file changed, 23 insertions(+)

[rtc-linux] [PATCH 4/5] rtc: ds1307: avoid using rtc-name

2017-06-02 Thread Alexandre Belloni
ds1307->rtc->name is a copy of ds1307->client->name, use it instead. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 77339b3d50a1..99e893d

[rtc-linux] [PATCH 2/5] rtc: dev: remove rtc->name from debug message

2017-06-02 Thread Alexandre Belloni
rtc->name is superfluous here because the rtc is already registered at that point and its name has already been printed. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-dev.c b/drivers/rtc/rtc-de

[rtc-linux] [PATCH 3/5] rtc: pcf8563: avoid using rtc->name

2017-06-02 Thread Alexandre Belloni
pcf8563->rtc->name is a copy of pcf8563_driver.driver.name, use it instead Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 1227ceab61ee..cea6ea

[rtc-linux] [PATCH 5/5] rtc: remove rtc_device.name

2017-06-02 Thread Alexandre Belloni
rtc->name is only used in messages were it is superfluous. Remove it completely from the structure. Signed-off-by: Alexandre Belloni --- drivers/rtc/class.c | 7 +++ include/linux/rtc.h | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/

[rtc-linux] [PATCH 1/5] rtc: sysfs: make name uniform

2017-06-02 Thread Alexandre Belloni
ion of driver.name (addition or removal of rtc-, -rtc, _rtc, rtc_) Make it uniform and use the driver name and the device name. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/r

[rtc-linux] [GIT PULL] RTC for 4.12 #2

2017-06-03 Thread Alexandre Belloni
list address Alexandre Belloni (1): MAINTAINERS: update RTC mailing list MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http:/

[rtc-linux] Re: [PATCH 1/3] tools: timer: add rtctest_setdate

2017-06-16 Thread Alexandre Belloni
> + retval = ioctl(fd, RTC_RD_TIME, ¤t); > + if (retval == -1) { > + perror("RTC_RD_TIME ioctl"); > + exit(errno); > + } > + > + fprintf(stderr, "\n\nCurrent RTC date/time is %d-%d-%d, > %02d:%02d:%02d.\n", > +

[rtc-linux] Re: [PATCH 2/3] tools: timer: add test to check y2038/2106 bug

2017-06-16 Thread Alexandre Belloni
; > + } > + > + fprintf(stderr, "RTC alarm is %d-%d-%d, %02d:%02d:%02d.\n", > + current.tm_mday, current.tm_mon + 1, current.tm_year + 1900, > + current.tm_hour, current.tm_min, current.tm_sec); > + > + if (new.tm_year != current.tm_year ||

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
| 25 > drivers/rtc/rtc-tegra.c | 22 +++--- > drivers/rtc/rtc-test.c | 17 +-- > drivers/rtc/rtc-tps6586x.c | 26 > drivers/rtc/rtc-vr41xx.c | 6 ++-- &

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits varia

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
> > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > > > > > On 20/06/2017 at 11:35:08 +0200, Benja

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > : > > >> Yes, that's argument against changing rtc _drivers_ for hardware th

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
he past, > which is quite unusual. > Or not, having an RTC set in the past is actually quite common. I'd find it weird to have a new device boot and be set to a date in the future. Also note that the threshold or offset thing may seem like a good idea but fails with many RTCs because o

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
On 21/06/2017 at 10:19:49 +0100, Russell King - ARM Linux wrote: > On Wed, Jun 21, 2017 at 10:39:07AM +0200, Alexandre Belloni wrote: > > On 21/06/2017 at 09:51:52 +0200, Pavel Machek wrote: > > > If someone uses different threshold, well, there will be > > > confusi

[rtc-linux] Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-21 Thread Alexandre Belloni
code, so that we can do fixups once > per class, not once per driver. Yes, I'm in the middle of the whole rework that allows that. I don't understand the sudden urgency of fixing that and the amount of bikeshedding, seeing that the closest cutoff date is actually 31st of decemb

[rtc-linux] Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug

2017-06-23 Thread Alexandre Belloni
make sure to also be the one for rtctest_setdate.c. > The third one is a rtc driver patch. Please let me know how do you want > to handle this series soon we can get this into 4.13-rc1. > I'll take the three patches but I still have comment I didn't have time to give yet. --

[rtc-linux] Re: [PATCH] rtc: opal: Implement rtc_class_ops.alarm_irq_enable callback

2017-06-23 Thread Alexandre Belloni
t; 1 file changed, 21 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.go

[rtc-linux] Re: [PATCH] drivers: rtc-mxc: remove unused variable

2017-06-24 Thread Alexandre Belloni
d-const-variable=] > static const u32 PIE_BIT_DEF[MAX_PIE_NUM][2] = { > > Signed-off-by: Diaz de Grenu, Jose > --- > drivers/rtc/rtc-mxc.c | 11 --- > 1 file changed, 11 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kern

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-24 Thread Alexandre Belloni
disabled\n", __func__); > + } else { > + /* Alarm is enabled */ > + alarm->enabled = 1; > + rtc_time_to_tm(sec, &alarm->time); > + dev_dbg(dev, "%s: alarm is enabled\n", __func__); > + } > + >

[rtc-linux] Re: [PATCH V2] rtc: ds1307: Add support for Epson RX8130CE

2017-06-24 Thread Alexandre Belloni
the chip, Alarm and > Timer is not supported. > > Signed-off-by: Marek Vasut > Cc: Alexandre Belloni > Cc: Arnd Bergmann > Cc: Felipe Balbi > Cc: Nishanth Menon > Cc: Tony Lindgren > --- > V2: Convert to regmap > --- > drivers/rtc/rtc-ds1307.c | 175 >

[rtc-linux] Re: [PATCH 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
s you removed it from v2. I'll applay that but it is ok if you change your mind. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at h

[rtc-linux] Re: [PATCH v2 2/2] rtc: brcmstb-waketimer: Add Broadcom STB wake-timer

2017-06-26 Thread Alexandre Belloni
le| 1 + > drivers/rtc/rtc-brcmstb-waketimer.c | 325 > > 3 files changed, 337 insertions(+) > create mode 100644 drivers/rtc/rtc-brcmstb-waketimer.c > Both applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linu

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-06-29 Thread Alexandre Belloni
s. One that does the initialization and another one that reads > > status1 and immediately doest the initialization when POC is set. If BLD > > is set, then we can wait for set_time to happen before initializing. > > -- Alexandre Belloni, Free Electrons Embedded Linux and K

[rtc-linux] Re: [PATCH 1/2] RTC: s35390a: handle invalid RTC time

2017-07-04 Thread Alexandre Belloni
On 04/07/2017 at 10:55:52 +0200, Fabien Lahoudere wrote: > On Thu, 2017-06-29 at 09:56 +0200, Alexandre Belloni wrote: > > On 26/06/2017 at 11:51:13 +0200, Fabien Lahoudere wrote: > > > > Actually, after reading the datasheet, I realize it is only POC that is > > >

[rtc-linux] Re: [PATCH 1/3 v2] rtc: gemini: Add optional clock handling

2017-07-05 Thread Alexandre Belloni
li Kroll > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Use devm_clk_get() so we do not leave dangling clocks > behind. > - Add Hans' ACK. > --- > drivers/rtc/rtc-gemini.c | 28 > 1 file changed, 28 insertion

[rtc-linux] Re: [PATCH 2/3 v2] rtc: gemini: Augment DT bindings for Faraday

2017-07-05 Thread Alexandre Belloni
| 28 > ++ > 2 files changed, 28 insertions(+), 14 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/cortina,gemini.txt > create mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt > Applied, thanks. -- Alexandre Bello

[rtc-linux] Re: [PATCH 3/3 v2] rtc: gemini/ftrtc010: rename driver and symbols

2017-07-05 Thread Alexandre Belloni
drivers/rtc/Makefile | 2 +- > drivers/rtc/{rtc-gemini.c => rtc-ftrtc010.c} | 91 > ++-- > 4 files changed, 53 insertions(+), 52 deletions(-) > rename drivers/rtc/{rtc-gemini.c => rtc-ftrtc010.c} (62%) > Applied, t

[rtc-linux] Re: [PATCH 2/2] rtc: stm32: add STM32H7 RTC support

2017-07-05 Thread Alexandre Belloni
else > + return -EINVAL; This will never happen, you can remove that test. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://gro

Re: [rtc-linux] [PATCH 2/2] rtc: ds1307: disable square wave output from ds1308

2017-07-06 Thread Alexandre Belloni
rom this group and stop receiving emails from it, send an > email to rtc-linux+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this messag

Re: [rtc-linux] [PATCH 1/2] rtc: ds1307: add ds1308 variant

2017-07-06 Thread Alexandre Belloni
> 1 file changed, 12 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/

[rtc-linux] Re: [PATCHv2 0/2] rtc: add support for STM32H7 RTC

2017-07-06 Thread Alexandre Belloni
STM32H7 > rtc: stm32: add STM32H7 RTC support > > .../devicetree/bindings/rtc/st,stm32-rtc.txt | 32 +++-- > drivers/rtc/rtc-stm32.c| 82 > +- > 2 files changed, 92 insertions(+), 22 deletions(-) > Applied, thanks

[rtc-linux] Re: [PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug

2017-07-09 Thread Alexandre Belloni
6 > 4 files changed, 212 insertions(+), 16 deletions(-) > create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c > Applied, thanks. I've fixed up the date to meaningful ones in patch 2. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel

[rtc-linux] Re: [PATCH v2 08/22] rtc: ds1305: stop using rtc deprecated functions

2017-07-12 Thread Alexandre Belloni
functions to safer 64bits ones. > > Signed-off-by: Benjamin Gaignard > CC: Alessandro Zummo > CC: Alexandre Belloni > CC: rtc-linux@googlegroups.com > CC: linux-ker...@vger.kernel.org > --- > drivers/rtc/rtc-ds1305.c | 11 --- > 1 file changed, 4 insertions(+)

[rtc-linux] Re: [PATCH v2 1/2] RTC: s35390a: handle invalid RTC time

2017-07-30 Thread Alexandre Belloni
information will be lost. > > Signed-off-by: Fabien Lahoudere > --- > drivers/rtc/rtc-s35390a.c | 72 > +++ > 1 file changed, 42 insertions(+), 30 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded

[rtc-linux] Re: [PATCH v2 2/2] RTC: s35390a: implement ioctls

2017-07-30 Thread Alexandre Belloni
> Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.co

[rtc-linux] Re: [RFC] rtc: ds1307: add square wave output from ds1308

2017-07-31 Thread Alexandre Belloni
S1308_BIT_BBCLK); That should not be needed, the CCF will disable any unused clock. > case ds_1338: > /* clock halted? turn it on, so clock can tick. */ > if (tmp & DS1307_BIT_CH) > -- > 2.13.3 > -- Alexandre Belloni, Free Electrons Embedd

Re: [rtc-linux] RTC used as a module

2017-08-20 Thread Alexandre Belloni
gt;>> Hi Alexandre, > >>>>> > >>>>> On 3.3.2017 10:41, Michal Simek wrote: > >>>>>> Hi Alexandre, > >>>>>> > >>>>>> On 23.2.2017 13:14, Alexandre Belloni wrote: > >>>>>>>

Re: [rtc-linux] RTC used as a module

2017-08-21 Thread Alexandre Belloni
On 21/08/2017 at 12:50:34 +0200, Michal Simek wrote: > Hi, > > On 21.8.2017 00:03, Alexandre Belloni wrote: > > Hi Michal, > > > > I've just send a patch to fix this issue (and avoid your other patch). > > > > Could you test it? (I did test on an at

Re: [rtc-linux] RTC used as a module

2017-08-21 Thread Alexandre Belloni
On 21/08/2017 at 14:19:07 +0200, Michal Simek wrote: > On 21.8.2017 14:13, Alexandre Belloni wrote: > > On 21/08/2017 at 12:50:34 +0200, Michal Simek wrote: > >> Hi, > >> > >> On 21.8.2017 00:03, Alexandre Belloni wrote: > >>> Hi Michal, > >

Re: [rtc-linux] RTC used as a module

2017-08-21 Thread Alexandre Belloni
On 21/08/2017 at 14:47:20 +0200, Alexandre Belloni wrote: > On 21/08/2017 at 14:19:07 +0200, Michal Simek wrote: > > On 21.8.2017 14:13, Alexandre Belloni wrote: > > > On 21/08/2017 at 12:50:34 +0200, Michal Simek wrote: > > >> Hi, > > >> > >

[rtc-linux] Re: [PATCH] rtc: m41t80: enable wakealarm when "wakeup-source" is specified

2017-08-22 Thread Alexandre Belloni
(-) > I've applied it but it didn't apply cleanly, please check rtc-next or linux-next, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux".

[rtc-linux] Re: [RESEND v9 06/12] rtc: Kconfig: Name RK805 in Kconfig for RTC_DRV_RK808

2017-08-24 Thread Alexandre Belloni
ine Zhang > Signed-off-by: Joseph Chen > --- > drivers/rtc/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message

Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127 watchdog functionality

2017-08-29 Thread Alexandre Belloni
t = misc_register(&pcf2127_wdt_miscdev); > + if (ret) > + return ret; > + } > + pcf2127_wdt_settimeout(32); > +#endif > + > + return 0; > } > > #ifdef CONFIG_OF > @@ -427,6 +595,10 @@ static void __exit pcf2127_exit(v

Re: [rtc-linux] [PATCH] drivers/rtc/rtc-pcf85263.c: add support for devicetree

2017-09-15 Thread Alexandre Belloni
e Clock > + > +Required properties: > +- compatible: should be: "nxp,rtc-pcf85263" The proper compatible string would be "nxp,pcf85263" Also, please have a look at http://patchwork.ozlabs.org/patch/658956/ http://patchwork.ozlabs.org/patch/658957/ Martin never rep

[rtc-linux] Re: [PATCH] rtc: ds1307: add OF and ACPI entries for Epson RX8130

2017-10-26 Thread Alexandre Belloni
t;) > Signed-off-by: Bastian Stender > --- > drivers/rtc/rtc-ds1307.c | 5 + > 1 file changed, 5 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message becaus

[rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Alexandre Belloni
On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > + Alessandro Zummo > + Alexandre Belloni > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > : > > Dear all, > > > > This is an attempt to revive some patches from that [1] patchset, some >

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Alexandre Belloni
On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > + Alessandro Zummo > > + Alexandre Belloni > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > : > > > Dear all, >

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-18 Thread Alexandre Belloni
On 13/12/2017 at 07:55:35 +, Lee Jones wrote: > On Tue, 12 Dec 2017, Alexandre Belloni wrote: > > > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > > + Alessandro Zu

[rtc-linux] Re: 500 ms delay in time saved into RTC

2018-02-19 Thread Alexandre Belloni
h has the x86 insanity commented out: https://git.busybox.net/busybox/tree/util-linux/hwclock.c -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- You received this message because you are subscribed to "rtc-linux". Membershi

[rtc-linux] Re: 500 ms delay in time saved into RTC

2018-02-24 Thread Alexandre Belloni
connected to a sama5d4 xplained, 96盜 on my PC. It can still be improved and doesn't handle RTCs in localtime. I'm planning to integrate that in hwclock at some point i(hopefully soon) but I didn't have the time to dive too much in the code yet. -- Alexandre Belloni, Bootlin (formerly

[rtc-linux] Re: [PATCH] rtc-pm8xxx: Fix issue in RTC write path

2018-03-01 Thread Alexandre Belloni
tc_dd->regmap, regs->ctrl, ctrl_reg); > + rc = regmap_write(rtc_dd->regmap, regs->alarm_ctrl, ctrl_reg); > if (rc) { > - dev_err(dev, "Write to RTC control register failed\n"); > + dev_err(dev, &

[rtc-linux] Re: [PATCH] rtc: ab8500: Drop AB8540 support

2018-03-22 Thread Alexandre Belloni
the support for now to simplify > maintenance of the AB8500. > > Cc: Loic Pallardy > Signed-off-by: Linus Walleij > --- Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- You received this message

[rtc-linux] Re: rtc: fix chardev initialization races

2018-09-04 Thread Alexandre Belloni
uct module *module is now > > > > > freed */ > > > > > chrdev_open() > > > > >spin_lock(cdev_lock) > > > > > cdev_get() > > > > >

[rtc-linux] Re: [PATCH] rtc: interface: ignore exprired timers one enqueing new timers

2016-05-19 Thread Alexandre Belloni
f-by: Colin Ian King Thanks for the resend. I was still planning to have a look at the patch you send in September 2014. I believe that one replaces it. I'll definitely have a look after 4.7-rc1. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering ht

[rtc-linux] Re: [PATCH 1/1] rtc: ds1685: correct check of day of month

2016-05-20 Thread Alexandre Belloni
/* Check the month date for validity. */ > - if (!(mday >= 1) && (mday <= 31)) > + if ((mday < 1) || (mday > 31)) > return -EDOM; > > /* -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http

[rtc-linux] [GIT PULL] RTC for 4.7

2016-05-21 Thread Alexandre Belloni
6586x Akinobu Mita (2): rtc: ds1302: fix error check in set_time rtc: ds1302: fix write value for day of week register Alexandre Belloni (1): rtc: remove useless DRV_VERSION Anurag Kumar Vulisha (3): rtc: z

[rtc-linux] Re: [GIT PULL] RTC for 4.7

2016-05-21 Thread Alexandre Belloni
On 21/05/2016 at 11:18:15 -0700, Linus Torvalds wrote : > On Sat, May 21, 2016 at 8:15 AM, Alexandre Belloni > wrote: > > > > Here is the pull-request for the RTC subsystem for 4.7. > > Grr. I noticed this too late, but this has all been rebased very recently. > >

[rtc-linux] Re: [PATCH RESEND 1/2] rtc: initialize output parameter for read alarm to "uninitialized"

2016-05-29 Thread Alexandre Belloni
> --- > drivers/rtc/interface.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subsc

[rtc-linux] Re: [PATCH v3 00/16] genrtc removal

2016-05-29 Thread Alexandre Belloni
Hi, On 03/05/2016 at 12:05:34 +0200, Arnd Bergmann wrote : > On Tuesday 03 May 2016 09:24:18 Alexandre Belloni wrote: > > Hi Arnd, > > > > I see you didn't copy Greg on that series (that may explain his > > confusion on the previous patch), do you expect me to

[rtc-linux] Re: [PATCH 39/54] MAINTAINERS: Add file patterns for rtc device tree bindings

2016-05-29 Thread Alexandre Belloni
On 22/05/2016 at 11:06:16 +0200, Geert Uytterhoeven wrote : > Submitters of device tree binding documentation may forget to CC > the subsystem maintainer if this is missing. > > Signed-off-by: Geert Uytterhoeven > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: rtc-l

[rtc-linux] Re: [abelloni:rtc-testing 2/17] include/linux/printk.h:375:9: error: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE'

2016-05-30 Thread Alexandre Belloni
the replacement patch. > > Alexandre, let me know if you'd prefer me to post the whole series > again instead. > Well, I think the plan was to send v4 and include GKH in the Cc list so that he could maybe put some acks. There is also the mn10300 one: arch/mn10300/proc-mn103e010/pr

[rtc-linux] Re: [PATCH v4 00/16] genrtc removal

2016-05-30 Thread Alexandre Belloni
one has been converted to a standard SPI driver in v4.6. Following some discussion, driving it using gpios will be added. m32r will have to use one of those two interfaces. It is broken on that architecture for now but we never got any reply from maintainers. -- Alexandre Belloni, Free Electr

[rtc-linux] Re: [PATCH] rtc: ds1307: Fix relying on reset value for weekday

2016-06-01 Thread Alexandre Belloni
using > + * timestamp > + */ > + if (wday != tm.tm_wday) { > + wday = i2c_smbus_read_byte_data(client, MCP794XX_REG_WEEKDAY); > + wday = wday & ~MCP794XX_REG_WEEKDAY_WDAY_MASK; > + wday = wday | (tm.tm_wday + 1); > + i2c_smbus_

[rtc-linux] Re: [PATCH] sparc32: remove stale RTC_PORT definition

2016-06-04 Thread Alexandre Belloni
> go through the rtc tree that introduced the build failure after my > earlier patches > > arch/sparc/include/asm/io_32.h | 10 -- > 1 file changed, 10 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://fre

[rtc-linux] Re: [PATCH] rtc: interface: ignore exprired timers one enqueing new timers

2016-06-04 Thread Alexandre Belloni
Ian King > --- > drivers/rtc/interface.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because

[rtc-linux] Re: [PATCH v2 1/1] rtc: ds1685: correct check of day of month

2016-06-04 Thread Alexandre Belloni
mp;& (mday <= 31)) is false for mday == 32. > > When verifying the day of month the binary and the BCD mode > have to be considered. > > v2: > consider ds1685_rtc_read_alarm > consider rtc->bcd_mode as indicated by Alexandre Belloni > > S

[rtc-linux] Re: [PATCH] rtc-pcf2123: use sign_extend32() for sign extension

2016-06-04 Thread Alexandre Belloni
On 18/04/2016 at 12:17:44 +0200, Martin Kepplinger wrote : > Signed-off-by: Martin Kepplinger > --- > drivers/rtc/rtc-pcf2123.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Andr

[rtc-linux] Re: [PATCH v4] rtc:add support for maxim rtc max6916

2016-06-04 Thread Alexandre Belloni
++ > 3 files changed, 180 insertions(+) > I've applied it but you probably edited the diff by hand so I had to edit it a bit more to get it to apply correctly. Also, I fixed the remaining checkpatch issues. -- Alexandre Belloni, Free E

[rtc-linux] Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-06-04 Thread Alexandre Belloni
le until the expired alarm is cleared. > I'm not completely sure to understand what is happening but could you check whether that one is solved by 2b2f5ff00f63847d95adad6289bd8b05f5983dd5 in my tree (rtc-next). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android eng

[rtc-linux] Re: [PATCH 1/2] rtc-cmos: Clear expired alarm after resume

2016-06-04 Thread Alexandre Belloni
On 04/06/2016 at 18:58:59 +0200, Gabriele Mazzotta wrote : > 2016-06-04 16:46 GMT+02:00 Alexandre Belloni > : > > On 01/06/2016 at 17:40:14 +0200, Gabriele Mazzotta wrote : > >> If the system wakes up because of a wake alarm, the internal state > >> of the alarm is no

[rtc-linux] Re: [PATCH] rtc: efi: Fail probing if RTC reads don't work

2016-06-06 Thread Alexandre Belloni
ver at all, because if > we do we'd get a non-functional driver that does nothing useful but only > spills > our kernel log with warnings. > > Signed-off-by: Alexander Graf > --- > drivers/rtc/rtc-efi.c | 6 ++ > 1 file changed, 6 insertions(+) Applied, thanks. -

[rtc-linux] Re: [PATCH] x86: include linux/ratelimit.h in nmi.c

2016-06-06 Thread Alexandre Belloni
roken in the linux-rtc git at the moment, so it makes sense > to fix it there. > > arch/x86/kernel/nmi.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You receiv

[rtc-linux] Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

2016-06-07 Thread Alexandre Belloni
685.c:265]: (style) Variable 'ctrlb' is assigned a > value that is never used. > [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a > value that is never used. > Well, feel free to send a patch. Please include the name of the tool you used t

[rtc-linux] [PATCH] rtc: rv8803: broaden workaround

2016-06-07 Thread Alexandre Belloni
The previous workaround may still fail as there are actually 4 retries to be done to ensure the communication succeed. Also, some I2C adapter drivers may return -EIO instead of -ENXIO. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv8803.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[rtc-linux] Re: [PATCH] rtc: ds1307: Fix relying on reset value for weekday

2016-06-14 Thread Alexandre Belloni
On 07/06/2016 at 14:59:05 +0530, Keerthy wrote : > Hi Alexandre, > > On Wednesday 01 June 2016 06:06 PM, Keerthy wrote: > > > > > > On Wednesday 01 June 2016 05:48 PM, Alexandre Belloni wrote: > > > Hi, > > > > > > On 01/06/2016 at 16:1

[rtc-linux] Re: [PATCH 3/5] rtc: rtc-pm8xxx: Add support for pm8018 rtc

2016-06-21 Thread Alexandre Belloni
On 17/06/2016 at 12:22:07 +0200, Neil Armstrong wrote : > In order to support RTC on Qualcomm MDM9615 SoC, add support for > the pm8018 rtc in rtc-pm8xxx driver. > > Signed-off-by: Neil Armstrong Acked-by: Alexandre Belloni -- Alexandre Belloni, Free Electrons Embedded Linux

[rtc-linux] Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options

2016-06-21 Thread Alexandre Belloni
bindings which do > > not have vendor prefixes. Will fix in v2. > > Okay, then they are fine if you are using existing properties. Perhaps > these should all be in a common binding doc though. > I'll try to collect the existing common properties and write that doc this week. --

[rtc-linux] Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default

2016-06-21 Thread Alexandre Belloni
>type]; > + ds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE); > > + if (chip->alarm && (ds1307->client->irq > 0 || > + ds1307_can_wakeup_device)) > want_irq = true; > - } &

[rtc-linux] Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently

2016-06-21 Thread Alexandre Belloni
ttery backup was disabled. " > + "Re-enabling it\n"); > } > > /* clock halted? turn it on, so clock can tick. */ > @@ -1507,7 +1525,7 @@ static int ds1307_chip_sanity_check(const struct ds1307 > *ds1307) >

[rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant

2016-06-21 Thread Alexandre Belloni
[ds_1339] = DS1339_BIT_BBSQI, > [ds_3231] = DS3231_BIT_BBSQW, > }; > @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client, > case ds_1337: > case ds_1339: > case ds_3231: > + case ds_1341: >

[rtc-linux] Re: [PATCH v2 00/17] DS1341 support and code cleanup

2016-06-21 Thread Alexandre Belloni
C: rtctest: Change no IRQ detection for RTC_IRQP_SET I already had patches for that issue in a development tree, I'll see if they match what I did. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this me

Re: [rtc-linux] [PATCH v2 1/4] devicetree: Add Micro Crystal AG vendor id

2016-06-24 Thread Alexandre Belloni
c-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups > "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to rtc-linux+unsubscr...@googl

Re: [rtc-linux] [PATCH v2 3/4] rtc: rv8803: add device tree compatible names

2016-06-24 Thread Alexandre Belloni
ttp://groups.google.com/group/rtc-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups > "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to r

Re: [rtc-linux] [PATCH v2 4/4] rtc: rv8803: Be able to set VDETOFF and SWOFF via devcie tree

2016-06-24 Thread Alexandre Belloni
> + u8 flags; > + > + if (!node) > + return 0; > + > + if (!of_device_is_compatible(node, "epson,rx8900")) > + return 0; > + Can you use the i2c_device_id instead of of_device_is_compatible to avoid matching on yet another strin

Re: [rtc-linux] [PATCH v2 2/4] dt/bindings: Add bindings for Micro Crystal rv8803

2016-06-24 Thread Alexandre Belloni
ric. I would use voltage-detection-disable. Andrey, can you use that one instead of dallas,disable-oscillator-stop-flag ? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to &quo

[rtc-linux] Re: [PATCH 1/2] mn10300: use RTC_DRV_CMOS instead of CONFIG_RTC

2016-06-25 Thread Alexandre Belloni
uot;Platform RTC drivers" > > config RTC_DRV_CMOS > tristate "PC-style 'CMOS'" > - depends on X86 || ARM || M32R || PPC || MIPS || SPARC64 > + depends on X86 || ARM || M32R || PPC || MIPS || SPARC64 || MN10300 > default y if X86 > help > S

[rtc-linux] Re: [PATCH v3 4/8] rtc: ac100: Add RTC driver for X-Powers AC100

2016-06-25 Thread Alexandre Belloni
> + /* Do not enable weekday alarm */ > + reg[3] = bin2bcd(alrm_tm->tm_wday) & AC100_ALM_WEE_MASK; > + reg[4] = (bin2bcd(alrm_tm->tm_mday) & AC100_ALM_DAY_MASK) | > + AC100_ALM_ENABLE_FLAG; > + reg[5] = (bin2bcd(alrm_tm->tm_mon) &a

[rtc-linux] Re: [PATCH v3 5/8] rtc: ac100: Add clk output support

2016-06-25 Thread Alexandre Belloni
uot;ac100-clk32k-ap", > + "ac100-clk32k-bb", > + "ac100-clk32k-md", > +}; > + Well, naming things is hard but I don't feel ac100_clk32k and ac100-clk32k are good prefixes for those clocks as they are actually dividing a 32KHz or 4MHz clock (one configura

[rtc-linux] Re: [PATCH 0/4] support control with using GPIO lines

2016-06-25 Thread Alexandre Belloni
mall fixes. Are you still planning to send a new version? I understand you had some fixes. Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux&quo

[rtc-linux] Re: [PATCH v3 4/8] rtc: ac100: Add RTC driver for X-Powers AC100

2016-06-25 Thread Alexandre Belloni
Forgot that one, platform_get_irq() is probably more common but I don't care that much. I think you can then avoid including of.h and of_irq.h. > + if (chip->irq < 0) { > + dev_err(&pdev->dev, "No IRQ resource\n"); > + return chip-&g

[rtc-linux] Re: [PATCH v2 00/17] DS1341 support and code cleanup

2016-06-26 Thread Alexandre Belloni
On 21/06/2016 at 23:32:19 +0200, Alexandre Belloni wrote : > > RTC: rtctest: Change alarm IRQ support detection > > RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ > > RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET > > I already had patches for tha

[rtc-linux] [PATCH 1/5] rtc: ds17287: remove unused header

2016-06-26 Thread Alexandre Belloni
ds17287rtc.h is unused since commit 15beb694c661 ("mips: ip32: add platform data hooks to use DS1685 driver"), remove it. Signed-off-by: Alexandre Belloni --- include/linux/ds17287rtc.h | 66 -- 1 file changed, 66 deletions(-) delete m

  1   2   3   4   >