Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-04-21 Thread Miroslav Suchý
On 04/21/2011 09:40 AM, Miroslav Suchý wrote: > TypeError: object does not support item assignment I fixed that in commit 94c68cff702bdcfebe9d8d0b5f7874dff5159758 -- Miroslav Suchy Red Hat Satellite Engineering ___ Spacewalk-devel mailing list Spacewa

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-04-21 Thread Miroslav Suchý
On 04/08/2011 04:19 PM, Jan Pazdziora wrote: > On Wed, Mar 23, 2011 at 03:25:43PM +0100, Michael Calmer wrote: >> >> Here is a new patchset. I had to do some more changes. To not loose the >> overview I have combined them into 4 patches. >> >> 0001: The database changes >> 0002: changes in the pyt

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-04-08 Thread Jan Pazdziora
On Wed, Mar 23, 2011 at 03:25:43PM +0100, Michael Calmer wrote: > > Here is a new patchset. I had to do some more changes. To not loose the > overview I have combined them into 4 patches. > > 0001: The database changes > 0002: changes in the python code; mainly reposync and yum repo_plugin > 000

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Michael Calmer
Hi, Am Freitag, 11. März 2011, 11:23:09 schrieb Jan Pazdziora: > On Fri, Mar 11, 2011 at 10:31:45AM +0100, Michael Calmer wrote: > > > > > > is at fault -- at least in that Fedora 7 updateinfo, the version > > > is not integer. When I've changed the line to > > > > > > e['advisory_rel'] = 1 >

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Jan Pazdziora
On Fri, Mar 11, 2011 at 10:31:45AM +0100, Michael Calmer wrote: > > > > is at fault -- at least in that Fedora 7 updateinfo, the version > > is not integer. When I've changed the line to > > > > e['advisory_rel'] = 1 > > > > things went much better. > > Yes, this is the version appended to

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Michael Calmer
Hi, Am Freitag, 11. März 2011, 09:58:39 schrieb Jan Pazdziora: > On Fri, Mar 11, 2011 at 09:40:25AM +0100, Jan Pazdziora wrote: > > [...] > > _buildExternalValue(extObject, object, parentTableObj) > > File "/usr/lib/python2.6/site- > > packages/spacewalk/server/importlib/backe

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Jan Pazdziora
On Fri, Mar 11, 2011 at 09:40:25AM +0100, Jan Pazdziora wrote: > > By the way, when I've removed some safechecks to actually see some > erratas being created from > > > http://archives.fedoraproject.org/pub/archive/fedora/linux/updates/7/i386/repodata/updateinfo.xml.gz > > I get traceback

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-11 Thread Jan Pazdziora
On Tue, Mar 08, 2011 at 05:57:05PM +0100, Michael Calmer wrote: > Hi, > > Am Montag, 7. März 2011, 15:49:59 schrieb Miroslav Suchý: > > On 03/07/2011 02:28 PM, Michael Calmer wrote: > > > Hello, > > [...] > > > Regarding patch 0001-implement-updateinfo-Errata-import-5.patch... > > It seems to

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-10 Thread Jan Pazdziora
On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: > Hello, > > the attached patch set implements updateinfo to errata import in spacewalk- > repo-sync. [...] > diff --git a/backend/satellite_tools/reposync.py > b/backend/satellite_tools/reposync.py > index 2fc46a0..ee3be6e 100644

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in?spacewalk-repo-sync

2011-03-10 Thread Jan Pazdziora
On Tue, Mar 08, 2011 at 05:57:05PM +0100, Michael Calmer wrote: > > * fix errata override bug. Create a unique advisory_name > This was about the element in the updateinfo which is not unique. Not unique where, across what domain? When I take http://archives.fedoraproject.org/pub/archi

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-10 Thread Jan Pazdziora
On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: > Hello, > > the attached patch set implements updateinfo to errata import in spacewalk- > repo-sync. > This patch also requires two small changes to yum. Patches are also attached. > > This patch include also two enhancements. It ad

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-10 Thread Michael Calmer
Hi, Am Mittwoch, 9. März 2011, 11:29:45 schrieb Jan Pazdziora: > On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: [...] > when running git am, I get the following whitespace-related warnings. > Could you please polish the patch to get rid of them? Sure, I will work on all the issu

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-09 Thread Jan Pazdziora
On Mon, Mar 07, 2011 at 02:28:48PM +0100, Michael Calmer wrote: > Hello, > > the attached patch set implements updateinfo to errata import in spacewalk- > repo-sync. > This patch also requires two small changes to yum. Patches are also attached. Michael, when running git am, I get the following

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-08 Thread Miroslav Suchy
Dne 8.3.2011 17:57, Michael Calmer napsal(a): Hi, Am Montag, 7. März 2011, 15:49:59 schrieb Miroslav Suchý: On 03/07/2011 02:28 PM, Michael Calmer wrote: Hello, [...] Regarding patch 0001-implement-updateinfo-Errata-import-5.patch... It seems to me that it is merge of 4 smaller commits and

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-08 Thread Michael Calmer
Hi, Am Montag, 7. März 2011, 15:49:59 schrieb Miroslav Suchý: > On 03/07/2011 02:28 PM, Michael Calmer wrote: > > Hello, [...] > Regarding patch 0001-implement-updateinfo-Errata-import-5.patch... > It seems to me that it is merge of 4 smaller commits and therefore the > commit description is q

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-07 Thread Michael Calmer
Hi, Am Montag, 7. März 2011, 15:05:36 schrieb Miroslav Suchý: > On 03/07/2011 02:28 PM, Michael Calmer wrote: > > Hello, > > > > the attached patch set implements updateinfo to errata import in > > spacewalk-repo-sync. > > This patch also requires two small changes to yum. Patches are also > > at

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-07 Thread Miroslav Suchý
On 03/07/2011 02:28 PM, Michael Calmer wrote: > Hello, > > the attached patch set implements updateinfo to errata import in spacewalk- > repo-sync. Regarding patch 0001-implement-updateinfo-Errata-import-5.patch... It seems to me that it is merge of 4 smaller commits and therefore the commit desc

Re: [Spacewalk-devel] [PATCH] updateinfo to Errata import in spacewalk-repo-sync

2011-03-07 Thread Miroslav Suchý
On 03/07/2011 02:28 PM, Michael Calmer wrote: > Hello, > > the attached patch set implements updateinfo to errata import in spacewalk- > repo-sync. > This patch also requires two small changes to yum. Patches are also attached. > > This patch include also two enhancements. It adds errata_from to