Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Dirk Hohndel
> On Sep 24, 2018, at 9:33 AM, Linus Torvalds > wrote: > > I'd actually argue that a dive site could be described as an "area", True. Because our data isn't confusing and inconsistent enough, we could add a "focus point" plus NW and SE corner :-) >> (b) a dive itself can be described in

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Monty Taylor
On 09/24/2018 11:33 AM, Linus Torvalds wrote: On Mon, Sep 24, 2018 at 9:04 AM Dirk Hohndel wrote: (a) a dive site, as an independent entity from a dive, does have a logical GPS location. One can argue where that is and in many ways that's a matter of taste and opinion (e.g., is it where you

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Monty Taylor
On 09/24/2018 11:04 AM, Dirk Hohndel wrote: So Linus said some interesting things about this topic - and others have added in the past. I'd like to try and connect some of the dots here - please correct me if I get things wrong... (a) a dive site, as an independent entity from a dive, does have

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Linus Torvalds
On Mon, Sep 24, 2018 at 9:33 AM Linus Torvalds wrote: > > But people literally do blackwater dives too, where you absolutely do > *not* have a site at all. You're literally just in a fairly random > location. You're doing it for Oops, this got cut short because I was editing something else. It

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Linus Torvalds
On Mon, Sep 24, 2018 at 9:04 AM Dirk Hohndel wrote: > > (a) a dive site, as an independent entity from a dive, does have a > logical GPS location. One can argue where that is and in many ways > that's a matter of taste and opinion (e.g., is it where you enter the water, > or is it where the

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Dirk Hohndel
So Linus said some interesting things about this topic - and others have added in the past. I'd like to try and connect some of the dots here - please correct me if I get things wrong... (a) a dive site, as an independent entity from a dive, does have a logical GPS location. One can argue where

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Linus Torvalds
On Mon, Sep 24, 2018 at 6:12 AM Monty Taylor wrote: > > Maybe at least collect the start/end GPS so we have them in the data, > and maybe later someone will good idea for visualization? For the Garmin Descent, the way it's currently done is that start/end coordinates are captures as "extra data"

Re: Silly problem with dive sites and GPS downloading

2018-09-24 Thread Monty Taylor
On 09/22/2018 04:07 PM, Dirk Hohndel wrote: PS. We have another pending problem with the dive site situaiton: the Garmin Descent Mk1 gives us both entry and exit coordinates, and having done four drift dives with it, I actually really *would* like to have our mapping to show it as not a flag,

Re: Silly problem with dive sites and GPS downloading

2018-09-23 Thread Dirk Hohndel
> On Sep 23, 2018, at 10:48 AM, Anton Lundin wrote: > > Quite a bit OT, but continuing in that tangent, it might be time for the > DLF thingie to grow up and become a proper libdivecomputer backend, > instead of the subsurface specific importer we got right now. All the > usb-file-import

Re: Silly problem with dive sites and GPS downloading

2018-09-23 Thread Linus Torvalds
On Sat, Sep 22, 2018 at 11:33 PM Berthold Stoeger wrote: > > This is actually on my TODO-list, notably when making import-dives undo-able. > Just like on undo/redo of add-dives we have to remove/add implicitly generated > dive-trips, on undo/redo of import-dives we'll have to remove/add new dive-

Re: Silly problem with dive sites and GPS downloading

2018-09-23 Thread Anton Lundin
On 23 September, 2018 - Berthold Stoeger wrote: > Hi Linus, > > On Sunday, 23 September 2018 00:17:38 CEST Linus Torvalds wrote: > > On Sat, Sep 22, 2018 at 2:35 PM Linus Torvalds > > > > wrote: > > > But it's basically unfixable as it is now. As long as a "struct dive" > > > contains that

Re: Silly problem with dive sites and GPS downloading

2018-09-23 Thread Berthold Stoeger
Hi Linus, On Sunday, 23 September 2018 00:17:38 CEST Linus Torvalds wrote: > On Sat, Sep 22, 2018 at 2:35 PM Linus Torvalds > > wrote: > > But it's basically unfixable as it is now. As long as a "struct dive" > > contains that broken "uint32_t dive_site_uuid;" as the dive site > > descriptor,

Re: Silly problem with dive sites and GPS downloading

2018-09-22 Thread Dirk Hohndel
> On Sep 22, 2018, at 3:17 PM, Linus Torvalds > wrote: > > On Sat, Sep 22, 2018 at 2:35 PM Linus Torvalds > wrote: >> >> But it's basically unfixable as it is now. As long as a "struct dive" >> contains that broken "uint32_t dive_site_uuid;" as the dive site >> descriptor, we *have* to

Re: Silly problem with dive sites and GPS downloading

2018-09-22 Thread Linus Torvalds
On Sat, Sep 22, 2018 at 2:35 PM Linus Torvalds wrote: > > But it's basically unfixable as it is now. As long as a "struct dive" > contains that broken "uint32_t dive_site_uuid;" as the dive site > descriptor, we *have* to create the dive site this way. Side note: one possible solution is to get

Re: Silly problem with dive sites and GPS downloading

2018-09-22 Thread Linus Torvalds
On Sat, Sep 22, 2018 at 2:07 PM Dirk Hohndel wrote: > > > On Sep 22, 2018, at 11:17 AM, Linus Torvalds > > wrote: > > > > Wrong again. As part of parsing the dive download, it obviously parses the > > GPS data, and it generates the dive site information for the GPS data. > > And this happens