Re: [systemd-devel] [Fwd: [PATCH] journal: fix dereferenced pointer in journal_file_rotate()]

2012-05-22 Thread shawn
On Tue, 2012-05-22 at 08:40 +0200, Sjoerd Simons wrote: > On Mon, 2012-05-21 at 21:35 -0700, shawn wrote: > > > If journal_file_open() failed, due to (e.g.) -ENOSPC on open() > > > new_file might still be NULL. > > > > > > On error, leave pointer to the old JournalFile (now closed), > > > and req

[systemd-devel] Trying systemd with Debian Sid/unstable on ASRock E350M1 with Crucial m4 SSD

2012-05-22 Thread Paul Menzel
Dear systemd folks, hopefully it is alright to report my findings here. If you have any suggestions to improve the startup time, please do not hesitate to tell me. ;-) Hardware • ASRock E350M1 with dual core 1.6 GHz Fusion CPU [1] • Crucial m4 SSD connected via SATA-3-cable [2] • one Ex

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-22 Thread Lennart Poettering
On Mon, 21.05.12 23:04, shawn (shawnland...@gmail.com) wrote: Heya, > Uggh, sorry for sending that super-buggy patch. Here is a better > version. > > On Mon, 2012-05-21 at 22:59 -0700, Shawn Landden wrote: > > cgtop quits on startup if all the cgroup mounts it expects are not ready. > > Provide

Re: [systemd-devel] [Fwd: [PATCH] journal: fix dereferenced pointer in journal_file_rotate()]

2012-05-22 Thread Sjoerd Simons
On Mon, 2012-05-21 at 21:35 -0700, shawn wrote: > > If journal_file_open() failed, due to (e.g.) -ENOSPC on open() > > new_file might still be NULL. > > > > On error, leave pointer to the old JournalFile (now closed), > > and require caller to check for error approiately. > > > > Bugzilla: ht

Re: [systemd-devel] [Fwd: [PATCH] journal: fix dereferenced pointer in journal_file_rotate()]

2012-05-22 Thread Lennart Poettering
On Tue, 22.05.12 08:40, Sjoerd Simons (sjo...@luon.net) wrote: > > On Mon, 2012-05-21 at 21:35 -0700, shawn wrote: > > > If journal_file_open() failed, due to (e.g.) -ENOSPC on open() > > > new_file might still be NULL. > > > > > > On error, leave pointer to the old JournalFile (now closed), > >

Re: [systemd-devel] [Fwd: [PATCH] journal: fix dereferenced pointer in journal_file_rotate()]

2012-05-22 Thread Sjoerd Simons
On Tue, 2012-05-22 at 13:26 +0200, Lennart Poettering wrote: > On Tue, 22.05.12 08:40, Sjoerd Simons (sjo...@luon.net) wrote: > > > > > On Mon, 2012-05-21 at 21:35 -0700, shawn wrote: > > > > If journal_file_open() failed, due to (e.g.) -ENOSPC on open() > > > > new_file might still be NULL. > >

[systemd-devel] [PATCH] util: rm_rf_children() add root_dev parameter

2012-05-22 Thread harald
From: Harald Hoyer if root_dev is set, remove subdirectories only, if the device is the same as the root_dev. This prevents to remove files across device boundaries. --- src/shared/util.c | 39 ++- src/shared/util.h |2 +- 2 files changed, 27 insertions(

[systemd-devel] [PATCH] switch-root: do not use close_nointr_nofail()

2012-05-22 Thread harald
From: Harald Hoyer rm_rf_children() might have already closed the fd with closedir(). We just don't know. --- src/core/switch-root.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/switch-root.c b/src/core/switch-root.c index ed0a31e..1802dc1 100644 --- a/src/core

Re: [systemd-devel] [PATCH] util: rm_rf_children() add root_dev parameter

2012-05-22 Thread Harald Hoyer
Am 22.05.2012 15:19, schrieb har...@redhat.com: > From: Harald Hoyer > > if root_dev is set, remove subdirectories only, if the device is the > same as the root_dev. This prevents to remove files across device > boundaries. > --- > src/shared/util.c | 39 ++-

[systemd-devel] [PATCH] switch-root: do not use close old_root_fd after rm_rf_children()

2012-05-22 Thread harald
From: Harald Hoyer rm_rf_children() has already closed the fd with closedir(). --- src/core/switch-root.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/switch-root.c b/src/core/switch-root.c index ed0a31e..9832a52 100644 --- a/src/core/switch-root.c +++ b/src

Re: [systemd-devel] [PATCH] switch-root: do not use close_nointr_nofail()

2012-05-22 Thread Harald Hoyer
Am 22.05.2012 15:19, schrieb har...@redhat.com: > From: Harald Hoyer > > rm_rf_children() might have already closed the fd with closedir(). > We just don't know. revised patch sent ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org htt

Re: [systemd-devel] [PATCH] switch-root: do not use close old_root_fd after rm_rf_children()

2012-05-22 Thread Lennart Poettering
On Tue, 22.05.12 15:28, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > rm_rf_children() has already closed the fd with closedir(). Thanks! Applied! Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list

Re: [systemd-devel] pam_systemd.so and su

2012-05-22 Thread Frederic Crozat
Le jeudi 22 mars 2012 à 02:11 +0100, Lennart Poettering a écrit : > On Thu, 22.03.12 00:41, Lennart Poettering (lenn...@poettering.net) wrote: > > > On Sun, 18.03.12 16:08, Canek Peláez Valdés (can...@gmail.com) wrote: > > > > > Hi; I'm using systemd 43 in Gentoo, and I usally have this line at t

Re: [systemd-devel] Trying systemd with Debian Sid/unstable on ASRock E350M1 with Crucial m4 SSD

2012-05-22 Thread Michael Biebl
2012/5/22 Paul Menzel : > 2. GDM 3 did not list the available users though, which had to be > entered manually. After logging out again users are displayed fine. The user list is populated via accountsservice. A D-Bus activated system service. accounts-daemon.service shows up in your list above. S

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-22 Thread shawn
On Tue, 2012-05-22 at 13:12 +0200, Lennart Poettering wrote: > On Mon, 21.05.12 23:04, shawn (shawnland...@gmail.com) wrote: > > Heya, > > > Uggh, sorry for sending that super-buggy patch. Here is a better > > version. > > > > On Mon, 2012-05-21 at 22:59 -0700, Shawn Landden wrote: > > > cgtop

[systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Lennart Poettering
Heya, just a quick heads-up. I just commited to git some work that rips out the fstab parsing from PID 1 and places this in a generator instead. The idea is that sooner or later we only parse native unit files from PID 1, and everything else is transformed as needed with generators. This makes the

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Bardur Arantsson
On 05/22/2012 08:03 PM, Lennart Poettering wrote: > Heya, > > just a quick heads-up. I just commited to git some work that rips out > the fstab parsing from PID 1 and places this in a generator instead. The > idea is that sooner or later we only parse native unit files from PID 1, > and everything

[systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Joachim Banzhaf
Hi, I found out about systemd because openSUSE uses it now. I read the annoncement and the three updates of it and some more and can say I like systemd a lot. It just seems to be the right way to do process/service management. As it happens I also like IBM DB2 a lot (for other reasons). DB2 is cl

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Kay Sievers
On Tue, May 22, 2012 at 9:26 PM, Bardur Arantsson wrote: > On 05/22/2012 08:03 PM, Lennart Poettering wrote: >> just a quick heads-up. I just commited to git some work that rips out >> the fstab parsing from PID 1 and places this in a generator instead. The >> idea is that sooner or later we only

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Kay Sievers
On Tue, May 22, 2012 at 9:27 PM, Joachim Banzhaf wrote: > I found out about systemd because openSUSE uses it now. > I read the annoncement and the three updates of it and some more and can > say I like systemd a lot. > It just seems to be the right way to do process/service management. > > As it h

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Tomasz Torcz
On Tue, May 22, 2012 at 09:27:34PM +0200, Joachim Banzhaf wrote: > As it happens I also like IBM DB2 a lot (for other reasons). > DB2 is closed source (I hope you dont stop reading now) and it installs > an inittab entry. > > fmc:2345:respawn:/opt/ibm/db2/V10.1/bin/db2fmcd #DB2 Fault Monitor > Coo

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Joachim Banzhaf
Thanks for your answers, all three of them! Am 22.05.2012 21:42, schrieb Tomasz Torcz: > Restart=always AFAIK SysV init restarts the service on failures immediatelly for some times, then uses a delay of some minutes before it retries, which seems sensible. If I understand systemd.service man corre

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Reindl Harald
Am 22.05.2012 22:06, schrieb Joachim Banzhaf: > Thanks for your answers, all three of them! > > Am 22.05.2012 21:42, schrieb Tomasz Torcz: >> Restart=always > AFAIK SysV init restarts the service on failures immediatelly for some times, > then uses a delay of some minutes > before it retries, wh

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Tomasz Torcz
On Tue, May 22, 2012 at 10:06:04PM +0200, Joachim Banzhaf wrote: > Thanks for your answers, all three of them! > > Am 22.05.2012 21:42, schrieb Tomasz Torcz: > > Restart=always > AFAIK SysV init restarts the service on failures immediatelly for some > times, then uses a delay of some minutes befor

[systemd-devel] How to set complex environment for apache?

2012-05-22 Thread Joachim Banzhaf
Me again :) I use apache to serve php pages that connect to a DB2 database via the php_pdo interface. For this to work, I have to set a DB2 specific environment. To make that easy, there is a shell script provided that does the necessary adjustments (db2profile). With SysV init I sourced that scr

Re: [systemd-devel] Is there a general inittab entry replacement available?

2012-05-22 Thread Joachim Banzhaf
Am 22.05.2012 22:13, schrieb Tomasz Torcz: > On Tue, May 22, 2012 at 10:06:04PM +0200, Joachim Banzhaf wrote: >> Thanks for your answers, all three of them! >> >> Am 22.05.2012 21:42, schrieb Tomasz Torcz: >>> Restart=always >> AFAIK SysV init restarts the service on failures immediatelly for some

Re: [systemd-devel] How to set complex environment for apache?

2012-05-22 Thread Joachim Banzhaf
It sets and modifies environment variables. I'll have a look and try, thanks. sorry for smartphone brevity ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] How to set complex environment for apache?

2012-05-22 Thread Zbigniew Jędrzejewski-Szmek
On 05/22/2012 10:46 PM, Joachim Banzhaf wrote: > It sets and modifies environment variables. I'll have a look and try, See also Environment= and EnvironmentFile= in systemd.exec(5). Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.o

Re: [systemd-devel] How to set complex environment for apache?

2012-05-22 Thread Zbigniew Jędrzejewski-Szmek
On 05/22/2012 10:16 PM, Joachim Banzhaf wrote: > Me again :) > > I use apache to serve php pages that connect to a DB2 database via the > php_pdo interface. > For this to work, I have to set a DB2 specific environment. > To make that easy, there is a shell script provided that does the > necessary

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Gustavo Sverzut Barbieri
On Tue, May 22, 2012 at 3:03 PM, Lennart Poettering wrote: > Heya, > > just a quick heads-up. I just commited to git some work that rips out > the fstab parsing from PID 1 and places this in a generator instead. The > idea is that sooner or later we only parse native unit files from PID 1, > and e

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Kay Sievers
On Tue, May 22, 2012 at 11:13 PM, Gustavo Sverzut Barbieri wrote: > Lennart, Kay: I hate you damn it! :-D I have nothing against you beside that you talk total nonsense below. :) > Man, how can a fstab file be so complex to justify it? It's simpler > than the service files we already load. Now

[systemd-devel] OT: Races with GDM3 and accountsservice (was: Trying systemd with Debian Sid/unstable on ASRock E350M1 with Crucial m4 SSD)

2012-05-22 Thread Paul Menzel
Am Dienstag, den 22.05.2012, 18:41 +0200 schrieb Michael Biebl: > 2012/5/22 Paul Menzel : > > 2. GDM 3 did not list the available users though, which had to be > > entered manually. After logging out again users are displayed fine. > > The user list is populated via accountsservice. > A D-Bus acti

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Gustavo Sverzut Barbieri
On Tue, May 22, 2012 at 6:47 PM, Kay Sievers wrote: > On Tue, May 22, 2012 at 11:13 PM, Gustavo Sverzut Barbieri > wrote: > >> Lennart, Kay: I hate you damn it! :-D > > I have nothing against you beside that you talk total nonsense below. :) > >> Man, how can a fstab file be so complex to justify

Re: [systemd-devel] [HEADSUP] fstab now parsed by generator in systemd git

2012-05-22 Thread Kay Sievers
On Wed, May 23, 2012 at 12:05 AM, Gustavo Sverzut Barbieri wrote: > On Tue, May 22, 2012 at 6:47 PM, Kay Sievers wrote: >> On Tue, May 22, 2012 at 11:13 PM, Gustavo Sverzut Barbieri >> wrote: >> >>> Lennart, Kay: I hate you damn it! :-D >> >> I have nothing against you beside that you talk total