Re: bgpd: adjust loopback filter for network statements

I agree with this. ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.12.23 15:37:02 +0100: > In bgpd statements like > network inet static > or > network rtlabel "exportme" > will skip routes that use 127.0.0.1 as nexthop. This makes sense for > network connected and network s

Re: bgpd show status of set tables

reads ok, benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.12.29 10:33:53 +0100: > On Thu, Dec 10, 2020 at 02:42:49PM +0100, Claudio Jeker wrote: > > On Thu, Dec 03, 2020 at 10:59:29PM +0100, Claudio Jeker wrote: > > > The use of roa-set, prefix-set and as-set is fairly common in bgpd. > > >

Re: bgpd: getifaddrs ifa_addr NULL check

Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.12.29 10:29:00 +0100: > On Thu, Dec 17, 2020 at 01:26:09PM +0100, Claudio Jeker wrote: > > getifaddrs can return a struct ifaddrs entry with a NULL ifa_addr. > > I think an unnumbered point-to-point interface can trigger this. > > So better check for

Re: kern.video.record man page updates

ok. maybe add a line to current.html so that people are not surprised that their video is no longer working after upgrade. /Benno Marcus Glocker(mar...@nazgul.ch) on 2020.12.28 23:47:54 +0100: > Since I'm receiving various private queries about documenting the new > kern.video.record sysctl(2)

Re: bgpd refactor roa-set internals

ok. Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.12.29 10:23:53 +0100: > On Fri, Dec 18, 2020 at 11:36:33AM +0100, Claudio Jeker wrote: > > In preparation for RTR support this diff changes the internal > > representation of roa-set to a simple RB tree based on struct roa. > > The big differen

usr.sbin/* getifaddrs ifa_addr NULL check

Hi, claudios bgpd diff and florian mentioning rad(8) made me look into usr.sbin/ for getifaddrs() usage. I think these need a NULL check as well. ok? diff --git usr.sbin/ospf6d/parse.y usr.sbin/ospf6d/parse.y index f163e24149d..509aa2f2e88 100644 --- usr.sbin/ospf6d/parse.y +++ usr.sbin/ospf6d/p

more getifaddrs ifa_addr NULL checks

More missing checks, outside of usr.sbin. Missing: isakmpd and ifconfig I have not yet looked at libc internal use, libpcap and regress/. ok? diff --git sbin/iked/parse.y sbin/iked/parse.y index aedbb74f3fd..b02ff55d4e7 100644 --- sbin/iked/parse.y +++ sbin/iked/parse.y @@ -2166,7 +2166,8 @@ i

getifaddrs ifa_addr NULL checks round 3

Another set of NULL checks in programs under usr.sbin/ ok? diff --git usr.sbin/eigrpd/parse.y usr.sbin/eigrpd/parse.y index f024e3cf0cd..0ac9431e829 100644 --- usr.sbin/eigrpd/parse.y +++ usr.sbin/eigrpd/parse.y @@ -1246,7 +1246,8 @@ get_rtr_id(void) for (ifa = ifap; ifa; ifa = ifa->ifa_n

getifaddrs ifa_addr NULL checks, last set

Hi, these last ones are a bit different from the others: Two cases in libc, two in ifconfig, and one in isakmpd that is a bit tricky. comments? ok? diff --git lib/libc/rpc/get_myaddress.c lib/libc/rpc/get_myaddress.c index d0ac78f796e..b84968e1807 100644 --- lib/libc/rpc/get_myaddress.c +++ lib

npppd: result of getifaddrs() not used?

It seems to me that this call to getifaddrs() is actually not needed. ok? diff --git usr.sbin/npppd/pppoe/pppoed.c usr.sbin/npppd/pppoe/pppoed.c index 5b3f09dccb1..bae41732199 100644 --- usr.sbin/npppd/pppoe/pppoed.c +++ usr.sbin/npppd/pppoe/pppoed.c @@ -458,7 +459,6 @@ pppoed_reload(pppoed *_thi

getifaddrs(3) manpage improvement

Hi, maybe add a hint about the needed check? comments? ok? diff --git lib/libc/net/getifaddrs.3 lib/libc/net/getifaddrs.3 index 26eac493202..946c2d9a9b0 100644 --- lib/libc/net/getifaddrs.3 +++ lib/libc/net/getifaddrs.3 @@ -74,13 +74,13 @@ Contains the interface flags, as set by References eith

Re: acme-client(1): backup certs

ok Florian Obser(flor...@openbsd.org) on 2021.01.02 17:23:11 +0100: > > Create .1 backup files when acme-client is going to overwrite a > certificate file. > > This files are not terribly big and it's convenient to keep one > previous file around for example if one adds or removes domains to the

Re: fix opsfd parse.y shit/reduce conflicts

Thanks, i think the dependon might have been my fault. code reads ok. I also checked a few configs, including an artificial one that uses depend on. /Benno Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.06 11:11:49 +0100: > The dependon statement in ospfd parse.y introduces some troubles si

Re: bgpd simplify update path

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.07 19:34:23 +0100: > When bgpd generates an UPDATE to update or withdraw prefixes it does this > from rde_generate_updates() and then decends into up_generate_update(). > Now there is up_test_update() that checks if a new prefix is actually OK > to

OpenBSD Errata: January 11th, 2021 (nd6)

Errata patches for the kernel have been released for OpenBSD 6.7 and 6.8. When an NDP entry is invalidated the associated layer 2 address is not invalidated. Binary updates for the amd64, i386, and arm64 platforms are available via the syspatch utility. Source code patches can be found on the res

Re: Make ospf6d work on point-to-point links

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.12 10:07:57 +0100: > On Wed, Jan 06, 2021 at 01:02:50PM +0100, Claudio Jeker wrote: > > The code in ospf6d is a bit broken when it comes to point-to-point links. > > This diff fixes this by a) using the neighbor address instead of the unset > > int

OpenBSD Errata: January 13th, 2021 (carp)

Errata patches for the kernel have been released for OpenBSD 6.8. Use of bpf(4) on a carp interface could result in a use after free error. Binary updates for the amd64, i386, and arm64 platforms are available via the syspatch utility. Source code patches can be found on the respective errata pag

Re: more refactor bgpd route decision process

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.01.13 13:10:23 +0100: > This is another cleanup round of the route decision process. > This time focusing on prefix_cmp(). Make sure that when using > return (a - b) that the results always fits in an int type. > Also make sure the check of the remote

Re: grep: add --null flag

Hi, the diff looks good, i would change the wording in the manpage a bit, see below. Anyone else who wants to ok it? /Benno Omar Polo(o...@omarpolo.com) on 2021.01.22 12:19:08 +0100: > > quasi three-weekly ping. > > Is this such a bad idea? > > (TBH: I have still to look at how to write a

Re: grep: add --null flag

Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > Stuart Henderson wrote: > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > I completely despise that the option is called "--null". > > > > > > Someone was a complete idiot. > > > > gnu grep has both --null and -z for this (w

Re: grep: add --null flag

Sebastian Benoit(be...@openbsd.org) on 2021.01.25 00:27:05 +0100: > Theo de Raadt(dera...@openbsd.org) on 2021.01.24 16:01:32 -0700: > > Stuart Henderson wrote: > > > > > On 2021/01/24 12:10, Theo de Raadt wrote: > > > > I completely despi

Re: "monitoring only" interfaces

David Gwynne(da...@gwynne.id.au) on 2021.01.27 17:13:09 +1000: > some of the discussion around dup-to made me think that a diff we > have here at work might be more broadly useful. > > we run a box here with a bunch of ethernet ports plugged into span > ports on switches. basically every packet go

Re: unwind(8): improve DNS64 detection

Florian Obser(flor...@openbsd.org) on 2021.02.06 19:18:20 +0100: > I noticed that sometimes DNS64 detection is not working correctly on > boot. Eventually I tracked it down to this: > Feb 6 08:56:22 x1 unwind[7139]: check_dns64_done: bad packet: too short: -1 > > The problem is that we are checki

Re: apmd: log ioctl failures

Klemens Nanni(k...@openbsd.org) on 2021.03.25 19:45:04 +0100: > On Sat, Mar 20, 2021 at 07:46:38PM +0100, Klemens Nanni wrote: > > Otherwise there is no way other than reading driver code to determine > > why running zzz(8) for example does not do anything on certain machines. > > > > apm(4/arm64)

delete unused variable in ix(4) rx checksum calc

ptype is never used. ok? diff --git sys/dev/pci/if_ix.c sys/dev/pci/if_ix.c index cb233034d23..72a221b97d9 100644 --- sys/dev/pci/if_ix.c +++ sys/dev/pci/if_ix.c @@ -148,7 +148,7 @@ voidixgbe_enable_intr(struct ix_softc *); void ixgbe_disable_intr(struct ix_softc *); intixgbe_txeof

Re: bgpd move nexthops to RB tree

Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.30 19:11:15 +0200: > I'm on a mission to remove the hash tables :) > > This one is for struct nexthop. Hopefully it makes nexthop_get a bit > better. ok, but one __func__ below > > -- > :wq Claudio > > Index: rde.c > =

make kernel build without INET6 again (pf_lb.c)

ok? diff --git sys/net/pf_lb.c sys/net/pf_lb.c index 588115cbff7..905af42e463 100644 --- sys/net/pf_lb.c +++ sys/net/pf_lb.c @@ -519,13 +519,18 @@ pf_map_addr(sa_family_t af, struct pf_rule *r, struct pf_addr *saddr, * fall back to POOL_NONE if there is a single host

Re: bgpd: only run one roa softreconfig process at a time

ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.30 22:54:43 +0200: > Currently if bgpd takes a long time to re-evaluate all prefixes because of > a ROA change a second update can come in before the first is processed. > This is not good. So add a barrier to only run one rde_roa_softreconfig

Re: bgpd change attr cache to use RB tree

Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.08.31 13:56:18 +0200: > Like all other hash tables use an RB tree instead. > Again the calculation of the hash can be skipped because the compare > function is probably fast enough. that sentence does parse, but i am semantically challenged by it. d

Re: bgpd cleanup hash leftovers

ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.01 12:48:32 +0200: > bgpd no longer needs siphash.h and also remove a hash member and a > prototype which are now unused. > > -- > :wq Claudio > > Index: rde.h > === > RCS file:

Re: bgpd switch rde_peer to RB tree

Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.01 12:04:03 +0200: > Convert the rde_peer hash table to an RB tree. This is a bit more complex > because rde_peer list is used in a lot of places. As a bonus use > peer_foreach in mrt.c to write the table v2 peer header (this needs a > special call

Re: ps(1): add -d (descendancy) option to display parent/child process relationships

Job Snijders(j...@openbsd.org) on 2022.09.01 03:37:59 +: > Dear all, > > Some ps(1) implementations have an '-d' ('descendancy') option. Through > ASCII art parent/child process relationships are grouped and displayed. > Here is an example: > > $ ps ad -O ppid,user > PID PPID USER

Re: httpd: overwrite rather than error for duplicate type entries

thanks, commited! Florian Obser(flor...@openbsd.org) on 2022.09.02 08:08:09 +0200: > This diff is correct and the use-case makes sense to me. > OK florian > > > On 2022-09-01 21:30 +01, Ben Fuller wrote: > > On Thu, Sep 01, 2022 at 21:22:13 +0100, Ben Fuller wrote: > >> On Thu, Sep 01, 2022 at

Re: unbound and cannot increase max open fds from 512 to 4152

Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > Hi, > > I have a question, could or should unbound in base be delivered with: > > # cat /etc/login.conf.d/unbound > unbound:\ > :openfiles-cur=4096:\ > :openfiles-max=8192:\ > :tc=daemon: > > or the

Re: unbound and cannot increase max open fds from 512 to 4152

Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 08:07:01 +: > On Fri, Sep 02, 2022 at 09:53:54AM +0200, Sebastian Benoit wrote: > > Mikolaj Kucharski(miko...@kucharski.name) on 2022.09.02 06:47:00 +: > > > Hi, > > > > > > I have a question

Re: unbound and cannot increase max open fds from 512 to 4152

Stuart Henderson(s...@spacehopper.org) on 2022.09.02 12:16:06 +0100: > On 2022/09/02 11:25, Sebastian Benoit wrote: > > > > > Sep 2 06:39:58 x1c unbound: [14264:0] notice: Restart of unbound > > > > > 1.16.0. > > > > > Sep 2 06:39

Re: rpki-client add abort to rrdp

Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.02 19:55:28 +0200: > We want to be able to abort RRDP syncs. Now the problem is that depending > on the state the abort request is more or less complex. What needs to be > avoided is that a message received after the corresponding RRDP session > wa

Re: mld6 remove global variable

Alexander Bluhm(alexander.bl...@gmx.net) on 2022.09.02 20:38:04 +0200: > Hi, > > Due to the KAME scope address hack, the link-local all nodes and > routers IPv6 addresses cannot be const. So move memory from data > to stack to make variables MP safe. > > ok? > > bluhm > > Index: netinet6/mld6.

Re: mld6 remove global variable

that was meant to be an ok :) Sebastian Benoit(be...@openbsd.org) on 2022.09.02 22:04:41 +0200: > Alexander Bluhm(alexander.bl...@gmx.net) on 2022.09.02 20:38:04 +0200: > > Hi, > > > > Due to the KAME scope address hack, the link-local all nodes and > > routers IPv

Re: rpki-client stop all repo fetching a bit before the timeout

Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.09.02 22:02:33 +0200: > Lets try to finish work by stopping all syncs and fall back to what we > have in cache after 7/8 of the timeout (timeout - 1/2 repo_timeout). > This way we still have 1/8 of time to finish the calculation and produce > output.

rpki-client 8.0 released

. See RFC 6480 and RFC 6811 for a description of how RPKI and BGP Prefix Origin Validation help secure the global Internet routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, Theo Buehler, Theo de Raadt and Sebastian Benoit as part of the OpenBSD

Re: wc(1): add -L flag to write length of longest line

Theo de Raadt(dera...@openbsd.org) on 2022.09.30 11:11:42 -0600: > I'm sure there are other people have other desireable features which I > haven't listed. For instance, could wc.c be the scaffold to use for the > long-desired web browser to be included in OpenBSD? Oh, it's clearly incomplete unti

Re: tzset(3): update man page to reality

Todd C. Miller(mill...@openbsd.org) on 2022.10.03 13:32:22 -0600: > On Mon, 03 Oct 2022 13:27:05 -0600, "Todd C. Miller" wrote: > > > We did not document tzname, timezone or daylight and the rules > > regarding pathnames was not entirely clear. reads ok to me > > I think it is worth mentioning t

rpki-client 8.5 has been released

. See RFC 6480 and RFC 6811 for a description of how RPKI and BGP Prefix Origin Validation help secure the global Internet routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, Theo Buehler, Theo de Raadt and Sebastian Benoit as part of the OpenBSD

rpki-client 8.6 has been released

. See RFC 6480 and RFC 6811 for a description of how RPKI and BGP Prefix Origin Validation help secure the global Internet routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, Theo Buehler, Theo de Raadt and Sebastian Benoit as part of the OpenBSD

Re: log.c use buffered IO

Theo Buehler(t...@theobuehler.org) on 2023.10.17 09:13:15 +0200: > On Mon, Oct 16, 2023 at 12:19:17PM +0200, Claudio Jeker wrote: > > I dislike how log.c does all these asprintf() calls with dubious > > workaround calls in case asprintf() fails. > > You're not alone. > > > IMO it is easier to use

Re: Improve IPv6 link-local support in bgpd

Claudio Jeker(cje...@diehard.n-r-g.com) on 2023.10.16 09:23:12 +0200: > This diff fixes a few more things when establishing connections with > link-local IPv6 addresses. In get_alternate_addr() the interface scope > of the connection is recovered and then passed to the RDE. The RDE can > then use t

Re: relayd.conf.5: less SSL

Klemens Nanni(k...@openbsd.org) on 2023.10.26 13:28:42 +: > On Tue, Oct 24, 2023 at 09:09:21AM +0200, Peter N. M. Hansteen wrote: > > On Tue, Oct 24, 2023 at 06:54:30AM +, Klemens Nanni wrote: > > > - parse.y still accepting undocumented "ssl" with a warning since 2014 > > > - more "SSL/TLS

Re: BIRD 1.x/2.x support at rpki-client

Robert Scheck(rob...@fedoraproject.org) on 2020.03.03 01:20:24 +0100: > Hi, > > job@ suggested to move this from GitHub to tech@ list (as upstream): > > 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per >BIRD upstream the "combined format" produced by rpki-client can't

Re: BIRD 1.x/2.x support at rpki-client

Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch > > Exactly. Ah, i though

Re: BIRD 1.x/2.x support at rpki-client

Hi, generate 3 different outputs for BIRD: - bird v1 with IPv4 routes - bird v1 with IPv6 routes - bird v2 when using command line option -B. BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org Note that I haven't tried this with bird 1 or 2 yet ;) comments, oks? (benno_rpki_bir

Re: BIRD 1.x/2.x support at rpki-client

Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +: > I have a small suggestion, in some deployments I saw the convention to > name it as following so it is clear the data came from user provided > data rather than internal bird structures > > I tested Benno's patch against BIRD 1.6.6 -

Re: BIRD 1.x/2.x support at rpki-client

Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch Thanks for the patch. I co

Re: regress: bgpd: config: Fix attribute ordering

I dont see that here. Sure that you have an up-to-date tree? And no diff in there? Klemens Nanni(k...@openbsd.org) on 2020.03.05 23:39:20 +0100: > > I ran bgpd to test diffs and stumbled across what looks like simple > disorder in the config checks. > > bgpd must have changed in how it orders a

Re: bgpctl code reshuffle

Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.03.19 18:42:28 +0100: > Move some more output functions to output.c and convert some other > functions to a fmt_xyz() function that returns a string with the value > instead of doing a printf(). This is mostly mechanical but please test. > ok > --

Re: rpki-client and non-existing files

ok you remove the "if (verbose > 0)" in the cms_parse_validate() case on purpose? Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.01 16:33:44 +0200: > On Wed, Apr 01, 2020 at 01:06:21PM +0200, Claudio Jeker wrote: > > Currently rpki-client logs missing files like this: > > > > rpki-client: .

Re: slaacd(8): honour rdomain we are running in

Florian Obser(flor...@openbsd.org) on 2020.04.12 19:53:23 +0200: > OK? yes, this is probably better than having it configurable via option. > diff --git slaacd.c slaacd.c > index 58f15bcda37..dae2eab3434 100644 > --- slaacd.c > +++ slaacd.c > @@ -755,7 +755,7 @@ configure_gateway(struct imsg_conf

Re: cpu utilisation bars for top(1)

Edd Barrett(e...@theunixzoo.co.uk) on 2020.04.13 15:47:03 +0100: > Hi, > > One thing I miss from our top(1) is the ability to see overall CPU > utilisation at a glance (I usually scan for the idle percentage and > invert it in my head). > > This diff adds a way to toggle (using `B`) CPU utilisati

rpki-client 6.6p2 (portable) has been released

routing stacks. See RFC 6811 for a description of how BGP Prefix Origin Validation secures the Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a

Re: unwind(8): recommend supersede in dhclient.conf

Florian Obser(flor...@openbsd.org) on 2020.04.21 06:57:49 +0200: > We didn't get around to run unwind per default and integrate it > tighter with dhclient this release cycle. > But there is also no need anymore to recomend prepend in > dhclient.conf, unwind(8) is no longer closing it's service port

Re: acme-client(1) and Buypass Go SSL

Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.20 18:51:17 +0200: > Hello, > > I've tried to get a certificate from Buypass Go SSL provider using > acme-client(1) but it ends with the following error: > > acme-client: https://api.buypass.com/acme-v02/new-acct: bad HTTP: 400 > acme-client:

Re: acme-client(1) and Buypass Go SSL

Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.21 20:59:54 +0200: > Hello, > > thanks for looking at this! > > On 21/04/2020 17:43, Florian Obser wrote: > >Hi, > > > >thanks for working on this and finding another acme implementor! > > > >On Mon, Apr 20, 2020 at 06:51:17PM +0200, Bartosz K

Re: bgpd local-address improvement

reads ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.23 10:04:15 +0200: > local-address is one of those values that need to be set in some cases but > is not very flexible to use. This diff tries to change this a bit. > > It allows to set the local-address for both IPv4 and IPv6 at the sam

Re: Make Rockchip RK3399 eMMC faster

Mark Kettenis(mark.kette...@xs4all.nl) on 2020.04.23 22:56:17 +0200: > I put this in at some point since I couldn't get the eMMC on my > firefly-rk3399 working otherwise. But its eMMC died and on my > rockpro64 and rk3399-q7 boards things work very well without it. On > the latter board it even m

alpha installation notes INSTALL.alpha

Hi, there have been no floppy images since the 6.2 release. This removes mention of boot floppies from the INSTALL.alpha notes. Maybe someone who knows something about alpha machines can do a check? comments or oks? diff --git distrib/notes/alpha/contents distrib/notes/alpha/contents index eccbc

Re: [PATCH] sysupgrade

James Jerkins(j...@jamesjerkinscomputer.com) on 2020.04.29 22:28:12 -0500: > Hello, > > This patch adds two new options to sysupgrade. The first option is for > small box systems like an APU system that only has the base and manual We wont add tons of options to this tool for every use case. Ju

Re: [patch] relayd.conf.5, DHE params seems incorrect/outdated.

Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200: > Hi all, > > I was trying to score 100 on all the tests over at ssllabs.com, but seem > to only reach 90 on "Key Exchange". Not sure if it's related, but I was > playing with the "dhe" option in relayd.conf(5) in order to increase t

Re: JSON support for bgpctl(8)

Hiltjo Posthuma(hil...@codemadness.org) on 2020.05.01 16:31:33 +0200: > On Fri, May 01, 2020 at 01:18:03PM +0200, Claudio Jeker wrote: > > This diff add JSON output support for bgpctl. > > Most commands should produce now a resonable JSON object. > > The individual objects can probably be improved

Re: iked(8): Removing SHA1 from default transforms

Stuart Henderson(s...@spacehopper.org) on 2020.05.01 23:46:49 +0100: > On 2020/05/02 00:43, Stephan Mending wrote: > > On 02/05/2020 00:40, Stuart Henderson wrote: > > > On 2020/05/02 00:23, Stephan Mending wrote: > > > > Hi, > > > > > > > > I actually read your thread. By what I understood you're

Re: [patch] relayd.conf.5, DHE params seems incorrect/outdated.

Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200: > Hi all, > > I was trying to score 100 on all the tests over at ssllabs.com, but seem > to only reach 90 on "Key Exchange". Not sure if it's related, but I was > playing with the "dhe" option in relayd.conf(5) in order to increase t

Re: teach bgpctl about IPv6 MPLS VPN

Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.08 09:40:38 +0200: > Bgpctl has a way to specify the address family to show in 'show rib' > commands. Teach it to also support IPv6 MPLS VPNs (aka VPNv6). > > OK? ok > -- > :wq Claudio > > Index: parser.c > ==

Re: bgpctl parser cleanup

Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.12 12:42:36 +0200: > Minimal cleanup of things not used in the bgpctl parser. > Bulk is not used and the ADDRESS / PREFIX tokens no longer overwrite the > action since a while. ok benno@ > > -- > :wq Claudio > > Index: parser.c > =

rpki-client 6.7p0 released

Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a base component of OpenBSD every six months, and follows the OpenBSD release numbering scheme. This i

Re: include interface name in rad error message

Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.20 09:12:23 +0200: > In my syslog I have this: > rad[83563]: RA from non link local address :: > now it would be splendid to know on which of the 4 interfaces rad is > operating on this happened. So here is a diff doing that. ok > > -- > :w

Re: {plus,}67.html: fix link crontab(5)

Martin Vahlensieck(open...@academicsolutions.ch) on 2020.05.20 19:15:48 +0200: > Hey there! > > Otherwise it's going to crontab(1). Thanks, commited. Benno

Re: sysupgrade change to allow installing from url

Solene Rapenne(sol...@perso.pw) on 2020.05.25 15:25:40 +0200: > Hi, > > I don't know if this will be accepted but I propose to add a -u [url] > parameter to use older snapshots from an archive server for example. > > I wanted to add an optional parameter to -s at first but in case of > sysupgrade

Re: ospf6d: change the way interfaces are handled

Remi Locherer(remi.loche...@relo.ch) on 2020.06.03 15:36:17 +0200: > On Sat, May 30, 2020 at 04:37:43PM +0200, Denis Fondras wrote: > > This diff updates how ospf6d(8) handles interfaces. > > It is now in line with what ospfd(8) does. > > > > Last step before enabling reload. > > > > Tested again

Re: urtwn(4) hardware crypto

Jonathan Matthew(jonat...@d14n.org) on 2020.06.05 21:54:30 +1000: > This enables use of hardware crypto for CCMP in urtwn(4). As with other > drivers, this reduces cpu usage significantly when moving lots of data. > I've tested this on an assortment of hardware (RTL8188CUS, RTL8188EU, > RTL8192EU)

Re: netstat -R: list rdomains with associated ifs and tables

Remi Locherer(remi.loche...@relo.ch) on 2020.06.10 22:16:36 +0200: > On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > > > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > > > On Mon, Jun 08, 2020 at

Re: netstat -R: list rdomains with associated ifs and tables

Remi Locherer(remi.loche...@relo.ch) on 2020.06.11 21:46:45 +0200: > > This would be clearer if it used table/tables as appropriate e.g. > > > > Routing table: 0 > > Routing table: 100 > > Routing tables: 0 6 7 77 > > > > the code to handle this gets messy though, maybe someone can think >

Re: unveil(2) relayd(8)'s main proc, now for real

Ricardo Mestre(ser...@helheim.mooo.com) on 2020.06.18 23:40:54 +0100: > Hi, > > Yes, this is a really broad permission to give but it's needed in order to > read > the config file (and those ones included from it) and also to exec the "check > script(s)" which I missed in my last attempt to unvei

Re: 11n Tx aggregation for iwm(4)

Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > This patch adds support for 11n Tx aggregation to iwm(4). > > Please help with testing if you can by running the patch and using wifi > as usual. Nothing should change, except that Tx speed may potentially > improve. If you have time

Re: 11n Tx aggregation for iwm(4)

Sebastian Benoit(be...@openbsd.org) on 2020.06.29 16:18:03 +0200: > Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > > This patch adds support for 11n Tx aggregation to iwm(4). > > > > Please help with testing if you can by running the patch and using wifi

Re: missing case in rpki-client rrdp repo merge

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.13 11:29:57 +0200: > rpki-client applies all delta files to a temporary location. At the same > time files or uri are tracked in a added and deleted set to know which > files to remove from the repo or move into place. > > Now when adding a file t

Re: rpki-client more http.c cleanup

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.13 14:14:38 +0200: > This is another minor cleanup. It makes http_done() similar to http_fail() > and by taking all the arguments (which would allow it to be called after > the http connection was removed) and it also no longer alters the http > st

Re: rpki-client skip deltas if session_id does not match

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.14 20:18:25 +0200: > There is no need to queue up any deltas if the session-id differes from > the one on disk. New session-id will always result in a snapshot download. > This may help in some situation to skip queuing many deltas that are just >

Re: relayd regress tcp performance

Hi, just a bit of caution: i remember getting args-http-slow-consumer.pl to work right in the first place was not easy. If i remember correctly i had quite a lot false positives depending on where i ran it. Alexander made it a bit better later, but i would not be surprised if it can still fail und

rpki-client 7.0 released

Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a base component of OpenBSD every six months, and follows the OpenBSD release numbering scheme. This re

Re: bgpctl time in sec in JSON output

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.28 10:45:20 +0200: > There are various time fields in the JSON output. > last_read, last_write, last_updown on sessions, last_update for rib > entries and last_change for sets. Currently the value is the fmt_timeframe > string (which looks somethin

Re: bgpd: stricter multiprotocol negotiation

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.28 12:40:46 +0200: > At the moment bgpd will fall back to IPv4 unicast if there was no match in > the multiprotocol capabilities between local and remote peer. > This is not correct, if the router expects a certain AFI/SAFI for the > session then i

Re: rpki-client delay deletes also for RRDP repos

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.29 15:34:15 +0200: > Like for rsync repos files in the RRDP repos should be delayed until after > the validation finished. As with anything RPKI related there is little > trust in the repositories and their abilities to not botch an update. > > On

Re: bgpd better reload behaviour

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.05 14:20:58 +0200: > The peer flags (mainly rde evaluate all but also transparent-as) and the > export options (none, default) are not properly handled on a config > reload. In both cases a full session restart is needed after the config > reload (

Re: openrsync mini cleanup

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.05 17:13:03 +0200: > Normalize some code. ok > > -- > :wq Claudio > > Index: receiver.c > === > RCS file: /cvs/src/usr.bin/rsync/receiver.c,v > retrieving revision 1.25 > diff -u

Re: simplify the openrsync uploader

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.05 17:53:20 +0200: > The rsync uploader (what is the generator in rsync) can be simplified and > cleaned up a fair bit. > > There is some confusion of non-blocking IO on regular files and the idea > to poll() between openat() and fstat(). This is

Re: rpki-client: change "asn" from string to integer in JSON output

Job Snijders(j...@openbsd.org) on 2021.05.05 16:35:46 +: > I'd like to modify our JSON format, many people in the community have > voiced complaints that transforming the string to an integer is > annoying. > > This won't break existing deployments coupled with GoRTR. > > OK? ok benno@ > >

Re: make rsync -v less verbose

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.05 20:03:19 +0200: > I like rsync -v but hell it is noisy with openrsync. > Just shut up about all the files that have not changed unless you go -vv. Before we do this, are there reasons to keep this like it is in the original? I think i actually

Re: more rsync cleanup

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.06 17:59:32 +0200: > As noticed by benno@ the blk.blks buffer is leaked in some cases. > Fix those and cleanup up the pre_* functions a bit more. > I increased the diff context a bit to make the diff easier to read. reads ok > > -- > :wq Claudi

Re: bgpd, non-blocking rtr connect

ok benno@ Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.03 17:37:36 +0200: > The RTR session was opened with a blocking connect() call. This is rather > bad if the RTR peer does not exist since then bgpd will block until the > connect timed out. This diff makes the connect() call non-blocking

Re: httpd(8): don't try to chunk-encode an empty body

Florian Obser(flor...@openbsd.org) on 2021.05.14 19:13:49 +0200: > As found out by Chris Narkiewicz the hard way, trying to chunk encode an > empty body makes the nextclown app stop working. (see "Nextcloud stopped > working after upgrade to 6.9" on ports@). > > I don't think there is a valid way

Re: limit concurrent RTR connects in bgpd

Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.05.14 11:21:11 +0200: > I think it is a good idea to limit the number of concurrent connects in > bgpd. I used 32 as the limit since that is way enough for the number of > RTR sessions people will configure. > > If the limit is hit the request will b

  1   2   3   4   5   6   7   8   >