Re: HBaseStore Deletes After Puts?

2015-10-08 Thread Lewis John Mcgibbney
I agree actually. I've logged the issue https://issues.apache.org/jira/browse/GORA-449 I'm working on fixing the tests in MemStore. I'll probably pivot to this if no one else does. On Thu, Oct 8, 2015 at 5:54 AM, Tim Robertson wrote: > Hi Lewis, > > I am not an HBase developer, but have done a l

Re: HBaseStore Deletes After Puts?

2015-10-08 Thread Tim Robertson
Hi Lewis, I am not an HBase developer, but have done a lot of work with HBase over the past years. It looks rather dubious that there are 3 deletes like that, and it should not be necessary unless there is some other race condition going on. I'd suggest removing those, and if an issue arises I'd

Re: HBaseStore Deletes After Puts?

2015-10-08 Thread Lewis John Mcgibbney
Yes this should be handled by the datastore. I have a feeling that this was inherent behavior for hBase some time ago and it had changed and become more robust now. We should confirm from hBase devs. On Thursday, October 8, 2015, Renato Marroquín Mogrovejo < renatoj.marroq...@gmail.com> wrote: >

Re: HBaseStore Deletes After Puts?

2015-10-08 Thread Renato Marroquín Mogrovejo
Hi Lewis, I think that one makes sense, we have three fields inserted, and we delete the three of them. But still seems off, and that test being part of core makes it even worst because this is not an HBase specific test. So for every field that we added to the query object, we have to call delet

Re: HBaseStore Deletes After Puts?

2015-10-07 Thread Lewis John Mcgibbney
Hi Renato, On Wed, Oct 7, 2015 at 3:31 PM, Renato Marroquín Mogrovejo < renatoj.marroq...@gmail.com> wrote: > I also don't understand why there are three table deletes. > did you ever notice https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestU

Re: HBaseStore Deletes After Puts?

2015-10-07 Thread Renato Marroquín Mogrovejo
Hi Jared, I am not very familiar with this part of the code, but I think you might be right. Because if we are updating a Map, we should first delete it the contents and then add it, not the other way around. I also don't understand why there are three table deletes. Maybe you could play around wi

Re: HBaseStore Deletes After Puts?

2015-09-29 Thread Lewis John Mcgibbney
Hi Jared, I briefly had a look into this and I am still trying to properly understand it. Do you have some suggestion(s) as to answering your own questions if you've maybe thought about it a bit more? Lewis On Sun, Sep 27, 2015 at 1:53 AM, Jared Wong wrote: > Hi, > > Why does gora process the de