Dan Kenigsberg has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 1: Code-Review+1
Oh dear. Creating a thread on import is quite bad. We should also understand
Ayal Baron has posted comments on this change.
Change subject: sp: avoid masking uuid in StoragePool methods
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21873
To unsubscribe, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 2:
(3 comments)
Commit Message
Line 3: AuthorDate
oVirt Jenkins CI Server has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6046/ : SUCCESS
Ayal Baron has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 489:
Nir Soffer has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 1:
Vinzenz - can you verify that this fix the issue on your host?
--
To view, visit http://gerri
Nir Soffer has uploaded a new change for review.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
remoteFileHandler: Remove harmful libvirt dependency
Commit ae7fbc6d4f2 added caps.isOvirtNode function, wh
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
File tests/functional/
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
File tests/functional
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6044/ : S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6043/ : SUCCESS
http://jenkins.ovirt
Antoni Segura Puimedon has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 12:
(1 comment)
File lib/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 10: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 9: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/j
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: replace events() with optionally continuous
iteration
..
Patch Set 7:
(3 comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6039/ : SUCCESS
http://jenkin
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 6: Verified+1
(1 comment)
Copying score since only the commit msg was altered.
.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6038/ : S
Antoni Segura Puimedon has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/22061
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 10:
(4 comments)
File lib
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: Don't reconfigure if configured when force is set
..
Patch Set 1:
this is one confusing commit message!
anyway, the reason to do --force and overwrite configurat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/326/ : SUCCESS
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix syntax error
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fix syntax error
..
Fix syntax error
Change-Id: Ib636c00a6b9670584b5a862ac4496e74915fbe04
Signed-off-by: Yaniv Bronhaim
Bug-Url: https://bugzilla.redhat.com/s
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Don't reconfigure if configured when force is set
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6037/ : SUCCESS
htt
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Don't reconfigure if configured when force is set
..
Don't reconfigure if configured when force is set
There is no need for that. We kept the old --force way w
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2: Code-Review+1
Thanks for the change Dan!
--
To view, visit http://gerrit.ovirt.org/222
Martin Polednik has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 6:
This patch in its current form without rebase and a bit of work wouldn't test
anything: we would only see if t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6036/ : SUCCESS
http:
Itamar Heim has posted comments on this change.
Change subject: Encapsulate vdsm-unregister into vdsm-tool function
..
Patch Set 1:
should this be abandoned?
--
To view, visit http://gerrit.ovirt.org/4527
To unsubscribe, visi
Itamar Heim has posted comments on this change.
Change subject: avoid race between load dev rules and trigger the rule
..
Patch Set 5:
no reply for 30 days post last pojt
--
To view, visit http://gerrit.ovirt.org/6780
To unsu
Itamar Heim has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 6:
so, should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt
Itamar Heim has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 8:
no comment - should this be abandoned?
--
To view, visit http://gerrit.ovirt.org/7492
To unsubscribe, visit h
Itamar Heim has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 12:
no comment for 30 days - should be abandoned?
--
To view, visit http://gerrit.ovirt.org/8411
To unsubscrib
Itamar Heim has posted comments on this change.
Change subject: add createVm support of cputune
..
Patch Set 9:
what's needed to get closure onthis?
--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 5: Code-Review+1
(1 comment)
Commit Message
Line 9: 'ip -d -
Dan Kenigsberg has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 10: Code-Review-1
(4 comments)
Fi
Ayal Baron has posted comments on this change.
Change subject: clientIF: Check device visibility on failed hotplugDisk
..
Patch Set 4:
(1 comment)
File vdsm/clientIF.py
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit http:
Antoni Segura Puimedon has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22084
To unsubscribe, visit h
Dan Kenigsberg has submitted this change and it was merged.
Change subject: syncproc: Add blocking mode.
..
syncproc: Add blocking mode.
By setting `proc.blocking = True` it will make reading and writing move
to blocking mode.
Dan Kenigsberg has posted comments on this change.
Change subject: syncproc: Add blocking mode.
..
Patch Set 9:
(1 comment)
File lib/vdsm/utils.py
Line 345: else
Dan Kenigsberg has posted comments on this change.
Change subject: syncproc: Add blocking mode.
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21897
To unsubscribe, visit http://gerrit.ovirt.org/settin
Dan Kenigsberg has submitted this change and it was merged.
Change subject: asyncproc: Removed the close count.
..
asyncproc: Removed the close count.
When I originally wrote the class I assumed that since the process side
FD i
Dan Kenigsberg has submitted this change and it was merged.
Change subject: asyncproc: Return None when no data could be read
..
asyncproc: Return None when no data could be read
According to http://docs.python.org/2/library/io
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Testing pinger thread
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6035/ : SUCCESS
http://jenkins.ovirt.org/job/vd
Nir Soffer has uploaded a new change for review.
Change subject: Testing pinger thread
..
Testing pinger thread
Add a comment to trigger networking functional tests.
Change-Id: I0ef69ea9b125f0d0af2e46b94690950a14d4c4f9
Signed-o
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 1:
Not in netconf/__init__, just that vdsm/nm.py should be vdsm/netconf/nm.py as
it is onl
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 1:
Toni, what belongs to netconf.__init__? _nm_around? What would is its usage for
something other
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6034/ : SUCCESS
http://jenkins.ovirt.org/j
Antoni Segura Puimedon has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
(1 comment)
File tests/functional/ping.py
Line 1: i
Nir Soffer has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
(2 comments)
File tests/functional/ping.py
Line 1: import time
Antoni Segura Puimedon has posted comments on this change.
Change subject: asyncproc: Removed the close count.
..
Patch Set 3: Verified+1
Verified the tip of the branch to work in the optional sync mode.
--
To view, visit htt
Antoni Segura Puimedon has posted comments on this change.
Change subject: asyncproc: Return None when no data could be read
..
Patch Set 2: Verified+1
Verified the tip of the branch.
--
To view, visit http://gerrit.ovirt.org
Antoni Segura Puimedon has posted comments on this change.
Change subject: syncproc: Add blocking mode.
..
Patch Set 9: Verified+1 Code-Review+1
verified in ipython:
In [1]: from vdsm.utils import execCmd
In [2]: p =
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Code-Review+2
thanks, I'll review the test later.
--
To view, visit http://gerrit.ovir
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
vdsm: prepareVolumePath correct path handling for cdrom
prepareVolumePath looked for 'path'
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 7: Code-Review-1
(1 comment)
Beside my comment to vm.py please add unit tests for the new Architectu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6033/ : SUCCESS
http://jenkins.ovirt.org/j
Dan Kenigsberg has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
(2 comments)
File tests/functional/ping.py
Line 1: import t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6032/ : SUCCESS
http://jenkins.ovirt.org/j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6032/ : SUCCESS
http://jenkins.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconf: provide a default rollback for configurators
..
netconf: provide a default rollback for configurators
This patch adds a default rollback metho
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21739
To unsubscribe, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21728
To unsubscribe, visit http://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconfpersistence: add diffing method to Config
..
netconfpersistence: add diffing method to Config
This patch makes it easy to diff two network confi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconf: define rollback contract at internal API
..
netconf: define rollback contract at internal API
This patch defines the contract Configurator rol
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21702
To unsubscribe, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6031/ : SUCCESS
http://jenkins.
Yeela Kaplan has abandoned this change.
Change subject: vm: Do not assume drive's iface attribute exists
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/21939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Nir Soffer has uploaded a new change for review.
Change subject: Run pinger in separate process
..
Run pinger in separate process
Running pinger in a separate process should be less fragile, as the
pinger thread cannot be delaye
Yaniv Bronhaim has posted comments on this change.
Change subject: asyncproc: Return None when no data could be read
..
Patch Set 2: Code-Review+1
uts?
When I'll add more spare time I add myself. but if you want to push it fas
Yaniv Bronhaim has posted comments on this change.
Change subject: syncproc: Add blocking mode.
..
Patch Set 9: Code-Review+1
please verify and add uts for the blocking variable if possible
--
To view, visit http://gerrit.ovi
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 15: Verified+1
Passes the unit tests just fine.
--
To view, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 15: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ : SU
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 1: Code-Review-1
I think it belongs in the netconf package.
--
To view, visit http://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Report fake capabilities
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19396
To unsubscribe, visit http://gerrit.ovirt.org/sett
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 14: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 14: Verified+1
Passed the new unit tests.
--
To view, visit http://gerrit.ovirt.org/2172
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 1:
(1 comment)
File vdsm/netconf/ifcf
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6028/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6027/ : SUCCESS
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
hsm: Log unhandled exceptions in storage refresh thread
hsm's storage refresh background thr
Yaniv Bronhaim has posted comments on this change.
Change subject: hsm: Log unhandled exceptions in storage refresh thread
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22213
To unsubscribe
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
domainMonitor: Log unhandled exceptions in domain monitor thread
DomainMonitorThrea
Yaniv Bronhaim has posted comments on this change.
Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22214
To un
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: utils: Add unhandled exceptions logging decorator
..
utils: Add unhandled exceptions logging decorator
We have at least two places where exceptions in
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22212
To unsubscribe, visit http://gerri
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22212
To unsubscribe, visit http://ge
Jiří Moskovčák has posted comments on this change.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Patch Set 3:
Yes, being able to set the logging level for the whole module makes more sense,
although i
Dan Kenigsberg has uploaded a new change for review.
Change subject: ifcfg: include HWADDR line only if NM is around
..
ifcfg: include HWADDR line only if NM is around
In prehistoric days, our ifcfg files included HWADDR lines f
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 13: Verified+1 Code-Review-1
Works, but should apply danken's comments.
--
To view, visi
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/21739
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: define rollback contract at internal API
..
Patch Set 13: Verified+1
Functional tests pass for ifcf configurator and persistence.
They also pa
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6026/ : SUCCESS
http://jenkins.ovirt.org/j
1 - 100 of 119 matches
Mail list logo
