On 12/19/2012 05:57 AM, vita...@yourcmc.ru wrote:
> Hello!
>
> 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts
> extensions.
> Since then I've corrected two of them ("uploaded patch set 2"), but
> after that, nobody did the review. As I understand, Gerrit will abandon
> changes
On Thu, 20 Dec 2012 14:20:07 +0100, Merlijn van Deen
wrote:
It's possible to do it the other way around - people can /subscribe/ to a
project via https://gerrit.wikimedia.org/r/#/settings/projects and receive
e-mails when new patchsets are uploaded. I don't think this adds people to
the reviewe
On 20 December 2012 13:35, Andre Klapper wrote:
> Does Gerrit support setting "default CCs" for certain code areas
> (projects, subfolders etc)?
> Letting new contributors search manually for a patch reviewer feels as
> wrong as letting new bug reporters search for an assignee or somebody to
> co
On Thu, Dec 20, 2012 at 7:35 AM, Andre Klapper wrote:
> On Wed, 2012-12-19 at 13:30 -0500, Sumana Harihareswara wrote:
>> Try these tips:
>> https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews
>
> Does Gerrit support setting "default CCs" for certain code areas
> (projects, subfolders e
On Wed, 2012-12-19 at 13:30 -0500, Sumana Harihareswara wrote:
> Try these tips:
> https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews
Does Gerrit support setting "default CCs" for certain code areas
(projects, subfolders etc)?
Letting new contributors search manually for a patch review
Lol yes. Parent5446 is my actual username, although it is not my name in
real life. :P
*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer Science
www.whizkidztech.com | tylerro...@gmail.com
On Wed, Dec 19, 2012 at 5:15 PM, Matthew Flaschen
wrote:
> On 12/19/201
On 12/19/2012 04:58 PM, Matma Rex wrote:
> On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen
> wrote:
>> On a simpler note, why does it have your name as Parent5446?
>>
>> https://gerrit.wikimedia.org/r/#/dashboard/278
>>
>> Can someone fix this?
>
> There's a bug for that:
> https://bugzilla.
On 12/19/2012 05:06 PM, Tyler Romeo wrote:
> Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been
> approved, i.e., +2 on CR. But it's yet to have been merged. At the very
> least, its dependency has been merged. I'm not in a humongous rush or
> anything, I'm just pointing ou
Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been
approved, i.e., +2 on CR. But it's yet to have been merged. At the very
least, its dependency has been merged. I'm not in a humongous rush or
anything, I'm just pointing out that sometimes you really just have to wait
it ou
On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen
wrote:
On a simpler note, why does it have your name as Parent5446?
https://gerrit.wikimedia.org/r/#/dashboard/278
Can someone fix this?
There's a bug for that: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061
I've been wanting to fi
On 12/19/2012 02:41 PM, Tyler Romeo wrote:
> I've had patchsets that I submitted in August and they still haven't been
> merged. For example, the account creation API, which has actually been
> approved, but never merged.
Which one are you referring to, https://gerrit.wikimedia.org/r/#/c/18127/ ?
I've had patchsets that I submitted in August and they still haven't been
merged. For example, the account creation API, which has actually been
approved, but never merged.
*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer Science
www.whizkidztech.com | tylerro...
On 12/19/2012 07:24 AM, vita...@yourcmc.ru wrote:
> Antoine Musso писал 2012-12-19 16:19:
>> Le 19/12/12 11:57, vita...@yourcmc.ru wrote:
>>> Hello!
>>>
>>> 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts
>>> extensions.
>>> Since then I've corrected two of them ("uploaded patch
Antoine Musso писал 2012-12-19 16:19:
Le 19/12/12 11:57, vita...@yourcmc.ru wrote:
Hello!
28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts
extensions.
Since then I've corrected two of them ("uploaded patch set 2"), but
after that, nobody did the review. As I understand, Gerri
Matma Rex писал 2012-12-19 15:01:
You could add people as reviewers, or personally ask someone to
review, prefereably someone who worked on the extension in the past.
Okay, I've just done it...
So, do you mean all committers just add random reviewers when they see
no reaction?
__
Le 19/12/12 11:57, vita...@yourcmc.ru wrote:
> Hello!
>
> 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts
> extensions.
> Since then I've corrected two of them ("uploaded patch set 2"), but
> after that, nobody did the review. As I understand, Gerrit will abandon
> changes afte
You could add people as reviewers, or personally ask someone to review,
prefereably someone who worked on the extension in the past.
--
Matma Rex
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/w
Hello!
28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts
extensions.
Since then I've corrected two of them ("uploaded patch set 2"), but
after that, nobody did the review. As I understand, Gerrit will abandon
changes after a month of inactivity, and it will come tomorrow...
18 matches
Mail list logo
