[Xen-devel] [xen-4.5-testing test] 103755: trouble: broken/fail/pass

2016-12-20 Thread osstest service owner
flight 103755 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103755/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 3 host-install(3) broken REGR. vs

Re: [Xen-devel] [PATCH 1/2] x86/hvm: Don't emulate all instructions hitting the #UD intercept

2016-12-20 Thread Jan Beulich
>>> On 19.12.16 at 17:37, wrote: > Having the instruction emulator fill in all #UDs when using FEP is unhelpful > when trying to test emulation behaviour against hardware. > > Restrict emulation from the #UD intercept to the cross-vendor case, and when a > postive Forced Emulation Prefix has been

[Xen-devel] [PATCH] x86emul: don't unconditionally clear segment bases upon null selector loads

2016-12-20 Thread Jan Beulich
AMD explicitly documents that namely FS and GS don't have their bases cleared in that case, and I see no reason why guests may not rely on that behavior. To facilitate this a new input field (the CPU vendor) is being added. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emula

Re: [Xen-devel] [PATCH 2/2] x86/emul: Bugfixes to SYSCALL emulation

2016-12-20 Thread Jan Beulich
>>> On 19.12.16 at 17:37, wrote: > Introduce vendor_is() to allow emulation to have vendor-specific > behaviour. Adjust the SYSCALL behaviour on Intel to raise #UD when > executed outside of 64bit mode. I'd rather not see us go this route. I've been carrying a patch making the vendor an input (n

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 06:54, wrote: > On December 20, 2016 1:37 PM, Tian, Kevin wrote: >>> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] >>> Sent: Friday, December 16, 2016 5:40 PM >>> >>> From 89fffdd6b563b2723e24d17231715bb8c9f24f90 Mon Sep 17 00:00:00 >>2001 >>> From: Quan Xu >>> Date: Fri,

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 06:37, wrote: >> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] >> Sent: Friday, December 16, 2016 5:40 PM >> -if (pt_vector != -1) >> -vmx_set_eoi_exit_bitmap(v, pt_vector); >> +if ( pt_vector != -1 ) { >> +if ( intack.vector > pt_ve

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, December 20, 2016 4:35 PM > > >>> On 20.12.16 at 06:37, wrote: > >> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] > >> Sent: Friday, December 16, 2016 5:40 PM > >> -if (pt_vector != -1) > >> -vmx_set_eoi_exi

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 09:53, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, December 20, 2016 4:35 PM >> >> >>> On 20.12.16 at 06:37, wrote: >> >> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] >> >> Sent: Friday, December 16, 2016 5:40 PM >> >> -if (pt_vecto

[Xen-devel] Ping: [PATCH 0/3] x86emul: misc adjustments

2016-12-20 Thread Jan Beulich
>>> On 12.12.16 at 10:38, wrote: > These patches are grouped together merely because of contextual > dependencies. > > 1: correct EFLAGS.TF handling > 2: conditionally clear BNDn for branches > 3: some REX related polishing > > Signed-off-by: Jan Beulich Any word on these? I realize patch 1 wi

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-20 Thread Praveen Kumar
Hi Dario, I tried with 'git am' to apply the patch after downloading the mbox file, that worked fine. Do let me know if that is ok. Regards, ~Praveen. On Sat, Dec 17, 2016 at 1:44 PM, Praveen Kumar wrote: > Hi, > > On Sat, Dec 17, 2016 at 7:16 AM, Dario Faggioli > wrote: > >> On Sat, 2016-12

Re: [Xen-devel] [PATCH] xsm: allow relevant permission during migrate and gpu-passthrough.

2016-12-20 Thread Anshul Makkar
On 20/12/2016 04:03, Doug Goldstein wrote: On 12/19/16 10:02 AM, Doug Goldstein wrote: On 12/14/16 3:09 PM, Daniel De Graaf wrote: On 12/12/2016 09:00 AM, Anshul Makkar wrote: During guest migrate allow permission to prevent spurious page faults. Prevents these errors: d73: Non-privileged (73)

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Xuquan (Quan Xu)
On December 20, 2016 4:32 PM, Jan Beulich wrote: On 20.12.16 at 06:54, wrote: >> On December 20, 2016 1:37 PM, Tian, Kevin wrote: From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] Sent: Friday, December 16, 2016 5:40 PM From 89fffdd6b563b2723e24d17231715bb8c9f24f90 Mon Se

[Xen-devel] [xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass

2016-12-20 Thread osstest service owner
flight 103756 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103756/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xend 3 host-install(3)broken REGR. vs. 10

Re: [Xen-devel] Xen ARM - Exposing a PL011 to the guest

2016-12-20 Thread Bhupinder Thakur
Hi Stefano, Thanks for a detailed explanation. I have some queries. > > Let me explain how the PV console protocol and drivers work, because > they are a bit unusual. The first PV console is advertised via > hvm_params. The guest calls: > > hvm_get_parameter(HVM_PARAM_CONSOLE_EVTCHN, &v); > h

[Xen-devel] [PATCH 00/10] x86: register renaming (part I)

2016-12-20 Thread Jan Beulich
This is a first (of three, as far as current plans go) steps to do away with misleading register names (eax instead of rax). 01: x86/MSR: introduce MSR access split/fold helpers 02: x86/guest-walk: use unambiguous register names 03: x86/shadow: use unambiguous register names 04: x86/oprofile: use

Re: [Xen-devel] [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2016-12-20 Thread Juergen Gross
On 20/12/16 06:02, Jiandi An wrote: > On 12/19/16 12:49, Stefano Stabellini wrote: >> On Mon, 19 Dec 2016, Juergen Gross wrote: >>> On 19/12/16 03:56, Jiandi An wrote: Ensure all reserved fields of xatp are zero before making hypervisor call to XEN in xen_map_device_mmio(). xenmem_add_to

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 10:38, wrote: > On December 20, 2016 4:32 PM, Jan Beulich wrote: > On 20.12.16 at 06:54, wrote: >>> On December 20, 2016 1:37 PM, Tian, Kevin wrote: > From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] > Sent: Friday, December 16, 2016 5:40 PM > > From 89fff

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Xuquan (Quan Xu)
On December 20, 2016 4:54 PM, Tian, Kevin wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, December 20, 2016 4:35 PM >> >> >>> On 20.12.16 at 06:37, wrote: >> >> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] >> >> Sent: Friday, December 16, 2016 5:40 PM >> >> -

[Xen-devel] [xen-unstable-smoke test] 103771: tolerable all pass - PUSHED

2016-12-20 Thread osstest service owner
flight 103771 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103771/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH] Xen: ARM: Zero reserved fields of xatp before making hypervisor call

2016-12-20 Thread Julien Grall
Hi Jiandi, Please respect the netiquette and wrap line to 70-75 characters. On 20/12/2016 06:02, Jiandi An wrote: On 12/19/16 12:49, Stefano Stabellini wrote: On Mon, 19 Dec 2016, Juergen Gross wrote: On 19/12/16 03:56, Jiandi An wrote: Thanks for you comments. xatp is passed to XEN via t

[Xen-devel] [PATCH 01/10] x86/MSR: introduce MSR access split/fold helpers

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@

[Xen-devel] [PATCH 02/10] x86/guest-walk: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/gues

[Xen-devel] [PATCH 03/10] x86/shadow: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -348,10 +348,10 @@ const struct x86_emulate_ops *shadow_ini

[Xen-devel] [PATCH 04/10] x86/oprofile: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Signed-off-by: Jan Beulich --- a/xen/arch/x86/oprofile/backtrace.c +++ b/xen/arch/x86/oprofile/backtrace.c @@ -150,7 +150,7 @@ static int valid_hypervisor_stack(const

[Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@

[Xen-devel] [PATCH 06/10] x86/HVMemul: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emula

[Xen-devel] [PATCH 07/10] x86/SVM: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm

[Xen-devel] [PATCH 08/10] x86/vm-event: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Signed-off-by: Jan Beulich --- a/xen/arch/x86/vm_event.c +++ b/xen/arch/x86/vm_event.c @@ -112,14 +112,14 @@ void vm_event_set_registers(struct vcpu { ASSERT(ato

[Xen-devel] [PATCH 09/10] x86/traps: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -202

[Xen-devel] [PATCH 10/10] x86/misc: use unambiguous register names

2016-12-20 Thread Jan Beulich
This is in preparation of eliminating the mis-naming of 64-bit fields with 32-bit register names (eflags instead of rflags etc). Use the guaranteed 32-bit underscore prefixed names for now where appropriate. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @

Re: [Xen-devel] [PATCH 03/10] x86/shadow: use unambiguous register names

2016-12-20 Thread Tim Deegan
At 03:38 -0700 on 20 Dec (1482205097), Jan Beulich wrote: > This is in preparation of eliminating the mis-naming of 64-bit fields > with 32-bit register names (eflags instead of rflags etc). > > Signed-off-by: Jan Beulich Acked-by: Tim Deegan ___ Xen

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -527,7 +527,37 @@ DECLARE_HVM_SAVE_TYPE(HPET, 12, struct hvm_hw_hpet); > /* > * PM timer > */ > +#if __XEN_INTERFACE_VERSION__ >= 0x00040800 > +struct hvm_hw_pmt

Re: [Xen-devel] [PATCH] xen/arm: fix rank/vgic locks inversion bug

2016-12-20 Thread Julien Grall
Hi Stefano, On 20/12/2016 00:22, Stefano Stabellini wrote: On Mon, 19 Dec 2016, Julien Grall wrote: Hi Stefano, On 19/12/2016 23:30, Stefano Stabellini wrote: On Mon, 19 Dec 2016, Julien Grall wrote: 2) We run gic_update_one_lr and vgic_store_itargetsr in parallel safely and locklessly. Ther

Re: [Xen-devel] Ping: [PATCH 0/3] x86emul: misc adjustments

2016-12-20 Thread Andrew Cooper
On 20/12/2016 09:04, Jan Beulich wrote: On 12.12.16 at 10:38, wrote: >> These patches are grouped together merely because of contextual >> dependencies. >> >> 1: correct EFLAGS.TF handling >> 2: conditionally clear BNDn for branches >> 3: some REX related polishing >> >> Signed-off-by: Jan Be

Re: [Xen-devel] [PATCH 3/3] x86emul: some REX related polishing

2016-12-20 Thread Andrew Cooper
On 12/12/2016 10:00, Jan Beulich wrote: > While there are a few cases where it seems better to open-code REX_* > values, there's one where this clearly is a bad idea. And the SYSEXIT > emulation has no need to look at REX at all, it can simply use op_bytes > instead. > > Signed-off-by: Jan Beulich

[Xen-devel] [ovmf test] 103763: all pass - PUSHED

2016-12-20 Thread osstest service owner
flight 103763 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/103763/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 83c6c3bfe293cd0a5983375dfbf46d4f364b38aa baseline version: ovmf 15dae68589243726f0374

Re: [Xen-devel] Xen: ARM: Support for mapping ECAM PCIe Config Space Specified In Static ACPI Table

2016-12-20 Thread Julien Grall
Hi Jiandi, On 20/12/2016 07:31, Jiandi An wrote: On 12/19/16 07:11, Julien Grall wrote: On 19/12/2016 13:20, Jaggi, Manish wrote: On 16/12/2016 15:49, Julien Grall wrote: On 14/12/16 08:00, Jiandi An wrote: Xen currently doesn't map ECAM space specified in static ACPI table. Seeking opinio

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > +static int acpi_cpumap_access_common(struct domain *d, > + int dir, unsigned int port, > + unsigned int bytes, uint32_t *val) > +{ > +unsigned int first_byte = port - XEN_ACPI_CPU_MAP; >

Re: [Xen-devel] Ping: [PATCH 0/3] x86emul: misc adjustments

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 12:30, wrote: > On 20/12/2016 09:04, Jan Beulich wrote: > On 12.12.16 at 10:38, wrote: >>> These patches are grouped together merely because of contextual >>> dependencies. >>> >>> 1: correct EFLAGS.TF handling >>> 2: conditionally clear BNDn for branches >>> 3: some REX re

Re: [Xen-devel] [PATCH] x86emul: don't unconditionally clear segment bases upon null selector loads

2016-12-20 Thread Andrew Cooper
On 20/12/2016 08:18, Jan Beulich wrote: > AMD explicitly documents that namely FS and GS don't have their bases > cleared in that case, and I see no reason why guests may not rely on > that behavior. To facilitate this a new input field (the CPU vendor) is > being added. > > Signed-off-by: Jan Beul

[Xen-devel] merlot0 and merlot1 (was Re: [xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass)

2016-12-20 Thread Ian Jackson
osstest service owner writes ("[xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass"): > flight 103756 xen-4.4-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/103756/ > > Failures and problems with tests :-( > > Tests which did not succeed and are blocking, > i

Re: [Xen-devel] Xen: ARM: Support for mapping ECAM PCIe Config Space Specified In Static ACPI Table

2016-12-20 Thread Julien Grall
Hi Stefano, On 20/12/2016 00:54, Stefano Stabellini wrote: On Mon, 19 Dec 2016, Julien Grall wrote: On 16/12/2016 15:49, Julien Grall wrote: On 14/12/16 08:00, Jiandi An wrote: Xen currently doesn't map ECAM space specified in static ACPI table. Seeking opinion on how this should be handled p

Re: [Xen-devel] [PATCH 2/2] x86/emul: Bugfixes to SYSCALL emulation

2016-12-20 Thread Andrew Cooper
On 20/12/2016 08:22, Jan Beulich wrote: On 19.12.16 at 17:37, wrote: >> Introduce vendor_is() to allow emulation to have vendor-specific >> behaviour. Adjust the SYSCALL behaviour on Intel to raise #UD when >> executed outside of 64bit mode. > I'd rather not see us go this route. I've been c

Re: [Xen-devel] [PATCH] x86/time: Adjust init-time handling of pit0_ticks

2016-12-20 Thread Andrew Cooper
On 20/12/2016 07:25, Jan Beulich wrote: On 19.12.16 at 17:58, wrote: >> On 19/12/16 16:51, Jan Beulich wrote: >> On 19.12.16 at 17:38, wrote: There is no need for the volatile cast in the timer interrupt. pit0_ticks has external linkage, preventing the compiler from elid

Re: [Xen-devel] [PATCH] xen/x86: Improve hypercall page writing

2016-12-20 Thread Andrew Cooper
On 20/12/2016 07:48, Jan Beulich wrote: > >> @@ -398,10 +400,11 @@ static void >> hypercall_page_initialise_ring1_kernel(void *hypercall_page) >> * calling it. >> */ >> p = (char *)(hypercall_page + (__HYPERVISOR_iret * 32)); >> -*(u8 *)(p+ 0) = 0x50;/* push %eax */ >> -

Re: [Xen-devel] Xen ARM - Exposing a PL011 to the guest

2016-12-20 Thread Julien Grall
Hi Stefano, On 19/12/2016 21:24, Stefano Stabellini wrote: On Mon, 19 Dec 2016, Christoffer Dall wrote: On Fri, Dec 16, 2016 at 05:03:13PM +, Julien Grall wrote: (CC rest maintainers for event channel questions) On 16/12/16 10:06, Bhupinder Thakur wrote: Hi, Hi Bhupinder, The idea is

Re: [Xen-devel] Ping: [PATCH v2 RESEND] x86/time: correctly honor late clearing of TSC related feature flags

2016-12-20 Thread Andrew Cooper
On 15/12/2016 15:09, Jan Beulich wrote: On 15.12.16 at 12:04, wrote: >> On 15/12/16 09:49, Jan Beulich wrote: >> On 06.12.16 at 11:51, wrote: As such clearing of flags may have an impact on the selected rendezvous function, handle such in a central place. But don't al

[Xen-devel] [PATCH v2 0/1] xen/arm: Map mmio-sram nodes as cached memory

2016-12-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This patch changes the mapping from non-cached to cached for mmio-sram nodes that do not have the no-memory-wc property. This is a hang-over from 4.8 since the mmio-sram patches went in late in the cycle. I've explained the rationale in the commit message: Although

[Xen-devel] [PATCH v2 1/1] xen/arm: Map mmio-sram nodes as cached memory

2016-12-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Relax the mapping of mmio-sram nodes that do not set the no-memory-wc property to cached normal memory. Rationale: Although on chip memories are relatively fast compared to off-chip memories, large on chip memories are still significantly slower than L1 caches. Dependin

Re: [Xen-devel] Xen ARM - Exposing a PL011 to the guest

2016-12-20 Thread Christoffer Dall
Hi Stefano, On Mon, Dec 19, 2016 at 12:24:18PM -0800, Stefano Stabellini wrote: > On Mon, 19 Dec 2016, Christoffer Dall wrote: > > On Fri, Dec 16, 2016 at 05:03:13PM +, Julien Grall wrote: > > > (CC rest maintainers for event channel questions) > > > > > > On 16/12/16 10:06, Bhupinder Thakur

Re: [Xen-devel] [PATCH v1 1/1] xen/arm: Map mmio-sram nodes as cached memory

2016-12-20 Thread Edgar E. Iglesias
On Mon, Dec 19, 2016 at 04:01:00PM -0800, Stefano Stabellini wrote: > On Mon, 19 Dec 2016, Julien Grall wrote: > > Hi Edgar, > > > > On 16/12/2016 18:04, Edgar E. Iglesias wrote: > > > On Fri, Dec 16, 2016 at 04:12:00PM +, Julien Grall wrote: > > > > On 15/12/16 11:26, Edgar E. Iglesias wrote:

Re: [Xen-devel] [PATCH] x86/time: Adjust init-time handling of pit0_ticks

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 13:17, wrote: > On 20/12/2016 07:25, Jan Beulich wrote: > On 19.12.16 at 17:58, wrote: >>> On 19/12/16 16:51, Jan Beulich wrote: >>> On 19.12.16 at 17:38, wrote: > There is no need for the volatile cast in the timer interrupt. > pit0_ticks has > external

Re: [Xen-devel] [PATCH] xen/x86: Improve hypercall page writing

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 13:21, wrote: > On 20/12/2016 07:48, Jan Beulich wrote: >> >>> @@ -398,10 +400,11 @@ static void >>> hypercall_page_initialise_ring1_kernel(void > *hypercall_page) >>> * calling it. >>> */ >>> p = (char *)(hypercall_page + (__HYPERVISOR_iret * 32)); >>> -*

Re: [Xen-devel] [PATCH 2/2] x86/emul: Bugfixes to SYSCALL emulation

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 13:14, wrote: > On 20/12/2016 08:22, Jan Beulich wrote: > On 19.12.16 at 17:37, wrote: >> What I've been thinking the other day though is: Why >> don't we put the whole SYSCALL emulation into a __XEN__ >> conditional (implying __x86_64__, i.e. allowing the inner ones >> to

[Xen-devel] merlot0 and merlot1 (was Re: [xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass)

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 12:59, wrote: > osstest service owner writes ("[xen-4.4-testing test] 103756: trouble: > blocked/broken/fail/pass"): >> flight 103756 xen-4.4-testing real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/103756/ >> >> Failures and problems with tests :-( >> >> Test

Re: [Xen-devel] [PATCH v3] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-20 Thread Xuquan (Quan Xu)
On December 20, 2016 1:37 PM, Tian, Kevin wrote: >> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] >> Sent: Friday, December 16, 2016 5:40 PM >I suppose you've verified this new version, but still would like get your >explicit confirmation - did you still see time accuracy issue in your side? >

Re: [Xen-devel] [PATCH v3] xen: sched: removal of redundant check in Credit

2016-12-20 Thread Dario Faggioli
On Tue, 2016-12-20 at 14:34 +0530, Praveen Kumar wrote: > Hi Dario, > > I tried with 'git am' to apply the patch after downloading the mbox > file, that worked fine. Do let me know if that is ok. > Well, if you tried and it works, I'm sure it is. I don't really use `git am` as part of my workload

Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > @@ -32,14 +34,15 @@ static int acpi_cpumap_access_common(struct domain *d, > memcpy(val, (uint8_t *)d->avail_vcpus + first_byte, > min(bytes, ((d->max_vcpus + 7) / 8) - first_byte)); > } > -else > +else if ( !is_guest

Re: [Xen-devel] [PATCH v5 08/13] pvh: Send an SCI on VCPU hotplug event

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > @@ -128,6 +130,13 @@ static int acpi_access_common(struct domain *d, bool > is_guest_access, > *en = (((v & 0xff) << 8) | (*en & 0xff)) & *mask_en; > break; > } > + > +/* > + * If a new bit has been set in statu

Re: [Xen-devel] [PATCH v5 12/13] pvh/acpi: Save ACPI registers for PVH guests

2016-12-20 Thread Jan Beulich
>>> On 17.12.16 at 00:18, wrote: > --- a/xen/arch/x86/hvm/pmtimer.c > +++ b/xen/arch/x86/hvm/pmtimer.c > @@ -257,7 +257,11 @@ static int acpi_save(struct domain *d, > hvm_domain_context_t *h) > int rc; > > if ( !has_vpm(d) ) > +{ > +if ( !has_acpi_dm_ff(d) ) > +

[Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/block/xen-blkback/blkback.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback

[Xen-devel] [PATCH] xen/evtchn: use rb_entry()

2016-12-20 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/xen/evtchn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c index e8c7f09..6890897 100644 --- a/dri

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 06:24 AM, Jan Beulich wrote: On 17.12.16 at 00:18, wrote: >> --- a/xen/include/public/arch-x86/hvm/save.h >> +++ b/xen/include/public/arch-x86/hvm/save.h >> @@ -527,7 +527,37 @@ DECLARE_HVM_SAVE_TYPE(HPET, 12, struct hvm_hw_hpet); >> /* >> * PM timer >> */ >> +#if __XEN_INT

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:03, wrote: > On 12/20/2016 06:24 AM, Jan Beulich wrote: > On 17.12.16 at 00:18, wrote: >>> --- a/xen/include/public/arch-x86/hvm/save.h >>> +++ b/xen/include/public/arch-x86/hvm/save.h >>> @@ -527,7 +527,37 @@ DECLARE_HVM_SAVE_TYPE(HPET, 12, struct hvm_hw_hpet); >>> /*

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 09:10 AM, Jan Beulich wrote: On 20.12.16 at 15:03, wrote: >> On 12/20/2016 06:24 AM, Jan Beulich wrote: >> On 17.12.16 at 00:18, wrote: --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save.h @@ -527,7 +527,37 @@ DECLARE_HVM_

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 06:50 AM, Jan Beulich wrote: > >> + >> +if ( dir == XEN_DOMCTL_ACPI_READ ) >> +{ >> +uint32_t mask = (bytes < 4) ? ~0U << (bytes * 8) : 0; >> +uint32_t data = (((uint32_t)*en) << 16) | *sts; > There's one pair of pointless parentheses around the cast > expressi

Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 08:24 AM, Jan Beulich wrote: > >> -static int acpi_access_common(struct domain *d, >> +static int acpi_access_common(struct domain *d, bool is_guest_access, > Why? I thought the domctl is needed only for updating the CPU > map? Or maybe it would help if the patch had a non-empty > des

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:16, wrote: > On 12/20/2016 09:10 AM, Jan Beulich wrote: > On 20.12.16 at 15:03, wrote: >>> On 12/20/2016 06:24 AM, Jan Beulich wrote: >>> On 17.12.16 at 00:18, wrote: > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:35, wrote: > On 12/20/2016 06:50 AM, Jan Beulich wrote: >>> +else >>> +{ >>> +uint32_t v = *val; >>> + >>> +/* Status register is write-1-to-clear by guests */ >>> +switch ( port & 3 ) >>> +{ >>> +case 0: >>> +*sts &

Re: [Xen-devel] [PATCH v5 06/13] x86/domctl: Handle ACPI access from domctl

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 15:45, wrote: > On 12/20/2016 08:24 AM, Jan Beulich wrote: >> >>> -static int acpi_access_common(struct domain *d, >>> +static int acpi_access_common(struct domain *d, bool is_guest_access, >> Why? I thought the domctl is needed only for updating the CPU >> map? Or maybe it woul

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Andrew Cooper
On 20/12/2016 14:45, Jan Beulich wrote: On 20.12.16 at 15:16, wrote: >> On 12/20/2016 09:10 AM, Jan Beulich wrote: >> On 20.12.16 at 15:03, wrote: On 12/20/2016 06:24 AM, Jan Beulich wrote: On 17.12.16 at 00:18, wrote: >> --- a/xen/include/public/arch-x86/hvm/save.h >>

Re: [Xen-devel] [PATCH v5 08/13] pvh: Send an SCI on VCPU hotplug event

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 08:37 AM, Jan Beulich wrote: On 17.12.16 at 00:18, wrote: >> @@ -128,6 +130,13 @@ static int acpi_access_common(struct domain *d, bool >> is_guest_access, >> *en = (((v & 0xff) << 8) | (*en & 0xff)) & *mask_en; >> break; >> } >> + >> +

Re: [Xen-devel] [PATCH v5 12/13] pvh/acpi: Save ACPI registers for PVH guests

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 08:57 AM, Jan Beulich wrote: On 17.12.16 at 00:18, wrote: >> --- a/xen/arch/x86/hvm/pmtimer.c >> +++ b/xen/arch/x86/hvm/pmtimer.c >> @@ -257,7 +257,11 @@ static int acpi_save(struct domain *d, >> hvm_domain_context_t *h) >> int rc; >> >> if ( !has_vpm(d) ) >> +{

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 09:47 AM, Jan Beulich wrote: On 20.12.16 at 15:35, wrote: >> On 12/20/2016 06:50 AM, Jan Beulich wrote: +else +{ +uint32_t v = *val; + +/* Status register is write-1-to-clear by guests */ +switch ( port & 3 ) +

Re: [Xen-devel] [PATCH v5 04/13] pvh/acpi: Install handlers for ACPI-related PVH IO accesses

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 09:55 AM, Andrew Cooper wrote: >>> Is this file is not supposed to be used by anyone outside of the Xen tree? >> I don't think so, no. In any event - prior additions did not do >> any precautions to guard possible foreign consumers. Maybe >> Andrew has an opinion here ... > Our polici

Re: [Xen-devel] [PATCH v5 12/13] pvh/acpi: Save ACPI registers for PVH guests

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 16:09, wrote: > On 12/20/2016 08:57 AM, Jan Beulich wrote: > On 17.12.16 at 00:18, wrote: >>> --- a/xen/arch/x86/hvm/pmtimer.c >>> +++ b/xen/arch/x86/hvm/pmtimer.c >>> @@ -257,7 +257,11 @@ static int acpi_save(struct domain *d, >>> hvm_domain_context_t *h) >>> int rc;

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Jan Beulich
>>> On 20.12.16 at 16:29, wrote: > On 12/20/2016 09:47 AM, Jan Beulich wrote: > On 20.12.16 at 15:35, wrote: >>> On 12/20/2016 06:50 AM, Jan Beulich wrote: > +else > +{ > +uint32_t v = *val; > + > +/* Status register is write-1-to-clear by guests */

[Xen-devel] [xen-unstable-smoke test] 103774: regressions - FAIL

2016-12-20 Thread osstest service owner
flight 103774 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103774/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt17 guest-start/debian.repeat fail REGR. vs. 103771 Tests which

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Konrad Rzeszutek Wilk
On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: > >> Signed-off-by: Alistair Francis > > > > > > Why? > > *adjusts his distro maintainer hat* It's considered

Re: [Xen-devel] [PATCH] xen/evtchn: use rb_entry()

2016-12-20 Thread Juergen Gross
On 20/12/16 15:02, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Reviewed-by: Juergen Gross > --- > drivers/xen/evtchn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Andrew Cooper
On 20/12/2016 15:41, Jan Beulich wrote: On 20.12.16 at 16:29, wrote: >> On 12/20/2016 09:47 AM, Jan Beulich wrote: >> On 20.12.16 at 15:35, wrote: On 12/20/2016 06:50 AM, Jan Beulich wrote: >> +else >> +{ >> +uint32_t v = *val; >> + >> +/*

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. That is OK but I think 'container_of' is more clear. Roger, thoughts? > > Signed-off-by: Geliang Tang > --- > drivers/block/xen-blkback/blk

Re: [Xen-devel] [PATCH v5 05/13] pvh/acpi: Handle ACPI accesses for PVH guests

2016-12-20 Thread Boris Ostrovsky
On 12/20/2016 11:46 AM, Andrew Cooper wrote: > On 20/12/2016 15:41, Jan Beulich wrote: > On 20.12.16 at 16:29, wrote: >>> On 12/20/2016 09:47 AM, Jan Beulich wrote: >>> On 20.12.16 at 15:35, wrote: > On 12/20/2016 06:50 AM, Jan Beulich wrote: >>> +else >>> +{ >>> +

[Xen-devel] merlot0 and merlot1 (was Re: [xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass)

2016-12-20 Thread Ian Jackson
Jan Beulich writes ("[Xen-devel] merlot0 and merlot1 (was Re: [xen-4.4-testing test] 103756: trouble: blocked/broken/fail/pass)"): > I consider this difficult to imagine, but it's also not entirely > impossible. Since this appears to recur, are there perhaps logs > (ideally more than one instance,

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Doug Goldstein
On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: Signed-off-by: Alistair Francis >>> >>> >>> Why? >> >

[Xen-devel] [xen-unstable test] 103762: regressions - trouble: broken/fail/pass

2016-12-20 Thread osstest service owner
flight 103762 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103762/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-33 host-install(3)broken REGR. vs. 103466 test-xtf-amd64-amd

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote: > On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: > > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: > >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Fr

Re: [Xen-devel] [PATCH 08/10] x86/vm-event: use unambiguous register names

2016-12-20 Thread Tamas K Lengyel
2016-12-20 3:42 GMT-07:00 Jan Beulich : > This is in preparation of eliminating the mis-naming of 64-bit fields > with 32-bit register names (eflags instead of rflags etc). > > Signed-off-by: Jan Beulich > Acked-by: Tamas K Lengyel ___ Xen-devel mail

Re: [Xen-devel] [PATCH v4 11/14] xen/x86: parse Dom0 kernel for PVHv2

2016-12-20 Thread Roger Pau Monne
On Fri, Dec 09, 2016 at 10:05:18AM -0700, Jan Beulich wrote: > >>> On 30.11.16 at 17:49, wrote: > > @@ -1930,12 +1931,148 @@ static int __init hvm_setup_p2m(struct domain *d) > > #undef MB1_PAGES > > } > > > > +static int __init hvm_copy_to_phys(struct domain *d, paddr_t paddr, void > > *buf,

Re: [Xen-devel] [PATCH 00/10] x86: register renaming (part I)

2016-12-20 Thread Andrew Cooper
On 20/12/2016 09:55, Jan Beulich wrote: > This is a first (of three, as far as current plans go) steps to do away > with misleading register names (eax instead of rax). > > 01: x86/MSR: introduce MSR access split/fold helpers > 02: x86/guest-walk: use unambiguous register names > 03: x86/shadow: us

Re: [Xen-devel] [PATCH 05/10] x86/HVM: use unambiguous register names

2016-12-20 Thread Andrew Cooper
On 20/12/2016 10:39, Jan Beulich wrote: > @@ -3032,16 +3032,16 @@ void hvm_task_switch( > if ( hvm_set_cr3(tss.cr3, 1) ) > goto out; > > -regs->eip= tss.eip; > -regs->eflags = tss.eflags | 2; > -regs->eax= tss.eax; > -regs->ecx= tss.ecx; > -regs->edx

[Xen-devel] [RFC 2/7] xen: Move xen files to accel/

2016-12-20 Thread Eduardo Habkost
Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xensource.com Signed-off-by: Eduardo Habkost --- Makefile.target| 4 +--- xen-common.c => accel/xen-common.c | 0 xen-hvm.c => accel/xen-hvm.c | 0 xen-mapcache.c => accel/xen-mapcache.c | 0 MAI

[Xen-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

2016-12-20 Thread Eduardo Habkost
This moves the KVM and Xen files to the an accel/ subdir. Instead of moving the *-stubs.c file to accel/ as-is, I tried to move most of the stub code to libqemustub.a. This way the obj-y logic for accel/ is simpler: obj-y includes accel/ only if CONFIG_SOFTMMU is set. The Xen stubs could be moved

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Roger Pau Monné
On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > > Roger

Re: [Xen-devel] Xen ARM community call - meeting minutes and date for the next one

2016-12-20 Thread Andrii Anisov
Julien, Stefano, Are there any updates about: ACTION: Bosch to send a bug report regarding xen-swiotlb Edgar: IOMMU could not be used by the guest (Stage-1). This would be useful to implement driver in userspace. Julien: When will it be required? Edgar: It is a trend Any mailing th

[Xen-devel] [RFC 1/7] xen: Move xen-*-stub.c to stubs/

2016-12-20 Thread Eduardo Habkost
Move xen stubs to stubs/ so they are handled automatically by libqemustub.a. Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xensource.com Cc: Paolo Bonzini Signed-off-by: Eduardo Habkost --- Makefile.target | 2 -- xen-hvm-stub.c => stubs/xen-hvm.c | 0 xen-co

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-20 Thread Alistair Francis
On Mon, Dec 19, 2016 at 8:00 PM, Doug Goldstein wrote: > On 12/19/16 12:01 PM, Alistair Francis wrote: >> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk >> wrote: >>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote: To avoid this build error with newer build systems:

Re: [Xen-devel] [PATCH] xen/blkback: use rb_entry()

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 05:44:06PM +, Roger Pau Monné wrote: > On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > > To make the code clearer, use rb_entry() instead of container_of() to > > > deal with rbt

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 9:21 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote: >> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: >> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: >> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wil

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Mon, Dec 19, 2016 at 7:53 PM, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >> >> >> Why? > > *adjusts his distro maintainer hat* It's considered really bad form

  1   2   >