Re: [PATCH v12 5/8] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-06-11 Thread Oleksii K.
On Tue, 2024-06-11 at 16:53 +0100, Andrew Cooper wrote: > On 30/05/2024 7:22 pm, Oleksii K. wrote: > > On Thu, 2024-05-30 at 18:23 +0100, Andrew Cooper wrote: > > > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > > > Signed-off-by: Oleksii Kurochko

Re: [PATCH for-4.19] CI: Update FreeBSD to 13.3

2024-06-11 Thread Oleksii K.
On Tue, 2024-06-11 at 13:47 +0100, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Release-Acked-by: Oleksii Kurochko ~ Oleksii > --- > CC: Stefano Stabellini > CC: Michal Orzel > CC: Roger Pau Monné > CC: Oleksii Kurochko > CC: Jan Beulich > > Updated run

Re: [PATCH v4 0/7] Static shared memory followup v2 - pt2

2024-06-11 Thread Oleksii K.
On Tue, 2024-06-11 at 12:35 +, Luca Fancellu wrote: > + Oleksii > > > On 24 May 2024, at 13:40, Luca Fancellu > > wrote: > > > > This serie is a partial rework of this other serie: > > https://patchwork.kernel.org/project/xen-devel/cover/20231206

Re: [PATCH v12 5/8] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-06-11 Thread Oleksii K.
On Thu, 2024-05-30 at 18:23 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich > > This patch looks like it can go in independently?  Or does it depend > on > having b

Re: [PATCH for-4.19] x86/EPT: relax iPAT for "invalid" MFNs

2024-06-11 Thread Oleksii K.
ially video frame buffer accesses are unduly affected by > > such > > a restriction. Permit PAT use for directly assigned MMIO as long as > > the > > domain is known to have been granted some level of cache control. > > > > Signed-off-by: Jan Beulich Re

Re: [PATCH for-4.19 v1] automation: add a test for HVM domU on PVH dom0

2024-06-11 Thread Oleksii K.
ers, similar to the PVH domU test. > > > > Signed-off-by: Marek Marczykowski-Górecki > > > > Acked-by: Andrew Cooper > > CC Oleksii. Release-Acked-By: Oleksii Kurochko ~ Oleksii > > > --- > > Requires rebuilding test-artifacts/kerne

Re: [XEN PATCH v6 0/7] FF-A notifications

2024-06-11 Thread Oleksii K.
Hi Bertrand and Julien, On Tue, 2024-06-11 at 07:09 +, Bertrand Marquis wrote: > Hi Julien and Oleksii, > > @Oleksii: Could we consider having this serie merged for next release > ? We can consider including it in Xen 4.19 as it has a low impact on existing systems and needs to b

Re: [PATCH v12 8/8] xen/README: add compiler and binutils versions for RISC-V64

2024-06-10 Thread Oleksii K.
On Thu, 2024-05-30 at 20:52 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > diff --git a/README b/README > > index c8a108449e..30da5ff9c0 100644 > > --- a/README > > +++ b/README > > @@ -48,6 +48,10 @@ provided by your OS distrib

Re: [PATCH for-4.19] x86/pvh: declare PVH dom0 supported with caveats

2024-06-10 Thread Oleksii K.
ing on both osstest and > gitlab. > > Signed-off-by: Roger Pau Monné Release-Acked-By: Oleksii Kurochko ~ Oleksii > --- > Hopefully this will attract more testing an resources to PVH dom0 in > order to > try to finish the missing features. > --- >  CHANGELOG.md |  1 +

Re: [PATCH] MAINTAINERS: alter EFI section

2024-06-10 Thread Oleksii K.
eing introduced in my place. > > Signed-off-by: Jan Beulich Release-Acked-by: Oleksii Kurochko ~ Oleksii > --- > For the new maintainers, here's a 1st patch to consider right away: > https://lists.xen.org/archives/html/xen-devel/2024-03/msg00931.html. > > --- a/MAINTAINERS &g

Re: [for-4.19] x86 emulator session outcome

2024-06-07 Thread Oleksii K.
On Thu, 2024-06-06 at 18:00 +0200, Jan Beulich wrote: > Oleksii, > > a decision of the session just finished was to deprecate support > for XeonPhi in 4.19, with the firm plan to remove support in 4.20. > This will want putting in the release notes. Thanks for notifing me. ~ Oleksii

Re: [XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines

2024-06-05 Thread Oleksii K.
On Tue, 2024-06-04 at 14:01 +0200, Nicola Vetrini wrote: > On 2024-06-04 13:39, Oleksii K. wrote: > > On Sat, 2024-06-01 at 21:13 +0200, Nicola Vetrini wrote: > > > Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they > > > are > > > added &

Re: [XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines

2024-06-04 Thread Oleksii K.
y can be removed from there. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > +Cc Oleksii for an opinion on the inclusion for 4.19 > > This is a follow-up to series > https://lore.kernel.org/xen-devel/cover.1717236930.git.nicola.vetr...@bugseng.com/

Re: [PATCH for-4.19 0/3] CI: Misc improvements

2024-05-31 Thread Oleksii K.
On Wed, 2024-05-29 at 15:19 +0100, Andrew Cooper wrote: > All found while making extensive use of Gitlab CI for the bitops boot > testing. > > For 4.19.  It's all very low risk, and improves the > utility/useability of our > testing. Release-Acked-by: Oleksii Kurochko ~ O

Re: [PATCH 2/2] arch/irq: Centralise no_irq_type

2024-05-30 Thread Oleksii K.
ion of no_irq_type into common/irq.c, and into .rodata for > good > measure. > > No functional change, but a whole lot less tangled. > > Signed-off-by: Andrew Cooper LGTM: Reviewed-by: Oleksii Kurochko > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Stefano

Re: [PATCH 1/2] arch/irq: Make irq_ack_none() mandatory

2024-05-30 Thread Oleksii K.
or PPC, introduce a stub irq_ack_none(). > > For ARM and x86, export the existing {ack,end}_none() helpers, > gaining an irq_ > prefix for consisntency with everything else in no_irq_type. > > No functional change. > > Signed-off-by: Andrew Cooper LGTM: Reviewed-by: Oleksii Ku

Re: [PATCH for-4.19 0/2] arch/irq: Untangle no_irq_type

2024-05-30 Thread Oleksii K.
>  xen/include/xen/irq.h  |  8 +++- >  6 files changed, 30 insertions(+), 30 deletions(-) > > > base-commit: 9a905d7dc65883af082532b4dc91ce0131e54047 I am okay to have it in release if the necessary acks will be recieved. Release-Acked-by: Oleksii Kurochko ~ Oleksii

Re: [PATCH v12 7/8] xen/riscv: enable full Xen build

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 18:45 +0100, Andrew Cooper wrote: > On 30/05/2024 6:12 pm, Oleksii K. wrote: > > On Thu, 2024-05-30 at 17:48 +0100, Andrew Cooper wrote: > > > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > > > diff --git a/xen/arch/riscv/stubs.c b/xen/ar

Re: [PATCH v12 5/8] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 18:23 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich > > This patch looks like it can go in independently?  Or does it depend > on > having b

Re: [PATCH v12 8/8] xen/README: add compiler and binutils versions for RISC-V64

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 17:47 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > diff --git a/README b/README > > index c8a108449e..30da5ff9c0 100644 > > --- a/README > > +++ b/README > > @@ -48,6 +48,10 @@ provided by your OS distrib

Re: [PATCH v12 7/8] xen/riscv: enable full Xen build

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 17:48 +0100, Andrew Cooper wrote: > On 29/05/2024 8:55 pm, Oleksii Kurochko wrote: > > diff --git a/xen/arch/riscv/stubs.c b/xen/arch/riscv/stubs.c > > index 8285bcffef..bda35fc347 100644 > > --- a/xen/arch/riscv/stubs.c > > +++ b/xen/arch/riscv/

Re: [PATCH] x86/hvm: allow XENMEM_machine_memory_map

2024-05-30 Thread Oleksii K.
? > > I've found it while attempting to repro an issue with e820_host > reported by Marek, but the issue he reported is not related to this. > It's just that I have most of my test systems set as PVH dom0. > > > Also, as it's mostly PVH Dom0 bugfixing, shouldn't we want it in > > 4.1

Re: [PATCH v12 1/8] xen/riscv: disable unnecessary configs

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 17:44 +0100, Andrew Cooper wrote: > > The subject should say "update Kconfig", because you're not (only) > disabling. > > I'd suggest "xen/riscv: Update Kconfig in preparation for a full Xen > build". > > On 29/05/2024 8

Re: [PATCH v4 0/2] Clean the policy manipulation path in domain creation

2024-05-30 Thread Oleksii K.
On Thu, 2024-05-30 at 10:44 +0100, Andrew Cooper wrote: > On 29/05/2024 3:30 pm, Alejandro Vallejo wrote: > > Alejandro Vallejo (2): > >   tools/xg: Streamline cpu policy serialise/deserialise calls > >   tools/xg: Clean up xend-style overrides for CPU policies > &g

Re: [PATCH] tools: (Actually) drop libsystemd as a dependency

2024-05-30 Thread Oleksii K.
is too. > > Fixes: ae26101f6bfc ("tools: Drop libsystemd as a dependency") > Signed-off-by: Andrew Cooper Release-Acked-by: Oleksii Kurochko ~ Oleksii > --- > CC: Anthony PERARD > CC: Juergen Gross > CC: Oleksii Kurochko > CC: George Dunlap > CC: Jan Beulich > C

[PATCH v12 7/8] xen/riscv: enable full Xen build

2024-05-29 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- At least this patch cann't be merged w/o Andrew's patch series is merged as ffs related functions are used from that patch series: https://lore.kernel.org/xen-devel/20240313172716.2325427-1-andrew.coop...@citrix.com/T/#t

[PATCH v12 1/8] xen/riscv: disable unnecessary configs

2024-05-29 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v12 4/8] xen/riscv: add definition of __read_mostly

2024-05-29 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v12 6/8] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-29 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V12: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v12 8/8] xen/README: add compiler and binutils versions for RISC-V64

2024-05-29 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko -- Changes in V5-V12: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v12 3/8] xen/riscv: introduce bitops.h

2024-05-29 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V11-V12: - Nothing changed. Only rebase was done. --- Changes in V10: - update the error message BITS_PER_LONG -> BITOP_BITS_PER_WORD --- Changes in V9: - add Acked-by: Jan Beulich - d

[PATCH v12 2/8] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii Kurochko
t_bit(). Signed-off-by: Oleksii Kurochko --- Changes in V12: - revert change of moving the definition of BITS_PER_BYTE from /bitops.h to xen/bitops.h. ( a separate patch will be provided to put BITS_PER_BYTE to proper place ) - drop comments on top of generic_*() functions and update the com

[PATCH v12 5/8] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-29 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V12: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH for-4.19? v12 0/8] *Enable build of full Xen for RISC-V

2024-05-29 Thread Oleksii Kurochko
introduction of asm/atomic.h. - update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (8): xen/riscv: disable unnecessary configs xen: introduce generic non-atomic test_*bit() xen/riscv: introduce bitops.h xen/riscv: add definition of __read_mostly xen/r

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 18:29 +0200, Oleksii K. wrote: > On Wed, 2024-05-29 at 17:22 +0200, Jan Beulich wrote: > > On 29.05.2024 16:58, Oleksii K. wrote: > > > static always_inline bool test_bit(int nr, const volatile void > > > *addr)On > > > Wed, 2024-05-

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 17:22 +0200, Jan Beulich wrote: > On 29.05.2024 16:58, Oleksii K. wrote: > > static always_inline bool test_bit(int nr, const volatile void > > *addr)On > > Wed, 2024-05-29 at 12:06 +0200, Jan Beulich wrote: > > > On 29.05.2024 11:59, Julien

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
static always_inline bool test_bit(int nr, const volatile void *addr)On Wed, 2024-05-29 at 12:06 +0200, Jan Beulich wrote: > On 29.05.2024 11:59, Julien Grall wrote: > > Hi, > > > > On 29/05/2024 09:36, Jan Beulich wrote: > > > On 29.05.2024 09:50, Oleksii K. wro

Re: [PATCH] Partial revert of "x86/MCE: optional build of AMD/Intel MCE code"

2024-05-29 Thread Oleksii K.
ixes: 19b6e9f9149f ("x86/MCE: optional build of AMD/Intel MCE code") > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Sergiy Kibrik > CC: Stefano Stabellini > CC: Oleksii Kurochko > > We're past feature freeze and this was

Re: Updated Xen 4.19 schedule

2024-05-29 Thread Oleksii K.
On Wed, 2024-05-29 at 10:19 +0200, Jan Beulich wrote: > On 29.05.2024 10:03, Oleksii K. wrote: > > Hello everyone, > > > > I would like to announce that I have decided to update the Xen 4.19 > > schedule due to the extended feature freeze period and the upcoming &

Re: [PATCH for-4.19 0/9] x86/irq: fixes for CPU hot{,un}plug

2024-05-29 Thread Oleksii K.
ng has some > unexpected corner cases that are hard to diagnose and reason about. Despite of the fact that it can be considered as bugfixes, it seems to me that this patch series can be risky. Let's wait for maintainers opinion... ~ Oleksii > > I'm currently also doing some extra testing

Updated Xen 4.19 schedule

2024-05-29 Thread Oleksii K.
Final commits: from July 5 to July 12 Release: July 17 The release date is shifted, but it still remains in July, which seems acceptable to me. One more thing: No release ack is needed before Rc1. Please commit bug fixes at will. Have a nice day. Best regards, Oleksii

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-29 Thread Oleksii K.
useful? " * If two examples of this operation race, one can appear to succeed * but actually fail. You must protect multiple accesses with a lock." It seems to me that it can dropped as basically "non-atomic and can be reordered." means that. ~ Oleksii

Re: [PATCH for-4.19 v3 0/3] xen/x86: support foreign mappings for HVM/PVH

2024-05-29 Thread Oleksii K.
le altp2m at create domain domctl > >   xen/x86: remove foreign mappings from the p2m on teardown > > Here, too, I'd like to ask whether to keep this as a candidate for > 4.19, or > whether to postpone. Afaict what's still missing are Arm and tool > chain acks > on

Re: [PATCH v2 for-4.19 0.5/13] xen: Introduce CONFIG_SELF_TESTS

2024-05-29 Thread Oleksii K.
s. > > Signed-off-by: Andrew Cooper Looks good to me. We can consider it to be merged to 4.19: Release-Acked-by: Oleksii Kurochko ~ Oleksii > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk >

Re: [PATCH for-4.19 0/3] xen: Misc MISRA changes

2024-05-29 Thread Oleksii K.
On Tue, 2024-05-21 at 18:15 +0100, Andrew Cooper wrote: > Misc fixes collected during today's call. Release-Acked-by: Oleksii Kurochko > > Andrew Cooper (3): >   xen/lzo: Implement COPY{4,8} using memcpy() >   xen/x86: Drop useless non-Kconfig CONFIG_* variables >   xen/x86

Re: [XEN PATCH v4 0/3] x86: make Intel/AMD vPMU & MCE support configurable

2024-05-29 Thread Oleksii K.
On Mon, 2024-05-27 at 17:47 +0200, Jan Beulich wrote: > Oleksii, > > On 22.05.2024 10:37, Sergiy Kibrik wrote: > > Three remaining patches to separate support of Intel & AMD CPUs in > > Xen build. > > Most of related patches from previous series had already been &

Re: [PATCH] x86/svm: Rework VMCB_ACCESSORS() to use a plain type name

2024-05-28 Thread Oleksii K.
On Tue, 2024-05-28 at 17:37 +0200, Jan Beulich wrote: > On 28.05.2024 17:32, Andrew Cooper wrote: > > This avoids having a function call in a typeof() expression. > > > > No functional change. > > > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich

Re: [PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-28 Thread Oleksii K.
On Tue, 2024-05-28 at 08:20 +0200, Jan Beulich wrote: > On 24.05.2024 13:08, Oleksii Kurochko wrote: > > The following generic functions were introduced: > > * test_bit > > * generic__test_and_set_bit > > * generic__test_and_clear_bit > > * generic__test_and_ch

Re: Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
On Mon, 2024-05-27 at 17:55 +0200, Jan Beulich wrote: > On 27.05.2024 17:52, Oleksii K. wrote: > > On Mon, 2024-05-27 at 17:12 +0200, Jan Beulich wrote: > > > On 27.05.2024 15:58, Oleksii K. wrote: > > > > I would like to remind you that the code fr

Re: [PATCH v2 3/3] CHANGELOG: Mention libxl blktap/tapback support

2024-05-27 Thread Oleksii K.
; capability. > + - libxl support for backendtype=tap with tapback. >   >  ### Removed >  - caml-stubdom.  It hasn't built since 2014, was pinned to Ocaml > 4.02, and has Acked-by: Oleksii Kurochko ~ Oleksii

Re: Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
On Mon, 2024-05-27 at 17:12 +0200, Jan Beulich wrote: > On 27.05.2024 15:58, Oleksii K. wrote: > > I would like to remind you that the code freeze date for Xen 4.19 > > is > > May 31, 2024. > > I may be confused: With feature freeze having been last Friday aiui, > i

Re: [PATCH v4 2/4] xen/arm: Alloc XenStore page for Dom0less DomUs from hypervisor

2024-05-27 Thread Oleksii K.
ink it is a big problem if this is not merged for the code > freeze as this is technically a bug fix. Agree, this is not a problem as it is still looks to me as a bug fix. ~ Oleksii > > Cheers, > > On 24/05/2024 23:55, Stefano Stabellini wrote: > > From: Henry Wang > >

Code freeze date for Xen 4.19 is 31.05.2024

2024-05-27 Thread Oleksii K.
Hi all, I would like to remind you that the code freeze date for Xen 4.19 is May 31, 2024. I'm okay with bug fixes being committed without my release ack (just CC me), except in cases where a one of maintainers gives a strong NACK. Have a nice week! Best regards, Oleksii

Re: [PATCH v2 for-4.19 00/13] xen/bitops: Untangle ffs()/fls() infrastructure

2024-05-27 Thread Oleksii K.
I think we can consider to have this patch series in Xen 4.19 release: Release-acked-by: Oleksii Kurochko ~ Oleksii On Fri, 2024-05-24 at 21:03 +0100, Andrew Cooper wrote: > bitops.h is a mess.  It has grown organtically over many years, and > forces > unreasonable repsonsibil

[PATCH v11 6/9] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V11: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH v11 7/9] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V11: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v11 2/9] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii Kurochko
* __test_and_set_bit() will be defined using arch__test_and_set_bit() and generic__test_and_set_bit(). Signed-off-by: Oleksii Kurochko --- Reviewed-by: Jan Beulich jbeul...@suse.com? Jan gave his R-by for the previous version of the patch, but some changes were done, so I wasn't sure if I could use th

[PATCH v11 3/9] xen/bitops: implement fls{l}() in common logic

2024-05-24 Thread Oleksii Kurochko
rototype of the per-architecture fls{l}() functions was changed to return 'unsigned int' to align with the generic implementation of these functions and avoid introducing signed/unsigned mismatches. Signed-off-by: Oleksii Kurochko --- The current one patch can be merged w/o waiting of Andrew's patc

[PATCH v11 0/9] Enable build of full Xen for RISC-V

2024-05-24 Thread Oleksii Kurochko
- update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (9): xen/riscv: disable unnecessary configs xen: introduce generic non-atomic test_*bit() xen/bitops: implement fls{l}() in common logic xen/riscv: introduce bitops.h xen/riscv: add definition of __read_m

[PATCH v11 5/9] xen/riscv: add definition of __read_mostly

2024-05-24 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v11 9/9] xen/README: add compiler and binutils versions for RISC-V64

2024-05-24 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko -- Changes in V5-V11: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v11 1/9] xen/riscv: disable unnecessary configs

2024-05-24 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v11 8/9] xen/riscv: enable full Xen build

2024-05-24 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- At least this patch cann't be merged w/o Andrew's patch series is merged as ffs related functions are used from that patch series: https://lore.kernel.org/xen-devel/20240313172716.2325427-1-andrew.coop...@citrix.com/T/#t

[PATCH v11 4/9] xen/riscv: introduce bitops.h

2024-05-24 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V11: - Nothing changed. Only rebase was done. --- Changes in V10: - update the error message BITS_PER_LONG -> BITOP_BITS_PER_WORD --- Changes in V9: - add Acked-by: Jan Beulich - d

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
for all the > > > other arch. > > It makes sense to add this comment on top of test_bit(), but I am > > curious if it is needed to mention that for x86 arch_test_bit() "is > > atomic and may not be reordered": > > I would say no because any developper modifying common code can't > relying it. But won't then be confusion that if not generic implementation of test_bit() is chosen then test_bit() can be " atomic and cannot be reordered " ( as it is in case of x86 )? ~ Oleksii

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
On Fri, 2024-05-24 at 09:35 +0200, Jan Beulich wrote: > On 24.05.2024 09:25, Oleksii K. wrote: > > On Fri, 2024-05-24 at 08:48 +0200, Jan Beulich wrote: > > > On 23.05.2024 18:40, Oleksii K. wrote: > > > > On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote:

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-24 Thread Oleksii K.
On Fri, 2024-05-24 at 08:48 +0200, Jan Beulich wrote: > On 23.05.2024 18:40, Oleksii K. wrote: > > On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote: > > > On 23/05/2024 15:11, Oleksii K. wrote: > > > > On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote:

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-23 Thread Oleksii K.
On Thu, 2024-05-23 at 15:33 +0100, Julien Grall wrote: > > > On 23/05/2024 15:11, Oleksii K. wrote: > > On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote: > > > Hi Oleksii, > > Hi Julien, > > > > > > > > On 17/05/2024 14:54, Oleksii K

Re: [PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-23 Thread Oleksii K.
On Thu, 2024-05-23 at 14:00 +0100, Julien Grall wrote: > Hi Oleksii, Hi Julien, > > On 17/05/2024 14:54, Oleksii Kurochko wrote: > > diff --git a/xen/arch/arm/arm64/livepatch.c > > b/xen/arch/arm/arm64/livepatch.c > > index df2cebedde..4bc8ed9be5 100644 > > ---

Re: [PATCH] x86/shadow: don't leave trace record field uninitialized

2024-05-23 Thread Oleksii K.
While there also drop the "event" local variable, thus eliminating an > instance of the being phased out u32 type. > > Coverity ID: 1598430 > Fixes: 9a86ac1aa3d2 ("xentrace 5/7: Additional tracing for the shadow > code") > Signed-off-by: Jan Beulich Release-ack

Re: [for-4.19] Re: [XEN PATCH v3] arm/mem_access: add conditional build of mem_access.c

2024-05-23 Thread Oleksii K.
Hi Julien, On Wed, 2024-05-22 at 21:50 +0100, Julien Grall wrote: > Hi, > > Adding Oleksii as the release manager. > > On 22/05/2024 19:27, Tamas K Lengyel wrote: > > On Fri, May 10, 2024 at 8:32 AM Alessandro Zucchelli > > wrote: > > > > > >

Re: [PATCH v10 03/14] xen/bitops: implement fls{l}() in common logic

2024-05-22 Thread Oleksii K.
On Tue, 2024-05-21 at 13:18 +0200, Jan Beulich wrote: > On 17.05.2024 15:54, Oleksii Kurochko wrote: > > To avoid the compilation error below, it is needed to update to > > places > > in common/page_alloc.c where flsl() is used as now flsl() returns > > unsigned

Re: [PATCH for-4.19 0/3] xen: Misc MISRA changes

2024-05-22 Thread Oleksii K.
Hi Andrew, We can consider this patch series to be in Xen 4.19: Release-acked-by: Oleksii Kurochko ~ Oleksii On Tue, 2024-05-21 at 18:15 +0100, Andrew Cooper wrote: > Misc fixes collected during today's call. > > Andrew Cooper (3): >   xen/lzo: Implement COPY{4,8} using memcpy()

Re: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state

2024-05-20 Thread Oleksii K.
dump_msi(unsigned char > key) > unsigned long flags; > const char *type = "???"; >   > +    if ( !(irq & 0x1f) ) > +    process_pending_softirqs(); > + >      if ( !irq_desc_initialized(desc) ) > continue; >   Release-acked-by: Oleksii Kurochko ~ Oleksii

[PATCH v10 13/14] xen/riscv: enable full Xen build

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Jan Beulich --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V4: - drop stubs for irq_actor_none() and irq_actor_none() as common/irq.c is compiled now. - drop defintion of max_page in stubs.c as common/page_alloc.c

[PATCH v10 10/14] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V8-V10: - Nothing changed only rebase. --- Changes in V7: - update argument type of maddr_to_virt() function: unsigned long -> paddr_t - rename argument of PFN_ORDER(): pfn -> pg. - add Acked-by: Jan Beulich --- C

[PATCH v10 11/14] xen/riscv: introduce vm_event_*() functions

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V5-V10: - Only rebase was done. --- Changes in V4: - New patch. --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/vm_event.c | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 xen/arch/riscv/vm_event.c diff --git

[PATCH v10 06/14] xen/riscv: introduce atomic.h

2024-05-17 Thread Oleksii Kurochko
kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V10: - drop unnessary parentheses around p i

[PATCH v10 12/14] xen/riscv: add minimal amount of stubs to build full Xen

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V7-V10: - Only rebase was done. --- Changes in V6: - update the commit in stubs.c around /* ... common/irq.c ... */ - add Acked-by: Jan Beulich --- Changes in V5: - drop unrelated changes - assert_failed("unimplm

[PATCH v10 05/14] xen/riscv: introduce cmpxchg.h

2024-05-17 Thread Oleksii Kurochko
".aqrl" was approved by (the author of the RVWMO spec) [2] [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1391516953-14541-1-git-send-email-will.dea...@arm.com/ [2] https://lore.kernel.org/linux-riscv/41e01514-74ca-84f2-f5cc-2645c444f...@nvidia.com/ Signed-off-by: Oleksii K

[PATCH v10 09/14] xen/riscv: add required things to current.h

2024-05-17 Thread Oleksii Kurochko
Add minimal requied things to be able to build full Xen. Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V4: - BUG() was changed to BUG_ON("unimplemented"); - Change "xen/bug.h" to "xen/li

[PATCH v10 03/14] xen/bitops: implement fls{l}() in common logic

2024-05-17 Thread Oleksii Kurochko
rototype of the per-architecture fls{l}() functions was changed to return 'unsigned int' to align with the generic implementation of these functions and avoid introducing signed/unsigned mismatches. Signed-off-by: Oleksii Kurochko --- The patch is almost independent from Andrew's patch series

[PATCH v10 14/14] xen/README: add compiler and binutils versions for RISC-V64

2024-05-17 Thread Oleksii Kurochko
to utilize Clang, it's important to note that, currently, there is no Xen RISC-V CI job in place to verify the seamless functioning of the build with Clang. Signed-off-by: Oleksii Kurochko --- Changes in V5-V10: - Nothing changed. Only rebase. --- Changes in V6: - update the message in README

[PATCH v10 01/14] xen/riscv: disable unnecessary configs

2024-05-17 Thread Oleksii Kurochko
requires asm/perf.h and asm/perfc-defn.h, so it is also disabled for now, as RISC-V hasn't introduced this headers yet. LIVEPATCH isn't ready for RISC-V too and it can be overriden by randconfig, so to avoid compilation errors for randconfig it is disabled for now. Signed-off-by: Oleksii Kurochko

[PATCH v10 07/14] xen/riscv: introduce monitor.h

2024-05-17 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V4-V10: - Nothing changed. Only rebase. --- Changes in V3: - new patch. --- xen/arch/riscv/include/asm/monitor.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 xen/arch/riscv/include/asm/monitor.h diff --git

[PATCH v10 04/14] xen/riscv: introduce bitops.h

2024-05-17 Thread Oleksii Kurochko
* __test_and_set_bit Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich --- Changes in V10: - update the error message BITS_PER_LONG -> BITOP_BITS_PER_WORD --- Changes in V9: - add Acked-by: Jan Beulich - drop redefinition of bitop_uint_t in asm/types.h as some operation in

[PATCH v10 08/14] xen/riscv: add definition of __read_mostly

2024-05-17 Thread Oleksii Kurochko
The definition of __read_mostly should be removed in: https://lore.kernel.org/xen-devel/f25eb5c9-7c14-6e23-8535-2c66772b3...@suse.com/ The patch introduces it in arch-specific header to not block enabling of full Xen build for RISC-V. Signed-off-by: Oleksii Kurochko --- - [PATCH] move

[PATCH v10 00/14] Enable build of full Xen for RISC-V

2024-05-17 Thread Oleksii Kurochko
s used. - align arch-riscv.h with Arm's version of it. - change the Author of commit with introduction of asm/atomic.h. - update some definition from spinlock.h. - code style changes. --- Oleksii Kurochko (14): xen/riscv: disable unnecessary configs xen: introduce generic non-atomic test_*bit

[PATCH v10 02/14] xen: introduce generic non-atomic test_*bit()

2024-05-17 Thread Oleksii Kurochko
t_bit(). Signed-off-by: Oleksii Kurochko --- The context ("* Find First Set bit. Bits are labelled from 1." in xen/bitops.h ) suggests there's a dependency on an uncommitted patch. It happens becuase the current patch series is based on Andrew's patch series ( htt

Re: [PATCH v9 03/15] xen/bitops: implement fls{l}() in common logic

2024-05-17 Thread Oleksii K.
$-1,%0\n" "1:" : "=r" (r) : "rm" (x)); return r + 1; } #define arch_fls arch_fls Any specific reason why 'long' and 'int' types for r are used? ~ Oleksii

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-17 Thread Oleksii K.
st_bit(). Thereby according to provided by me naming for test_bit() should be defined using {generic, arch}_test_bit(). ~ Oleksii

Re: [XEN PATCH 0/4] address violations of MISRA C Rule 20.7

2024-05-16 Thread Oleksii K.
his one rather want/need delaying until after branching. > > Lets follow the same approach for 4.19. > > Well, okay. But if you don't say now until when this is okay, you'll > need to announce the "stop" very prominently later on, so no-one > misses it. For me it is okay until we don't have Hard Code Release deadline. ~ Oleksii

Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"

2024-05-16 Thread Oleksii K.
On Tue, 2024-05-14 at 12:13 +0100, Julien Grall wrote: > Hi, > > (+ Oleksii as the release manager) > > Chiming into the discussion as there seems there is disagreement. > > On 14/05/2024 11:03, Jan Beulich wrote: > > On 14.05.2024 11:51, Andrew Cooper wrote: > &

Re: [PATCH for-4.19] tools/xentop: fix cpu% sort order

2024-05-16 Thread Oleksii K.
6.3 > >   Domain-0 -r   1060    1.5    1048576    1.6    > > 1048576   1.6 > >   neon --b---    827    1.1    2097216    3.1    > > 2098176   3.1 > >     cheese --b---    225    0.7    1048384    1.6    > > 1049600   1.6 > > pizza --b---    359    0.5 524352    0.8 > > 525312   0.8 > >    cassini --b---    490    0.4    3145792    4.7    > > 3146752   4.7 > >    fusilli --b---    159    0.2 524352    0.8 > > 525312   0.8 > >    bob --b---    502    0.2   16777284   25.0   > > 16778240  25.0 > >    blender --b---    121    0.2    1048640    1.6    > > 1049600   1.6 > > bread --b--- 69    0.1 524352    0.8 > > 525312   0.8 > >   chickpea --b--- 67    0.1 524352    0.8 > > 525312   0.8 > >     lentil --b--- 67    0.1 262208    0.4 > > 263168   0.4 > > > Ah, so it's the rounding, and a straight cast discards the fractional > part. > > I think your patch is fine, although it could do with a mention of > why > this goes wrong in the commit message.  I'm happy to adjust on > commit. Feel free to merge it as I am considering it as bugfix: Release-acked-by: Oleksii Kurochko ~ Oleksii > > ~Andrew

Re: [XEN PATCH v7 1/5] xen/vpci: Clear all vpci status of device

2024-05-16 Thread Oleksii K.
n linux-next [0]. > > [0] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20240515=b272722511d5e8ae580f01830687b8a6b2717f01 Sure! Fixes should be merged. Release-acked-by: Oleksii Kurochko ~ Oleksii

Re: [PATCH for-4.19?] xen/x86: pretty print interrupt CPU affinity masks

2024-05-16 Thread Oleksii K.
s going to write exactly the same patch, but you beat me to > it. > > Acked-by: Andrew Cooper Looks good to me for having in Xen 4.19 release. Release-acked-by: Oleksii Kurochko ~ Oleksii

Re: [XEN PATCH 0/4] address violations of MISRA C Rule 20.7

2024-05-16 Thread Oleksii K.
On Wed, 2024-05-15 at 09:48 +0200, Jan Beulich wrote: > Oleksii, > > On 15.05.2024 09:34, Nicola Vetrini wrote: > > Hi all, > > > > this series aims to refactor some macros that cause violations of > > MISRA C Rule > > 20.7 ("Expressions resulting from

Feature Freeze Deadline Extended to May 24

2024-05-16 Thread Oleksii K.
regards, Oleksii

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-16 Thread Oleksii K.
On Thu, 2024-05-16 at 09:04 +0200, Jan Beulich wrote: > On 15.05.2024 19:03, Oleksii K. wrote: > > On Wed, 2024-05-15 at 17:41 +0200, Jan Beulich wrote: > > > On 15.05.2024 17:29, Oleksii K. wrote: > > > > On Wed, 2024-05-15 at 10:52 +0200, Jan Beulich wrote: > >

Re: [PATCH v9 02/15] xen: introduce generic non-atomic test_*bit()

2024-05-15 Thread Oleksii K.
On Wed, 2024-05-15 at 17:41 +0200, Jan Beulich wrote: > On 15.05.2024 17:29, Oleksii K. wrote: > > On Wed, 2024-05-15 at 10:52 +0200, Jan Beulich wrote: > > > On 06.05.2024 12:15, Oleksii Kurochko wrote: > > > > The following generic functions were

  1   2   3   4   5   6   7   8   9   10   >