Be more precise in describing the return value.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-output.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/xwayland/xwayland-output.c b/hw/xwayland/xwayland-output.c
index d9047c5..bfaf979
On Fri, Aug 4, 2017 at 8:44 AM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 03/08/17 09:11 PM, Roman Gilg wrote:
> > On Wed, Aug 2, 2017 at 11:36 AM, Michel Dänzer <mic...@daenzer.net
> > <mailto:mic...@daenzer.net>> wrote:
> >
> &g
In xwl_seat_maybe_lock_on_hidden_cursor the confined_pointer is
destroyed in case it exists. We can remove this since we do it in
the subsequent call to xwl_seat_create_pointer_warp_emulator as well.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-input.c | 3 ---
On Thu, Aug 10, 2017 at 2:49 PM, Pekka Paalanen wrote:
>
> how does this work when windows are reparented? Does reparenting force
> them to go through the unrealize/realize steps again?
>
I assumed this because it is described this way for the XLib
function XReparentWindow:
Hi,
I'm working for my GSoC project on a better Present integration in
Xwayland. This should improve performance as well as minimize tearing. My
mentor is Daniel Stone and the starting point was my work on KWin and this
bug report: https://bugs.freedesktop.org/show_bug.cgi?id=99702.
I'm writing
According to the feedback I received on my first mail (see:
https://lists.x.org/archives/xorg-devel/2017-July/054136.html) I reworked
huge parts of my code for enabling Present pixmap flips in Xwayland. The
current code now provides the following functionality:
Summary:
(1)
On Wed, Aug 2, 2017 at 11:36 AM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 02/08/17 03:53 AM, Roman Gilg wrote:
> >
> > Overview of differences in Rootless mode:
> >
> > * Maintain a list of all windows, that are currently flipping pixmaps.
> > * In
the looping by
always putting the respective xwl_window in the Window's private field on
its realization. If the Window doesn't feature an xwl_window on its own,
it's the xwl_window in the ancestor chain found by xwl_window_from_window.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xw
I've just sent another version with different naming and the additional
function for comparing the private field's xwl_window with its creator as
reply to your mail. Take a look how you like it. One other difference: I
realized that the xwl_window_find(..) function is unneeded, since when
putting
On Wed, Aug 30, 2017 at 4:42 AM, Michel Dänzer <mic...@daenzer.net> wrote:
>
> Hi Roman,
>
>
> On 30/08/17 12:24 AM, Roman Gilg wrote:
> >
> > Originating from the bug report
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=99702
> >
> &g
and the only interfaces are input events and buffer content
delivery.
On Wed, Aug 30, 2017 at 4:10 AM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 30/08/17 12:24 AM, Roman Gilg wrote:
> > This patch enables Pixmap flips for child windows via Wayland
> > sub-surfaces.
>
On Wed, Aug 30, 2017 at 4:35 AM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 30/08/17 12:24 AM, Roman Gilg wrote:
> > This patch adds a new mode to the internal flip mode API, that
> > enables per window flips on capable hardware platforms.
> >
> > Pixmap fl
12:24 AM, Roman Gilg wrote:
> >
> > There is a small change to the window mode in Present as well, that now
> > calls flip_executed at the end of processing the flip with the
> > calculated damage. Xwayland then commits the new buffer.
>
> As discussed before, I'd
the looping by
always putting the respective xwl_window in the Window's private field on
its realization. If the Window doesn't feature an xwl_window on its own,
it's the xwl_window of its first ancestor with one.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-input.
The vblank and execute functions aren't static anymore. Therefore we
can put them into separate files in order to increase clarity.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am | 4 +-
present/meson.build | 2 +
present/present.c
the first available mode in the new API.
There is otherwise no change in functionality and the current workings
are meant to stay completely the same.
The scrmode is also used, when flipping is not supported by the hardware.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefil
by holding back the PresentIdleNotify event for a
flipped pixmaps of a preceding frame until present_winmode_event_notify
is called once more.
The mode is initialized by calling present_winmode_screen_init instead
of present_screen_init for a particular ScreenPtr.
Signed-off-by: Roman Gilg <s
operation.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 44 --
hw/xwayland/xwayland.c | 6 +-
hw/xwayland/xwayland.h | 2 ++
present/present_winmode.c | 4 +---
4 files changed, 46 inse
Originating from the bug report
https://bugs.freedesktop.org/show_bug.cgi?id=99702
and my own observations with Xwayland misbehaving when outscanning on overlay
planes, this patch series aims at improving Present support in Xwayland.
For that it introduces an internal flip mode API to
at the end of processing the flip with the
calculated damage. Xwayland then commits the new buffer.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/Makefile.am| 1 +
hw/xwayland/meson.build| 1 +
hw/xwayland/xwayland-glamor.c | 17 +-
hw/xwayland/xwayland-pre
There is a mistake in the patch description since the mentioned small
change to the Present extension code wasn't necessary in the end. So I
reverted the change, but forgot about the description.
On Tue, Aug 29, 2017 at 5:24 PM, Roman Gilg <subd...@gmail.com> wrote:
> This patch enabl
the time and the msc counter is monotonically
counting for a window so there should be no need to have different
CRTCs for different msc counters.
Tested the patch in a Plasma session with VLC and Skype.
Tested-by: Roman Gilg <subd...@gmail.com>
Reviewed-by: Roman Gilg <subd...@gmail.com>
Without this patch plasmashell on Xserver/Mesa master freezes on me
when opening the launcher menu (Kickoff). With the patch haven't
experienced freezes yet.
Haven't tested the Steam client yet. Might be a different problem though.
Tested-by: Roman Gilg <subd...@gmail.com>
On Fri, May 4
, which always get discarded on unmap. So that the
change directly worked for you without regressions is probably a
consequence of that.
On Fri, May 4, 2018 at 10:05 AM, Olivier Fourdan <ofour...@redhat.com> wrote:
> Hi Roman,
>
> On Fri, May 4, 2018 at 3:07 AM, Roman Gilg <subd..
On Sat, May 5, 2018 at 8:50 PM, Mario Kleiner
wrote:
> Thanks. Can you see if you get any freezes in kwin_x11 by "violent
> alt-tabbing" with patch 1? I've seen two such freezes within 8 hours
> of normal use yesterday, each occuring when i alt-tabbed (normally)
> and
The only question open to me is how the window and pixmap size can be
different at all at this point. But taking the Pixmap size is in any
case better.
I reviewed v3 on patchworks.
Reviewed-by: Roman Gilg
___
xorg-devel@lists.x.org: X.Org development
window flip mode"
Thank you for patching this difficult to find issue. That's a
behavioral change to screen flips, that I missed.
Reviewed-by: Roman Gilg
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Modifiers support needs gbm as a dependency. Without setting the dependency
included headers are not found reliably and the build might fail if the
headers are not placed in the default system include paths.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xfree86/drivers/modes
correctly in
present_wnmd_window_to_crtc_msc.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 10 +-
present/present.h | 2 +-
present/present_wnmd.c | 14 +-
3 files changed, 19 insertions(+), 7 deletions(-)
diff --gi
Instead of reusing xwl_window introduce a persistent window struct for every
window, that asks for Present flips.
This struct saves all relevant data and is only freed on window destroy.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c
> wrote:
> On Mon, 2018-01-29 at 14:34 +0100, Roman Gilg wrote:
>
>> @@ -100,6 +128,21 @@ typedef struct present_screen_info {
>>
>> } present_screen_info_rec, *present_screen_info_ptr;
>>
>> +typedef struct present_wnmd_info {
>> +uint32_t
#endif /* _PRESENT_PRIV_H_ */
diff --git a/present/present_wnmd.c b/present/present_wnmd.c
new file mode 100644
index 000..c428232
--- /dev/null
+++ b/present/present_wnmd.c
@@ -0,0 +1,672 @@
+/*
+ * Copyright © 2018 Roman Gilg
+ *
+ * Permission to use, copy, modify, distribute, and sell this software a
Allow drivers now to initialize window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h| 2 ++
present/present_screen.c | 23 ++-
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/present/present.h b/present/present.h
To be shared by multiple flip modes, refactor execute functionality,
such that logical chunks can go in new separate file.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am | 1 +
present/meson.build | 1 +
present/present_execute.c
Calculate damage before trying to flip and report it to the driver.
This allows supporting drivers to optimize their rendering.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h | 3 ++-
present/present_wnmd.c | 24 +---
2 files changed, 15 inse
Add arguments to allow the caller more information and control
over the creation of a wl_buffer with GBM, in particular let
the caller determine the size of the buffer.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-glamor.c | 22 ++
hw/xw
Make sure that vblanks and windows get cleaned up correctly
in window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_screen.c | 33 -
present/present_vblank.c | 2 ++
2 files changed, 34 insertions(+), 1 deletion(-)
diff
han the xwl_window,
* queuing events to MSC times,
* reporting UST values to present.
To make use of this functionality Xwayland must run rootless and with
Glamor/GBM.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/Makefile.am| 1 +
hw/xwayland/meson.build| 1 +
hw
To enable special functionality of window flips introduce for window flips
a separate set of driver facing function hooks.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h | 43 +++
present/present_priv.h | 1 +
2 files chang
To reduce future code duplication refactor timings adjustment out
as a separate function.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c | 38 ++
present/present_priv.h | 7 +++
present/present_scmd.
To initialize easily different flip modes, refactor
'present_screen_init'.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_screen.c | 46 +-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/present/present_scre
Flipping pixmaps per window needs additional arguments in the
flip mode API. Add these as preperation for window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_execute.c | 2 ++
present/present_priv.h| 10 +++---
present/present_scmd.c
Add 'queue_vblank', 'flush' and 're_execute' hooks, that
are supposed to be shared with other flip modes.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 12
present/present_scmd.c | 3 +++
2 files changed, 15 insertions(+)
diff --git a/p
Make present_pixmap a common function callable by any
flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c | 57 ++
present/present_priv.h | 68 +++---
present/present_scmd.
Introduce vblank property for flip modes, that demand explicite
allowance by the driver for vblanks to become idle.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 1 +
present/present_vblank.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/p
For window flip mode data about flips needs to be stored per window.
Add properties to 'present_window_priv' and initialize them on creation.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 11 +++
present/present_screen.c | 6 ++
2 files chang
Add hooks to query caps, get crtcs, abort vblanks and destroy
a flip.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c| 28
present/present_priv.h | 33 +
present/present_scmd.c
As a preperation for future flip mode alternatives move most of the
functionality from 'present.c' into a separate file.
Leave some functions needed by future other flip modes in 'present.c'.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am|1 +
present/meson
With the new internal flip mode API move vblank creation
and so on into a seperate file, such that it can be shared
between flip modes.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am | 3 +-
present/meson.build | 1 +
present/present_priv.h
Add some basic function hooks to our future present-internal flip mode API,
that will allow us to share functionality in between modes and move more code
in separate files.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 26 +++---
p
This is a follow up on my work as GSoC project in 2017. The patches have been
split up and some functionality has been removed in order to stabalize the
patches.
In contrast to my earlier patches
https://lists.x.org/archives/xorg-devel/2017-August/054422.html
with this patch the new window flip
decided to first go for a simple implementation by just copying
the pixmap content in order to decrease the overall complexity of the
patch set.
On Thu, Feb 1, 2018 at 4:33 PM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 2018-01-29 02:34 PM, Roman Gilg wrote:
>> In contrast to s
Do flips for child windows via subsurfaces if the Wayland server
supports them.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 57 +-
hw/xwayland/xwayland.c | 6 -
hw/xwayland/xwayland.h
The above patch series only allows flips on a child window with the same
dimensions as its parent xwl_window. For flips on child windows (for example
the video view port of a video player in windowed mode, see here:
http://www.subdiff.de/assets/images/2017-07-28-a-new-beginning.jpg) I wanted
to
/2018-January/055674.html
The above patch series only allows flips..."
and so on.
On Mon, Jan 29, 2018 at 5:54 PM, Roman Gilg <subd...@gmail.com> wrote:
> The above patch series only allows flips on a child window with the same
> dimensions as its parent xwl_window. For
Add functionality for queuing events as requested by Present.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 73 +-
1 file changed, 51 insertions(+), 22 deletions(-)
diff --git a/hw/xwayland/xwayland-present.
This is a RFC on a follow-up patch to my recently posted patch series on the
xorg-devel mailing list to enable per window flips of Present Pixmaps to
Wayland surfaces:
https://lists.freedesktop.org/archives/xorg-devel/2018-January/055674.html
With the attached patch queuing events should be
On Fri, Feb 2, 2018 at 5:11 PM, Michel Dänzer wrote:
> Taking a step back, do we even need to keep around the original pixmap
> and unflip to it at all? I had a chat on IRC about this with Keith a
> while ago, see the attached log excerpt.
>
> Keith's main concern is that the
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
include/list.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/list.h b/include/list.h
index 3f0574d..f81d97f 100644
--- a/include/list.h
+++ b/include/list.h
@@ -211,7 +211,8 @@ xorg_list_del(struct xorg_list
The helper xorg_list_is_empty returns True when the list is empty and not when
it contains one or more elements.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
include/list.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/list.h b/include/list.h
index 3
The Valgrind backtrace is very similar to the gdb backtraces in:
https://bugs.freedesktop.org/show_bug.cgi?id=106620
The patch could be a fix for this bug as well, which would be awesome.
___
xorg-devel@lists.x.org: X.Org development
Archives:
Looking at the code I think it would be better to not use an else, but put
the present_vblank_notify call before the if (vblank->abort_flip) line.
Even if the flip was aborted, the client should receive a complete event.
At least that's what we do in case of screen flips.
On Fri, Aug 24, 2018 at
On Mon, Aug 27, 2018 at 2:06 AM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> v2: Still notify aborted flips (Roman)
I also want to test it later this week when I've finished some other work,
but for now:
Reviewed-by: R
Ok, I just got a failing assert in xwl_present_flips_stop with the patch
when opening a context menu in Steam. Seems the xwl_present_flips_stop call
is coming in too late now after the presenting window has already been
changed.
>
#0 __GI_raise (sig=sig@entry=6) at
So I have it running now without problems for a few days. I tested it once
with CS:GO and Hitman and there were no crashes. I can't test the suspend
recovery because this is currently not working due to a problem in KWin.
Tested-by: Roman Gilg
___
xorg
When the compositor is not sending frame callbacks while we still wait
on buffer release events fake a continuous msc counter with a timer.
Having this timer is a prerequisite for queuing events.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.
to not
suddenly regress on Xwayland only.
The sample client, that triggers this behavior, is the Steam client.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/xwayland/xwayland-pre
Queue present events to msc values. Fake msc events with a refresh rate of
about 60fps when flips are not possible. When flips are executed rely on
frame callbacks with a slow updating timer as fallback.
This is important for applications, that want to limit their framerate.
Signed-off-by: Roman
Link the newly introduced support for Present flips. For now flips can only
be used in rootless mode together with Glamor.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/hw/xwayland/xwayla
This revision rebases the patch set on current master and does changes
requested by Michel Dänzer.
Please note that while compilation works fine for me, I can't test the runtime
any longer because the latest changes to xserver master require a newer mesa
build, and although I tried extensively I
As a preperation for future flip mode alternatives move most of the
functionality from 'present.c' into a separate file.
Leave some functions needed by future other flip modes in 'present.c'.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am|1 +
present/meson
Add some basic function hooks to our future present-internal flip mode API,
that will allow us to share functionality in between modes and move more code
in separate files.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 27 ---
p
Make present_pixmap a common function callable by any
flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c | 57 ++
present/present_priv.h | 68 +++---
present/present_scmd.
Add 'queue_vblank', 'flush' and 're_execute' hooks, that
are supposed to be shared with other flip modes.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 12
present/present_scmd.c | 3 +++
2 files changed, 15 insertions(+)
diff --git a/p
With the new internal flip mode API move vblank creation
and so on into a seperate file, such that it can be shared
between flip modes.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am | 3 +-
present/meson.build | 1 +
present/present_priv.h
To be shared by multiple flip modes, refactor execute functionality,
such that logical chunks can go in new separate file.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am | 1 +
present/meson.build | 1 +
present/present_execute.c
To reduce future code duplication refactor timings adjustment out
as a separate function.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c | 38 ++
present/present_priv.h | 7 +++
present/present_scmd.
Flip modes can now have different implementations of
present_can_window_flip.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c | 9 +
present/present_priv.h | 2 ++
present/present_scmd.c | 5 +++--
3 files changed, 14 insertions(+), 2 deletions(-)
diff
Add hooks to query caps, get crtcs, abort vblanks and destroy
a flip.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.c| 28
present/present_priv.h | 33 +
present/present_scmd.c
Flipping pixmaps per window needs additional arguments in the
flip mode API. Add these as preperation for window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_execute.c | 2 ++
present/present_priv.h| 10 +++---
present/present_scmd.c
introduces the new mode as a stub. It additionally needs a
driver hook, such that it can get initialized and appropriate cleanup
functions.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am| 3 +-
present/meson.build| 1 +
present/present.h | 6 +
p
Calculate damage before trying to flip and report it to the driver.
This allows drivers to optimize their rendering.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h | 3 ++-
present/present_wnmd.c | 24 +---
2 files changed, 15 insertions(
Allow drivers now to initialize window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h| 2 ++
present/present_screen.c | 23 ++-
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/present/present.h b/present/present.h
Make sure that vblanks and windows get cleaned up correctly
in window flip mode.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_screen.c | 33 -
present/present_vblank.c | 2 ++
2 files changed, 34 insertions(+), 1 deletion(-)
diff
To enable special functionality of window flips introduce for window flips
a separate set of driver facing function hooks.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present.h | 43 +++
present/present_priv.h | 1 +
2 files chang
Add arguments to give the caller more information and control
over the creation of a wl_buffer with GBM, in particular let
the caller determine the size of the buffer.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-glamor.c | 23 +--
hw/xw
ake use of this functionality Xwayland must run rootless and with
Glamor/GBM.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/Makefile.am| 1 +
hw/xwayland/meson.build| 1 +
hw/xwayland/xwayland-present.c | 366 +
hw
Introduce vblank property for flip modes, that demand explicite
allowance by the driver for vblanks to become idle.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 1 +
present/present_vblank.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/p
For window flip mode data about flips needs to be stored per window.
Add properties to 'present_window_priv' and initialize them on creation.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_priv.h | 10 ++
present/present_screen.c | 6 ++
2 files chang
To initialize easily different flip modes, refactor
'present_screen_init'.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_screen.c | 46 +-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/present/present_scre
On Sat, Apr 7, 2018 at 9:56 AM, Mike Lothian wrote:
> Switching to glx from egl gets things started for me
Do you mean switching from egl to glx as in switching the compositing
backend? And it did not work with egl backend but with glx?
The egl backend on X in KWin isn't
yladn from 1.20 rc4.
Sorry for the annoyances. But I'm of course very glad you found them
before release. Thanks!
> This is due to commit 82df2ce3:
>
> Author: Roman Gilg <subd...@gmail.com>
> Date: Tue Aug 22 15:38:26 2017 +0200
>
> xwayland: Avoid repeatedl
On Wed, Apr 18, 2018 at 4:02 PM, Olivier Fourdan wrote:
> diff --git a/hw/xwayland/xwayland-present.c b/hw/xwayland/xwayland-present.c
> index f403ff701..e835a1399 100644
> --- a/hw/xwayland/xwayland-present.c
> +++ b/hw/xwayland/xwayland-present.c
> @@ -73,13 +73,9 @@
Instead of getting the current msc value from the window, which might be
different to old one directly take the last saved msc value saved in
the window_priv struct.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/present_wnmd.c | 7 +--
1 file changed, 1 insertion(+), 6 del
Clean up only if the request points to the presenting window or its top
parent window.
Since in this case all events are removed unconditionally, always stop
the timer.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
hw/xwayland/xwayland-present.c | 16
1 file chan
Reviewed-by: Roman Gilg <subd...@gmail.com>
On Thu, Apr 19, 2018 at 9:13 AM, Olivier Fourdan <ofour...@redhat.com> wrote:
> Regardless of the order we un-realize windows.
>
> Suggested-by: Roman Gilg <subd...@gmail.com>
> Signed-off-by: Olivier Fourdan <ofour...
the window_priv->msc value
instead).
On Fri, Apr 20, 2018 at 6:11 PM, Michel Dänzer <mic...@daenzer.net> wrote:
> On 2018-04-20 05:10 PM, Roman Gilg wrote:
>> Instead of getting the current msc value from the window, which might be
>> different to old one directly take
On Fri, Apr 20, 2018 at 6:23 PM, Olivier Fourdan wrote:
> Unfortunately, contrary to my initial tests, the black window still occurs
> randomly even with that patch applied.
That's unfortunate. How severe is it? Is it just for a short period or
longer? I believe you said on IRC
Thank you Olivier. Sorry for that.
An alternative solution would be to only ifdef out the
xwl_glamor_pixmap_get_wl_buffer call in xwl_present_flip and otherwise
return FALSE. But we then would needlessly still build the Present
support when compiling without glamor.
Reviewed-by: Roman Gilg <s
introduces the new mode as a stub. It additionally needs a
driver hook, such that it can get initialized and appropriate cleanup
functions.
Signed-off-by: Roman Gilg <subd...@gmail.com>
---
present/Makefile.am| 3 +-
present/meson.build| 1 +
present/present.h | 6 +
p
1 - 100 of 133 matches
Mail list logo