Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsub
Review: Approve
The previous version of the soundex-key function had indeed a problem with the
string "3-D Adventure", returning a stack overflow since it as recursively
trying to produce a soundex key with just 4 characters. The new implementation
fixes this, and also seems to be correct.
I'
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/add-info-extraction-module/+merge/141245
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpa
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/add-info-extraction-module/+merge/141245
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpa
Review: Approve
The fix seems OK to me. Notice nonetheless that the regular expression
'([0-9]*[ ][A-Z]*[a-z]*)*' will not match address names containing diacritics
or hyphens (which should not occur for the specific coordinates given in the
test, but still).
--
https://code.launchpad.net/~zor
Review: Approve
--
https://code.launchpad.net/~diogo-simoes89/zorba/DC-documentation/+merge/103902
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : htt
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683
--
https://code.launchpa
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683
--
https://code.launchpa
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683
--
https://code.launchpa
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning-thesaurus into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning-thesaurus/+merge/100683
--
https://code.launchpa
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-release/+merge/94461
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/
Review: Approve
--
https://code.launchpad.net/~diogo-simoes89/zorba/DC-conversion-tests/+merge/91599
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : h
The proposal to merge lp:~diogo-simoes89/zorba/DC-conversion-tests into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/DC-conversion-tests/+merge/91599
--
https://code.launchpad.net/~di
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://laun
The proposal to merge lp:~diogo-simoes89/zorba/data-cleaning into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning/+merge/79530
--
https://code.launchpad.net/~diogo-simoes89
Review: Approve
Checked the latest revisions from Diogo and they seem ok.
--
https://code.launchpad.net/~diogo-simoes89/zorba/data-cleaning/+merge/79530
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
Review: Needs Fixing
Some minor things that should be changed before approving the merge:
* The documentation for functions like conversion:address-from-phone,
conversion:user-from-phone and conversion:address-from-user should be revised,
in order to keep just one example (i.e., the one from @e
The proposal to merge lp:~matthias-brantner/zorba/data-cleaning into
lp:zorba/data-cleaning-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~matthias-brantner/zorba/data-cleaning/+merge/79759
--
https://code.launchpad.net/~matthias
18 matches
Mail list logo
