[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User tm changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from t...@openoffice.org Thu Jan 7 15:10:39 + 2010 --- checked and verified in cws menuincustomtoolbar - OK ! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User cd changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from c...@openoffice.org Tue Nov 24 11:56:53 + 2009 --- cd: Fixed. Patch applied and successfully checked in CWS build. cd-npower: Could you please set the release to OOo 3.3. I am not able to change the release and not set is not acceptable for QA. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from c...@openoffice.org Thu Nov 19 09:15:52 + 2009 --- cd-npower: Could you please add a XML file which works with your CreateToolbarMenu.odt file. So the QA is able to check this enhancement. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Thu Nov 19 09:25:10 + 2009 --- Could you please add a XML file which works with your CreateToolbarMenu.odt sorry, not sure what you mean, what XML file? maybe you mean an example of the document with the persisted toolbar/menu items, if so QA can just ( details also in first comment of this issue ) a) click the button to create the toolbar menu on toolbar b) run the Persist macro ( one has to do that manually, sorry I didn't provide a button to do so ) c) save the document, reload or close/reopen the saved version and make sure the items exist is that what you mean? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Wed Nov 18 11:38:19 + 2009 --- -carsten As discussed ( privately on IRC ) I created a new cws ( based off m65 ), the patch has been commited, the only changes extra to the patch already attached to this issue was that I did a) remove the irrelevant changes to vcl/source/window/toolbox2.cxx b) modify offapi/com/sun/star/ui/ItemStyle.idl to add some idldocification ;-) note: the name of the cws is menuincustomtoolbar, I added you as a member, I didn't assign myself as owner ( didn't know if you wanted to take ownership yourself or have me as the owner etc.) anyway, let me know what you need me to do next. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User cd changed the following: What|Old value |New value CC|'cornouws,eberlein,helgekr|'cornouws,eberlein,helgekr |aak' |aak,pl' --- Additional comments from c...@openoffice.org Wed Nov 11 13:03:06 + 2009 --- cd-pl: Could you please have a look at the changes in VCL. You are the maintainer of VCL therefore I don't want to accept changes in your area. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from p...@openoffice.org Wed Nov 11 13:12:26 + 2009 --- pl-cd: seems ok to me. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from c...@openoffice.org Tue Nov 10 15:50:02 + 2009 --- cd-npower: Now I am back from the OOo conference and will check your changes. It's possible that I will contact you to discuss some aspects of your work. Additionally I need feedback from PL as you also made changes in VCL. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Tue Nov 10 16:00:02 + 2009 --- Now I am back from the OOo conference and will check your changes. great, pity we didn't hook up there :-( I tried but missed your talk after which I intended to intercept you ( then inevitable other distractions occurred ) It's possible that I will contact you to discuss some aspects of your work. I would hope you will keep me in the loop, IRC is the most efficient way to get my input ;-) Additionally I need feedback from PL as you also made changes in VCL. yes, they are pretty minor and really non-invasive - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User eberlein changed the following: What|Old value |New value CC|'helgekraak' |'eberlein,helgekraak' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User cornouws changed the following: What|Old value |New value CC|'eberlein,helgekraak' |'cornouws,eberlein,helgekr | |aak' --- Additional comments from corno...@openoffice.org Fri Oct 16 21:43:04 + 2009 --- :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User helgekraak changed the following: What|Old value |New value CC|''|'helgekraak' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User cd changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.3 --- Additional comments from c...@openoffice.org Tue Oct 6 13:05:25 + 2009 --- cd-npower: Thanks for your patch and work. There is a complex toolbar controller implementation which provides a menu that is accessible via drop down button. The content of the menu must be set by UNO API and there is no persistence. Please give me some days to apply your patch and check your changes. I must be sure that your changes don't break anything. Currently I am rather busy with show stoppers. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Tue Oct 6 14:04:12 + 2009 --- cd-npower: Thanks for your patch and work. There is a complex toolbar controller implementation which provides a menu that is accessible via drop down button. The content of the menu must be set by UNO API and there is no persistence. yeah, I have seen some info on this but it seems... o you need to actually provide a component for that right? o and the interface is command based for populating the dropdown o iirc ( I only skimmed the code ) it didn't look like the menu had support o didn't look like sub menus supported either ( its a listbox iirc ) on the whole it seemed not really suitable for what I wanted :-/ ( but perhaps I missed some things, wouldn't be unusual that ) Please give me some days to apply your patch and check your changes. I must be sure that your changes don't break anything. sure, I am interested in your feedback, beware there is no ui support for these enhancements ( and I doubt I will have time to look at that aspect either ) but I don't think that should block this work Currently I am rather busy with show stoppers. yes, I understand, anyway look forward to hearing your comments, thanks again - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Tue Oct 6 14:08:25 + 2009 --- o iirc ( I only skimmed the code ) it didn't look like the menu had support hmmm seems I managed to cut the last words somehow, anyway I meant no support for icons - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 Issue #|105626 Summary|framework: can't add menu to toolbar Component|framework Version|DEV300m58 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|cd Reported by|npower --- Additional comments from npo...@openoffice.org Mon Oct 5 20:24:01 + 2009 --- Hi Carsten, I am attaching here a couple of enhancements for toolbars / menu(s) that I would like to get reviewed ( opinions on, help etc. ) I hope you are interested in this So, whats it all about, o Currently it is not possible to add ( programatically ) a menu to a custom toolbar ( and if it is I have wasted alot of time :-/ ) o It is not possible to define whether a toolbar ( or menu ) item displays text, icon or texticon type styles ( e.g. for menu there is a global setting that defines this and for the toolbar there is a setting per toolbar ). o The tooltip for a toolbar item is defined by the label/command. All of the functionality described above are behaviour that I need ;-) However, not being any sort of framework expert I have cobbled together a patch of sorts that attempts addresses the issues above. I'm looking for help/support upstreaming this and I look for advice about a number of things to do with the patch particually a) I have introduced a new property to the property sequence for creating a toolbar item, this property is used to define a seperate Tooltip. However after looking at the code I noticed that the HelpURL doesn't seem to be used at all, so... could the HelpURL be recycled to define the tooltip? b) Similarly I currently reuse the ICON style property to override the global menu setting for displaying icons in a menu and use the same property again in the context of a toolbar item to do the same. Additionally I have added a new constant css::ui::ItemStyle::TEXT for a similar purpose to css::ui::ItemStyle c) to hold the menu information of the menu to be dropped by a toolbar item I use the existing menubar container ( and associated configuration ) 1 settings container per dropdown, e.g. the settings container just contains a single entry/popup ) - perhaps this is wasteful ( an alternative would be to have a settings container per custom toolbar but I did like the fact the menubar is retrievable by name, additionally from a conceptual point of view especially in the interoperability case the dropdown *is* a menubar. d) where possible I have resused the existing infrastucture, but not being all that familiar with this stuff my implementation maybe more complex than needed, would be good to get some advice about that too attached is a test document that you can play with that show the usage, additionally persistance of the items above is also implemented ( note: in the example document you need to explicitly/manually run the 'Persist' macro before tring to save a document with those settings. p.s. the patch is based of dev300m58 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 User npower changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |65146) patch file --- Additional comments from npo...@openoffice.org Mon Oct 5 20:25:01 + 2009 --- Created an attachment (id=65146) patch file - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 105626] framework: can't add menu to toolbar
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 --- Additional comments from npo...@openoffice.org Mon Oct 5 20:26:03 + 2009 --- Created an attachment (id=65147) test document and data - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
