[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User msc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Tue Jun 30 13:39:23 + 2009 --- verified in cws dba32c. When test this in the master, please remember that textfields can't be exported to excel. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Assigned to|fs|msc --- Additional comments from f...@openoffice.org Mon Jun 22 11:39:00 + 2009 --- fs-msc: please verify in CWS dba32c - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Mon Jun 22 11:41:04 + 2009 --- fs-msc: There's actually three things to check here: - the new Visible property for form controls. That's your part, anyway. - the new Visible property for Basic dialog controls. JSK said he'd be happy if you would take that. - the im/export of that property when reading/writing MS Excel files - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Target milestone|--- |OOo 3.2 --- Additional comments from f...@openoffice.org Fri May 22 10:08:08 + 2009 --- fs-npower: Committed your patch to CWS dba32c, thanks a lot for implementing this! (I took the liberty to rename the enable-visible in the file format to visible, since you were kind enough to say I'm allowed to :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Assigned to|npower|fs --- Additional comments from f...@openoffice.org Fri May 22 10:08:35 + 2009 --- grabbing (now part of my CWS) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from f...@openoffice.org Fri May 22 10:08:53 + 2009 --- fixed in CWS dba32c find more information about this CWS, like when it is available in the master builds, in EIS, the Environment Information System: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba32c - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Thu May 21 19:29:49 + 2009 --- if there is anything you need me to do or help with, please, please, just ask So you volunteer writing a test case in forms/qa/integration/forms, which creates a document, puts in some controls, makes some of them invisible, saves the doc, reloads it, checks whether the visibility flags of the controls survived? Perhaps also with some method which checks whether the XControl belonging to a given form control model is really invisible, when the model's EnableVisible is false/? :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 21 21:33:32 + 2009 --- So you volunteer writing a test case in forms/qa/integration/forms well, it wasn't quite what I had in mind ;-) I don't actually know anything about writing those qaTestTool test thingies. If I get a chance I will have a look. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 21 22:16:11 + 2009 --- Created an attachment (id=62420) another test file - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 21 22:17:17 + 2009 --- Created an attachment (id=62421) and another test doc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 21 22:18:17 + 2009 --- Created an attachment (id=62422) and yet another test document - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 21 22:19:06 + 2009 --- Some notes for testing, just some ideas that can be used with the test documents attached to this document * all-form-controls.ods This document contains all ( afaik ) form controls in openoffice, additionally there are 2 buttons, one hide ( makes all controls invisible ) and the other sow makes all the controls visible. a) test initial state when the document is loaded all controls are visible, pressing the hide btton should hide all the controls. b) test control state after a repaint force a repaint ( close the window, minimize etc. ) controls should still be invisible. c) test change of view ( ensure model preserves the visibilty state ) switch sheets ( e.g. switch to sheet 2, then back to sheet 1 ) the controls should still be invisible d) test visibility in design mode. If the controls obeyed their model regarding visibility in design mode it would be hard to find invisible controls on the document to modify them ;-) switch to design mode, all controls should become visible. e) test the property browser for form controls while still in design mode set the visibility attribute for a couple of controls to be visible ( note: those controls ), turn off design mode, the controls you set to be visible should have remained visible, the others controls should be ininvisible the above is a basic set of steps, just for illustration of what should be tested, with more imagination more combinations etc. can be tested * odf-some-invisible-persisted.ods This document tests the persisted state of some controls a) open the document, b) ensure that the only controls visible are those in the red boxes c) press the toggle button, the previously invisible controls ( in the blue boxes ) should become visible and vice-versa d) reload the document, state should be as in step b) * hiddenbutton.xls import/export of visibility attribute from MSO form documents a) open the excel document, it contains 2 push buttons, 1 is visible, the other invisible, note only CommandButton1 is visible b) enter design mode, you should see command button 2 c) in design mode change CommandButton1's visible state to true, export the document as hiddenbutton-modified.xls d) reload document, see that the 2 buttons are visible e) load the document in MSO Excel and verify it is displayed as expected Dialogs/Userforms * DialogStepVistest.ods Tests use visibilty attributes on controls with basic dialogs a) press the button, a Dialog will launch b) verify basic behaviour, each command button is assigned a different step value, the topmost button has a step value of 1, the next 2, and the last one 3. Dialogs display controls that have a step value of 0 or controls that have a step value equal to the present value of the step attribute of the dialog itself. The dialogs step value can be modified using the scroll bar, the dialogs step value is displayed in the numberic field. expected behaviour: Dialog Step 0 all 3 buttons displayed 1 top button displayed 2 middle button displayed 3 bottom button displayed c) while the dialog is executing, clicking the toggle button changes the visible state of the button associated with that step, e.g if you press the toggle button when the dialog step = 1 you will notice that the button on step 1 disappears. Setting the scroll bar to zero you will notice that only the bottom 2 buttons are visibile d) Check after reload, e.g. dismiss the dialog and press the button again to relaunch. state should be as it was in b) again e) test attribute persistence, o use the script browser to edit the dialog o when the dialog is opened, select the topmost button change its visibilty state to false o select another control, one that is present on all steps e.g. the toggle Numeric field button and change its visibility state to false. o Save the document as DialogStepVistest-modified.ods, o Close reload document, launch dialog from the button o ensure that at step 0, the bottom 2 buttons are displayed, and that at all steps the toggle Numeric.. f) design mode, Open the dialog editor, notice all invisible controls ( at the current dialog step ) are visible, changing the step should show any invisible controls on that step value, e.g. setting the dialog step to 1 and the top button should still be visible * UserformVisibility.xls test userform import a) load the document b) insert the following code ( the vba code obviously will not work ) Sub Dialog1Show DialogLibraries.LoadLibrary( Standard ) oDialog1 = CreateUnoDialog( DialogLibraries.Standard.UserForm1 ) oDialog1.Execute() End Sub c) after lauching the document the opened dialog should contain just a button. open the IDE and in design mode
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Wed May 20 07:20:32 + 2009 --- Daniel offline told me that the parts of the patch which reviewed are okay, same holds for my parts. Noel, do you want to bring this in in some own CWS, or do you want me to commit it to dba32c (targeted for 3.2)? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Wed May 20 08:25:34 + 2009 --- Noel, do you want to bring this in in some own CWS, or do you want me to commit it to dba32c (targeted for 3.2)? It should be no suprise that I would be delighted to take you up on your offer to commit this ( and really, thanks again for the excellent useful help with this ) I feel guilty handing this off ( but not *that* guilty :-) ) but, please don't feel abandoned, if there is anything you need me to do or help with, please, please, just ask. I will add here as well some MSO examples ( for the import filter testing ), probably there needs to be an odf document for both form controls and basic dialogs with the persisted visibility state, I will provide these too ( and some testing instructions for QA ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from d...@openoffice.org Wed May 20 08:50:41 + 2009 --- @Noel: While creating the test files, please note that Excel shows strange behaviour with visibility for form controls embedded into a sheet. If you hide a control (set Visible property to False) but do not turn off the design mode before saving, the Visible property is reset to True in the saved file. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |62337) latest patch file ( | | erroneous hunk removed ) --- Additional comments from npo...@openoffice.org Mon May 18 09:12:21 + 2009 --- Created an attachment (id=62337) latest patch file ( erroneous hunk removed ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value Issue type|ENHANCEMENT |PATCH --- Additional comments from npo...@openoffice.org Mon May 18 09:15:20 + 2009 --- -patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Fri May 15 12:24:29 + 2009 --- not exactly the same I observe here: After switching back to Sheet1, I need the press the Show all button for the grid/navbar to appear, all others are still hidden until a repaint. Assuming your description simply missed that step ... Interestingly, when you force the repaint by minimizing and restoring the doc window (*not* by switching to Sheet2 and back), then all other controls re-appear, too - with the difference that they're not really alive, but instead look like painted in design mode. Try clicking into an input field, or selecting all cells covered by controls, and you'll see what I mean. I think there's some design mode confusion here. One main difference between the grid/navbar and all other controls is that the former are always really-visible VCL windows, even in design mode (other controls are invisible in design mode, and just painted where necessary). Also, the effect described above also seems to suggest that all those other controls did not really become visible, but instead think they're in design mode, so the respective VCL window is not shown. Need to investigate, but I suppose the relationship between the two visibility flags in the VCLXWindow is key here. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Fri May 15 12:37:56 + 2009 --- Removing the chunk from your latest patch which starts in line 215 fixes the problem. That is, UnoControl::createPeer does not tamper with the bVisible flags of the ComponentInfo anymore. As a consequence, xView-setVisible is called when the pure bVisible flag requests this. There should not be a problem here, as the ::setVisible implementation itself cares for the EnableVisible setting. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Fri May 15 13:20:07 + 2009 --- Removing the chunk from your latest patch which starts in line 215 fixes the problem. I think I might have been a long long time trying to find this, especially since it is a part of the orig patch that I don't recall looking at, mucho mucho thanks!!! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Thu May 14 08:10:25 + 2009 --- Noel, this is great! The patch is *nearly* perfect :), only a couple of minor issues/questions: - VCLXWindow::getProperty( EnableVisible ): shouldn't this return isEnableVisible()? - both the sdtandard and the copy ctor of OGridControlModel miss an initialization of m_bEnableVisible. Same for ONavigationBarModel's copy ctor. - Not sure if in the file format, I would prefer calling the attribute visible instead of enablevisible (which for consistency reasons would need to be enable-visible, btw.) I know you don't like EnableVisible at all :) I still think that API-wise, it does make sense, at the very least for the scenario where somebody uses the property together with the XWindow::setVisible method, here EnableVisible is way much clearer than Visible would be. But for the file format, there is no such argument. - I suppose it is intended that invisible controls are still printed? So conceptually, EnableVisible is a show on screen, where Print is a show on printer, and both are orthogonal. Makes sense, /me thinks. - persistency for the dialog case is missing, as you said yourself already. - The UI in the property browser is missing (I'll attach an updated version of the patch for this) - I didn't look at the SVX code, this is in Daniel's competency - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |62258) patch enabling the | |Visible property in the | |property browser --- Additional comments from f...@openoffice.org Thu May 14 08:13:35 + 2009 --- Created an attachment (id=62258) patch enabling the Visible property in the property browser - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from d...@openoffice.org Thu May 14 08:43:19 + 2009 --- - in msocximex.cxx, export of the visibility flag is missing, intended? - in sc/source/filter/excel/xiescher.cxx, enable line 1705 (DEV300m46) and remove the waiting comment - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 14 09:06:24 + 2009 --- Frank, persistency for the dialog case is missing, as you said yourself already. yes, but I included the dialog xml changes in userform-filter-dialog-vba-m46.diff, sorry if I didn't make that clear enough in the comments. I didn't look into the rest of the comments in more detail yet ( there are a few and I am slow ) but you do mention changing the xml attribute name so I guess it's counterpart in the dialog xml changes in the patch above should change in a consistent way. Daniel, in msocximex.cxx, export of the visibility flag is missing, intended? in msocximex for sure it is intended because Visibility here only relates to userform controls and we don't export userforms. But.. your question prompts me to think about form control export for which visibility is iirc a property in the MsofbtOPT record, do you recall if the export part was done for this when you applied ( commented out ) the Visibility support? - in sc/source/filter/excel/xiescher.cxx, enable line 1705 (DEV300m46) ah ok, good catch, I had completely forgotten about those changes you sucked in ( /me was only testing odf ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from d...@openoffice.org Thu May 14 09:23:42 + 2009 --- Yes, export of that flag to DFF is still missing, please have a look at sc/source/filter/excel/xeescher.cxx, line 394 ff. The fHidden flag is part of the second shape flags field (0x03BF, 959). You can add something like bool bVisible = aCtrlProp.GetBoolProperty( CREATE_OUSTRING( EnableVisible ) ); aPropOpt.AddOpt( ESCHER_Prop_fPrint, bVisible ? 0x0008 : 0x00080002 ); Yes, fPrint, the property ID needs to be the one of the LSB, which is the (unused) printable flag with ID 0x03BF (959). The next bit has the ID 0x03BE (958) and is the hidden flag. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 14 09:36:02 + 2009 --- Frank, VCLXWindow::getProperty( EnableVisible ): shouldn't this return isEnableVisible()? yep, that would seem to make sense ( how did I do that ) perhaps I hope that was in the orig patch ( /me has a new years resolution to become less careless ) both the sdtandard and the copy ctor of OGridControlModel missed... right, completely missed those, thanks Not sure if in the file format... Your call here Frank, my preference[*] would be for enable-visible to be consistent with what has gone before and with the api property name. [*] my preferences are very fickle, likely to change at any moment, because of that naming is something I always hate, I think I mentioned this before :- I know you don't like EnableVisible at all :) I still think that API-wise... as someone so elegantly said in a mailing list recently Your petty interests in language aesthetics are irrelevant! - only joking of course, anyway as I said this is no real issue for me, just a personal preference I suppose it is intended that invisible controls are still printed? So... I didn't even realise this property existed so right now I don't know, I will have a think about it too - The UI in the property browser is missing (I'll attach an updated version of the patch for this) excellent, I saw you had a patch earlier in this bug but I forgot about that, I presume this works for the dialogs too. - I didn't look at the SVX code, this is in Daniel's competency Daniel is competent ?? :-P I will have a look at all the above and the other related bits and regenerate the patch, shall I put *everthing* in the one patch, this would be easier for me? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 14 09:40:32 + 2009 --- daniel: thanks for the pointer to ESCHER_Prop_fPrint maybe you are competent after all :-P - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from d...@openoffice.org Thu May 14 09:43:50 + 2009 --- oh really, do you think so? :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Thu May 14 09:48:20 + 2009 --- I suppose it is intended that invisible controls are still printed? So... I didn't even realise this property existed so right now I don't know, I will have a think about it too Well, the current behavior of the patch is consistent with what I see in Excel, for OLE controls (which also have separate and independent Print and Visible properties). Didn't test with the other controls (more precise: didn't find a Visible there, which might mean it doesn't exist, or the clumsy UI doesn't let me find it). So, I'd be fine with the current behavior. - The UI in the property browser is missing (I'll attach an updated version of the patch for this) excellent, I saw you had a patch earlier in this bug but I forgot about that, I presume this works for the dialogs too. Yes. I will have a look at all the above and the other related bits and regenerate the patch, shall I put *everthing* in the one patch, this would be easier for me? I'd prefer a single patch, too. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from f...@openoffice.org Thu May 14 09:54:08 + 2009 --- The xmlscript patch (thanks for pointing me to the right diff file :) looks good to me (disclaimer: that's not my module, so I easily might miss things here). One picky item in xmldlg_im/export.cxx: If you follow the (commendable!) habit of caring for exceptions, then it's worth putting a DBG_UNHANDLED_EXCEPTION() (from tools/diagnose_ex.h) into the catch branch, so at least non-product versions will report that something went wrong, instead of /completely/ silencing the exception. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |62272) latest patch ( the | |whole lot ) post comments --- Additional comments from npo...@openoffice.org Thu May 14 18:37:04 + 2009 --- Created an attachment (id=62272) latest patch ( the whole lot ) post comments - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Thu May 14 18:44:04 + 2009 --- frank, I went with enable-visible in both the xmloff and xmldlg bits for the attribute name, feel free to change :-) also, I found an interesting repaint bug, o open all-form-controls.ods o press the Hide all button o change to sheet2 o change back to sheet1 notice only the TableControl NavigationBar bar controls are displayed, switching sheets again will trigger a repaint, any ideas? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |62205) patch file --- Additional comments from npo...@openoffice.org Tue May 12 15:21:23 + 2009 --- Created an attachment (id=62205) patch file - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 12 15:26:46 + 2009 --- I revisited the issue of controls whose enablevisible model setting is false,. The attached patch visibility-in-designmode.diff seems to do the required ( or at least what I expect ) regarding the controls becoming visible in design mode. At least it works for me with dialogs and form controls. e.g. using all-form-controls.ods ( also attached ) hide all of the controls ( by pressing the button, which programatically changes the enablevisible attribute on the models ), go into design mode see the controls reappear ready for resizing, assigning macros to events etc. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |62095) userform filter, di | |alog xml and vba api chang | |es --- Additional comments from npo...@openoffice.org Fri May 8 11:01:27 + 2009 --- Created an attachment (id=62095) userform filter, dialog xml and vba api changes - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 13:35:36 + 2009 --- Hi Frank, eventually I have got around to looking at this ( sorry, I know it is a long time ) but lets push on this again Here is what I have done regarding you previous review comments of the patch, I descrbe them in order 1) - PROPERTY_VISIBLE should be renamed to PROPERTY_ENABLE_VISIBLE Action: Done btw. I don't agree that VISIBLE needs to change to ENABLE_VISIBLE which I find confusing, I am quite happy to accept that the model's 'VISIBLE' state is the desired ( and persisted ) state. I am equally happy to accept that this state is not honoured in all cases ( the obvious one design mode where I would expect the control to be visible regardless of the state of enable visible ) but this is just my opinion and it is not imo a real important issue 2) + toolkit/source/helper/property.cxx Action: done 3) - mbDirectVisible should be a member of VCLXWindowImpl Action: done 4) + when a VCLXWindow is created, a subsequent call to VCLXWindow::SetWindow... Action: done 5) + VCLXWindow::setVisible: I suppose mbDirectVisible needs to be set in every case. Action: Done 6) + VCLXWindow::setProperty: I am not sure the current behavior of setting the visibility is correct. Action: done 7) + VCLXWindow::ImplGetPropertyIds: I suppose the addition of BASEPROPERTY_VISIBLE to rIds belongs into the if( bWithDefaults ) branch. I am not completely sure about this, since I do not know those relatively new ImplGetPropertyIds methods too well. Action: not done, for some dialog controls at least it seemed ( with a test ) you need to specify the propery ids ( they don't get picked up with the bWithDefaults ). I'm afraid I was a little lazy and just err'ed on the side of caution and added BASEPROPERTY_ENABLEVISIBLE everywhere BASEPROPERTY_ENABLE is used 8) + VCLXWindow::draw the isEnableVisible should be used more generous... Action: done Additionally you will notice some tweaking to enable EnableVisible in the forms module for some controls that seem not to use the awt base classes ( see to be attached test document too ) Regarding the issue of when the model says false and we are in design mode that you mentioned, I think it would be enough to just ignore ( e.g. consider 'enablevisible' to be true ) and just show the control. Indicating somehow it will be invisible when alive seems like overkill. But.. I do think it is necessary to show the control when in design mode ;-) otherwise clicking in various parts of the document to try and find the now invisible control is not much fun ;-) ( which is what happens currently, but perhaps this is to do with the milestones I am using? ). In anycase I did try modify the Show methods in vclxwindow.cxx to take this into account and it *mostly* worked but it seemed when resizing the control (in design mode of course ) the green boxes that mark the edges of control and the drawing/graphic representation of the control don't move or resize when dragging with the mouse, of course when you release the mouse it is resized etc. :-( Some little advise here on what to do would be good for someone as vcl/drawing ignorant as I With basic dialogs there are still some open items. As you mentioned there is the issue of the step, I need to look at the code for that, but... it seems that a test something like ( ( controlStep == 0 || controlStep == dialogStep ) bEnableVisible ) controlling the visibility probably is close to what we need in alive mode and in design mode I think like mentioned earlier it would be enough for the 'enablevisible' to be ignored ( e.g. considered to be always true ). Finally there is no provision for either persistence of the EnableVisible state for Dialogs or the appropriate hooks for the MS Userform import filter to set 'EnableVisible'. I have a patch for the persistence ( dialog xml ) and import filter that I will attach later ( do you think a seperate bug is needed ? ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 13:37:14 + 2009 --- Created an attachment (id=62005) latest patch file ( agains dev300-m46 ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 13:38:22 + 2009 --- Created an attachment (id=62006) test document - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 13:39:58 + 2009 --- test document has all ( afaics ) form controls, the two buttons, show/hide are self explanatory ;-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 16:02:25 + 2009 --- In anycase I did try modify the Show methods in vclxwindow.cxx sigh I did this a couple of days ago and forget the details, what I meant to say was I modified the draw() method and changed the test if ( mpImpl-isEnableVisible() ) to if ( mpImpl-mbDesignMode || mpImpl-isEnableVisible() ) Additionally I had set mpImpl-mbDesignMode from some temporary code I introduced into unocontrol.cxx ( UnoControl::setDesignMode(...) ) for Dialogs ( wrt Step ) here ( about to be attached ) is a small little test document to show the current behaviour in alive mode, imo the current behavior regarding 'EnableVisible' and 'Step' is fine and works how I would expect. However once the visible attribute can be changed from the property sheet in design mode then like the form control case above things are not so nice, we really do need to show the control in design mode - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from npo...@openoffice.org Tue May 5 16:03:48 + 2009 --- Created an attachment (id=62012) test document for step Dialogs - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Thu Sep 4 06:30:31 + 2008 --- noel: please leave out the MS Excel filter part, as I have written above, code will change significantly in CWS dr63. There, I have added import of the visibility attribute for all controls embedded in sheets (drawing controls and ActiveX controls) and support for the EnableVisible property. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User npower changed the following: What|Old value |New value CC|'cd,dr,mt'|'cd,dr,mt,npower' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed Sep 3 15:56:35 + 2008 --- -all so, jianhuajiao no longer works on this issue ( or I suspect openoffice ) I will as soon as I can try and takeover his bugs ( or assign them on ) it's a pity this one seems to have fallen to the wayside. Please let me know what I can do ( or if anything needs to be done ) to progress this. Note: I haven't read all of the comments here yet, but I appreciate any help getting this going again - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed Sep 3 15:59:03 + 2008 --- frank, is there review comments somewhere that need addressing in the patch? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value CC|'cd,dr,mt,npower' |'cd,dr,fs,mt,npower' Assigned to|fs|npower --- Additional comments from [EMAIL PROTECTED] Wed Sep 3 19:34:19 + 2008 --- Noel, I'm glad to see you taking this feature. Do you mind if I assign it to you? :) IIRC (I also didn't (re-)read all of the above :), the only major open issue was the semantics of the EnableVisible property. We initially agreed that it in fact is really an enable the control to become visible, where the actual visibility depends on calls to the XWindow's setVisible. This is because there's a lot of scenarios (described above somewhere) where a component decides to set a control window to in/visible, *without* tampering with the model (which would affect *all* control windows belonging to the model). However, the latest version of the patch does not follow this semantics, instead EnableVisible is effectively treated like Visible at the VCLXWindow. IMO, this is wrong, and will lead to problems. Note that when you work on this patch, you should use a milestone prior to DEV300m30. In m30, CWS aw033 was integrated, which broke large parts of the form control functionality. In particular, the visibility of form control windows is not correct anymore. (Search for open issues submitted by fs and owned by aw to get an idea. It will also find you some issues which describe interesting scenarios to test together with this new visibility property, such as hiding a section in which a control is anchored.) Thinking about it something we never talked about is how to represent invisible controls (i.e. control windows whose model has the EnableVisible property set to false) in design mode. It might be desirable to somehow indicate they're to be invisible in alive mode - perhaps by shadowing them in some way. I suppose that the Drawing Layer's overlays nowadays should easily support this. However, such a feature probably belongs into the nice-to-have, not into the must-have category. (Though I'm not completely sure, I would need to play with the final feature to get a final opinion.) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed Aug 13 06:44:00 + 2008 --- fs-jianhuajiao: Do you still work on the patch? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed Aug 13 08:16:35 + 2008 --- Please note that in CWS dr63 (targeted for OOo 3.1) I have made lots of changes in the area of Excel drawing and form controls import (file sc/sc/source/filter/excel/xiescher.cxx). I have already added the import of the visibility flag, and have added a line that sets the bool property EnableVisible but is commented out. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Sat Jun 14 12:48:14 + 2008 --- I don't think mbDirectVisible could be set when isEnableVisible is False. Because the window is invisible at this time. Invisible form should not be set invisible or visible. Hmm - why? With your current code, consider the following scenario: - EnableVisible is set to FALSE - some instance calls setVisible( sal_False ), which means make this control invisible, no matter what - now some other instance sets EnableVisible to TRUE = suddenly, the control will appear. This would most certainly be wrong, since the previous setVisible( sal_False ) was meant unconditionally: just hide it. Also, regarding your Invisible form should not be set invisible or visible.: The control is *not* invisible in this scenario - it's just that it's disabled to become visible, this is what EnableVisible = FALSE means. So, my understanding would be - EnableVisible controls whether a control *can* be visible - mbDirectVisible, set by setVisible, controls whether the control is actually visible, in case EnableVisible would be TRUE at this time. If we test the mbDirectVisible when isEnableVisible is set to True, its behavior will be some against with the behavior set mbEnableVisible to False. mbEnableVisible - False, form will be invisible, without think about mbDirectVisible mbEnableVisible - True, form's behavior should similar with above, ignore mbDirectVisible, set mbDirectVisible to True and show the form. Again, why? This would mean that EnableVisibile is not really used in the sense of Enable, but in the sense of do it: Whenever somebody changes EnableVisible to TRUE, then it *will* become visible, and when somebody changes it to FALSE, it will become invisible. This would actually mean we could have named it Visible, because that's what it would be then. And we already said that a pure Visible property does not work in all scenarios - for instance in the scenario I described in the review. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Tue Jun 3 04:00:01 + 2008 --- jianhuajiao-dr: yes. it should be that. jianhuajiao-fs: 1. + VCLXWindow::setVisible: I don't think mbDirectVisible could be set when isEnableVisible is False. Because the window is invisible at this time. Invisible form should not be set invisible or visible. 2. VCLXWindow::setProperty: If we test the mbDirectVisible when isEnableVisible is set to True, its behavior will be some against with the behavior set mbEnableVisible to False. mbEnableVisible - False, form will be invisible, without think about mbDirectVisible mbEnableVisible - True, form's behavior should similar with above, ignore mbDirectVisible, set mbDirectVisible to True and show the form. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Thu May 22 12:22:05 + 2008 --- dr-jianhuajiao: you are mixing a DFF flag (DFF_Prop_fPrint) with an Excel-specific flag from the OBJ record (EXC_OBJ_CMO_VISIBLE) which does not even exist. Please remove the OBJ record part and use the DFF flag directly: in sc/source/filter/inc/xlescher.hxx: - remove the EXC_OBJ_CMO_VISIBLE definition in sc/source/filter/inc/xiescher.hxx: - change the sal_uInt32 mnObjVisible member into bool mbObjVisible - change the Set*() and Is*() functions accordingly - add comments for the functions, similar to all other functions in sc/source/filter/excel/xiescher.cxx: - change the line xDrawObj-SetVisible( GetPropertyValue( DFF_Prop_fPrint ) ); into xDrawObj-SetVisible( !GetPropertyBool( DFF_Prop_fHidden ) ); The value of DFF_Prop_fHidden is 958 (see svx/inc/svx/msdffdef.hxx), which corresponds the the second bit of the physically existing 32-bit property 959. The GetPropertyBool() function resolves this internally, so it is a convenient way to access single bits in DFF property sets. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53825) experimental user | | interface for the EnableV | |isible property --- Additional comments from [EMAIL PROTECTED] Wed May 21 20:33:12 + 2008 --- Created an attachment (id=53825) experimental user interface for the EnableVisible property - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed May 21 20:38:31 + 2008 --- The attachment, when applied in module extensions, adds an entry Visible to the property browser of form controls, which allows to easily play with the new property. Just in case you're interested in ... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed May 21 20:39:04 + 2008 --- Created an attachment (id=53826) review of form-control-visibility-v4.diff - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed May 21 20:42:22 + 2008 --- fs-jianhuajiao: Attached is my review of your latest patch. You are *really* close, but not completely there. Note that items in the review which are denoted by a + should be addressed before integration of the patch (or you should argue why you think I am wrong on this, which might be a valid outcome). Items denoted by a - are on the nice-to-have list. Provided the +-items are addressed, I would be willing to integrate this patch, it already looks very good. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value CC|'cd,mt' |'cd,dr,mt' --- Additional comments from [EMAIL PROTECTED] Wed May 21 20:44:52 + 2008 --- fs-jianhuajiao: Please note that I cannot review the sc-part of the patch - I don't have any stakes in the sc module. fs-dr: Do I assume right that you're the right one to ask for the sc-part of the attached form-control-visibility-v4.diff? If so, please review, and give jianhuajiao feedback for it. If not, please advise who would be able to review this part. Thanks. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53790) Change Visible to | | EnableVisible and make | |design mode invisible if t | |he EnableVisible is fals | |e. and update invisible/vi | |silbe change logic. --- Additional comments from [EMAIL PROTECTED] Tue May 20 10:22:54 + 2008 --- Created an attachment (id=53790) Change Visible to EnableVisible and make design mode invisible if the EnableVisible is false. and update invisible/visilbe change logic. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Tue May 20 10:20:24 + 2008 --- jianhuajiao-fs: yes, I agree. and I have updated the patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User pl changed the following: What|Old value |New value Issue type|PATCH |ENHANCEMENT --- Additional comments from [EMAIL PROTECTED] Fri May 16 09:44:12 + 2008 --- since the patch will not be applied as is I'll change the type to enhancement - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53463) guard for visibilit | |y --- Additional comments from [EMAIL PROTECTED] Thu May 8 06:09:06 + 2008 --- Created an attachment (id=53463) guard for visibility - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Thu May 8 06:16:42 + 2008 --- jianhuajiao-fs yes, You are right, the patch separate the property and windows peer. and I have update the patch to guard the visibility state like Enabled. but I am not sure this guard we need. because in some scenario, we just want the windowpeer invisilbe, but not change the model. if the guard exist. we could make the window peer invisible. maybe it will some dialog could not work correctly. and this patch just enabled the feature in sc module. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53464) v3 form dev300-m10 --- Additional comments from [EMAIL PROTECTED] Thu May 8 06:24:19 + 2008 --- Created an attachment (id=53464) v3 form dev300-m10 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Thu May 8 11:09:00 + 2008 --- jianhuajiao, after applying your patch, form controls are *always* visible in design mode. This implies several problems, amongst others, it implies that the user cannot open a context menu on a form control in design mode. This is because your current patch always keeps the control's visibility in sync with the model property. As outline above, this should not be the case - even if the model's Visible is true, then there are situations where the control *must* be invisible, due to side conditions. This side conditions include the following (and maybe more): - the control is in design mode - the control is in a hidden section in the text document - the control is on a layer which is not visible So, I suggest you (1) completely remove the WindowStateGuard changes in forms, which currently ensure that a form control's visibility is always in sync with the model property (2) rename the Visible property to EnableVisible, to indicate that it does *not* control the visibility, but only the *allowance* to be visible (3) introduce code in toolkit which ensures that the control's visibility is switched *only* if the EnableVisible property changes from TRUE to FALSE, but *not* if it changes from FALSE to TRUE. However, I think even the last point might not be enough. Consider the following scenario: - a control is currently visible, and its model's EnableVisible property is set to TRUE - the model property is set the FALSE = the control becomes invisible - the model property is set to TRUE = the control stays invisible This result is certainly not desired. So, in real, a control would need to *distinguish* between two cases: - it became invisible because of a model property change - it became invisible because some other instance called setVisible( false ) Consequently, we need a place where we distinguish between those two cases. One possible solution would be that an VCLXWindow tracks the EnableVisible property itself. That is, the model property EnableVisible is reflected in a boolean member of VCLXWindowImpl, say mbEnableVisible. Those two are always in sync. Also, another member is introduced, let's call it mbDirectVisible. This member is modified in VCLXWindow::setVisible. Then, whenever mbEnableVisible or mbDirectVisible change, the VCL window is set to visible if and only if *both* members are TRUE. (Note: With an approach like this, (3) from above does not need to be done anymore.) This should address all scenarios, in that one could modify either the model's EnableVisible property, or directly call XWindow::setVisible, and always get the result, no matter in which order you do this. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User pl changed the following: What|Old value |New value Summary|import/export form control|import/export form control | visibility | visibility --- Additional comments from [EMAIL PROTECTED] Wed May 7 09:51:17 + 2008 --- pl-fs: so will you integrate this patch or not ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User fs changed the following: What|Old value |New value CC|''|'cd,mt' Ever confirmed| |1 Status|UNCONFIRMED |NEW --- Additional comments from [EMAIL PROTECTED] Wed May 7 11:08:59 + 2008 --- fs-pl,jianhuajiao: The patch looks good, however, I have some headache with some scenarios I need to try out - and I simply didn't find the time to do so, yet. fs-jianhuajiao: While the patch properly touches all needed places, the problem is that there are *other* places which also change a control's visibility. For instance, if you put a control into a section (in Writer) which you hide, then the control is hidden, too. I am pretty sure that with your patch, when you then un-hide the section, the control is made visible - even if its visibility property is FALSE. Similar, in UNO dialogs (which your patch also affects), control visibility is implicitly switched when the dialog's Step property changes. So, in short: control today visibility is controlled by some side conditions, and my gut feeling tells me your patch interferes with those. However, I need to apply the patch and try some things ... I copy MT and CD on this issue - they suggested a mechanism where the visible property is only propagated from the model to the control when it changes from TRUE to FALSE, but not when it changes from FALSE to TRUE. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 --- Additional comments from [EMAIL PROTECTED] Wed May 7 12:27:32 + 2008 --- Please remember that we also suggested to not name the property Visible, but EnableVisibility or something like this. So it doesn't mean the controls are all visible or not, it just means they can be visible or not. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53462) for setPropertyValu | |e --- Additional comments from [EMAIL PROTECTED] Thu May 8 03:52:15 + 2008 --- Created an attachment (id=53462) for setPropertyValue - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |53283) patch --- Additional comments from [EMAIL PROTECTED] Wed Apr 30 09:37:51 + 2008 --- Created an attachment (id=53283) patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 88878] import/export form control visibility
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878 Issue #|88878 Summary|import/export form control visibility Component|gsl Version|DEV300m10 Platform|All URL| OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|fs Reported by|jianhuajiao --- Additional comments from [EMAIL PROTECTED] Wed Apr 30 09:36:44 + 2008 --- In MSO, form control can be set to invisible and persisted in document. but OOo could import invisible property of form control always as visible. For compatibility oMSO, 1. I think we should import this property without export it. 2. export/import in odf format. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
