[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User es changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Wed Jan 9 13:34:25 + 2008 --- Verified in CWS aquavcl04 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User pl changed the following: What|Old value |New value Assigned to|macport |es --- Additional comments from [EMAIL PROTECTED] Tue Dec 11 10:05:23 + 2007 --- please verify in CWS aquavcl04 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 --- Additional comments from [EMAIL PROTECTED] Fri Nov 23 14:42:58 + 2007 --- I made one last exception for ctrl-alt-shift-d; this does not come to insertText or doCommandBySelector via the input manager (and is quite helpful in debugging). However for the moment this is the only exception. If you have an idea where that vanishes to, we could remove the exception again. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User pl changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Thu Nov 8 14:16:51 + 2007 --- For the moment we will pass all keyDown events to the input manager first. Ctrl-Q is something we don't need since on Mac it is Command-Q anyway. Similar is true for copy/paste. We will need to think harder again if we find a shortcut that is not available by its Command eqeuivalent anymore. In the long term I'd like (cross platform BTW, gtk and X suffer from problems in the same area) the shortcuts to be registered in the native code so we can explicitly know which key is an accelerator used by OOo and which not, so at least we could decide which key event would be ours. Which is no solution to clash problem either, of course ;-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 --- Additional comments from [EMAIL PROTECTED] Fri Nov 9 00:31:03 + 2007 --- Thanks for a nice decision :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=82684
--- Additional comments from [EMAIL PROTECTED] Mon Nov 5 10:28:11 +
2007 ---
The whole idea of calling checkSpecialCharacters in keyDown was that some keys
should not be swallowed by the input manager. If we pass key events to the input
manage first, then we should scrap checkSpecialCharacters wholesale. At the
moment with your patch if you press Ctrl-shift-j you get into full screen mode
and back again, because the event is dispatched twice - unless you happen to
have the input method which swallows that key event.
Since it simplifies the code, I'd vote to remove the block
bool bHandleCommandKey = mpFrame-mpMenu ? false : true;
if( (mpFrame-mnLastModifierFlags NSControlKeyMask) ||
( (mpFrame-mnLastModifierFlags NSCommandKeyMask)
bHandleCommandKey )
)
{
// note: checkSpecialCharacters sets mbInKeyInput to false as a side
effect
// if the event is consumed
if ( [self checkSpecialCharacters:pEvent] )
return;
}
Any conflicts that occur between input manager and our shortcuts will have to be
solved somehow by OOo using other shortcus.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 --- Additional comments from [EMAIL PROTECTED] Mon Nov 5 11:15:09 + 2007 --- At the moment with your patch if you press Ctrl-shift-j you get into full screen mode and back again, because the event is dispatched twice - unless you happen to have the input method which swallows that key event. Hmm, actually I didn't consider that case. Thanks for the explanation. Since it simplifies the code, I'd vote to remove the block I also think it's good idea. But this may cause some key combinations like Control-q disabled because doCommandBySelector will be not called in such key combination. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 --- Additional comments from [EMAIL PROTECTED] Mon Nov 5 12:00:27 + 2007 --- I see. Actually doCommandBySelector only works if there is another clash with a system key binding, right ? In which case the OOo binding would be preferred. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User pl changed the following: What|Old value |New value Target milestone|--- |OOo 2.4 --- Additional comments from [EMAIL PROTECTED] Mon Nov 5 12:01:39 + 2007 --- Anyway we should find a solution and fix this in aquavcl04 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 --- Additional comments from [EMAIL PROTECTED] Mon Nov 5 12:27:31 + 2007 --- Actually doCommandBySelector only works if there is another clash with a system key binding, right ? Yes, here is an Apple's doc (http://developer.apple.com/documentation/Cocoa/Conceptual/InputManager/Concepts/KeyBindings.html). From this document, it doesn't seem that there is a way to configure the key-binding from application side. In which case the OOo binding would be preferred. Sure. I couldn't understand way Apple set the return value of interpretKeyEvents _void_. Anyway we should find a solution about this, however, other applications like Safari, Camino, iTerm seems to also suffer from this problem. For example, With AquaSKK, Control-j causes both mode change in Input Method and application event simultaneously... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User ekato changed the following: What|Old value |New value CC|''|'ekato,pl' --- Additional comments from [EMAIL PROTECTED] Sun Nov 4 07:55:26 + 2007 --- I think every key combination for input method should be handled at the first priority. For example, AquaSKK (http://aquaskk.sourceforge.jp/) input method uses Control-j to switch input mode, however, current OpenOffice.org Mac will change justification of text alignment instead of input mode change in AquaSKK. Following change for salframeview.mm will do that, but as it seems there is no way to check the key combination for input method is consumed in NSTextInputMethod, the key combination like C-j with AquaSKK will be handled twice (input mode change and then text alignment of OOO). @pl:, what do you think? ndex: salframeview.mm === RCS file: /cvs/gsl/vcl/aqua/source/window/Attic/salframeview.mm,v retrieving revision 1.1.2.11 diff -u -r1.1.2.11 salframeview.mm --- salframeview.mm 1 Nov 2007 13:48:47 - 1.1.2.11 +++ salframeview.mm 4 Nov 2007 07:38:19 - @@ -461,6 +461,9 @@ mpFrame-mnLastEventTime = static_castULONG( [pEvent timestamp] * 1000.0 ); mpFrame-mnLastModifierFlags = [pEvent modifierFlags]; +NSArray* pArray = [NSArray arrayWithObject: pEvent]; +[self interpretKeyEvents: pArray]; + bool bHandleCommandKey = mpFrame-mpMenu ? false : true; if( (mpFrame-mnLastModifierFlags NSControlKeyMask) || ( (mpFrame-mnLastModifierFlags NSCommandKeyMask) bHandleCommandKey ) @@ -472,9 +475,6 @@ return; } -NSArray* pArray = [NSArray arrayWithObject: pEvent]; -[self interpretKeyEvents: pArray]; - mbInKeyInput = false; } } - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 User smsm1 changed the following: What|Old value |New value Ever confirmed| |1 Status|UNCONFIRMED |NEW Keywords| |aqua --- Additional comments from [EMAIL PROTECTED] Wed Oct 17 06:43:33 + 2007 --- Another reason to only support apple+shortcut key and not have both apple+ and control+ - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[porting-issues] [Issue 82684] AQUA PORT : writer : ^+SHI FT+J conflicts with kotoeri
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=82684 Issue #|82684 Summary|AQUA PORT : writer : ^+SHIFT+J conflicts with kotoeri Component|porting Version|680m233 Platform|Macintosh URL| OS/Version|Mac OS X Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|MacOSX Assigned to|macport Reported by|nazcafan --- Additional comments from [EMAIL PROTECTED] Wed Oct 17 00:03:48 + 2007 --- Hello, on writer, aqua port (680mm233, french version), pressing ctrl+Shift+J starts/stops fullscreen (as well as apple+shift+J). However, ctrl+shift+J is already used by the kotoeri input method in order to switch to hiragana input. Have a good day - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
