[script-issues] [Issue 96087] basic: ambiguous || seq uence

2009-04-08 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User dtardon changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from dtar...@openoffice.org Wed Apr  8 13:53:54 
+ 2009 ---
seen in DEV300_m45 and OOO310_m9

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@script.openoffice.org
For additional commands, e-mail: issues-h...@script.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2009-01-22 Thread tkr
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User tkr changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from t...@openoffice.org Thu Jan 22 10:49:31 + 
2009 ---
Verified in source code

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@script.openoffice.org
For additional commands, e-mail: issues-h...@script.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2009-01-21 Thread ab
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User ab changed the following:

What|Old value |New value

 Assigned to|ab|tkr





--- Additional comments from a...@openoffice.org Wed Jan 21 12:36:03 + 
2009 ---
ab-tkr: Please verify in source code


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@script.openoffice.org
For additional commands, e-mail: issues-h...@script.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2009-01-13 Thread ab
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User ab changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from a...@openoffice.org Tue Jan 13 13:49:47 + 
2009 ---
I had a closer look and interestingly this seems to make no difference,
at least for two of the cases.

The results of (X  Y) || Z and X  (Y || Z) only differ if
X==false/Y==true/Z==true or X==false/Y==false/Z==true

In the cases while( *p... and while( *pLine... this is not possible.
If *p / *pLine is false, the char is 0, so it cannot be anything else.

This is not so obvious for the while( refVar.Is() case, but the cri-
tical cases require z==true - *p=='!'. I've never seen this, so
this probably is an exotic case.

At least this explains why this hasn't caused any problems so far.
Applied patch, FIXED


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@script.openoffice.org
For additional commands, e-mail: issues-h...@script.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2009-01-09 Thread ab
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087





--- Additional comments from a...@openoffice.org Fri Jan  9 08:11:10 + 
2009 ---
This somehow confuses me. I wonder why this bug does not affect the 
functionality.
I will try to understand this, otherwise I'll move it to 3.2 to be on the save
side in
the sense of never touch a running system.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@script.openoffice.org
For additional commands, e-mail: issues-h...@script.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-13 Thread ab
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User ab changed the following:

What|Old value |New value

Target milestone|---   |OOo 3.1





--- Additional comments from [EMAIL PROTECTED] Thu Nov 13 10:22:54 + 
2008 ---
- OOo 3.1


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-12 Thread ab
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User ab changed the following:

What|Old value |New value

  Status|NEW   |STARTED





--- Additional comments from [EMAIL PROTECTED] Wed Nov 12 09:12:47 + 
2008 ---
STARTED


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |57868)
dodgy code






--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 10:38:29 + 
2008 ---
Created an attachment (id=57868)
dodgy code


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |96084
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-11 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087
 Issue #|96087
 Summary|basic: ambiguous  || sequence
   Component|scripting
 Version|DEV300m35
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|kr
 Reported by|cmc





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 10:35:30 + 
2008 ---
X  Y || Z
binds operator precedence-wise as
(X  Y) || Z
not
X  (Y || Z)

so I am a little suspicious about...

in basic/source/sbx/sbxexec.cxx
while( *p  rCharClass.isAlphaNumeric( *p ) || *p == '_' )
which really means...
while( (*p  rCharClass.isAlphaNumeric( *p )) || *p == '_' )
while
while( *p  (rCharClass.isAlphaNumeric( *p ) || *p == '_' ))
seems the more likely desired meaning ?

similarly 
while( refVar.Is()  *p == '.' || *p == '!' )
means
while( (refVar.Is()  *p == '.') || *p == '!' )
while
while( refVar.Is()  (*p == '.' || *p == '!') )
seems more the likely intent ?

and finally in
basic/source/comp/scanner.cxx
while( *pLine  ( *pLine == ' ' ) || ( *pLine == '\t' ) || ( *pLine == '\f' ) )
means
while( (*pLine  ( *pLine == ' ' )) || ( *pLine == '\t' ) || ( *pLine == '\f' 
) )
but I suspect
while( *pLine  (( *pLine == ' ' ) || ( *pLine == '\t' ) || ( *pLine == '\f' ) 
))
is what we want.

Patch attached to change to what I *suspect* we might mean.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[script-issues] [Issue 96087] basic: ambiguous || seq uence

2008-11-11 Thread kr
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087


User kr changed the following:

What|Old value |New value

 Assigned to|kr|ab





--- Additional comments from [EMAIL PROTECTED] Tue Nov 11 11:10:28 + 
2008 ---
Andreas, please have a look ...



-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]