Re: Nitpick - amreport statistics
On Mon, Sep 20, 2010 at 6:56 PM, Jon LaBadie j...@jgcomp.com wrote: Looks better to my eye. Any one else? With Jean-Louis' review, committed in r3428. Thanks! Dustin -- Open Source Storage Engineer http://www.zmanda.com
Re: Nitpick - amreport statistics
On Thu, Sep 16, 2010 at 4:52 PM, Dustin J. Mitchell dus...@zmanda.com wrote:
Are you working on this? Perhaps someone else on the list can jump in?
Hmm, well, I just took care of this:
http://github.com/djmitche/amanda/commit/z11908.patch
Total Full Incr. Level:#
Estimate Time (hrs:min) 0:00
Run Time (hrs:min) 0:00
Dump Time (hrs:min) 0:00 0:00 0:00
Output Size (meg)0.00.00.0
Original Size (meg) 0.00.00.0
Avg Compressed Size (%)100.0-- 100.0
DLEs Dumped1 0 1 1:1
Avg Dump Rate (k/s) 3750.0-- 3750.0
Tape Time (hrs:min) 0:00 0:00 0:00
Tape Size (meg) 0.00.00.0
Tape Used (%)0.00.00.0
DLEs Taped 1 0 1 1:1
Parts Taped1 0 1 1:1
Avg Tp Write Rate (k/s)300.0-- 300.0
Jon, what do you think?
Dustin
--
Open Source Storage Engineer
http://www.zmanda.com
Re: Nitpick - amreport statistics
On Mon, Sep 20, 2010 at 04:22:34PM -0500, Dustin J. Mitchell wrote:
On Thu, Sep 16, 2010 at 4:52 PM, Dustin J. Mitchell dus...@zmanda.com wrote:
Are you working on this? ??Perhaps someone else on the list can jump in?
Hmm, well, I just took care of this:
http://github.com/djmitche/amanda/commit/z11908.patch
Total Full Incr. Level:#
Estimate Time (hrs:min) 0:00
Run Time (hrs:min) 0:00
Dump Time (hrs:min) 0:00 0:00 0:00
Output Size (meg)0.00.00.0
Original Size (meg) 0.00.00.0
Avg Compressed Size (%)100.0-- 100.0
DLEs Dumped1 0 1 1:1
Avg Dump Rate (k/s) 3750.0-- 3750.0
Tape Time (hrs:min) 0:00 0:00 0:00
Tape Size (meg) 0.00.00.0
Tape Used (%)0.00.00.0
DLEs Taped 1 0 1 1:1
Parts Taped1 0 1 1:1
Avg Tp Write Rate (k/s)300.0-- 300.0
Jon, what do you think?
Looks better to my eye. Any one else?
jl
--
Jon H. LaBadie j...@jgcomp.com
JG Computing
12027 Creekbend Drive (703) 787-0884
Reston, VA 20194 (703) 787-0922 (fax)
Re: Nitpick - amreport statistics
On Thu, Sep 9, 2010 at 11:05 PM, Dustin J. Mitchell dus...@zmanda.com wrote: I don't mean to put you on the spot - like I said, I can take care of this if you'd prefer. Are you working on this? Perhaps someone else on the list can jump in? Dustin -- Open Source Storage Engineer http://www.zmanda.com
Re: Nitpick - amreport statistics
On Thu, Sep 9, 2010 at 10:26 PM, Jon LaBadie j...@jgcomp.com wrote: First, what I call a DLE is refered to as Filesystem some places and disk others. Second I don't like the repeating extra column headings printed 3 times after the Incr. column. The headings should be moved to the top and the unnecessary blank line reclaimed. I'm not against blank lines to group things, but not just to stick an extra column hdr. Two ways to fix the extra headers. Move them to the top or put them at the end of the first column. I.e. make Parts Taped into Parts Taped (lvl:#parts ...). All good suggestions, and I can take care of this if you'd like. I do wonder if anyone is parsing those lines and expects those particular row labels, but I suppose they can update their regexes if that's the case. For what it's worth, this code is in perl/Amanda/Report/human.pm, or in your installed system it will be in human.pm under either /usr/lib/amanda/perl or your perl sitedir (locate human.pm should find it..). Do you want to take a crack at making those changes yourself, and send along either a patch or just the tweaked version of human.pm (from which I can generate a patch)? I don't mean to put you on the spot - like I said, I can take care of this if you'd prefer. Dustin -- Open Source Storage Engineer http://www.zmanda.com
