[Bugzilla] Release blockers

2011-10-24 Thread bugzilla_noreply 
The following bugs are blocking the next Amarok release:

  This search was scheduled by bcooks...@kde.org.





Bug 233170:
  http://bugs.kde.org/show_bug.cgi?id=233170
  Priority: HI  Severity: crash  Platform: Unlisted Binaries
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: Crash when browsing a category on Jamendo [@ 
CollectionTreeItem::row]
Bug 261421:
  http://bugs.kde.org/show_bug.cgi?id=261421
  Priority: NOR  Severity: crash  Platform: Compiled Sources
  Assignee: amarok-bugs-d...@kde.org
Status: REOPENED
   Summary: Amarok crashed on exit [@ MySqlStorage::escape, 
SqlRegistry::getDirectory]
Bug 277015:
  http://bugs.kde.org/show_bug.cgi?id=277015
  Priority: NOR  Severity: minor  Platform: Gentoo Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: In Unified mode the collection is not grouped after startup 
according to the selected groups (artist/album)
Bug 278897:
  http://bugs.kde.org/show_bug.cgi?id=278897
  Priority: NOR  Severity: normal  Platform: Debian testing
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Amarok uses ~40% of CPU until main window is maximized
Bug 282875:
  http://bugs.kde.org/show_bug.cgi?id=282875
  Priority: HI  Severity: crash  Platform: Ubuntu Packages
  Assignee: amarok-bugs-d...@kde.org
Status: NEW
   Summary: Crash during playback [@ 
Context::ContextView::slotCollapseAnimationsFinished]


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/#review7587
---

Ship it!


Done, commited as 
http://commits.kde.org/amarok/b4b59198a3b991df198a294f7abb1e2f6d945e56 (whith 
some slight modifications)

Thanks for making Amarok better. Silver, plese mark this request as submitted, 
I don't (yet) have permissions to do so.

- Matěj Laitl


On Oct. 24, 2011, 5:55 p.m., Silver Juurik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102956/
> ---
> 
> (Updated Oct. 24, 2011, 5:55 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The patch adds a keyboard shortcut for moving focus to collection search 
> input box. The default shortcut is ctrl+F.
> 
> The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
> The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to 
> playlist search box) and ctrl+F partially solve the problem described in the 
> bug.
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionWidget.h a206914 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 
>   src/MainWindow.h 076628f 
>   src/MainWindow.cpp 2d2ebac 
> 
> Diff: http://git.reviewboard.kde.org/r/102956/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Silver Juurik
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add new collection filter to find exact matches

2011-10-24 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/#review7586
---


I like the feature, but the syntax seems little incoherent wrt current one, 
specifically the greater-than and smaller-than variants e.g. playcount:<3 or 
track:>10. I know these are numeric values, but being coherent counts. What 
about field:=value? (I must admit it looks a bit weird, let's see what others 
will say)

Please do the gui (this has additional benefit of telling user that 
artist:something is a "contains" match) and I'll be happy to merge this once 
other Amarok devs agree.

- Matěj Laitl


On Aug. 8, 2011, 2:38 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102252/
> ---
> 
> (Updated Aug. 8, 2011, 2:38 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> Since I use labels quite intensive it sometimes comes handy to search for 
> songs with an exact label, not just a label containing the string I'm 
> searching for.
> So I added a new filter type for this and used the '=' sign.
> 
> Searching for label=pop finds songs labeled with 'pop' but not with 'electro 
> pop'.
> While searching for label:pop finds songs labeled with 'pop' and 'electro 
> pop'.
> 
> This is not integrated into the GUI like the EditFilterDialog since I wanted 
> to hear your opinions first.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/support/Expression.h 1e49f45 
>   src/core-impl/collections/support/Expression.cpp 531850a 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 735772b 
> 
> Diff: http://git.reviewboard.kde.org/r/102252/diff/diff
> 
> 
> Testing
> ---
> 
> I'm using this patch for a few weeks now without any problems.
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/102252/s/221/
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Daniel Faust 


> On Oct. 24, 2011, 4:56 p.m., Matěj Laitl wrote:
> > Good, thanks for your work, Silver.
> > 
> > I've found an interesting corner case - while the keyboard is always 
> > focused to collection search upon CTRL+F, the collection widget itself does 
> > not show itself if it was previously hidden - see these screenshots to see 
> > when it happens: http://www.laitl.cz/soubory/amarok-ctrl-f-1.jpeg 
> > http://www.laitl.cz/soubory/amarok-ctrl-f-2.jpeg
> > 
> > You may perhaps have luck looking at the "Amarok bookmarks" code to see how 
> > to raise Collection browser widget - especially the part dealing with 
> > amarok://navigate/... urls.

Looks like a very nice feature.
And as somebody having tabbed the collection view myself, I would like to see 
the calling of a bookmark, too.

Something like this should do the trick.

#include "amarokurls/AmarokUrl.h"

AmarokUrl bookmark( "amarok://navigate/collections" );
bookmark.run();


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/#review7581
---


On Oct. 24, 2011, 4:31 p.m., Silver Juurik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102956/
> ---
> 
> (Updated Oct. 24, 2011, 4:31 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The patch adds a keyboard shortcut for moving focus to collection search 
> input box. The default shortcut is ctrl+F.
> 
> The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
> The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to 
> playlist search box) and ctrl+F partially solve the problem described in the 
> bug.
> 
> 
> Diffs
> -
> 
>   src/MainWindow.h 076628f 
>   src/MainWindow.cpp 2d2ebac 
>   src/browsers/collectionbrowser/CollectionWidget.h a206914 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 
> 
> Diff: http://git.reviewboard.kde.org/r/102956/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Silver Juurik
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Silver Juurik 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/
---

(Updated Oct. 24, 2011, 4:31 p.m.)


Review request for Amarok.


Changes
---

Renamed the methods to slotFocusPlaylistSearch and slotFocusCollectionSearch. 
The text for the "Jump to" action changed to "Search playlist". Debug blocks 
removed.


Description
---

The patch adds a keyboard shortcut for moving focus to collection search input 
box. The default shortcut is ctrl+F.

The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to 
playlist search box) and ctrl+F partially solve the problem described in the 
bug.


Diffs (updated)
-

  src/MainWindow.h 076628f 
  src/MainWindow.cpp 2d2ebac 
  src/browsers/collectionbrowser/CollectionWidget.h a206914 
  src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 

Diff: http://git.reviewboard.kde.org/r/102956/diff/diff


Testing
---


Thanks,

Silver Juurik

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/#review7581
---


Good, thanks for your work, Silver.

I've found an interesting corner case - while the keyboard is always focused to 
collection search upon CTRL+F, the collection widget itself does not show 
itself if it was previously hidden - see these screenshots to see when it 
happens: http://www.laitl.cz/soubory/amarok-ctrl-f-1.jpeg 
http://www.laitl.cz/soubory/amarok-ctrl-f-2.jpeg

You may perhaps have luck looking at the "Amarok bookmarks" code to see how to 
raise Collection browser widget - especially the part dealing with 
amarok://navigate/... urls.

- Matěj Laitl


On Oct. 24, 2011, 4:31 p.m., Silver Juurik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102956/
> ---
> 
> (Updated Oct. 24, 2011, 4:31 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The patch adds a keyboard shortcut for moving focus to collection search 
> input box. The default shortcut is ctrl+F.
> 
> The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
> The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to 
> playlist search box) and ctrl+F partially solve the problem described in the 
> bug.
> 
> 
> Diffs
> -
> 
>   src/MainWindow.h 076628f 
>   src/MainWindow.cpp 2d2ebac 
>   src/browsers/collectionbrowser/CollectionWidget.h a206914 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 
> 
> Diff: http://git.reviewboard.kde.org/r/102956/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Silver Juurik
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add keyboard shortcut for collection search

2011-10-24 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/#review7573
---


Looks okay to me, just a few minor things (see below).

Silver, would you also mind correcting the "Jump to" action and methods a bit? 
I think both user-visible KAction name "Jump to" and method name slotJumpTo are 
uninformative, it should be something more specific such as "Jump to playlist". 
(or "Search playlist" to be on par with the greyed out text in the input button 
and "Search collection") If you want, add this to your patch. (you may also 
remove the DEBUG_BLOCK)


src/MainWindow.h


This perhaps deserves a doc comment that states it just focuses collection 
search bar, otherwise the name is a bit misleading. (it doesn't search anything 
it just focuses the bar)



src/MainWindow.cpp


Is the DEBUG_BLOCK necessary here? I think it would just pollute debug log.


- Matěj Laitl


On Oct. 23, 2011, 8:17 p.m., Silver Juurik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102956/
> ---
> 
> (Updated Oct. 23, 2011, 8:17 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> The patch adds a keyboard shortcut for moving focus to collection search 
> input box. The default shortcut is ctrl+F.
> 
> The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
> The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to 
> playlist search box) and ctrl+F partially solve the problem described in the 
> bug.
> 
> 
> Diffs
> -
> 
>   src/MainWindow.h 076628f 
>   src/MainWindow.cpp 2d2ebac 
>   src/browsers/collectionbrowser/CollectionWidget.h a206914 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 
> 
> Diff: http://git.reviewboard.kde.org/r/102956/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Silver Juurik
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Fwd: [LikeBack: Dislike] #2613 (2.4-GIT - fr)

2011-10-24 Thread Myriam Schweingruber 
FYI, this is an often mentioned problem:


-- Forwarded message --
From:  
Date: Mon, Oct 24, 2011 at 16:46
Subject: [LikeBack: Dislike] #2613 (2.4-GIT - fr)
To: myr...@kde.org, valorie.zimmer...@gmail.com, stuffcor...@archlinux.us


http://likeback.kollide.net/admin/view.php

Version: 2.4-GIT
Locale:  fr
Window:  MainWindow
Context:
Type:    Dislike
Comment:
Hi,

I know it's not new but I find it very unpleasant for a while and
didn't take the time to report it earlier: the blue background in the
bottom part of the panels makes it look like there is a bug and
something is not being displayed. In addition the white color police
on it is very hard to read. It doesn't look like the rest of the
interface.
Last detail: when transfering a track to another collection, the
progress bar is so small that it's hard to distinguish the progress.

Thanks!




-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel