Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- One minor comment: Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. who do I ask when this code doesn't work) reasons. The ScriptResolver.* files come from Tomahawk, and I'm totally happy with you re-using the code that we wrote. However, you need to retain the same copyright header that exists in the original source file, and additionally adding your own copyright if you modify the file. This is the original: https://github.com/tomahawk-player/tomahawk/blob/master/src/libtomahawk/resolvers/ScriptResolver.cpp This is also why the ScriptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API. thanks! - Leo Franchi On June 10, 2012, 7:10 a.m., Zhengliang Feng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 10, 2012, 7:10 a.m.) Review request for Amarok. Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the class handles communcation with standalone Spotify resolver, the code is mainly from original ScriptResolver, but added more functions to handle messages separately. The controller class is used to start a ScriptResolver in a separate thread and handles queries. Diffs - src/core-impl/collections/CMakeLists.txt c78b9202ece71b51189c4e47d85acfa4a74ef8d6 src/core-impl/collections/spotifycollection/CMakeLists.txt PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyCollection.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyMeta.cpp PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.h PRE-CREATION src/core-impl/collections/spotifycollection/SpotifyQueryMaker.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Controller.cpp PRE-CREATION src/core-impl/collections/spotifycollection/support/QMFunctionTypes.h PRE-CREATION src/core-impl/collections/spotifycollection/support/Query.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105201/diff/ Testing --- Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ). Logging into Spotify using a username and password. Thanks, Zhengliang Feng ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #140
See http://build.kde.org/job/amarok_master/140/changes Changes: [sam] Fix inconsistent scrobbling with GStreamer backend [matej] Trivial change in proxy collection EditCapability -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision dc7dce5ae78aec7c8cfaf3ac420d90f2e50769f3 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision 4479b118033c1bbacf81d5d4261a518eab89e216 (refs/remotes/origin/master) Checking out Revision 4479b118033c1bbacf81d5d4261a518eab89e216 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson2721588894608083313.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=4479b118033c1bbacf81d5d4261a518eab89e216 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/140/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=0f9afe54-e65f-4d89-b28c-56e109cf27b5 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_13-43-52 BUILD_TAG=jenkins-amarok_master-140 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=140 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14622 --- Ship it! Testing done: mounted an external HDD via Plasma's Device Notifier. This made an item corresponding to it appear in the Local Music pane of Amarok. Unmounting it by the same method made it go away again. - Alex Merry On June 11, 2012, 3:14 p.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/ --- (Updated June 11, 2012, 3:14 p.m.) Review request for Amarok. Description --- MediaDeviceCache: remove polling, solid events should suffice This fixes a bug where Amarok (very probably needlessly) polls solid for all devices every single second (!!!) just to detect whether some unmounted paths become mounted or vice versa. This should not be needed at all, solid should notify us about everything. However, I am not sure, so this is definitely not a material for 2.6 final but rather 2.7 if no problems show up. BUG: 289462 FIXED-IN: 2.7 REVIEW: 105221 This addresses bug 289462. https://bugs.kde.org/show_bug.cgi?id=289462 Diffs - src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 Diff: http://git.reviewboard.kde.org/r/105221/diff/ Testing --- little Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14624
---
From the code:
297 if ((*it)-mountType() == nfs || (*it)-mountType() == nfs4
||
298 (*it)-mountType() == smb || (*it)-mountType() ==
cifs) {(...)
This was supposedly just for the network filesystems. Can anybody test with a
collection folder on one of those network fs's? With positive results, we could
even push to 2.6 final.
- Matěj Laitl
On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/
---
(Updated June 11, 2012, 3:14 p.m.)
Review request for Amarok.
Description
---
MediaDeviceCache: remove polling, solid events should suffice
This fixes a bug where Amarok (very probably needlessly) polls solid
for all devices every single second (!!!) just to detect whether some
unmounted paths become mounted or vice versa. This should not be needed
at all, solid should notify us about everything.
However, I am not sure, so this is definitely not a material for 2.6
final but rather 2.7 if no problems show up.
BUG: 289462
FIXED-IN: 2.7
REVIEW: 105221
This addresses bug 289462.
https://bugs.kde.org/show_bug.cgi?id=289462
Diffs
-
src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52
src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991
Diff: http://git.reviewboard.kde.org/r/105221/diff/
Testing
---
little
Thanks,
Matěj Laitl
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #141
See http://build.kde.org/job/amarok_master/141/changes Changes: [vonreth] added missing translations and updated some [kde] Fix insert options in AddTrack in the MPRIS1 interface -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision 4479b118033c1bbacf81d5d4261a518eab89e216 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision 0e6f9bd01128936dfbf255eb0714ca160568aeba (refs/remotes/origin/master) Checking out Revision 0e6f9bd01128936dfbf255eb0714ca160568aeba (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson5476384331075714209.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=0e6f9bd01128936dfbf255eb0714ca160568aeba HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/141/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=d92ab93e-6f5c-4800-824a-9bc42e020992 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_16-32-55 BUILD_TAG=jenkins-amarok_master-141 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=141 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok. Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the class handles communcation with standalone Spotify resolver, the code is mainly from original ScriptResolver, but added more functions to handle messages separately. The controller class is used to start a ScriptResolver in a separate thread and handles queries. Diffs (updated) - src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105201/diff/ Testing --- Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ). Logging into Spotify using a username and password. Thanks, Zhengliang Feng ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
On June 11, 2012, 8:52 a.m., Leo Franchi wrote: One minor comment: Please don't remove copyright headers when copying files from another project--this is important for both legal and authorship (e.g. who do I ask when this code doesn't work) reasons. The ScriptResolver.* files come from Tomahawk, and I'm totally happy with you re-using the code that we wrote. However, you need to retain the same copyright header that exists in the original source file, and additionally adding your own copyright if you modify the file. This is the original: https://github.com/tomahawk-player/tomahawk/blob/master/src/libtomahawk/resolvers/ScriptResolver.cpp This is also why the ScriptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API. thanks! Sorry about that, I forgot to add them when copying from the scratch repo. Now they are added in diff r2. - Zhengliang --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14599 --- On June 11, 2012, 1:26 p.m., Zhengliang Feng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok. Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the class handles communcation with standalone Spotify resolver, the code is mainly from original ScriptResolver, but added more functions to handle messages separately. The controller class is used to start a ScriptResolver in a separate thread and handles queries. Diffs - src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105201/diff/ Testing --- Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ). Logging into Spotify using a username and password. Thanks, Zhengliang Feng ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #143
See http://build.kde.org/job/amarok_master/143/changes Changes: [kde] Update the changelog -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision 0e07efe5908f927ba20cfbcc46298985c372c819 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision e5cea18aad41f209b2c9fb416ab4dd6a15dd1f44 (refs/remotes/origin/master) Checking out Revision e5cea18aad41f209b2c9fb416ab4dd6a15dd1f44 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson9026406812040873228.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=e5cea18aad41f209b2c9fb416ab4dd6a15dd1f44 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/143/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=ad67c74a-d466-405f-beac-a5ccfeff53b1 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_17-38-42 BUILD_TAG=jenkins-amarok_master-143 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=143 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #142
See http://build.kde.org/job/amarok_master/142/changes Changes: [kde] Make the playlist code a little clearer [kde] Play the correct track when inserting tracks into a sorted playlist -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision 0e6f9bd01128936dfbf255eb0714ca160568aeba (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision 0e07efe5908f927ba20cfbcc46298985c372c819 (refs/remotes/origin/master) Checking out Revision 0e07efe5908f927ba20cfbcc46298985c372c819 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson6964142735956784174.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=0e07efe5908f927ba20cfbcc46298985c372c819 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/142/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=82e4a053-1cc5-404c-8f23-95790d6e54c1 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=0 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_17-35-00 BUILD_TAG=jenkins-amarok_master-142 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=142 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)
On June 11, 2012, 8:41 a.m., Bart Cerneels wrote: I'm assuming this is mostly code copied and edited (but not completely) from the playdar work done by Andy for GSoC 2010. As far as I understand it the protocol used by the Tomahawk resolver is still the same (playdar API), so that should work. There are a few things you should look at before going on with this design though. First do some namespace cleanup. ScriptResolver for instance is a confusing name. Here you won't be dealing with a resolver script but the spotify-resolver application. ResolverProcessInterface looks a little long, but does cover it's function pretty well. Up to you to figure out a good name. I've not gone through the architecture of the playdar QueryMaker. It probably works, but I wonder if it has to be so complicated. QM is not a simple API to begin with though. Spotify does not support search strings for specific types (artist, album, genre, etc) AFAIU, so a mapping might be more straight forward. If this code is working keep it for now, as long as no performance issues pop up. Yes, some code like meta classe are just copy and paste. Some of them like Controller class might be deleted or replaced later, I was thinking about replacing it by ScriptResolver. QM is more complicated than I thought, it may take some time to fully understand how it works. Spotify can do specific search by using artist: or album: and using of logical operands like 'AND' or 'OR' is also possible, details are on https://developer.spotify.com/technologies/libspotify/guidelines-hardware/ in the 'Search' section. So it is easy to construct a search string for specific types. - Zhengliang --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/#review14597 --- On June 11, 2012, 1:26 p.m., Zhengliang Feng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105201/ --- (Updated June 11, 2012, 1:26 p.m.) Review request for Amarok. Description --- Add Spotify collection code Currently implemented SpotifyCollection, SpotifyQueryMaker and SpotifyMeta. The ScriptResolver is the class handles communcation with standalone Spotify resolver, the code is mainly from original ScriptResolver, but added more functions to handle messages separately. The controller class is used to start a ScriptResolver in a separate thread and handles queries. Diffs - src/core-impl/collections/spotifycollection/support/ScriptResolver.h PRE-CREATION src/core-impl/collections/spotifycollection/support/ScriptResolver.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105201/diff/ Testing --- Communication between ScriptResolver and Spotify resolver( from Tomahawk resolver repo https://github.com/ofan/tomahawk-resolvers ). Logging into Spotify using a username and password. Thanks, Zhengliang Feng ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #145
See http://build.kde.org/job/amarok_master/145/changes Changes: [kde] Add more debugging info for mpris:artUrl in the MPRIS2 interface -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision 1742ccf33267dc3e6a5722d51aeeabe4f101a377 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision 58017cdb353282b9cfc8286477fed05334ebf331 (refs/remotes/origin/master) Checking out Revision 58017cdb353282b9cfc8286477fed05334ebf331 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson393755066810811243.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=58017cdb353282b9cfc8286477fed05334ebf331 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/145/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=ab2841c3-3d89-4cdf-b644-0397e45f56fd JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_18-30-31 BUILD_TAG=jenkins-amarok_master-145 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=145 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #144
See http://build.kde.org/job/amarok_master/144/changes Changes: [kde] Construct the MPRIS1 arturl the same way as the MPRIS2 mpris:artUrl -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision e5cea18aad41f209b2c9fb416ab4dd6a15dd1f44 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision 1742ccf33267dc3e6a5722d51aeeabe4f101a377 (refs/remotes/origin/master) Checking out Revision 1742ccf33267dc3e6a5722d51aeeabe4f101a377 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson8113061069570625401.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=1742ccf33267dc3e6a5722d51aeeabe4f101a377 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/144/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=f1ef900b-19fb-4c7a-8219-fcbd9f5f1096 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_18-14-54 BUILD_TAG=jenkins-amarok_master-144 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=144 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
Build failed in Jenkins: amarok_master #146
See http://build.kde.org/job/amarok_master/146/changes Changes: [kde] MPRIS: Actually use the cached we created -- Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspace http://build.kde.org/job/amarok_master/ws/ Checkout:amarok_master / http://build.kde.org/job/amarok_master/ws/ - hudson.remoting.LocalChannel@fe6cb1e Using strategy: Default Last Built Revision: Revision 58017cdb353282b9cfc8286477fed05334ebf331 (refs/remotes/origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://anongit.kde.org/amarok.git Commencing build of Revision f6262ff64d9ca4341f86b3f2e569a151531af4b5 (refs/remotes/origin/master) Checking out Revision f6262ff64d9ca4341f86b3f2e569a151531af4b5 (refs/remotes/origin/master) [amarok_master] $ /bin/sh -xe /tmp/hudson5149531501900047423.sh + env JENKINS_HOME=/var/lib/jenkins USER=jenkins LANGUAGE=en_US:en MAIL=/var/mail/jenkins LD_LIBRARY_PATH=/usr/lib/jvm/java-6-openjdk/jre/lib/amd64/server:/usr/lib/jvm/java-6-openjdk/jre/lib/amd64:/usr/lib/jvm/java-6-openjdk/jre/../lib/amd64 GIT_COMMIT=f6262ff64d9ca4341f86b3f2e569a151531af4b5 HUDSON_URL=http://build.kde.org/ NODE_LABELS=master SHLVL=1 HOME=/var/lib/jenkins JENKINS_SLAVE_HOME=/home/jenkins/slave BUILD_URL=http://build.kde.org/job/amarok_master/146/ XDG_SESSION_COOKIE=d0ae1686aea3470ac84b2956d938-1338567538.372139-474903396 HUDSON_COOKIE=5199eab7-5cfd-4e08-9704-c0bb38cd2cf8 JENKINS_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 WORKSPACE=http://build.kde.org/job/amarok_master/ws/ BUILD_CAUSE_SCMTRIGGER=true MASTER=huey.kde.org LOGNAME=jenkins _=/usr/bin/daemon BUILD_CAUSE=SCMTRIGGER GIT_BRANCH=refs/remotes/origin/master EXECUTOR_NUMBER=1 KDE_STABLE_BRANCH=KDE/4.8 TERM=xterm HUDSON_HOME=/var/lib/jenkins QT_FUTURE_BRANCH=master PATH=/usr/lib/ccache:/home/jenkins/slave:/usr/lib/ccache:/home/jenkins/slave:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games QT_LEGACY_BRANCH=4.7 BUILD_ID=2012-06-11_20-01-36 BUILD_TAG=jenkins-amarok_master-146 LANG=en_US.UTF-8 JENKINS_URL=http://build.kde.org/ JOB_URL=http://build.kde.org/job/amarok_master/ POLL_DELAY=1 BUILD_NUMBER=146 SHELL=/bin/bash JENKINS_DEPENDENCY_BRANCH=branch_info QT_STABLE_BRANCH=4.8 HUDSON_SERVER_COOKIE=eb94dd7581d401fe721018deca23db43 JOB_NAME=amarok_master PWD=http://build.kde.org/job/amarok_master/ws/ GEM_PATH=file:/var/lib/jenkins/plugins/ruby-runtime/WEB-INF/lib/stapler-jruby-1.177.jar!/gem ROOT=/srv + cd /home/jenkins/slave + git pull ssh: connect to host www.nyblom.org port 222: Connection timed out fatal: The remote end hung up unexpectedly Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Performing Post build task... Match found for :.* : True Logical operation result is TRUE Skipping post build task 0 - job status is worse than unstable : FAILURE Recording test results Failed to send e-mail to ralf.engels because no e-mail address is known, and no default e-mail domain is configured ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
