RE: [PATCH 00/46] DC Patches April 29, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 6fdf2d7a8aaa drm/amd/display: 3.2.282) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Wayne Lin Sent: Wednesday, April 24, 2024 4:49 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Lin, Wayne Subject: [PATCH 00/46] DC Patches April 29, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Disable seamless boot on 128b/132b encoding - Change ASSR disable sequence to avoid corruption - Fix few IPS problems - Enable Replay for DCN315 - Fix few ODM problems - Fix FEC_READY write timing - Fix few FPO problems - Adjust DML21 gpuvm_enable assignment - Fix divide by 0 error in VM environment - Fix few DCN35 problems - Fix flickering on DCN321 - Fix mst resume problem - Fix multi-disp FAMS problem - Refactor Replay - Update some of the dcn303 parameters - Enable legacy fast update for dcn301 - Add VCO parameter for DCN31 FPU - Have cursor and surface updates together - Fix problems reported by Coverity --- Alex Hung (9): drm/amd/display: Check index msg_id before read or write drm/amd/display: Check pipe offset before setting vblank drm/amd/display: Skip finding free audio for unknown engine_id drm/amd/display: Do not return negative stream id for array drm/amd/display: ASSERT when failing to find index by plane/stream id drm/amd/display: Remove redundant include file drm/amd/display: Fix uninitialized variables in DM drm/amd/display: Fix uninitialized variables in DC drm/amd/display: Fix uninitialized variables in DC Alvin Lee (3): drm/amd/display: Only program P-State force if pipe config changed drm/amd/display: Assign linear_pitch_alignment even for VM drm/amd/display: For FPO + Vactive check that all pipes support VA Aric Cyr (1): drm/amd/display: 3.2.283 Daniel Miess (1): drm/amd/display: Enable RCO for PHYSYMCLK in DCN35 Dennis Chan (1): drm/amd/display: Refactor for Replay Link off frame count Harry Wentland (2): drm/amd/display: Do cursor programming with rest of pipe drm/amd/display: Always use legacy way of setting cursor on DCE Hersen Wu (2): drm/amd/display: Add NULL pointer check for kzalloc drm/amd/display: Fix overlapping copy within dml_core_mode_programming Ilya Bakoulin (1): drm/amd/display: Fix FEC_READY write on DP LT Iswara Nagulendran (1): drm/amd/display: Restrict multi-disp support for in-game FAMS Joan Lee (1): drm/amd/display: Enable Replay for DCN315 Leo Ma (1): drm/amd/display: Fix DC mode screen flickering on DCN321 Nevenko Stupar (1): drm/amd/display: gpuvm handling in DML21 Nicholas Kazlauskas (2): drm/amd/display: Add trigger FIFO resync path for DCN35 drm/amd/display: Notify idle link detection through shared state Revalla Hari Krishna (1): drm/amd/display: Refactor HUBBUB into component folder Rodrigo Siqueira (10): drm/amd/display: Improve registers write drm/amd/display: Add missing SMU version drm/amd/display: Adjust codestyle for dcn31 and hdcp_msg drm/amd/display: Add VCO speed parameter for DCN31 FPU drm/amd/display: Adjust functions
RE: [PATCH 00/37] DC Patches April 22, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 8862638f2371 drm/amdgpu: enable redirection of irq's for IH V6.1) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Aurabindo Pillai Sent: Monday, April 22, 2024 11:27 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Pillai, Aurabindo Subject: [PATCH 00/37] DC Patches April 22, 2024 Summary: * Changes across DSC, MST, DMCUB, Panel Replay and misc fixes. * Fixes to cursor programming sequence * Add some missing register defs * Formatting/Sytle fixes == Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.214.0 Aric Cyr (1): drm/amd/display: 3.2.282 Cruise (1): drm/amd/display: Disable error correction if it's not supported Dennis Chan (1): drm/amd/display: Fix Replay Desync Error Test Dmytro Laktyushkin (1): drm/amd/display: Increase SAT_UPDATE_PENDING timeout Ethan Bitnun (1): drm/amd/display: Block FPO According to Luminance Delta Gabe Teeger (1): drm/amd/display: Atom Integrated System Info v2_2 for DCN35 George Shen (2): drm/amd/display: Handle Y carry-over in VCP X.Y calculation drm/amd/display: Skip SST ACT polling when sink_count is 0 Harry Wentland (2): drm/amd/display: Separate setting and programming of cursor drm/amd/display: Set cursor attributes before position Hersen Wu (1): drm/amd/display: Fix incorrect DSC instance for MST Ilya Bakoulin (1): drm/amd/display: Add condition for dp_set_dsc_config call Joshua Aberback (1): Revert "drm/amd/display: Fix incorrect pointer assignment" Meenakshikumar Somasundaram (1): drm/amd/display: Allocate zero bw after bw alloc enable Michael Strauss (1): drm/amd/display: Add delay to improve LTTPR UHBR interop Natanel Roizenman (1): drm/amd/display: Add null check in resource_log_pipe_topology_update Nicholas Kazlauskas (1): drm/amd/display: Force flush after write to IPS driver signals Rodrigo Siqueira (13): drm/amd/display: Add missing debug registers for DCN2/3/3.1 drm/amd/display: Add missing dwb registers drm/amd/display: Add TMDS DC balancer control drm/amd/display: Add some missing HDMI registers for DCN3x drm/amd/display: Clean up code in DC drm/amd/display: Adjust registers sequence in the DIO list drm/amd/display: Code style adjustments drm/amd/display: Add some HDCP registers DCN35 list drm/amd/display: Update comments in DC drm/amd/display: Ensure that dmcub support flag is set for DCN20 drm/amd/display: Add missing IRQ types drm/amd/display: Drop unnecessary semicolon drm/amd/display: Replace uint8_t with u8 for dp_hdmi_dongle_signature_str Sung Joon Kim (3): drm/amd/display: Reuse the modified power sequence drm/amd/display: Fix recout calculation for stereo side-by-side drm/amd/display: Update dcn351 debug flags and function pointers Sung-huai Wang (1): drm/amd/display: Handle HPD_IRQ for internal link Swapnil Patel (1): drm/amd/display: Add dtbclk access to dcn315 yi-lchen (1): drm/amd/display: Keep VBios pixel rate div setting util next mode set
RE: [PATCH 00/25] DC Patches April 10, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 9ef923c9f876 drm/amd/display: 3.2.280) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Wednesday, April 10, 2024 5:26 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/25] DC Patches April 10, 2024 This DC patchset brings improvements in multiple areas. In summary, we have: * Expand dmub_cmd operations. * Update DVI configuration. * Modify power sequence. * Enable Z10 flag for IPS. * Multiple code cleanups. Cc: Daniel Wheeler Thanks Siqueira Anthony Koo (1): drm/amd/display: Expand dmub_cmd operations Aric Cyr (1): drm/amd/display: 3.2.281 Bitnun, Ethan (1): drm/amd/display: Improve the log precision Chaitanya Dhere (1): drm/amd/display: Fix incorrect pointer assignment Charlene Liu (1): drm/amd/display: limit the code change to ips enabled asic Chris Park (1): drm/amd/display: Add a function for checking tmds mode Eric Bernstein (1): drm/amd/display: Update FMT settings for 4:2:0 Mikita Lipski (1): drm/amd/display: Fix PSR command version passed Nicholas Kazlauskas (1): drm/amd/display: Pass sequential ONO bit to DMCUB boot options Rodrigo Siqueira (11): drm/amd/display: Use dce_version instead of chip_id drm/amd/display: Adjust headers drm/amd/display: Group scl_data together in resource_build_scaling_params drm/amd/display: Replace int with unsigned int drm/amd/display: Update some comments to improve the code readability drm/amd/display: Remove unnecessary code drm/amd/display: Rework dcn10_stream_encoder header drm/amd/display: Move REG sequence from program ogam to idle before connect drm/amd/display: Update DCN201 link encoder registers drm/amd/display: Add missing callback for init_watermarks in DCN 301 drm/amd/display: Add missing replay field Samson Tam (1): drm/amd/display: add support for chroma offset Sung Joon Kim (4): drm/amd/display: Modify power sequence drm/amd/display: Modify resource allocation logic drm/amd/display: Enable Z10 flag for IPS FSM drm/amd/display: Rework power sequence and resource allocation logic .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 +- .../gpu/drm/amd/display/dc/core/dc_state.c| 10 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 2 +- drivers/gpu/drm/amd/display/dc/dc.h | 16 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 7 + drivers/gpu/drm/amd/display/dc/dc_types.h | 2 + .../gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 6 - .../amd/display/dc/dcn10/dcn10_link_encoder.h | 6 - .../gpu/drm/amd/display/dc/dcn10/dcn10_opp.c | 9 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_opp.h | 2 + .../display/dc/dcn10/dcn10_stream_encoder.h | 10 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.h | 2 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c | 10 +- .../drm/amd
RE: [PATCH 00/43] DC Patches Apr 1, 2024
[Public] Sorry about that, meant to respond to this one. Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - a6b494a44fd6 drm/amd/display: Set DCN351 BB and IP the same as DCN35) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: roman...@amd.com Sent: Thursday, March 28, 2024 3:50 PM To: amd-gfx@lists.freedesktop.org Cc: Wheeler, Daniel ; Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Chiu, Solomon ; Gutierrez, Agustin ; Mahfooz, Hamza ; Li, Roman Subject: [PATCH 00/43] DC Patches Apr 1, 2024 From: Roman Li This DC patchset brings improvements in multiple areas. In summary, we have: - Fix underflow in subvp/non-subvp configs - Fix compiler warnings - Add handling for DC power mode - Add extra logging for DMUB, HUBP and OTG - Add timing pixel encoding for mst mode validation - Expand supported Replay residency mode - Allow HPO PG and RCG for DCN35 - Update pipe topology log to support subvp - Disable Z8 minimum stutter period check for DCN35 - Enable RCO for HDMISTREAMCLK in DCN35 Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: Skip on writeback when it's not applicable Alvin Lee (2): drm/amd/display: Add extra logging for HUBP and OTG drm/amd/display: Add extra DMUB logging to track message timeout Aric Cyr (2): drm/amd/display: Fix compiler warnings on high compiler warning levels drm/amd/display: 3.2.279 Daniel Miess (2): drm/amd/display: Toggle additional RCO options in DCN35 drm/amd/display: Enable RCO for HDMISTREAMCLK in DCN35 Dillon Varone (1): drm/amd/display: Add dmub additional interface support for FAMS Duncan Ma (1): drm/amd/display: Allow HPO PG for DCN35 Eric Bernstein (1): drm/amd/display: Fix MPCC DTN logging George Shen (1): drm/amd/display: Add dummy interface for tracing DCN32 SMU messages Hersen Wu (2): drm/amd/display: Add timing pixel encoding for mst mode validation drm/amd/display: FEC overhead should be checked once for mst slot nums Joshua Aberback (3): drm/amd/display: handle invalid connector indices drm/amd/display: remove context->dml2 dependency from DML21 wrapper drm/amd/display: Add handling for DC power mode Leo (Hanghong) Ma (1): drm/amd/display: Add OTG check for set AV mute Leon Huang (1): drm/amd/display: Expand supported Replay residency mode Mounika Adhuri (1): drm/amd/display: Fix compiler redefinition warnings for certain configs Nicholas Kazlauskas (1): drm/amd/display: Disable Z8 minimum stutter period check for DCN35 Rodrigo Siqueira (15): drm/amd/display: Initialize DP ref clk with the correct clock drm/amd/display: Set alpha enable to 0 for some specific formats drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled drm/amd/display: Add some missing debug registers drm/amd/display: Update DSC compute parameter calculation drm/amd/display: Drop legacy code drm/amd/display: Add missing registers drm/amd/display: Remove redundant RESERVE0 and RESERVE1 drm/amd/display: Add missing SFB and OPP_SF drm/amd/display: Initialize debug variable data drm/amd/display: Add WBSCL ram coefficient for writeback drm/amd/display: Add code comments clock and encode code drm/amd/display: Includes adjustments drm/amd/display:
RE: [PATCH 01/43] drm/amd/display: Fix compiler redefinition warnings for certain configs
[Public]
Hi all,
This week this patchset was tested on the following systems:
* Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
* MSI Gaming X Trio RX 6800
* Gigabyte Gaming OC RX 7900 XTX
These systems were tested on the following display/connection types:
* eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600
120hz[6600U])
* VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI])
* DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes
USB-C to DP/HDMI adapters])
* Thunderbolt (LG Ultrafine 5k)
* MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays)
* DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays,
and HP Hook G2 with 1 4k60 display)
* USB 4 (Kensington SD5700T and 1x 4k 60Hz display)
* PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that
is the max the adapter supports])
The testing is a mix of automated and manual tests. Manual testing includes
(but is not limited to):
* Changing display configurations and settings
* Benchmark testing
* Feature testing (Freesync, etc.)
Automated testing includes (but is not limited to):
* Script testing (scripts to automate some of the manual checks)
* IGT testing
The patchset consists of the amd-staging-drm-next branch (Head commit -
a6b494a44fd6 drm/amd/display: Set DCN351 BB and IP the same as DCN35) with new
patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com
-Original Message-
From: roman...@amd.com
Sent: Thursday, March 28, 2024 3:50 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wheeler, Daniel ; Wentland, Harry
; Li, Sun peng (Leo) ; Siqueira,
Rodrigo ; Pillai, Aurabindo
; Li, Roman ; Lin, Wayne
; Chiu, Solomon ; Gutierrez, Agustin
; Mahfooz, Hamza ; Adhuri,
Mounika ; Leung, Martin
Subject: [PATCH 01/43] drm/amd/display: Fix compiler redefinition warnings for
certain configs
From: Mounika Adhuri
[why & how]
Modified definitions of 1 function and 2 structs to remove warnings on certain
specific compiler configurations due to redefinition.
Reviewed-by: Martin Leung
Acked-by: Roman Li
Signed-off-by: Mounika Adhuri
Tested-by: Daniel Wheeler
---
drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 4 ++--
drivers/gpu/drm/amd/display/include/grph_object_id.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
index 35c631c22934..17b404cb1155 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
@@ -249,7 +249,7 @@ static bool dce110_enable_display_power_gating(
return false;
}
-static void build_prescale_params(struct ipp_prescale_params *prescale_params,
+static void dce110_prescale_params(struct ipp_prescale_params
+*prescale_params,
const struct dc_plane_state *plane_state) {
prescale_params->mode = IPP_PRESCALE_MODE_FIXED_UNSIGNED; @@ -291,7
+291,7 @@ dce110_set_input_transfer_func(struct dc *dc, struct pipe_ctx
*pipe_ctx,
tf = _state->in_transfer_func;
- build_prescale_params(_params, plane_state);
+ dce110_prescale_params(_params, plane_state);
ipp->funcs->ipp_program_prescale(ipp, _params);
if (!plane_state->gamma_correction.is_identity && diff --git
a/drivers/gpu/drm/amd/display/include/grph_object_id.h
b/drivers/gpu/drm/amd/display/include/grph_object_id.h
index c6bbd262f1ac..08ee0350b31f 100644
--- a/drivers/gpu/drm/amd/display/include/grph_object_id.h
+++ b/drivers/gpu/drm/amd/display/include/grph_object_id.h
@@ -226,8 +226,8 @@ enum dp_alt_mode {
struct graphics_object_id {
uint32_t id:8;
- uint32_t enum_id:4;
- uint32_t type:4;
+ enum object_enum_id enum_id;
+ enum object_type type;
uint32_t reserved:16; /* for padding. total size should be u32 */ };
--
2.34.1
RE: [PATCH 00/22] DC Patches Mar 25 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 8294fd749e0d drm/amd/display: Get min/max vfreq from display_info) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Tom Chung Sent: Wednesday, March 20, 2024 2:36 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/22] DC Patches Mar 25 2024 This DC patchset brings improvements in multiple areas. In summary, we have: - Fix some bound and NULL check - Fix nonseamless transition from ODM + MPO to ODM + subvp - Allow Z8 when stutter threshold is not met - Remove plane and stream pointers from dc scratch - Remove read/write to external register - Increase number of hpo dp link encoders - Increase clock table size - Add new IPS config mode - Build scaling params when a new plane is appended - Refactor DML2 interfaces - Allow idle opts for no flip case on PSR panel Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: Allow idle opts for no flip case on PSR panel drm/amd/display: Remove plane and stream pointers from dc scratch Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.210.0 Aric Cyr (1): drm/amd/display: 3.2.278 Bhawanpreet Lakha (2): drm/amd/display: Allow Z8 when stutter threshold is not met drm/amd/display: Allow Z8 when stutter threshold is not met for dcn35 Dillon Varone (3): drm/amd/display: Expand DML2 callbacks drm/amd/display: Refactor DML2 interfaces drm/amd/display: Modify DHCUB waterwark structures and functions George Shen (1): drm/amd/display: Remove MPC rate control logic from DCN30 and above Muhammad Ahmed (1): drm/amd/display: Skip pipe if the pipe idx not set properly Natanel Roizenman (1): drm/amd/display: Consolidate HPO enable/disable and restrict only to state transitions. Nicholas Kazlauskas (1): drm/amd/display: Add new IPS config mode Roman Li (1): drm/amd/display: Fix bounds check for dcn35 DcfClocks Sohaib Nadeem (1): drm/amd/display: Added missing null checks Sridevi Arvindekar (1): drm/amd/display: Increase number of hpo dp link encoders Sung Joon Kim (2): drm/amd/display: Remove read/write to external register drm/amd/display: Increase clock table size Taimur Hassan (1): drm/amd/display: Send DTBCLK disable message on first commit Wenjing Liu (3): drm/amd/display: fix a dereference of a NULL pointer drm/amd/display: fix nonseamless transition from ODM + MPO to ODM + subvp drm/amd/display: build scaling params when a new plane is appended .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +-- .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 42 +++--- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 45 +-- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 21 --- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.h | 2 - drivers/gpu/drm/amd/display/dc/core/dc.c | 86 ++-- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 8 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 89 - .../gpu/drm/amd/display/dc/core/dc_state.c| 31 +++-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 16 +-- .../gpu/drm/amd/display/dc/core
RE: [PATCH 00/43] DC Patches March 18, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 0b233252a7c1 drm/amd/display: 3.2.275) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Wayne Lin Sent: Tuesday, March 12, 2024 5:20 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Lin, Wayne ; Wheeler, Daniel Subject: [PATCH 00/43] DC Patches March 18, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Clear mpc_tree in init_pipes - Program pixclk according to dcn revision - Add stream clock source to DP DTO params - Enabling urgent latency adjustment for DCN35 - To adjust dprefclk by down spread percentage - Add debug option for idle reg checks - Revert few patches which cause regression - skip forcing odm in minimal transition - Fix noise issue on HDMI AV mute - Enable fast update for DCN314 - Enable 2to1 ODM policy for DCN35 - Fix DCN31 underflow problem - Add the MALL size in the fallback function - Modify coding style/errors and remove redundant codes - Add missing registers and offset - Fix few problems for DCN35 - Fix a bug which dereferences freed memory - Enable new interface design for alternate scrambling - Enhance IPS handshake - Increase Z8 watermark times - Fix DML2 problem - Revert patch which cause regression - Fix problems for dmub idle power optimization Cc: Daniel Wheeler --- Alex Hung (2): drm/amd/display: Delete duplicated function prototypes drm/amd/display: Correct indentations and spaces Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.208.0 Aric Cyr (2): drm/amd/display: 3.2.276 drm/amd/display: 3.2.277 Chaitanya Dhere (1): drm/amd/display: Add TB_BORROWED_MAX definition Charlene Liu (2): drm/amd/display: fix debug key not working on dml2 drm/amd/display: change aux_init to apu version Chris Park (1): drm/amd/display: Prevent crash on bring-up Dillon Varone (3): drm/amd/display: add stream clock source to DP DTO params drm/amd/display: Program pixclk according to dcn revision drm/amd/display: Power on VPG memory unconditionally if off Gabe Teeger (1): drm/amd/display: Revert Add left edge pixel + ODM pipe split Leo Ma (1): drm/amd/display: Fix noise issue on HDMI AV mute Martin Leung (1): drm/amd/display: revert Exit idle optimizations before HDCP execution Natanel Roizenman (2): drm/amd/display: Added debug prints for zstate_support and StutterPeriod drm/amd/display: Increase Z8 watermark times. Nicholas Kazlauskas (6): drm/amd/display: Add debug option for idle reg checks drm/amd/display: Workaround register access in idle race with cursor drm/amd/display: Detect and disallow idle reallow during reentrancy drm/amd/display: Add optional optimization for IPS handshake drm/amd/display: Enable optimized handshake for DCN35 drm/amd/display: Enable reallow for idle on DCN35 Nicholas Susanto (1): drm/amd/display: Enabling urgent latency adjustment for DCN35 Ovidiu Bunea (1): drm/amd/display: Revert "Set the power_down_on_boot function pointer to null" Rodrigo Siqueira (9): drm/amd/display: Remove code duplication drm/amd/display: Remove wrong s
RE: [PATCH] drm/amd/display: Get min/max vfreq from display_info
[Public]
Hi all,
I can confirm that this re-enables VRR for a RX6800, and a RX7900XTX.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook | Twitter | amd.com
-Original Message-
From: amd-gfx On Behalf Of Harry
Wentland
Sent: Tuesday, March 12, 2024 11:29 AM
To: Alex Deucher
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Get min/max vfreq from display_info
On 2024-03-12 10:58, Alex Deucher wrote:
> On Tue, Mar 12, 2024 at 9:57 AM Harry Wentland wrote:
>>
>> We need the min/max vfreq on the amdgpu_dm_connector in order to
>> program VRR.
>>
>> Fixes: db3e4f1cbb84 ("drm/amd/display: Use freesync when
>> `DRM_EDID_FEATURE_CONTINUOUS_FREQ` found")
>> Signed-off-by: Harry Wentland
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index b1ca0aee0b30..cffb2655177c 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -11278,12 +11278,15 @@ void amdgpu_dm_update_freesync_caps(struct
>> drm_connector *connector,
>>
>> if (is_dp_capable_without_timing_msa(adev->dm.dc,
>> amdgpu_dm_connector)) {
>> - if (edid->features &
>> DRM_EDID_FEATURE_CONTINUOUS_FREQ)
>> + if (edid->features &
>> + DRM_EDID_FEATURE_CONTINUOUS_FREQ) {
>> freesync_capable = true;
>> - else
>> + amdgpu_dm_connector->min_vfreq =
>> connector->display_info.monitor_range.min_vfreq;
>> + amdgpu_dm_connector->max_vfreq =
>> + connector->display_info.monitor_range.max_vfreq;
>
> Does this need special handling for DRM_EDID_RANGE_OFFSET_MIN_VFREQ
> and DRM_EDID_RANGE_OFFSET_MAX_VFREQ as well (similar to the code below
> it)?
>
get_monitor_range in drm_edid.c already handles it. I'm actually wondering if
the "else" and "edid_check_required" case is still required now, as it
essentially just duplicates the drm_edid code. But I don't want to rip it out
in the same patch and without a bit of testing.
Harry
> Alex
>
>> + } else {
>> edid_check_required = edid->version > 1 ||
>> (edid->version == 1 &&
>>edid->revision
>> > 1);
>> + }
>> }
>>
>> if (edid_check_required) {
>> --
>> 2.44.0
>>
RE: [PATCH 00/34] DC Patches Feb 28, 2020
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 0312d86bf720 drm/amd/pm: Increase SMUv13.0.6 mode-2 reset time) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Hung, Alex Sent: Wednesday, February 28, 2024 1:39 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Hung, Alex ; Wheeler, Daniel Subject: [PATCH 00/34] DC Patches Feb 28, 2020 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes on HDCP, eDP and FW idle check. * Enhancement in debug messages * Improvement on updates sequences * DPP refactoring to a new directory * Enhancements in DMUB Cc: Daniel Wheeler Allen Pan (1): drm/amd/display: Add a dc_state NULL check in dc_state_release Alvin Lee (1): drm/amd/display: Backup and restore only on full updates Anthony Koo (2): drm/amd/display: Add entry and exit counters drm/amd/display: Update DMUB flags and definitions Aric Cyr (2): drm/amd/display: 3.2.274 drm/amd/display: 3.2.275 Aurabindo Pillai (3): drm/amd/display: Enable DML2 debug flags drm/amd/display: Add some forward declarations drm/amd/display: Add DML2 folder to include path ChunTao Tso (1): drm/amd/display: Amend coasting vtotal for replay low hz Dillon Varone (1): drm/amd/display: Init DPPCLK from SMU on dcn32 George Shen (1): drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split Josip Pavic (1): drm/amd/display: Allow dirty rects to be sent to dmub when abm is active Muhammad Ahmed (2): drm/amd/display: Add debug key to allow disabling dtbclk drm/amd/display: Set the power_down_on_boot function pointer to null Nicholas Kazlauskas (6): drm/amd/display: Add debug prints for IPS testing drm/amd/display: Exit idle optimizations before HDCP execution drm/amd/display: Fix idle check for shared firmware state drm/amd/display: Add guards for idle on reg read/write drm/amd/display: Guard cursor idle reallow by DC debug option drm/amd/display: Add debug counters to IPS exit prints Revalla Hari Krishna (1): drm/amd/display: Refactor DPP into a component directory Robin Chen (1): drm/amd/display: Support long vblank feature Rodrigo Siqueira (2): drm/amd/display: Return the correct HDCP error code drm/amd/display: Add comments to v_total calculation and drop legacy TODO Roman Li (1): drm/amd/display: Fix function banner for amdgpu_dm_psr_disable_all() Ryan Lin (1): drm/amd/display: Add monitor patch for specific eDP Sohaib Nadeem (1): drm/amd/display: Override min required DCFCLK in dml1_validate Swapnil Patel (1): drm/amd/display: Change default size for dummy plane in DML2 Wenjing Liu (4): drm/amd/display: Update odm when ODM combine is changed on an otg master pipe with no plane drm/amd/display: Implement update_planes_and_stream_v3 sequence drm/amd/display: Lock all enabled otg pipes even with no planes drm/amd/display: Implement wait_for_odm_update_pending_complete Xi Liu (1): drm/amd/display: Set DCN351 BB and IP the same as DCN35 drivers/gpu/drm/amd/display/Makefile | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
RE: [PATCH 00/17] DC Patches February 14, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 030c6867a687 drm/amd/display: 3.2.272) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Wednesday, February 14, 2024 1:39 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/17] DC Patches February 14, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Re-enable windowed MPO support for DCN32/321. - Improvements in the subvp feature. - Code clean-up. - USB4 fixes. Cc: Daniel Wheeler Thanks Siqueira Alvin Lee (2): drm/amd/display: Generalize new minimal transition path drm/amd/display: Remove pixle rate limit for subvp Aric Cyr (2): drm/amd/display: Fix nanosec stat overflow drm/amd/display: 3.2.273 Ethan Bitnun (1): drm/amd/display: Only log during optimize_bandwidth call George Shen (1): drm/amd/display: Check DP Alt mode DPCS state via DMUB Lewis Huang (1): drm/amd/display: Only allow dig mapping to pwrseq in new asic Nicholas Kazlauskas (1): drm/amd/display: Fix S4 hang polling on HW power up done for VBIOS DMCUB Rodrigo Siqueira (6): drm/amd/display: Remove break after return drm/amd/display: Initialize variable with default value drm/amd/display: Remove unused file drm/amd/display: Add SMU timeout check and retry drm/amd/display: Remove redundant FPU guard drm/amd/display: Drop unnecessary header Swapnil Patel (1): drm/amd/display: fix input states translation error for dcn35 & dcn351 Wayne Lin (1): drm/amd/display: adjust few initialization order in dm Wenjing Liu (1): drm/amd/display: reenable windowed mpo odm support on dcn32 and dcn321 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 37 +++-- .../gpu/drm/amd/display/dc/basics/dce_calcs.c | 2 - .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 3 - .../display/dc/clk_mgr/dce100/dce_clk_mgr.c | 2 +- .../display/dc/clk_mgr/dcn10/rv1_clk_mgr.c| 2 - .../dc/clk_mgr/dcn10/rv1_clk_mgr_clk.c| 79 -- .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 11 +- .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 6 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 146 +++--- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- .../drm/amd/display/dc/dce/dce_panel_cntl.c | 1 + .../amd/display/dc/dcn301/dcn301_panel_cntl.c | 1 + .../amd/display/dc/dcn31/dcn31_panel_cntl.c | 18 ++- .../display/dc/dcn32/dcn32_dio_link_encoder.c | 85 +++--- .../display/dc/dcn32/dcn32_dio_link_encoder.h | 5 + .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 1 - .../display/dc/dml2/dml2_translation_helper.c | 9 +- .../gpu/drm/amd/display/dc/hdcp/hdcp_msg.c| 2 - .../gpu/drm/amd/display/dc/inc/core_types.h | 31 ++-- .../drm/amd/display/dc/inc/hw/panel_cntl.h| 2 +- .../display/dc/irq/dcn20/irq_service_dcn20.c | 2 - .../display/dc/irq/dcn21/irq_service_dcn21.c | 2 - .../drm/amd/display/dc/link/link_factory.c| 26 +--- .../dc/resource/dcn20/dcn20_resource.c| 2 - ..
RE: [PATCH 00/15] DC Patches for 12 Feb 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - f1e799c39016 drm/amdgpu: Avoid fetching VRAM vendor info) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com public mailing list to update community on promotion details. -Original Message- From: Aurabindo Pillai Sent: Wednesday, February 7, 2024 3:51 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/15] DC Patches for 12 Feb 2024 Summary: * Revert some changes related to pixel encoding and clocks that cause corruption * IPS hang fix and FGCG enable by default for DCN35 * PSR-SU/Replay fixes * Plane clip size change treated as medium update * Fix for checking link alignment done during link training. * HDMI compliance test fixes and other improvements Cc: Daniel Wheeler Aric Cyr (1): drm/amd/display: 3.2.272 Charlene Liu (2): drm/amd/display: enable fgcg by default drm/amd/display: allow psr-su/replay for z8 Gabe Teeger (1): Revert "drm/amd/display: Send DTBCLK disable message on first commit" George Shen (1): Revert "drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split" Martin Tsai (1): drm/amd/display: should support dmub hw lock on Replay Michael Strauss (1): drm/amd/display: Update FIXED_VS Retimer HWSS Test Pattern Sequences Nicholas Kazlauskas (2): drm/amd/display: Add shared firmware state for DMUB IPS handshake drm/amd/display: Increase ips2_eval delay for DCN35 Roman Li (1): drm/amd/display: Fix array-index-out-of-bounds in dcn35_clkmgr Sohaib Nadeem (2): Revert "drm/amd/display: increased min_dcfclk_mhz and min_fclk_mhz" drm/amd/display: fixed integer types and null check locations Tom Chung (1): drm/amd/display: Preserve original aspect ratio in create stream Wenjing Liu (1): drm/amd/display: treat plane clip size change as MED update type Zhikai Zhai (1): drm/amd/display: Add align done check .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +- .../drm/amd/display/dc/bios/bios_parser2.c| 16 ++- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 16 ++- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 12 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 37 -- drivers/gpu/drm/amd/display/dc/dc.h | 15 ++- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 83 +++-- .../drm/amd/display/dc/dce/dmub_hw_lock_mgr.c | 4 + .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 2 +- .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 8 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 9 +- .../gpu/drm/amd/display/dc/inc/core_types.h | 2 - drivers/gpu/drm/amd/display/dc/inc/resource.h | 4 - .../display/dc/link/accessories/link_dp_cts.c | 27 ++-- .../hwss/link_hwss_dio_fixed_vs_pe_retimer.c | 16 +-- .../link_hwss_hpo_fixed_vs_pe_retimer_dp.c| 51 .../drm/amd/display/dc/link/link_validation.c | 2 +- .../display/dc/link/protocols/link_dp_phy.c | 6 +- .../dc/link/protocols/link_dp_training.c | 5 +- .../dc/r
RE: [PATCH 00/21] DC Patches January 31, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 0b48b36f80b0 -> drm/amdgpu: Need to resume ras during gpu reset for gfx v9_4_3 sriov) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: Wednesday, January 31, 2024 3:11 PM To: amd-gfx@lists.freedesktop.org Cc: Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Li, Roman ; Zuo, Jerry ; Pillai, Aurabindo ; Wu, Hersen ; Mahfooz, Hamza ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin Subject: [PATCH 00/21] DC Patches January 31, 2024 This version brings along the following: * DCN35 fixes * DMUB fixes * Link training fixes * Misc code style fixes * MST fixes * ODM fixes * SubVP fixes Allen Pan (1): drm/amd/display: correct static screen event mask Alvin Lee (2): Revert "drm/amd/display: For FPO and SubVP/DRR configs program vmin/max sel" drm/amd/display: Update phantom pipe enable / disable sequence Aric Cyr (1): drm/amd/display: 3.2.271 Camille Cho (1): drm/amd/display: correct comment in set_default_brightness_aux() Ethan Bitnun (2): drm/amd/display: Add delay before logging clks from hw drm/amd/display: Adjust set_p_state calls to fix logging Fangzhi Zuo (1): drm/amd/display: Fix MST Null Ptr for RV George Shen (2): drm/amd/display: Add debug option to force 1-tap chroma subsampling drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split Michael Strauss (2): drm/amd/display: Remove Legacy FIXED_VS Transparent LT Sequence drm/amd/display: Don't perform rate toggle on DP2-capable FIXED_VS retimers Nicholas Kazlauskas (4): drm/amd/display: Add more checks for exiting idle in DC drm/amd/display: Disable timeout in more places for dc_dmub_srv drm/amd/display: Increase eval/entry delay for DCN35 drm/amd/display: Disable idle reallow as part of command/gpint execution Rodrigo Siqueira (4): drm/amd/display: Drop legacy code drm/amd/display: Disable ODM by default for DCN35 drm/amd/display: Trivial code style adjustment drm/amd/display: Drop some unnecessary guards Wenjing Liu (1): drm/amd/display: set odm_combine_policy based on context in dcn32 resource .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 - .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 4 - .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 4 - .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 4 - .../display/dc/clk_mgr/dcn314/dcn314_smu.c| 6 - .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 4 - .../display/dc/clk_mgr/dcn316/dcn316_smu.c| 4 - .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 + .../dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.h | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 115 +++--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 68 ++-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 18 + .../gpu/drm/amd/display/dc/core/dc_surface.c | 2 + drivers/gpu/drm/amd/display/dc/dc.h | 9 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 17 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 2 - drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 + .../gpu/drm/amd/display/dc/dcn10/dcn10_opp.c | 7 +
RE: [PATCH 00/22] DC Patches Jan 29 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - dbed0943b062d0837668fef7ad4af18639e9b241 -> drm/amdgpu: Show vram vendor only if available) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Tom Chung Sent: Wednesday, January 24, 2024 2:02 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/22] DC Patches Jan 29 2024 This DC patchset brings improvements in multiple areas. In summary, we have: - Add control flag for IPS residency profiling - Populate invalid split index to be 0xF - Fix dcn35 8k30 Underflow/Corruption Issue - Fix DP audio settings - Use correct phantom pipe when populating subvp pipe info - Fix incorrect mpc_combine array size - Fix DPSTREAM CLK on and off sequence - Fix USB-C flag update after enc10 feature init - Add debugfs disallow edp psr - Unify optimize_required flags and VRR adjustments - Increased min_dcfclk_mhz and min_fclk_mhz - Fix static screen event mask definition change Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: For FPO and SubVP/DRR configs program vmin/max sel drm/amd/display: Populate invalid split index to be 0xF Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.202.0 Aric Cyr (2): drm/amd/display: Unify optimize_required flags and VRR adjustments drm/amd/display: 3.2.270 Charlene Liu (3): Revert "drm/amd/display: initialize all the dpm level's stutter latency" drm/amd/display: fix USB-C flag update after enc10 feature init drm/amd/display: fix DP audio settings Dmytro Laktyushkin (1): drm/amd/display: Fix DPSTREAM CLK on and off sequence Eric Yang (1): drm/amd/display: fix invalid reg access on DCN35 FPGA Fangzhi Zuo (1): drm/amd/display: Fix dcn35 8k30 Underflow/Corruption Issue Fudongwang (1): drm/amd/display: refine code for dmcub inbox1 ring buffer debug Hersen Wu (1): drm/amd/display: add debugfs disallow edp psr Mounika Adhuri (1): drm/amd/display: clkmgr unittest with removal of warn & rename DCN35 ips handshake for idle Nicholas Kazlauskas (2): drm/amd/display: Wait before sending idle allow and after idle disallow drm/amd/display: Wait for mailbox ready when powering up DMCUB Nicholas Susanto (1): drm/amd/display: Underflow workaround by increasing SR exit latency Sohaib Nadeem (1): drm/amd/display: increased min_dcfclk_mhz and min_fclk_mhz Taimur Hassan (1): drm/amd/display: Send DTBCLK disable message on first commit Wenjing Liu (2): drm/amd/display: fix incorrect mpc_combine array size drm/amd/display: use correct phantom pipe when populating subvp pipe info Yiling Chen (1): drm/amd/display: Fix static screen event mask definition change .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 7 ++- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 53 +++ .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 53 ++- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 15 ++ drivers/gpu/drm/amd/display/dc/co
RE: [PATCH 00/12] DC Patches January 18, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 00263633aa58 drm/amd/display: Fix timing bandwidth calculation for HDMI) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of roman...@amd.com Sent: Thursday, January 18, 2024 9:34 AM To: amd-gfx@lists.freedesktop.org Cc: Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Li, Roman ; Zuo, Jerry ; Pillai, Aurabindo ; Wu, Hersen ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin Subject: [PATCH 00/12] DC Patches January 18, 2024 From: Roman Li This DC patchset brings improvements in multiple areas. In summary, we highlight: * Add power_state/pme_pending flag/usb4_bw_alloc_support flags * Add GART memory support * Improvements for HDMI, IPS, DML2 and others Allen Pan (1): drm/amd/display: Add NULL-checks in dml2 assigned pipe search Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.201.0 Aric Cyr (2): drm/amd/display: Promote DAL to 3.2.268 drm/amd/display: Promote DAL to 3.2.269 Charlene Liu (1): drm/amd/display: Revert "Rework DC Z10 restore" ChunTao Tso (1): drm/amd/display: Replay + IPS + ABM in Full Screen VPB Fudongwang (1): drm/amd/display: Add GART memory support for dmcub Leo (Hanghong) Ma (1): drm/amd/display: Fix timing bandwidth calculation for HDMI Muhammad Ahmed (1): drm/amd/display: add power_state and pme_pending flag Peichen Huang (1): drm/amd/display: Add usb4_bw_alloc_support flag Roman Li (1): drm/amd/display: Add IPS checks before dcn register access Wenjing Liu (1): drm/amd/display: turn off windowed Mpo ODM feature for dcn321 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++-- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 9 +- drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 1 + drivers/gpu/drm/amd/display/dc/dc_types.h | 5 + .../display/dc/dml2/dml2_dc_resource_mgmt.c | 19 ++-- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 5 + .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 2 + .../amd/display/dc/inc/hw/clk_mgr_internal.h | 1 + .../drm/amd/display/dc/link/link_detection.c | 18 +++ .../gpu/drm/amd/display/dc/link/link_dpms.c | 58 ++ .../dc/resource/dcn321/dcn321_resource.c | 1 + drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 19 +++- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 59 -- .../gpu/drm/amd/display/dmub/src/dmub_srv.c | 106 -- .../amd/display/modules/power/power_helpers.c | 5 + .../amd/display/modules/power/power_helpers.h | 1 + 18 files changed, 244 insertions(+), 109 deletions(-) -- 2.34.1
RE: [PATCH 00/19] DC Patches January 10, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - b2db1b01c3ec drm/amdgpu: update regGL2C_CTRL4 value in golden setting) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Hung, Alex Sent: Wednesday, January 10, 2024 4:53 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; stylon.w...@amd.com; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Hung, Alex ; Wheeler, Daniel Subject: [PATCH 00/19] DC Patches January 10, 2024 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes on DCN35 and DML2. * Enhancements in DMUB. * Improvements on IPS, DP and MPO and others. Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: Add Replay IPS register for DMUB command table drm/amd/display: Ensure populate uclk in bb construction Charlene Liu (2): drm/amd/display: Add logging resource checks drm/amd/display: Update P010 scaling cap Dillon Varone (1): drm/amd/display: Init link enc resources in dc_state only if res_pool presents Dmytro Laktyushkin (1): drm/amd/display: Fix dml2 assigned pipe search George Shen (1): drm/amd/display: Add DP audio BW validation Ilya Bakoulin (1): drm/amd/display: Clear OPTC mem select on disable Martin Leung (1): drm/amd/display: 3.2.267 Nicholas Kazlauskas (5): drm/amd/display: Allow IPS2 during Replay drm/amd/display: Port DENTIST hang and TDR fixes to OTG disable W/A drm/amd/display: Rework DC Z10 restore drm/amd/display: Set default Z8 minimum residency for DCN35 drm/amd/display: Allow Z8 for multiplane configurations on DCN35 Ovidiu Bunea (1): drm/amd/display: Fix DML2 watermark calculation Tom Chung (1): drm/amd/display: Enable Panel Replay for static screen use case Wayne Lin (1): drm/amd/display: Align the returned error code with legacy DP Wenjing Liu (2): drm/amd/display: Floor to mhz when requesting dpp disp clock changes to SMU drm/amd/display: Reenable windowed mpo odm support .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 44 ++- .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 59 +++- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 5 + .../amd/display/amdgpu_dm/amdgpu_dm_replay.c | 119 +--- .../amd/display/amdgpu_dm/amdgpu_dm_replay.h | 4 +- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 21 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 40 ++- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 25 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 4 + .../gpu/drm/amd/display/dc/core/dc_state.c| 8 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 9 +- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- .../gpu/drm/amd/display/dc/dce/dce_audio.c| 288 +- .../gpu/drm/amd/display/dc/dce/dce_audio.h| 3 +- .../dc/dml/dcn30/display_mode_vba_30.c| 16 +- .../amd/display/dc/dml/dcn303/dcn303_fpu.c| 11 + .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 4 +- .../amd/display/dc/dml2/display_mode_core.c | 14 +- .../display/dc/dml2/dml2_dc_resource_mgmt.c | 36 ++- .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 56 +++- .../amd/display/dc/hwss
RE: [PATCH 00/10] DC Patches Jan 04, 2024
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - bf901afac5d5 drm/amdkfd: Fix type of 'dbg_flags' in 'struct kfd_process') with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma (Version 5.24.7) and Gnome (Version 42.9). Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Thursday, January 4, 2024 10:51 AM To: amd-gfx@lists.freedesktop.org Cc: Wheeler, Daniel ; Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza Subject: [PATCH 00/10] DC Patches Jan 04, 2024 This DC patchset brings improvements in multiple areas. In summary, we have: - Improve z8/z10 support - Revert some of the VRR optimization - Improve usb4 when using MST Thanks Siqueira Cc: Daniel Wheeler Aric Cyr (1): drm/amd/display: 3.2.266 Charlene Liu (2): drm/amd/display: allow z8/z10 from driver drm/amd/display: Update z8 latency Daniel Miess (1): Revert "drm/amd/display: Fix conversions between bytes and KB" George Shen (1): drm/amd/display: Disconnect phantom pipe OPP from OPTC being disabled Martin Leung (2): drm/amd/display: revert "for FPO & SubVP/DRR config program vmin/max" drm/amd/display: revert "Optimize VRR updates to only necessary ones" Martin Tsai (1): drm/amd/display: To adjust dprefclk by down spread percentage Meenakshikumar Somasundaram (1): drm/amd/display: Dpia hpd status not in sync after S4 Peichen Huang (1): drm/amd/display: Request usb4 bw for mst streams .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 71 ++- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.h| 11 +++ drivers/gpu/drm/amd/display/dc/core/dc.c | 14 ++-- .../gpu/drm/amd/display/dc/core/dc_resource.c | 14 drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 + drivers/gpu/drm/amd/display/dc/dc_types.h | 12 ++-- .../gpu/drm/amd/display/dc/dce/dce_audio.c| 2 +- .../drm/amd/display/dc/dce/dce_clock_source.c | 9 ++- .../display/dc/dcn32/dcn32_resource_helpers.c | 14 .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 11 ++- .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 6 +- .../amd/display/dc/dml2/display_mode_core.c | 18 ++--- .../drm/amd/display/dc/dml2/dml2_wrapper.c| 2 + .../amd/display/dc/hwss/dce110/dce110_hwseq.c | 2 +- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 45 ++-- .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h | 1 + drivers/gpu/drm/amd/display/dc/inc/resource.h | 3 - .../gpu/drm/amd/display/dc/link/link_dpms.c | 42 --- .../drm/amd/display/dc/link/link_validation.c | 60 +--- .../display/dc/link/protocols/link_dp_dpia.c | 36 ++ .../dc/link/protocols/link_dp_dpia_bw.c | 59 +++ .../dc/link/protocols/link_dp_dpia_bw.h | 9 +++ .../amd/display/dc/optc/dcn32/dcn32_optc.c| 19 +++-- .../amd/display/dc/optc/dcn35/dcn35_optc.c| 12 ++-- .../dc/resource/dcn32/dcn32_resource.c| 2 +- .../dc/resource/dcn32/dcn32_resource.h| 3 + .../dc/resource/dcn321/dcn321_resource.c | 2 +- .../gpu/drm/amd/display/include/audio_types.h | 2 +- 30 fil
RE: [PATCH 00/20] DC Patches December 20, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 97221259f157 drm/amd/display: 3.2.265) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you and happy holidays, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Wednesday, December 20, 2023 11:34 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/20] DC Patches December 20, 2023 Here we are at the end of the year, the last set of patches for DC. This DC patch set brings improvements in multiple areas. In summary, we highlight: * Address SubVP issues * Update DMUB * Improve mechanisms for test Thanks Siqueira Cc: Daniel Wheeler Alvin Lee (4): drm/amd/display: Fix subvp+drr logic errors drm/amd/display: Don't allow FPO if no planes drm/amd/display: Assign stream status for FPO + Vactive cases drm/amd/display: For FPO and SubVP/DRR configs program vmin/max sel Camille Cho (1): drm/amd/display: Correctly restore user_level Gabe Teeger (1): drm/amd/display: Fix Mismatch between pipe and stream Josip Pavic (1): drm/amd/display: Add null pointer guards where needed Leo (Hanghong) Ma (1): drm/amd/display: Add HDMI capacity computations using fixed31_32 Meenakshikumar Somasundaram (2): drm/amd/display: Fix minor issues in BW Allocation Phase2 drm/amd/display: Add dpia display mode validation logic Nicholas Kazlauskas (4): drm/amd/display: Always exit DMCUB idle when called drm/amd/display: Wait forever for DMCUB to wake up drm/amd/display: Switch DMCUB notify idle command to NO_WAIT drm/amd/display: Verify disallow bits were cleared for idle Relja Vojvodic (3): drm/amd/display: Add more mechanisms for tests drm/amd/display: Add log end specifier drm/amd/display: Fixing stream allocation regression Revalla (1): drm/amd/display: Refactor INIT into component folder Tom Chung (1): drm/amd/display: Add some functions for Panel Replay Wayne Lin (1): drm/amd/display: pbn_div need be updated for hotplug event .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/amd/display/dc/Makefile | 2 - .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 90 - drivers/gpu/drm/amd/display/dc/core/dc.c | 76 +++- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 172 + .../drm/amd/display/dc/core/dc_link_exports.c | 9 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 17 + .../gpu/drm/amd/display/dc/core/dc_stream.c | 3 +- drivers/gpu/drm/amd/display/dc/dc.h | 29 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 32 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 6 + drivers/gpu/drm/amd/display/dc/dc_types.h | 2 + drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 4 +- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 4 +- .../gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c | 4 +- .../gpu/drm/amd/display/dc/dce/dmub_abm_lcd.h | 2 +- .../gpu/drm/amd/display/dc/dce/dmub_replay.c | 96 - .../gpu/drm/amd/display/dc/dce/dmub_replay.h | 2 + drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/dcn20/Makefile | 2 +- .../gpu/drm/amd
RE: [PATCH 00/25] DC Patches for Dec 18, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - cf25f7abf109 drm/amdgpu: xgmi_fill_topology_info) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Wayne Lin Sent: Wednesday, December 13, 2023 1:12 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Lin, Wayne ; Wheeler, Daniel Subject: [PATCH 00/25] DC Patches for Dec 18, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - change static screen wait frame_count for ips - Fix hang/underflow when transitioning to ODM4:1 - Only clear symclk otg flag for HDMI - Fix lightup regression with DP2 single display configs - Refactor phantom resource allocation - Refactor dc_state interface - Wake DMCUB before executing GPINT commands - Wake DMCUB before sending a command - Refactor DMCUB enter/exit idle interface - enable dcn35 idle power optimization - fix usb-c connector_type - add debug option for ExtendedVBlank DLG adjust - Set test_pattern_changed update flag on pipe enable - dereference variable before checking for zero - get dprefclk ss info from integration info table - skip error logging when DMUB is inactive from S3 - make flip_timestamp_in_us a 64-bit variable - Add case for dcn35 to support usb4 dmub hpd event - Add function for dumping clk registers - Unify optimize_required flags and VRR adjustments - Revert using channel_width as 2 for vram table 3.0 - remove HPO PG in driver side - do not send commands to DMUB if DMUB is inactive from S3 Cc: Daniel Wheeler --- Allen Pan (2): drm/amd/display: fix usb-c connector_type drm/amd/display: change static screen wait frame_count for ips Alvin Lee (2): drm/amd/display: Revert " drm/amd/display: Use channel_width = 2 for vram table 3.0" drm/amd/display: Only clear symclk otg flag for HDMI Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.197.0 Aric Cyr (2): drm/amd/display: Unify optimize_required flags and VRR adjustments drm/amd/display: 3.2.265 Charlene Liu (1): drm/amd/display: get dprefclk ss info from integration info table Dillon Varone (2): drm/amd/display: Refactor dc_state interface drm/amd/display: Refactor phantom resource allocation George Shen (1): drm/amd/display: Set test_pattern_changed update flag on pipe enable Ilya Bakoulin (1): drm/amd/display: Fix hang/underflow when transitioning to ODM4:1 Johnson Chen (1): drm/amd/display: Add function for dumping clk registers Josip Pavic (2): drm/amd/display: make flip_timestamp_in_us a 64-bit variable drm/amd/display: dereference variable before checking for zero Michael Strauss (1): drm/amd/display: Fix lightup regression with DP2 single display configs Muhammad Ahmed (2): drm/amd/display: remove HPO PG in driver side drm/amd/display: add debug option for ExtendedVBlank DLG adjust Nicholas Kazlauskas (3): drm/amd/display: Refactor DMCUB enter/exit idle interface drm/amd/display: Wake DMCUB before sending a command drm/amd/display: Wake DMCUB before executing GPINT commands Roman Li (1): drm/amd/display: enable dcn35 idle power optimization Sam
RE: [PATCH 00/13] DC Patches for Dec 11, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 93de84df60bc71c5f0d95de84a71eb119b51afe1 -> drm/amdgpu: optimize the printing order of error data) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Aurabindo Pillai Sent: Wednesday, December 6, 2023 2:52 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 00/13] DC Patches for Dec 11, 2023 This DC patchset brings improvements in multiple areas. In summary, we have: Bug fixes for: * DCN35 power gating * P-state change, & prefetch logic * ABM * DP 2.1 Cc: Daniel Wheeler === Allen (1): drm/amd/display: Disable OPTC pg to match DC Hubp/dpp pg Alvin Lee (2): drm/amd/display: For prefetch mode > 0, extend prefetch if possible drm/amd/display: Force p-state disallow if leaving no plane config Aric Cyr (1): drm/amd/display: 3.2.264 Aurabindo Pillai (2): drm/amd/display: Use explicit size for types in DCCG's struct dp_dto_params drm/amd/display: trivial comment change Charlene Liu (1): drm/amd/display: fix HW block PG sequence Fangzhi Zuo (1): drm/amd/display: Populate dtbclk from bounding box Joshua Aberback (1): drm/amd/display: Remove minor revision 5 until proper parser is ready Michael Strauss (1): drm/amd/display: Revert DP2 MST hub triple display fix Ran Shi (1): drm/amd/display: allow DP40 cables to do UHBR13.5 Sung Joon Kim (1): drm/amd/display: Exit from idle state before accessing HW data Taimur Hassan (1): drm/amd/display: Revert "Fix conversions between bytes and KB" .../drm/amd/display/dc/bios/bios_parser2.c| 2 - .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 4 + .../gpu/drm/amd/display/dc/dcn35/dcn35_init.c | 3 +- .../dc/dml/dcn32/display_mode_vba_32.c| 3 + .../dc/dml/dcn32/display_mode_vba_util_32.c | 33 - .../dc/dml/dcn32/display_mode_vba_util_32.h | 1 + .../drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 14 +- .../amd/display/dc/dml2/display_mode_core.c | 16 +-- .../display/dc/dml2/dml2_translation_helper.c | 5 +- .../gpu/drm/amd/display/dc/dml2/dml2_utils.c | 7 - .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 20 +++ .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 134 +- .../amd/display/dc/hwss/dcn35/dcn35_hwseq.h | 6 +- .../drm/amd/display/dc/hwss/hw_sequencer.h| 6 +- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 4 +- .../dc/link/protocols/link_dp_capability.c| 14 +- .../dc/resource/dcn35/dcn35_resource.c| 1 + 19 files changed, 195 insertions(+), 82 deletions(-) -- 2.39.2
RE: [PATCH 00/47] DC Patches December 1, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 135b1ad12685 drm/amd/display: Promote DAL to 3.2.262) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Friday, December 1, 2023 8:25 AM To: amd-gfx@lists.freedesktop.org Cc: Wheeler, Daniel ; Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Lillian ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza Subject: [PATCH 00/47] DC Patches December 1, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Enable writeback. * Add multiple fixes for DML2 and DCN35. * Introduce small code style adjustments. Cc: Daniel Wheeler Thanks Siqueira Alex Hung (12): drm/amd/display: Avoid virtual stream encoder if not explicitly requested drm/amd/display: Initialize writeback connector drm/amd/display: Check writeback connectors in create_validate_stream_for_sink drm/amd/display: Hande writeback request from userspace drm/amd/display: Add writeback enable/disable in dc drm/amd/display: Fix writeback_info never got updated drm/amd/display: Validate hw_points_num before using it drm/amd/display: Fix writeback_info is not removed drm/amd/display: Add writeback enable field (wb_enabled) drm/amd/display: Setup for mmhubbub3_warmup_mcif with big buffer drm/amd/display: Add new set_fc_enable to struct dwbc_funcs drm/amd/display: Disable DWB frame capture to emulate oneshot Alvin Lee (2): drm/amd/display: Optimize fast validation cases drm/amd/display: Use channel_width = 2 for vram table 3.0 Aric Cyr (1): drm/amd/display: 3.2.263 Charlene Liu (4): drm/amd/display: initialize all the dpm level's stutter latency drm/amd/display: insert drv-pmfw log + rollback to new context drm/amd/display: revert removing otg toggle w/a back when no active display drm/amd/display: keep domain24 power on if eDP not exist Chris Park (1): drm/amd/display: Update BIOS FW info table revision Daniel Miess (1): drm/amd/display: Add missing dcn35 RCO registers Dennis Chan (1): drm/amd/display: Fix Replay Desync Error IRQ handler Dillon Varone (1): drm/amd/display: Add dml2 copy functions George Shen (1): drm/amd/display: Skip DPIA-specific DP LL automation flag for non-DPIA links Harry Wentland (7): drm/amd/display: Skip entire amdgpu_dm build if !CONFIG_DRM_AMD_DC drm/amd/display: Create one virtual connector in DC drm/amd/display: Skip writeback connector when we get amdgpu_dm_connector drm/amd/display: Return drm_connector from find_first_crtc_matching_connector drm/amd/display: Use drm_connector in create_stream_for_sink drm/amd/display: Create amdgpu_dm_wb_connector drm/amd/display: Create fake sink and stream for writeback connector Ilya Bakoulin (1): drm/amd/display: Fix MST PBN/X.Y value calculations Ivan Lipski (1): drm/amd/display: Add monitor patch for specific eDP Johnson Chen (1): drm/amd/display: Fix null pointer Josip Pavic (1): drm/amd/display: Increase scratch buffer size Krunoslav Kovac (1): drm/amd/display: Change dither policy for 10bpc to round Lewis Huang (1): drm/amd/display: Pass pwrseq inst
RE: [PATCH 0/7] DC Patches Nov 20 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - d1619cb96246076df2a5b4a10055c51836584001 drm/amd/display: 3.2.261) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Tom Chung Sent: Wednesday, November 22, 2023 1:59 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Wheeler, Daniel Subject: [PATCH 0/7] DC Patches Nov 20 2023 This DC patchset brings improvements in multiple areas. In summary, we have: - Add DSC granular throughput adjustment - Allow DTBCLK disable for DCN35 - Update Fixed VS/PE Retimer Sequence - Block dcn315 dynamic crb allocation when unintended - Update dcn315 lpddr pstate latency Cc: Daniel Wheeler Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.194.0 Aric Cyr (1): drm/amd/display: Promote DAL to 3.2.262 Dmytro Laktyushkin (2): drm/amd/display: update dcn315 lpddr pstate latency drm/amd/display: block dcn315 dynamic crb allocation when unintended Ilya Bakoulin (1): drm/amd/display: Add DSC granular throughput adjustment Michael Strauss (1): drm/amd/display: Update Fixed VS/PE Retimer Sequence Nicholas Kazlauskas (1): drm/amd/display: Allow DTBCLK disable for DCN35 .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 8 +++--- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 27 +-- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 10 +-- .../link_dp_training_fixed_vs_pe_retimer.c| 10 +++ .../dc/resource/dcn315/dcn315_resource.c | 6 +++-- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +++ 7 files changed, 43 insertions(+), 24 deletions(-) -- 2.25.1
RE: [PATCH 00/35] DC Patches November 15, 2023
[Public] Hi all, This week this patchset was tested on the following systems: • Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U • MSI Gaming X Trio RX 6800 • Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: • eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) • VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) • DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) • Thunderbolt (LG Ultrafine 5k) • MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) • DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) • USB 4 (Kensington SD5700T and 1x 4k 60Hz display) • PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): • Changing display configurations and settings • Benchmark testing • Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): • Script testing (scripts to automate some of the manual checks) • IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit 2ca13e7462d5 drm/amd/display: Promote DC to 3.2.260) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: Wednesday, November 15, 2023 2:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Li, Roman ; Zuo, Jerry ; Pillai, Aurabindo ; Wu, Hersen ; Mahfooz, Hamza ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin Subject: [PATCH 00/35] DC Patches November 15, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: * DCN314 fixes * DCN32 fixes * DCN35 fixes * DML2 fixes * eDP fixes * HDR fixes * MST fixes * Replay fixes * SubVP support for more configs Alvin Lee (5): drm/amd/display: Include udelay when waiting for INBOX0 ACK drm/amd/display: Use DRAM speed from validation for dummy p-state drm/amd/display: Increase num voltage states to 40 drm/amd/display: Enable SubVP on 1080p60 displays drm/amd/display: If P-State is supported try SubVP for smaller vlevel Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.193.0 Aric Cyr (1): drm/amd/display: 3.2.261 Bhuvana Chandra Pinninti (1): drm/amd/display: Refactor DSC into component folder Camille Cho (1): drm/amd/display: Simplify brightness initialization Dennis Chan (2): drm/amd/display: Add new Replay command and Disabled Replay Timing Reysnc drm/amd/display: Disable Timing sync check in Full-Screen Video Case Gabe Teeger (1): Revert "drm/amd/display: Enable CM low mem power optimization" Ian Chen (1): drm/amd/display: add skip_implict_edp_power_control flag for dce110 Ilya Bakoulin (1): drm/amd/display: Fix MPCC 1DLUT programming Max Tseng (2): drm/amd/display: replay: generalize the send command function usage drm/amd/display: replay: Augment Frameupdate Command Meenakshikumar Somasundaram (1): drm/amd/display: Fix tiled display misalignment Michael Strauss (1): drm/amd/display: Do not read DPREFCLK spread info from LUT on DCN35 Nicholas Kazlauskas (7): drm/amd/display: Add z-state support policy for dcn35 drm/amd/display: Update DCN35 watermarks drm/amd/display: Add Z8 watermarks for DML2 bbox overrides drm/amd/display: Feed SR and Z8 watermarks into DML2 for DCN35 drm/amd/display: Remove min_dst_y_next_start check for Z8 drm/amd/display: Update min Z8 residency time to 2100 for DCN314 drm/amd/display: Update DCN35 clock table policy Parandhaman K (1): drm/amd/display: Refactor OPTC into component folder Sung Joon Kim (1): drm/amd/display: Fix black screen on video playback with embedded panel Taimur Hassan (3): drm/amd/display: Remove config update drm/amd/display: Fix conversions between bytes and KB drm/amd/display: Fix some HostVM parameters in DML Wayne Lin (1): drm/amd/display: adjust flow for deallocation mst payload Wenjing Liu (3): drm/amd/display: fix a pipe mapping error in dcn32_fpu drm/amd/display: update pixel clock params after stream slice count change in context drm/amd/display: always use mpc factor of 2 for stereo timings Zhongwei (1): drm/amd/display: force toggle rate wa for first link training for a retimer
RE: [PATCH 00/20] DC Patches Nov 08, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 7bb6e298b738 drm/amdkfd: Move TLB flushing logic into amdgpu) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Hung, Alex Sent: Wednesday, November 8, 2023 1:44 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Hung, Alex ; Wheeler, Daniel Subject: [PATCH 00/20] DC Patches Nov 08, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Add missing chips for HDCP * Add new command to disable replay timing resync * Fix encoder disable logic * Enable DSC Flag in MST Mode Validation * Change the DMCUB mailbox memory location from FB to inbox * Add disable timeout option * Negate IPS allow and commit bits * Enable DCN clock gating for DCN35 * Prefer currently used OTG master when acquiring free pipe * Try to acquire a free OTG master not used in cur ctx first * Clear dpcd_sink_ext_caps if not set * Enable fast plane updates on DCN3.2 and above * Add null checks for 8K60 lightup * Refactor resource into component directory * Fix DSC not Enabled on Direct MST Sink * Guard against invalid RPTR/WPTR being set * Enable CM low mem power optimization * Fix a debugfs null pointer error Cc: Daniel Wheeler Anthony Koo (1): drm/amd/display: Add new command to disable replay timing resync Aric Cyr (1): drm/amd/display: Promote DC to 3.2.260 Aurabindo Pillai (1): drm/amd/display: Fix a debugfs null pointer error Daniel Miess (1): drm/amd/display: Enable DCN clock gating for DCN35 Duncan Ma (2): drm/amd/display: Negate IPS allow and commit bits drm/amd/display: Add disable timeout option Fangzhi Zuo (2): drm/amd/display: Fix DSC not Enabled on Direct MST Sink drm/amd/display: Enable DSC Flag in MST Mode Validation Krunoslav Kovac (1): drm/amd/display: Send PQ bit in AMD VSIF Lewis Huang (1): drm/amd/display: Change the DMCUB mailbox memory location from FB to inbox Mounika Adhuri (1): drm/amd/display: Refactor resource into component directory Muhammad Ahmed (1): drm/amd/display: Add null checks for 8K60 lightup Nicholas Kazlauskas (1): drm/amd/display: Guard against invalid RPTR/WPTR being set Nicholas Susanto (1): drm/amd/display: Fix encoder disable logic Paul Hsieh (1): drm/amd/display: Clear dpcd_sink_ext_caps if not set Rodrigo Siqueira (1): drm/amd/display: Add missing chips for HDCP Tianci Yin (1): drm/amd/display: Enable fast plane updates on DCN3.2 and above Wenjing Liu (2): drm/amd/display: Try to acquire a free OTG master not used in cur ctx first drm/amd/display: Prefer currently used OTG master when acquiring free pipe Yihan Zhu (1): drm/amd/display: Enable CM low mem power optimization drivers/gpu/drm/amd/display/Makefile | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 63 +++--- drivers/gpu/drm/amd/display/dc/Makefile | 5 +- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 18 +- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 3
RE: [PATCH 00/12] DC Patches October 30, 2023
[Public] > Hi all, > > This week this patchset was tested on the following systems: > * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U > * MSI Gaming X Trio RX 6800 > * Gigabyte Gaming OC RX 7900 XTX > > These systems were tested on the following display/connection types: > * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 > 120hz[6600U]) > * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) > * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes > USB-C to DP/HDMI adapters]) > * Thunderbolt (LG Ultrafine 5k) > * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) > * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 > displays, and HP Hook G2 with 1 4k60 display) > * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) > * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, > as that is the max the adapter supports]) > > The testing is a mix of automated and manual tests. Manual testing includes > (but is not limited to): > * Changing display configurations and settings > * Benchmark testing > * Feature testing (Freesync, etc.) > > Automated testing includes (but is not limited to): > * Script testing (scripts to automate some of the manual checks) > * IGT testing > > The patchset consists of the amd-staging-drm-next branch (Head commit - > 01d1a1e1dddb drm/amd/display: 3.2.258) with new patches added on top of it. > > Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. > > > Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Hersen Wu Sent: Wednesday, November 1, 2023 4:08 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Li, Roman ; Zuo, Jerry ; Pillai, Aurabindo ; Wu, Hersen ; Lin, Wayne ; Wentland, Harry ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/12] DC Patches October 30, 2023 Title: DC Patches October 30, 2023 Start from: 9379d9fc18582c69862dc25fb770ae2e102f29d6 drm/amd/display: 3.2.258 Stopped at: 0a6aa88e926196036c7cf9edb70924b659461617 drm/amd/display: 3.2.259 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Enable DCN35 physymclk root clock gating - Fix DP automation test pattern bug - Disable OTG for mode switch from TMDS to FRL - Refactor DML2 - Revert Fix handling duplicate planes on one stream - Revert Enable DCN clock gating - Implement cursor P-State allow for SubVP - Save and restore mall state while switching from ODM to Subvp Alvin Lee (1): drm/amd/display: For cursor P-State allow for SubVP Aric Cyr (1): drm/amd/display: Promote DAL to 3.2.259 Chaitanya Dhere (1): drm/amd/display: Remove references to unused dml arch version Daniel Miess (2): drm/amd/display: Revert Enable DCN clock gating drm/amd/display: Enable physymclk RCO George Shen (1): drm/amd/display: Set stream's DP test pattern upon test request Joshua Aberback (1): drm/amd/display: Remove unused duplicate register definition Ovidiu Bunea (1): drm/amd/display: Disable OTG for mode timing switch on DCN35 Rodrigo Siqueira (1): drm/amd/display: Create optc.h file Sung Joon Kim (2): drm/amd/display: Revert Fix handling duplicate planes on one stream drm/amd/display: Fix handling duplicate planes on one stream Wenjing Liu (1): drm/amd/display: save and restore mall state when applying minimal transition .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 + .../amd/display/amdgpu_dm/amdgpu_dm_trace.h | 2 +- .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 20 ++ drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 15 -- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 186 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 6 +- .../gpu/drm/amd/display/dc/dcn35/dcn35_dccg.c | 84 --- .../drm/amd/display/dc/dcn35/dcn35_pg_cntl.c | 10 +- .../drm/amd/display/dc/dcn35/dcn35_pg_cntl.h | 1 + .../drm/amd/display/dc/dcn35/dcn35_resource.c | 22 +- .../display/dc/dml2/dml2_dc_resource_mgmt.c | 16 +- .../amd/display/dc/dml2/dml2_internal_types.h | 1 - .../display/dc/dml2/dml2_translation_helper.c | 40 +--- .../drm/amd/display/dc/hwss/dce/dce_hwseq.h | 18 +- .../amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 17 +- .../amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 33 ++- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 9 +- drivers/gpu/drm/amd/display/dc/inc/hw/optc.h | 219
RE: [PATCH v2 00/24] DC Patches October 18, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 310b5f1a3c9eb1ed96e437ead40f900f3b7bf530 -> drm/amd/display: Revert "drm/amd/display: Use drm_connector in create_validate_stream_for_sink") with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: roman...@amd.com Sent: Thursday, October 19, 2023 9:32 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Kotarac, Pavle ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wu, Hersen ; Zuo, Jerry ; Li, Roman ; Wheeler, Daniel Subject: [PATCH v2 00/24] DC Patches October 18, 2023 From: Roman Li This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fixes null-deref regression after "drm/amd/display: Update OPP counter from new interface" * Fixes display flashing when VSR and HDR enabled on dcn32 * Fixes dcn3x intermittent hangs due to FPO * Fixes MST Multi-Stream light up on dcn35 * Fixes green screen on DCN31x when DVI and HDMI monitors attached * Adds DML2 improvements * Adds idle power optimization improvements * Accommodates panels with lower nit backlight * Updates SDP VSC colorimetry from DP test automation request * Reverts "drm/amd/display: allow edp updates for virtual signal" Cc: Daniel Wheeler Agustin Gutierrez (1): drm/amd/display: Remove power sequencing check Alex Hung (2): drm/amd/display: Revert "drm/amd/display: allow edp updates for virtual signal" drm/amd/display: Set emulated sink type to HDMI accordingly. Alvin Lee (1): drm/amd/display: Update FAMS sequence for DCN30 & DCN32 Aric Cyr (1): drm/amd/display: 3.2.256 Aurabindo Pillai (1): drm/amd/display: add interface to query SubVP status Fangzhi Zuo (1): drm/amd/display: Fix MST Multi-Stream Not Lighting Up on dcn35 George Shen (1): drm/amd/display: Update SDP VSC colorimetry from DP test automation request Hugo Hu (1): drm/amd/display: reprogram det size while seamless boot Ilya Bakoulin (1): drm/amd/display: Fix shaper using bad LUT params Iswara Nagulendran (1): drm/amd/display: Read before writing Backlight Mode Set Register Michael Strauss (1): drm/amd/display: Disable SYMCLK32_SE RCO on DCN314 Nicholas Kazlauskas (2): drm/amd/display: Revert "Improve x86 and dmub ips handshake" drm/amd/display: Fix IPS handshake for idle optimizations Rodrigo Siqueira (3): drm/amd/display: Correct enum typo drm/amd/display: Add prefix to amdgpu crtc functions drm/amd/display: Add prefix for plane functions Samson Tam (2): drm/amd/display: fix num_ways overflow error drm/amd/display: add null check for invalid opps Sung Joon Kim (2): drm/amd/display: Add a check for idle power optimization drm/amd/display: Fix HDMI framepack 3D test issue Swapnil Patel (1): drm/amd/display: Reduce default backlight min from 5 nits to 1 nits Wenjing Liu (2): drm/amd/display: add pipe resource management callbacks to DML2 drm/amd/display: implement map dc pipe with callback in DML2 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +- .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 48 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |
RE: [PATCH] drm/amd/display: Fix DMUB errors introduced by DML2
[Public]
Hi all,
I verified that this fix solved both a GPU init error and a
hubbub2_get_dchub_ref_freq warning when re-enabling the amdgpu module.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook | Twitter | amd.com
-Original Message-
From: Siqueira, Rodrigo
Sent: Friday, October 20, 2023 12:42 PM
To: amd-gfx@lists.freedesktop.org
Cc: Siqueira, Rodrigo ; Prosyak, Vitaly
; Li, Roman ; Zhuo, Lillian
; Wheeler, Daniel ; Deucher,
Alexander
Subject: [PATCH] drm/amd/display: Fix DMUB errors introduced by DML2
When DML 2 was introduced, it changed part of the generic sequence of DC, which
caused issues on previous DCNs with DMUB support. This commit ensures the new
sequence only works for new DCNs from 3.5 and above.
Cc: Vitaly Prosyak
Cc: Roman Li
Cc: Qingqing Zhuo
Cc: Daniel Wheeler
Cc: Alex Deucher
Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
index 97f402123fbb..73cc6e1b0e65 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
@@ -321,10 +321,11 @@ struct resource_pool *dc_create_resource_pool(struct dc
*dc,
res_pool->ref_clocks.xtalin_clock_inKhz;
res_pool->ref_clocks.dchub_ref_clock_inKhz =
res_pool->ref_clocks.xtalin_clock_inKhz;
- if (res_pool->hubbub &&
res_pool->hubbub->funcs->get_dchub_ref_freq)
-
res_pool->hubbub->funcs->get_dchub_ref_freq(res_pool->hubbub,
-
res_pool->ref_clocks.dccg_ref_clock_inKhz,
-
_pool->ref_clocks.dchub_ref_clock_inKhz);
+ if (dc_version >= DCN_VERSION_3_5)
+ if (res_pool->hubbub &&
res_pool->hubbub->funcs->get_dchub_ref_freq)
+
res_pool->hubbub->funcs->get_dchub_ref_freq(res_pool->hubbub,
+
res_pool->ref_clocks.dccg_ref_clock_inKhz,
+
_pool->ref_clocks.dchub_ref_clock_inKhz);
} else
ASSERT_CRITICAL(false);
}
--
2.42.0
RE: [PATCH 00/28] DC Patches September 13, 2020
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - b5ce5056952786df17c852f154c92085ebac76d8 drm/amd/display: add skip_implict_edp_power_control flag for dcn32) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using Gnome for both. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Wednesday, September 13, 2023 10:00 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/28] DC Patches September 13, 2020 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Use optc32 instead of optc30 in DC - Optimize OLED T7 delay - Multiple fixes for MST, register mas, and others - Update driver and IPS interop - Improve z8 watermark mask - DCN35 updates - Enable replay for DCN35 - Temporarily disable clock gating Cc: Daniel Wheeler Thanks Siqueira Agustin Gutierrez (1): drm/amd/display: Optimize OLED T7 delay Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.183.0 Aric Cyr (2): drm/amd/display: 3.2.251 drm/amd/display: 3.2.252 Artem Grishin (1): drm/amd/display: STREAM_MAPPER_CONTROL register offset on DCN35 Charlene Liu (4): drm/amd/display: Temporarily disable clock gating drm/amd/display: Add z8_marks related in dml for DCN35 drm/amd/display: Correct z8 watermark mask drm/amd/display: fix some non-initialized register mask and setting Duncan Ma (2): drm/amd/display: Fix dig register undefined drm/amd/display: Update driver and IPS interop Gabe Teeger (1): drm/amd/display: Add option to flip ODM optimization Muhammad Ahmed (6): drm/amd/display: disable clock gating logic drm/amd/display: Enable DCLK_DS from driver by default drm/amd/display: disable IPS drm/amd/display: Fix MST recognizes connected displays as one drm/amd/display: Expand DML to better support replay drm/amd/display: Enable DCN low mem power by default Mustapha Ghaddar (1): drm/amd/display: Add DPIA Link Encoder Assignment Fix for DCN35 Ovidiu Bunea (1): drm/amd/display: Use optc32 instead of optc30 in DC Qingqing Zhuo (1): drm/amd/display: Add DCN35 case for dc_clk_mgr_create Rodrigo Siqueira (1): drm/amd/display: Drop unused code Roman Li (1): drm/amd/display: Enable replay for dcn35 Sung Joon Kim (2): drm/amd/display: Add pointer check before function call drm/amd/display: Add IPS control flag Sung-huai Wang (1): drm/amd/display: fix static screen detection setting for DCN35 Taimur Hassan (1): drm/amd/display: Add reset for SYMCLKC_FE_SRC_SEL Wenjing Liu (1): drm/amd/display: Update pipe resource interfaces for DCN35 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + .../drm/amd/display/dc/bios/bios_parser2.c| 9 -- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 13 ++ .../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 24 ++- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 16 +- .../amd/display/dc/clk_mgr/dcn35/dcn35_smu.h | 1 + drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 4 + .../display/dc/dce110/dce110_hw_sequencer.c | 3 +- .../drm/amd/display/dc/dcn10
RE: [PATCH 00/21] DC Patches August 23, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 1d35782cce09 drm/amdgpu: Fix the return for gpu mode1_reset) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using Gnome for both. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Mahfooz, Hamza Sent: Wednesday, August 23, 2023 11:58 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza ; Wheeler, Daniel Subject: [PATCH 00/21] DC Patches August 23, 2023 This DC patch-set brings improvements in multiple areas. In summary, we highlight: * DCN315 fixes * DCN31 fixes * DPIA fixes * Dump the pipe topology when it updates * Misc code cleanups * New debugfs interface to query the current ODM combine configuration * ODM fixes * Potential deadlock while waiting for MPC idle fix * Support for windowed MPO ODM Cc: Daniel Wheeler Aurabindo Pillai (2): drm/amd/display: Fix incorrect comment drm/amd/display: Add debugfs interface for ODM combine info Charlene Liu (1): drm/amd/display: correct z8_watermark 16bit to 20bit mask Dillon Varone (1): drm/amd/display: Skip dmub memory flush when not needed Ethan Bitnun (1): drm/amd/display: Add support for 1080p SubVP to reduce idle power Fudong Wang (1): drm/amd/display: Add smu write msg id fail retry process Gabe Teeger (1): drm/amd/display: Remove wait while locked Martin Leung (1): drm/amd/display: 3.2.249 Mustapha Ghaddar (1): drm/amd/display: Add DPIA Link Encoder Assignment Fix Wenjing Liu (12): Partially revert "drm/amd/display: update add plane to context logic with a new algorithm" drm/amd/display: update blank state on ODM changes drm/amd/display: always switch off ODM before committing more streams drm/amd/display: add comments to add plane functions drm/amd/display: rename function to add otg master for stream drm/amd/display: add new resource interface for acquiring sec opp heads and release pipe drm/amd/display: add new resource interfaces to update odm mpc slice count drm/amd/display: add more pipe resource interfaces drm/amd/display: use new pipe allocation interface in dcn32 fpu drm/amd/display: switch to new ODM policy for windowed MPO ODM support drm/amd/display: add pipe topology update log drm/amd/display: fix pipe topology logging error .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 36 +- drivers/gpu/drm/amd/display/dc/Makefile |1 + .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 20 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 68 +- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 35 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 1473 + .../gpu/drm/amd/display/dc/core/dc_stream.c |2 +- drivers/gpu/drm/amd/display/dc/dc.h |3 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 59 +- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 22 +- .../drm/amd/display/dc/dcn20/dcn20_resource.h |4 +- .../amd/display/dc/dcn201/dcn201_resource.c |1 + .../drm/amd/display/dc/dcn21/dcn21_resource.c |1 + .../drm/amd/display/dc/dcn30/dcn30_resource.c |1 + .../amd/display/dc/dcn301/dcn301_
RE: [PATCH 00/16] DC Patches August 18, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 06e1ec5a9a88 drm/amd/display: Promote DAL to 3.2.247) with new patches added on top of it. Tested on Ubuntu 22.04.3, on Wayland and X11, using Gnome for both. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Wayne Lin Sent: Wednesday, August 16, 2023 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Lin, Wayne ; Wheeler, Daniel Subject: [PATCH 00/16] DC Patches August 18, 2023 This DC patchset brings improvements in multiple areas. In summary, we have: - Ensure FS is enabled before sending request to DMUB for FS changes - Add check for PMFW hard min request complete - Save addr update in scratch before flip - Fix static screen detection setting - Write flip addr to scratch reg for subvp - set minimum of VBlank_nom - Correct unit conversion for vstartup - Roll back unit correction - Enable runtime register offset init for DCN32 DMUB - Refactor edp power control - PQ regamma end point - PQ tail accuracy - Blank phantom OTG before enabling - Expose mall capability Cc: Daniel Wheeler --- Alvin Lee (3): drm/amd/display: Blank phantom OTG before enabling drm/amd/display: Write flip addr to scratch reg for subvp drm/amd/display: Save addr update in scratch before flip Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.180.0 Aric Cyr (1): drm/amd/display: 3.2.248 Aurabindo Pillai (2): drm/amd/display: Expose mall capability drm/amd/display: Enable runtime register offset init for DCN32 DMUB ChunTao Tso (1): drm/amd/display: set minimum of VBlank_nom Ian Chen (1): drm/amd/display: Refactor edp power control Krunoslav Kovac (2): drm/amd/display: PQ tail accuracy drm/amd/display: PQ regamma end point Ovidiu Bunea (1): drm/amd/display: Roll back unit correction Reza Amini (1): drm/amd/display: Correct unit conversion for vstartup Samson Tam (2): drm/amd/display: add check for PMFW hard min request complete drm/amd/display: ensure FS is enabled before sending request to DMUB for FS changes SungHuai Wang (1): drm/amd/display: fix static screen detection setting .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 19 +++ .../drm/amd/display/dc/clk_mgr/dcn32/dalsmc.h | 11 +- .../dc/clk_mgr/dcn32/dcn32_clk_mgr_smu_msg.c | 154 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 71 +++- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 23 +++ drivers/gpu/drm/amd/display/dc/dc.h | 6 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 11 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 + drivers/gpu/drm/amd/display/dc/dc_stream.h| 1 - .../display/dc/dce110/dce110_hw_sequencer.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 22 ++- .../amd/display/dc/dcn30/dcn30_cm_common.c| 104 .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 17 ++ .../drm/amd/display/dc/dcn30/dcn30_hwseq.h| 2 + .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c | 17 -- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 2 +- .../drm/amd/display/dc
RE: [PATCH 00/22] DC Patches Aug 04 2023
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 389af3e7a5f7 drm/amd/display: Promote DC to 2.3.245) with new patches added on top of it. Tested on Ubuntu 22.04.2 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Tom Chung Sent: Wednesday, August 2, 2023 2:51 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Chung, ChiaHsuan (Tom) ; Wheeler, Daniel Subject: [PATCH 00/22] DC Patches Aug 04 2023 This DC patchset brings improvements in multiple areas. In summary, we have: - Fix a regression in blank pixel data caused by coding mistake - Fix a bug when searching for insert_above_mpcc - Fix backlight off cmd for OLED panel - Update add plane to context logic with a new algorithm - Adjust visual confirm dpp height offset to be 1/240 of v addressable - Add interface to enable DPIA trace - Support plane clip with zero recout size - Blocking invalid 420 modes on HDMI TMDS for DCN31 and DCN314 - Make mpc32 functions available to future DCNs - Change HDCP update sequence for DM Cc: Daniel Wheeler Alvin Lee (1): drm/amd/display: Use max memclk variable when setting max memclk Austin Zheng (2): drm/amd/display: Set Stream Update Flags in commit_state_no_check drm/amd/display: Use DTBCLK as refclk instead of DPREFCLK Bhawanpreet Lakha (1): drm/amd/display: Change HDCP update sequence for DM Leo Chen (3): drm/amd/display: Revert "dc: read down-spread percentage from lut to adjust dprefclk" drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN31 drm/amd/display: Blocking invalid 420 modes on HDMI TMDS for DCN314 Martin Leung (1): drm/amd/display: Promote DAL to 3.2.246 Mike Hsieh (1): drm/amd/display: Add vendor Id for reference Stylon Wang (2): drm/amd/display: Add interface to enable DPIA trace drm/amd/display: Enable DPIA trace with DC debug mask Swapnil Patel (1): drm/amd/display: Fix backlight off cmd for OLED panel Wenjing Liu (8): drm/amd/display: fix a regression in blank pixel data caused by coding mistake drm/amd/display: support plane clip with zero recout size drm/amd/display: always acquire MPO pipe for every blending tree drm/amd/display: update add plane to context logic with a new algorithm drm/amd/display: adjust visual confirm dpp height offset to be 1/240 of v addressable drm/amd/display: do not treat clip_rect size change as a scaling change drm/amd/display: move idle pipe allocation logic into dcn specific layer drm/amd/display: rename acquire_idle_pipe_for_layer to acquire_free_pipe_as_sec_dpp_pipe Wesley Chalmers (2): drm/amd/display: Fix a bug when searching for insert_above_mpcc drm/amd/display: Make mpc32 functions available to future DCNs .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 80 ++- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 32 +- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.h| 7 - .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 111 +--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 589 -- drivers/gpu/drm/amd/
RE: [PATCH 00/11] DC Patches June 22, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - be7ba5b1098d drm/amd/display: 3.2.240) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.2 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: Thursday, June 22, 2023 5:57 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/11] DC Patches June 22, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Improve debugging mechanism for Gaming FAMS - Add monitor-specific edid quirks - Fixes for Phantom pipe - Fixes for Shapper LUT - Clean-up asserts Cc: Daniel Wheeler Alvin Lee (3): drm/amd/display: Limit new fast update path to addr and gamma / color drm/amd/display: For new fast update path, loop through each surface drm/amd/display: Take full update path if number of planes changed Aric Cyr (1): drm/amd/display: 3.2.241 Aurabindo Pillai (1): drm/amd/display: Add monitor specific edid quirk Austin Zheng (1): drm/amd/display: Remove Phantom Pipe Check When Calculating K1 and K2 Gianna Binder (1): drm/amd/display: Create debugging mechanism for Gaming FAMS Harry Wentland (1): drm/amd/display: Fix the delta clamping for shaper LUT Hong-lu Cheng (1): drm/amd/display: Remove asserts Ilya Bakoulin (1): drm/amd/display: Work around bad DPCD state on link loss Melissa Wen (1): drm/amd/display: program DPP shaper and 3D LUT if updated .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 26 drivers/gpu/drm/amd/display/dc/core/dc.c | 121 +- drivers/gpu/drm/amd/display/dc/dc.h | 14 +- .../amd/display/dc/dcn10/dcn10_cm_common.c| 19 ++- .../amd/display/dc/dcn10/dcn10_cm_common.h| 1 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 11 +- .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 2 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 3 +- .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 10 +- .../display/dc/dcn32/dcn32_resource_helpers.c | 3 +- .../dc/dml/dcn20/display_mode_vba_20.c| 16 ++- .../dc/link/protocols/link_dp_irq_handler.c | 26 14 files changed, 224 insertions(+), 32 deletions(-) -- 2.39.2
RE: [PATCH 00/20] DC Patches June 9, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - f54a4d03fde5487d27889495854c82624e919d19 drm/amd/display: edp do not add non-edid timings) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.2 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Wang, Chao-kai (Stylon) Sent: Wednesday, June 7, 2023 8:15 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/20] DC Patches June 9, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Improvement on eDP - PSR bug fixes - SubVP bug fixes - Improvements on pipe handling to address potential issues - Freesync bug fix - DPIA bug fix - Fix multi-display issues Cc: Daniel Wheeler Alvin Lee (4): drm/amd/display: SubVP high refresh only if all displays >= 120hz drm/amd/display: Re-enable SubVP high refresh drm/amd/display: Block SubVP + DRR if the DRR is PSR capable drm/amd/display: Include CSC updates in new fast update path Aric Cyr (2): drm/amd/display: Promote DAL to 3.2.238 drm/amd/display: 3.2.239 Artem Grishin (1): drm/amd/display: Bug fix in dcn315_populate_dml_pipes_from_context Austin Zheng (2): drm/amd/display: Add DP2 Metrics drm/amd/display: Limit Minimum FreeSync Refresh Rate Daniel Miess (2): drm/amd/display: Re-enable DPP/HUBP Power Gating Revert "drm/amd/display: Move DCN314 DOMAIN power control to DMCUB" Dmytro Laktyushkin (1): drm/amd/display: fix pixel rate update sequence Fangzhi Zuo (1): drm/amd/display: Add Error Code for Dml Validation Failure Hersen Wu (2): drm/amd/display: edp do not add non-edid timings drm/amd/display: add debugfs for allow_edp_hotplug_detection Peichen Huang (1): drm/amd/display: limit DPIA link rate to HBR3 Saaem Rizvi (1): drm/amd/display: Do not disable phantom pipes in driver Samson Tam (1): Revert "drm/amd/display: reallocate DET for dual displays with high pixel rate ratio" Tom Chung (2): drm/amd/display: fix the system hang while disable PSR drm/amd/display: Fix disbling PSR slow response issue .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 32 .../drm/amd/display/dc/core/dc_hw_sequencer.c | 70 +++ drivers/gpu/drm/amd/display/dc/dc.h | 9 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 11 -- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 1 + .../amd/display/dc/dcn302/dcn302_resource.c | 1 + .../amd/display/dc/dcn303/dcn303_resource.c | 1 + .../drm/amd/display/dc/dcn314/dcn314_hwseq.c | 30 +-- .../drm/amd/display/dc/dcn314/dcn314_hwseq.h | 4 +- .../drm/amd/display/dc/dcn314/dcn314_init.c | 2 +- .../amd/display/dc/dcn314/dcn314_resource.c | 11 +- .../amd/display/dc/dcn315/dcn315_resource.c | 1 + .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 11 +- .../drm/amd/display/dc/dcn32
RE: [PATCH 00/14] DC Patches June 2, 2023
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: * eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) * VGA and DVI (1680x1050 60hz [DP to VGA/DVI, USB-C to VGA/DVI]) * DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz, 4k 240hz [Includes USB-C to DP/HDMI adapters]) * Thunderbolt (LG Ultrafine 5k) * MST (Startech MST14DP123DP [DP to 3x DP] and 2x 4k 60Hz displays) * DSC (with Cable Matters 101075 [DP to 3x DP] with 3x 4k60 displays, and HP Hook G2 with 1 4k60 display) * USB 4 (Kensington SD5700T and 1x 4k 60Hz display) * PCON (Club3D CAC-1085 and 1x 4k 144Hz display [at 4k 120HZ, as that is the max the adapter supports]) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): * Changing display configurations and settings * Benchmark testing * Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): * Script testing (scripts to automate some of the manual checks) * IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 3e54d382a51b71bd08702a10c0864a60f0108c66 -> drm/amd/amdgpu: Fix up locking etc in amdgpu_debugfs_gprwave_ioctl()) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.2 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Wang, Chao-kai (Stylon) Sent: Wednesday, May 31, 2023 12:48 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/14] DC Patches June 2, 2023 This DC patchset brings improvements in multiple areas. In summary, we have: * Clock optimiation for DCN 3.1.4 * Performance improvements * Improvements on power saving * Fix screen flash in high resolution displays * Enable Freesync video mode by default * Bug fixed on hang or crashes in various cases * Improved code robustness in corner cases Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: Refactor fast update to use new HWSS build sequence drm/amd/display: Reduce sdp bw after urgent to 90% Aurabindo Pillai (1): drm/amd/display: Enable Freesync Video Mode by default Austin Zheng (1): drm/amd/display: Filter out AC mode frequencies on DC mode systems Charlene Liu (1): drm/amd/display: add NULL pointer check Daniel Miess (1): drm/amd/display: Enable dcn314 DPP RCO Dmytro Laktyushkin (2): drm/amd/display: fix seamless odm transitions drm/amd/display: fix dcn315 single stream crb allocation Leo Ma (1): Revert "drm/amd/display: cache trace buffer size" Max Tseng (1): drm/amd/display: Add control flag to dc_stream_state to skip eDP BL off/link off Nicholas Kazlauskas (1): drm/amd/display: Skip DPP DTO update if root clock is gated Saaem Rizvi (1): drm/amd/display: Wrong index type for pipe iterator Samson Tam (1): drm/amd/display: add ODM case when looking for first split pipe Sridevi (1): drm/amd/display: DSC Programming Deltas .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 13 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 307 -- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 255 +++ .../gpu/drm/amd/display/dc/core/dc_resource.c | 20 ++ .../gpu/drm/amd/display/dc/core/dc_stream.c | 4 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 + drivers/gpu/drm/amd/display/dc/dc_stream.h| 1 + .../amd/display/dc/dce100/dce100_resource.c | 5 + .../display/dc/dce110/dce110_hw_sequencer.c | 3 +- .../amd/display/dc/dce110/dce110_resource.c | 5 + .../amd/display/dc/dce112/dce112_resource.c | 5 + .../amd/display/dc/dce120/dce120_resource.c | 1 + .../drm/amd/display/dc/dce80/dce80_resource.c | 6 + .../drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 29 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.h | 28 ++ .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 11 + .../drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + .../amd/display/dc/dcn201/dcn201_resource.c | 1 + .../drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + .../gpu/drm/a
RE: [PATCH 00/10] DC Patches for 15 May 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo ThinkPad T14s Gen2, with AMD Ryzen 5 5650U Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays USB 4 testing with Kensington SD5700T and 1x 4k 60Hz display PCON tested with Club3D CAC-1085 and 1x 4k 144Hz display (at 4k 120HZ, as that is the max the adapter supports) The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 53967b9f28f9 drm/amd/display: Promote DAL to 3.2.235) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.2 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Aurabindo Pillai Sent: May 10, 2023 4:49 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/10] DC Patches for 15 May 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.236 * Fixes related to DCN clock sequencing * Changes to FPO acceptance heuristics for various modelines * Dmesg log readability, visual debug improments and various bug fixes. Cc: Daniel Wheeler --- Alvin Lee (3): drm/amd/display: Only skip update for DCFCLK, UCLK, FCLK on overclock drm/amd/display: Update vactive margin and max vblank for fpo + vactive drm/amd/display: Make unbounded req update separate from dlg/ttu Aric Cyr (1): drm/amd/display: 3.2.236 Daniel Miess (2): drm/amd/display: Fix possible underflow for displays with large vblank drm/amd/display: Remove v_startup workaround for dcn3+ Leo (Hanghong) Ma (1): drm/amd/display: Add visual confirm color support for MCLK switch Mustapha Ghaddar (1): drm/amd/display: enable dpia validate Rodrigo Siqueira (2): drm/amd/display: Convert connector signal id to string drm/amd/display: Remove unnecessary variable .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 24 + drivers/gpu/drm/amd/display/dc/core/dc.c | 51 --- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 50 -- drivers/gpu/drm/amd/display/dc/dc.h | 12 - .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 22 +++- .../amd/display/dc/dcn10/dcn10_hw_sequencer.h | 1 - .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 37 -- .../drm/amd/display/dc/dcn20/dcn20_hwseq.h| 5 -- .../gpu/drm/amd/display/dc/dcn20/dcn20_init.c | 2 +- .../drm/amd/display/dc/dcn201/dcn201_hwseq.c | 4 +- .../drm/amd/display/dc/dcn201/dcn201_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn21/dcn21_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 +- .../drm/amd/display/dc/dcn301/dcn301_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 2 +- .../drm/amd/display/dc/dcn314/dcn314_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 2 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 2 + .../drm/amd/display/dc/dcn32/dcn32_resource.h | 1 - .../display/dc/dcn32/dcn32_resource_helpers.c | 2 +- .../amd/display/dc/dcn321/dcn321_resource.c | 2 + .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 24 +++-- .../amd/display/dc/dml/dcn314/dcn314_fpu.c| 19 +++ .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 10 +++- .../gpu/drm/amd/display/dc/inc/core_types.h | 3 ++ .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 9 +++- .../drm/amd/display/dc/link/link_factory.c| 6 +-- .../drm/amd/display/dc/link/link_validation.c | 3 ++ .../drm/amd/display/include/signal_types.h| 28 ++ 29 files changed, 224 insertions(+), 107 deletions(-) -- 2.40.0
RE: [PATCH 0/8] DC Patches May 02, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 6bbcaa25b0c180dfb9c1a90155fc1cfe964f3e36 drm/amd/display: 3.2.234) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Hung, Alex Sent: May 2, 2023 9:39 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Hung, Alex ; Wheeler, Daniel Subject: [PATCH 0/8] DC Patches May 02, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Block SubVP on displays that have pixclk > 1800Mhz * Block SubVP high refresh when VRR active fixed * Enforce 60us prefetch for 200Mhz DCFCLK modes * Check Vactive for VRR active for FPO + Vactive * Add symclk workaround during disable link output * Show the DCN/DCE version in the log * Add additional pstate registers to HW state query Cc: Daniel Wheeler Alvin Lee (4): drm/amd/display: Check Vactive for VRR active for FPO + Vactive drm/amd/display: Enforce 60us prefetch for 200Mhz DCFCLK modes drm/amd/display: Block SubVP high refresh when VRR active fixed drm/amd/display: Block SubVP on displays that have pixclk > 1800Mhz Aric Cyr (1): drm/amd/display: Promote DAL to 3.2.235 Leo Chen (1): drm/amd/display: Add symclk workaround during disable link output Rodrigo Siqueira (1): drm/amd/display: Show the DCN/DCE version in the log Sung Lee (1): drm/amd/display: Add additional pstate registers to HW state query .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_helper.c| 56 drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 + .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 2 + .../drm/amd/display/dc/dcn20/dcn20_hubbub.c | 6 ++ .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c | 6 ++ .../drm/amd/display/dc/dcn314/dcn314_hwseq.c | 65 +++ .../drm/amd/display/dc/dcn314/dcn314_hwseq.h | 2 + .../drm/amd/display/dc/dcn314/dcn314_init.c | 2 +- .../drm/amd/display/dc/dcn32/dcn32_resource.h | 1 + drivers/gpu/drm/amd/display/dc/dm_services.h | 2 + .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 10 ++- .../dc/dml/dcn32/display_mode_vba_32.c| 5 +- .../dc/dml/dcn32/display_mode_vba_32.h| 1 + .../gpu/drm/amd/display/dc/inc/hw/dchubbub.h | 2 + 17 files changed, 164 insertions(+), 8 deletions(-) -- 2.40.0
RE: [PATCH 0/8] DC Patches April 26, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - f53eb9bfc5d7 BACKPORT: ASoC: SOF: fix compilation issue with readb/writeb helper) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Alan Liu Sent: April 26, 2023 12:27 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Liu, HaoPing (Alan) ; Wheeler, Daniel Subject: [PATCH 0/8] DC Patches April 26, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - FW Release 0.0.165.0 - Add w/a to disable DP dual mode on certain ports - Revert "Update scaler recout data for visual confirm" - Filter out invalid bits in pipe_fuses - Adding debug option to override Z8 watermark values - Change default Z8 watermark values - Workaround wrong HDR colorimetry with some receivers Cc: Daniel Wheeler Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.165.0 Aric Cyr (1): drm/amd/display: 3.2.234 George Shen (1): drm/amd/display: Add w/a to disable DP dual mode on certain ports Ilya Bakoulin (1): drm/amd/display: Workaround wrong HDR colorimetry with some receivers Leo Chen (2): drm/amd/display: Change default Z8 watermark values drm/amd/display: Adding debug option to override Z8 watermark values Leo Ma (1): drm/amd/display: revert "Update scaler recout data for visual confirm" Samson Tam (1): drm/amd/display: filter out invalid bits in pipe_fuses drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++ .../gpu/drm/amd/display/dc/core/dc_resource.c | 17 - drivers/gpu/drm/amd/display/dc/dc.h| 8 +++- .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 18 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 11 ++- .../amd/display/dc/dcn321/dcn321_resource.c| 10 +- .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 11 +++ .../drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 4 ++-- .../drm/amd/display/dc/link/link_detection.c | 4 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h| 10 +- 10 files changed, 76 insertions(+), 24 deletions(-) -- 2.34.1
RE: [PATCH 00/21] DC Patches April 20, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 329fb1a32e80 drm/amd/display: 3.2.231) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: April 20, 2023 7:50 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/21] DC Patches April 20, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Improvements in the SubVP feature - Keep disabling aux-i delay as 0 - Add p-state debugging and improvements - Fix in secure display context creation - add an option to use custom backlight caps - Lowering min Z8 residency time - Restore rptr/wptr for DMCUB as a workaround - Update FW feature caps struct Cc: Daniel Wheeler Alan Liu (1): drm/amd/display: Fix in secure display context creation Alex Hung (1): drm/amd/display: implement force function in amdgpu_dm_connector_funcs Alvin Lee (6): drm/amd/display: Update FW feature caps struct drm/amd/display: Limit DCN32 8 channel or less parts to DPM1 for FPO drm/amd/display: Enable SubVP on PSR panels if single stream drm/amd/display: For no plane case set pstate support in validation drm/amd/display: Query GECC enable for SubVP disable drm/amd/display: Enable SubVP for high refresh rate displays Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.163.0 Aric Cyr (2): drm/amd/display: 3.2.232 drm/amd/display: 3.2.233 Dmytro Laktyushkin (1): drm/amd/display: add pixel rate based CRB allocation support Gabe Teeger (1): drm/amd/display: update extended blank for dcn314 onwards Hersen Wu (1): drm/amd/display: assign edid_blob_ptr with edid from debugfs JinZe.Xu (1): drm/amd/display: Restore rptr/wptr for DMCUB as workaround Josip Pavic (1): drm/amd/display: add option to use custom backlight caps Leo (Hanghong) Ma (1): drm/amd/display: Update scaler recout data for visual confirm Leo Chen (1): drm/amd/display: Lowering min Z8 residency time Michael Strauss (2): drm/amd/display: Convert Delaying Aux-I Disable To Monitor Patch drm/amd/display: Keep disable aux-i delay as 0 Sung Lee (1): drm/amd/display: Add p-state debugging .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 56 --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 2 +- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 4 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 7 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 21 .../gpu/drm/amd/display/dc/core/dc_resource.c | 18 drivers/gpu/drm/amd/display/dc/dc.h | 8 +- drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 18 +--- .../drm/amd/display/dc/dcn20/dcn20_hubbub.c | 5 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 4 +- .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 1 + .../amd/display/dc/dcn314/dcn314_resource.c | 2 +- .../amd/display/dc/dcn315/dcn315_resource.c | 97 ++- .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 2 + .../drm/amd/display/dc/dcn32/dcn32_resource.c | 3 + .../drm/amd/display/dc/dcn32/dcn32_resource.h | 14 +++ .../display/dc/dcn32/dcn32_resource_helpers.c | 15 +++ .../amd/display/dc/dcn321/dcn321_resource.c | 1 + .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 31 +++--- .../drm/amd
RE: [PATCH 00/66] DC Patches Apr 17th, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - c940e09ec9ad drm/amd/display: 3.2.230) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: April 14, 2023 11:52 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/66] DC Patches Apr 17th, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - FW Release 0.0.162.0 - Enable FPO+Vactivate - Support for VESA SCR on OLED - Refactor DMUB commands - Fixes in secure display, modeset, memleak and more - Picked up missed patches in history Cc: Daniel Wheeler Alan Liu (1): drm/amd/display: Fix in disabling secure display Alex Hung (2): drm/amd/display: allow edp updates for virtual signal drm/amd/display: fix a divided-by-zero error Alvin Lee (5): drm/amd/display: Only consider DISPCLK when using optimized boot path drm/amd/display: Reduce SubVP + DRR stretch margin drm/amd/display: Set watermarks set D equal to A drm/amd/display: Enable FPO + Vactive drm/amd/display: Update DTBCLK for DCN32 Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.162.0 Aric Cyr (1): drm/amd/display: 3.2.231 Aurabindo Pillai (13): drm/amd/display: Fix hang when skipping modeset drm/amd/display: remove incorrect early return drm/amd/display: Fixes for dcn32_clk_mgr implementation drm/amd/display: Do not clear GPINT register when releasing DMUB from reset drm/amd/display: Update bounding box values for DCN321 drm/amd/display: add support for low bpc drm/amd/display: Set DRAM clock if retraining is required drm/amd/display: Add check for PState change in DCN32 drm/amd/display: Remove DET check from DCN32 drm/amd/display: Add extra check for 444 16 format drm/amd/display: Add FAMS capability to DCN31 drm/amd/display: Add FAMS related definitions and documenation for enum fields drm/amd/display: remove some unused variables Cruise Hung (1): drm/amd/display: Reset OUTBOX0 r/w pointer on DMUB reset Daniel Miess (1): drm/amd/display: limit timing for single dimm memory Dmytro Laktyushkin (4): drm/amd/display: update max streams per surface drm/amd/display: add extra dc odm debug options drm/amd/display: set dcn315 lb bpp to 48 drm/amd/display: Limit nv21 dst_y Eric Yang (1): drm/amd/display: add mechanism to skip DCN init Hersen Wu (2): drm/amd/display: fix memleak in aconnector->timing_requested drm/amd/display: fix access hdcp_workqueue assert Igor Kravchenko (1): drm/amd/display: Set min_width and min_height capability for DCN30 Iswara Nagulendran (1): drm/amd/display: Adding support for VESA SCR Jasdeep Dhillon (1): drm/amd/display: Isolate remaining FPU code in DCN32 Jingwen Zhu (1): drm/amd/display: Improvement for handling edp link training fails Josip Pavic (3): drm/amd/display: copy dmub caps to dc on dcn31 drm/amd/display: refactor dmub commands into single function drm/amd/display: drain dmub inbox if queue is full Krunoslav Kovac (1): drm/amd/display: 3-plane MPO enablement for DCN321 Leon Huang (2): drm/amd/display: Refactor ABM feature drm/amd/display: Fix ABM pipe/backlight issues when change backlight Meenakshikumar Somasundaram (1): drm/amd/display: Adjust dmub outbox notification ena
RE: [PATCH 00/10] DC Patches Apr 3rd, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 705a9d96f697 drm/amd/display: Promote DAL to 3.2.229) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.2 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: March 30, 2023 4:57 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/10] DC Patches Apr 3rd, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - FW Release 0.0.161.0 - Improvements on FPO/FAMS - Correction to DML calculation - Fix to multiple clock related issues Cc: Daniel Wheeler --- Alvin Lee (3): drm/amd/display: Clear FAMS flag if FAMS doesn't reduce vlevel drm/amd/display: Add FPO + VActive support drm/amd/display: On clock init, maintain DISPCLK freq Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.161.0 Aric Cyr (1): drm/amd/display: 3.2.230 Charlene Liu (1): drm/amd/display: add dscclk instance offset check Hamza Mahfooz (1): drm/amd/display: prep work for root clock optimization enablement for DCN314 Michael Strauss (1): drm/amd/display: Improve robustness of FIXED_VS link training at DP1 rates Paul Hsieh (1): drm/amd/display: Correct DML calculation to follow HW SPEC Zhikai Zhai (1): drm/amd/display: add scaler control for dcn32 .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 18 + drivers/gpu/drm/amd/display/dc/dc.h | 6 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 20 + .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 8 + .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 18 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 + .../drm/amd/display/dc/dcn314/dcn314_dccg.c | 28 +- .../drm/amd/display/dc/dcn314/dcn314_dccg.h | 10 + .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 26 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 3 + .../drm/amd/display/dc/dcn32/dcn32_resource.h | 4 + .../display/dc/dcn32/dcn32_resource_helpers.c | 156 .../amd/display/dc/dcn321/dcn321_resource.c | 3 + .../dc/dml/dcn30/display_mode_vba_30.c| 2 +- .../dc/dml/dcn31/display_mode_vba_31.c| 2 +- .../dc/dml/dcn314/display_mode_vba_314.c | 2 +- .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 85 +++- .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.h | 4 + .../dc/dml/dcn32/display_mode_vba_32.c| 2 +- .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h | 3 + .../gpu/drm/amd/display/dc/link/link_dpms.c | 8 +- .../dc/link/protocols/link_dp_training.c | 5 +- .../link_dp_training_fixed_vs_pe_retimer.c| 378 +- .../link_dp_training_fixed_vs_pe_retimer.h| 5 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 28 +- 25 files changed, 807 insertions(+), 19 deletions(-) -- 2.34.1
RE: [PATCH 00/19] DC Patches Mar 27th, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - a59f70678940 drm/amd/pm: enable TEMP_DEPENDENT_VMIN for navi1x) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr -Original Message- From: Zhuo, Qingqing (Lillian) Sent: March 24, 2023 2:51 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/19] DC Patches Mar 27th, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Enable FPO optimization - Support for 6.75 GBps link rate - Fixes to underflow, black screen and more Cc: Daniel Wheeler --- Alvin Lee (6): drm/amd/display: Enable FPO for configs that could reduce vlevel drm/amd/display: Update FCLK change latency drm/amd/display: Use per pipe P-State force for FPO drm/amd/display: Only keep cursor p-state force for FPO drm/amd/display: Enable FPO optimization drm/amd/display: Uncomment assignments after HW headers are promoted Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.160.0 Aric Cyr (1): drm/amd/display: Promote DAL to 3.2.229 Artem Grishin (2): drm/amd/display: Add support for 6.75 GBps link rate drm/amd/display: Conditionally enable 6.75 GBps link rate Ayush Gupta (1): drm/amd/display: fixed dcn30+ underflow issue Charlene Liu (1): drm/amd/display: update dig enable sequence Dmytro Laktyushkin (1): drm/amd/display: w/a for dcn315 inconsistent smu clock table Martin Leung (1): drm/amd/display: fix double memory allocation Nicholas Kazlauskas (2): drm/amd/display: Add NULL plane_state check for cursor disable logic drm/amd/display: Fix 4to1 MPC black screen with DPP RCO Peichen Huang (1): drm/amd/display: skip ClearPayloadIdTable if device mst_en is 0 Qingqing Zhuo (1): drm/amd/display: Add infrastructure for enabling FAMS for DCN30 Taimur Hassan (1): drm/amd/display: Add 90Mhz to video_optimized_pixel_rates .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 5 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +- drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 44 +++--- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 17 +++--- drivers/gpu/drm/amd/display/dc/dc_stream.h| 1 + .../drm/amd/display/dc/dce/dce_clock_source.c | 1 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 16 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 18 +- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 3 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 2 + .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 13 + .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 2 +- .../drm/amd/display/dc/dcn314/dcn314_dccg.c | 23 .../drm/amd/display/dc/dcn314/dcn314_hwseq.c | 10 .../drm/amd/display/dc/dcn314/dcn314_hwseq.h | 2 + .../drm/amd/display/dc/dcn314/dcn314_init.c | 1 + .../dc/dcn32/dcn32_dio_stream_encoder.c | 10 ++-- .../dc/dcn32/dcn32_dio_stream_encoder.h | 8 +++ .../gpu/drm/amd/display/dc/dcn32/dcn32_hubp.c | 10 .../gpu/drm/amd/display/dc/dcn32/dcn32_hubp.h | 2 + .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 49 ++-- .../drm/amd/display/dc/dcn32/dcn32_hwseq.h| 2 +- .../gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 2 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 1 + .../amd/display/dc/dcn321/dcn321_resource.c | 1 + .../drm
RE: [PATCH 00/19] DC Patches Mar 20th, 2023
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: March 18, 2023 3:56 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/19] DC Patches Mar 20th, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Power down eDP if eDP not present - Set MPC_SPLIT_DYNAMIC for DCN10 and DCN301 - Initialize link_srv in virtual env - Code cleanup and alignment Cc: Daniel Wheeler --- Alex Deucher (2): Revert "drm/amdgpu/display: change pipe policy for DCN 2.0" drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x Alex Hung (1): drm/amd/display: remove outdated 8bpc comments Aric Cyr (1): drm/amd/display: 3.2.228 Charlene Liu (3): drm/amd/display: update dio for two pixel per container case drm/amd/display: Add CRC and DMUB test support drm/amd/display: add missing code change init pix_per_cycle Hersen Wu (3): drm/amd/display: align commit_planes_for_stream to latest dc code drm/amd/display: fix wrong index used in dccg32_set_dpstreamclk drm/amd/display: Set dcn32 caps.seamless_odm Martin Leung (1): drm/amd/display: initialize link_srv in virtual env Mustapha Ghaddar (1): drm/amd/display: Add function pointer for validate bw usb4 Paul Hsieh (1): drm/amd/display: power down eDP if eDP not present Rodrigo Siqueira (3): drm/amd/display: Add const to a function drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN10 drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN301 Saaem Rizvi (1): drm/amd/display: Implement workaround for writing to OTG_PIXEL_RATE_DIV register Wesley Chalmers (1): drm/amd/display: Make DCN32 3dlut function available to future DCNs Zhikai Zhai (1): drm/amd/display: skip wait vblank .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - drivers/gpu/drm/amd/display/dc/core/dc.c | 27 +++-- .../drm/amd/display/dc/core/dc_link_exports.c | 8 +++-- drivers/gpu/drm/amd/display/dc/dc.h | 18 ++-- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 29 +++ .../drm/amd/display/dc/dcn10/dcn10_resource.c | 4 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 3 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 4 +-- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- .../amd/display/dc/dcn301/dcn301_resource.c | 2 +- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 25 ++-- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.h | 3 +- .../dc/dcn32/dcn32_dio_stream_encoder.c | 6 .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 4 +-- .../drm/amd/display/dc/dcn32/dcn32_hwseq.h| 3 ++ .../drm/amd/display/dc/dcn32/dcn32_resource.c | 1 + .../drm/amd/display/dc/dcn32/dcn32_resource.h | 3 +- drivers/gpu/drm/amd/display/dc/inc/link.h | 3 ++ .../drm/amd/display/dc/link/link_detection.c | 5 .../drm/amd/display/dc/link/link_factory.c| 1 + .../drm/amd/display/dc/link/link_validation.c | 18 .../drm/amd/display/dc/link/link_validation.h | 4 +++ .../dc/link/protocols/link_dp_dpia_bw.c | 9 ++ .../dc/link/protocols/link_dp_dpia_bw.h | 7 - drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 2 ++ .../g
RE: [PATCH 00/19] DC Patches Mar 13rd, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - c4a5cf85ab8c: drm/amdgpu: Optimize end of non-contig VA ranges) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: March 10, 2023 4:31 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/19] DC Patches Mar 13rd, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - FW Release 0.0.158.0 - Fixes to HDCP, DP MST and more - Improvements on USB4 links and more - Code re-architecture on link.h Cc: Daniel Wheeler Alvin Lee (1): drm/amd/display: Use DPP inst instead of pipe idx for DPP DTO programming Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.158.0 Aric Cyr (1): drm/amd/display: 3.2.227 Ayush Gupta (1): drm/amd/display: disconnect MPCC only on OTG change Bhawanpreet Lakha (1): drm/amd/display: Fix HDCP failing to enable after suspend Cruise Hung (1): drm/amd/display: Fix DP MST sinks removal issue Fangzhi Zuo (2): drm/amd/display: Add DSC Support for Synaptics Cascaded MST Hub drm/amd/display: Take FEC Overhead into Timeslot Calculation Mustapha Ghaddar (1): drm/amd/display: Add Validate BW for USB4 Links Robin Chen (1): drm/amd/display: hpd rx irq not working with eDP interface Saaem Rizvi (1): drm/amd/display: Remove OTG DIV register write for Virtual signals. Samson Tam (2): drm/amd/display: reallocate DET for dual displays with high pixel rate ratio drm/amd/display: fix assert condition Stylon Wang (1): drm/amd/display: Clearly states if long or short HPD event in dmesg logs Swapnil Patel (1): drm/amd/display: default values for luminance range if they are 0 Wenjing Liu (1): drm/amd/display: convert link.h functions to function pointer style Wesley Chalmers (2): drm/amd/display: Do not set DRR on pipe Commit drm/amd/display: Make DCN32 functions available to future DCNs Zhikai Zhai (1): drm/amd/display: reset the scaler boundary mode .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 2 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 51 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 15 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 4 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 38 ++- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.h | 3 + drivers/gpu/drm/amd/display/dc/core/dc.c | 33 +- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 2 +- .../drm/amd/display/dc/core/dc_link_exports.c | 34 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 13 +- drivers/gpu/drm/amd/display/dc/dc.h | 15 +- drivers/gpu/drm/amd/display/dc/dc_types.h | 7 + .../display/dc/dce110/dce110_hw_sequencer.c | 60 ++-- .../gpu/drm/amd/display/dc/dcn10/dcn10_dpp.h | 4 + .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 4 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 +- .../display/dc/dcn10/dcn10_stream_encoder.c | 7 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 14 +- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 9 +- .../display/dc/dcn20/dcn20_stream_encoder.c | 3 +- .../drm/amd/display/dc/dcn21/dcn21_hwseq.c| 4 +- .../gpu/drm/amd/display/dc/dcn30/dcn30_dpp.h | 2 + .../drm/amd/display/dc
RE: [PATCH 00/20] DC Patches Feb 27th, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit aaac77ad65330444aa506614529bb7883e024d9e -> Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL") with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: February 22, 2023 1:40 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/20] DC Patches Feb 27th, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes Alvin Lee (1): drm/amd/display: DAL to program DISPCLK WDIVIDER if PMFW doesn't Aric Cyr (6): drm/amd/display: Reduce CPU busy-waiting for long delays Revert "drm/amd/display: Do not set DRR on pipe commit" Revert "drm/amd/display: Fix FreeSync active bit issue" drm/amd/display: Do not update DRR while BW optimizations pending drm/amd/display: Only wait for blank completion if OTG active drm/amd/display: Promote DAL to 3.2.224 Ayush Gupta (1): drm/amd/display: populate subvp cmd info only for the top pipe Hersen Wu (1): drm/amd/display: dcn32/321 dsc_pg_control not executed properly Jasdeep Dhillon (1): drm/amd/display: Updating Video Format Fall Back Policy. Mustapha Ghaddar (2): drm/amd/display: Allocation at stream Enable drm/amd/display: Update BW ALLOCATION Function declaration Paul Hsieh (1): drm/amd/display: Correct DML calculation as HW SpreadSheet Ryan Lin (1): drm/amd/display: Ext displays with dock can't recognized after resume Samson Tam (1): drm/amd/display: enable DPG when disabling plane for phantom pipe Sung Joon Kim (1): drm/amd/display: Extend Freesync over PCon support for more devices Wenjing Liu (2): drm/amd/display: merge dc_link.h into dc.h and dc_types.h drm/amd/display: remove empty dc_link.c Yihan Zhu (1): drm/amd/display: update pixel format in DP hw sequence .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 1 + .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 4 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 41 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 253 +++- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 27 - .../drm/amd/display/dc/core/dc_link_exports.c | 87 +++ drivers/gpu/drm/amd/display/dc/dc.h | 556 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 3 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 107 drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 14 + drivers/gpu/drm/amd/display/dc/dc_link.h | 8 +- drivers/gpu/drm/amd/display/dc/dc_types.h | 104 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 9 +- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h | 5 +- .../display/dc/dce110/dce110_hw_sequencer.c |
RE: [PATCH 00/22] DC Patches Feb 13, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 87b54ffb9424 drm/amd/pm: bump SMU 13.0.7 driver_if header version) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: February 12, 2023 12:00 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/22] DC Patches Feb 13, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Move domain power control to DMCUB for DCN314 - Enable P-state validation check for DCN314 - Add support for multiple overlay planes - Fixes in prefetch, k1 k2 divider programming and more - Code cleanup Cc: Daniel Wheeler Alvin Lee (2): drm/amd/display: Set max vratio for prefetch to 7.9 for YUV420 MPO drm/amd/display: Fix prefetch vratio check Aric Cyr (1): drm/amd/display: Promote DAL to 3.2.223 Aurabindo Pillai (1): drm/amd/display: fix k1 k2 divider programming for phantom streams Ayush Gupta (1): drm/amd/display: temporary fix for page faulting Bhawanpreet Lakha (1): drm/amd/display: Add support for multiple overlay planes Charlene Liu (1): drm/amd/display: add NULL pointer check Daniel Miess (1): Revert "drm/amd/display: Correct bw_params population" Leo (Hanghong) Ma (1): drm/amd/display: Fix FreeSync active bit issue Mustapha Ghaddar (1): drm/amd/display: upstream link_dp_dpia_bw.c Nasir Osman (2): drm/amd/display: Remove stutter only configurations drm/amd/display: Disable unbounded request mode during rotation Nicholas Kazlauskas (4): drm/amd/display: Move DCN314 DOMAIN power control to DMCUB drm/amd/display: Enable P-state validation checks for DCN314 drm/amd/display: Update Z8 SR exit/enter latencies drm/amd/display: Disable HUBP/DPP PG on DCN314 for now Samson Tam (1): drm/amd/display: enable DPG when disabling plane for phantom pipe Tom Chung (1): drm/amd/display: Fix video glitch while drag window in PSR-SU Wenjing Liu (4): drm/amd/display: do not set RX back to SST mode for non 0 mst stream count drm/amd/display: Extract temp drm mst deallocation wa into its own function drm/amd/display: on dp link lost event toggle dpms for master pipe only drm/amd/display: move public dc link function implementation to dc_link_exports .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 83 +++- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 22 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.h | 1 + drivers/gpu/drm/amd/display/dc/Makefile | 2 +- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 31 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 47 +- .../drm/amd/display/dc/core/dc_link_exports.c | 103 + drivers/gpu/drm/amd/display/dc/dc.h | 211 + drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 3 + drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 136 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 60 +-- drivers/gpu/drm/amd/display/dc/dc_types.h | 109 ++--- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 16 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 16 +- .../drm/amd/display/dc/dcn30/dcn30_resource.h | 3 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- .../drm/amd/display/dc/dcn314/dcn314_hwseq.c | 24 + .../drm/amd/display/dc/dcn314/dcn314_hwseq.h | 2
RE: [PATCH IP-REVIEW 00/26] DC Patches Jan. 16, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - bc9269304ec8 drm/amd/display: 3.2.218) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Alan Liu Sent: January 17, 2023 7:58 AM To: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Amini, Reza ; Bernstein, Eric ; Cyr, Aric ; Kazlauskas, Nicholas ; Lei, Jun ; Leung, Martin ; Liu, Wenjing ; Pavic, Josip ; Sun, Yongqiang ; Othman, Ahmad ; Kotarac, Pavle ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza ; Wheeler, Daniel Cc: Liu, HaoPing (Alan) Subject: [PATCH IP-REVIEW 00/26] DC Patches Jan. 16, 2023 Start from: c3e3354d0433 drm/amd/display: force connector state when bpc changes during compliance Stopped at: 2452279f91cb drm/amd/display: 3.2.220 Please, pay extra attention to the following patches: - c71cc6871515a drm/amd/display: adjust MALL size available for DCN32 and DCN321 Code that changed by this patch is not synchronized between dal and upstream. Please help check if the change is ok. - ab109555e11c drm/amd/display: move eDP panel control logic to link_edp_panel_control There is a IP_CHECK_BODY label but I seem not to find the IP words in the code. Please help check it. Extra notes: - drm/amd/display: Refactor PWM Mechanism for MiniLED - drm/amd/display: Fix ABM not enabled when S3 resume I drop these 2 patches because they depend on another patch (commit 75c0c3caa0 on amd-dal) which was dropped in previous promotion cycle (DC version 3.2.217). - drm/amd/display: Avoid ASSERT for some message failures Drop this patch because such code change is already in upstream. Below are all of the patches in this promotion: Alvin Lee (4): drm/amd/display: Allow idle optimization after turning off all pipes drm/amd/display: Disable SubVP for PSR panels drm/amd/display: Use |= when assigning wm_optimized_required drm/amd/display: Set init freq for DCFCLK DS Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.150.0 Aric Cyr (2): drm/amd/display: 3.2.219 drm/amd/display: 3.2.220 Aurabindo Pillai (3): drm/amd/display: Revert "ignore msa parameter only if freesync is enabled" drm/amd/display: set allow_freesync parameter in DM drm/amd/display: Fix timing not changning when freesync video is enabled Dillon Varone (1): drm/amd/display: Disable MALL SS and messages for PSR supported configs Ilya Bakoulin (1): drm/amd/display: Speed up DML fast_validate path Jingwen Zhu (1): drm/amd/display: avoid disable otg when dig was disabled Qingqing Zhuo (1): drm/amd/display: force connector state when bpc changes during compliance Robin Chen (1): drm/amd/display: Pass DSC slice height to PSR FW Roman Li (1): drm/amd/display: Set hvm_enabled flag for S/G mode Saaem Rizvi (1): drm/amd/display: Correcting prefetch mode for fast validate Samson Tam (1): drm/amd/display: adjust MALL size available for DCN32 and DCN321 Stylon Wang (2): drm/amd/display: Guard Freesync HDMI parsing with dc_lock drm/amd/display: Properly reuse completion structure Sung Joon Kim (1): drm/amd/display: Enable AdaptiveSync in DC interface Wenjing Liu (5): drm/amd/display: create accessories, hwss and protocols sub folders in link drm/amd/display: move eDP panel control logic to link_edp_panel_control drm/amd/display: move dp irq handler functions from
RE: [PATCH 00/37] DC Patches Jan 10, 2023
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 004cf26320ba drm/amd/display: 3.2.217) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: January 10, 2023 11:55 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza ; Wheeler, Daniel Subject: [PATCH 00/37] DC Patches Jan 10, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight the following areas: - Revert patches that caused regressions associated with audio and an old change that checks the DCN version. - Refactor DDC and HDP. - Move DPIA and DPCD logic to new files. - Updates to DMUB. - Optimization and bug fixes for SUBVP/DRR. - Drop legacy code. Cc: Daniel Wheeler Thanks Siqueira Alvin Lee (2): drm/amd/display: Request min clocks after disabling pipes on init drm/amd/display: Allow subvp on vactive pipes that are 2560x1440@60 Aric Cyr (1): drm/amd/display: 3.2.218 Aurabindo Pillai (2): Revert "drm/amd/display: Demote Error Level When ODM Transition Supported" drm/amd/display: fix an error check condition for synced pipes Bhawanpreet Lakha (1): drm/amd/display: Change i2c speed for hdcp Brandon Syu (1): drm/amd/display: fix mapping to non-allocated address Charlene Liu (2): drm/amd/display: add hubbub_init related drm/amd/display: contional remove disable dig_fifo when blank Cruise Hung (1): drm/amd/display: Fix DPIA link encoder assignment issue Dillon Varone (9): drm/amd/display: Implement FIFO enable sequence on DCN32 drm/amd/display: Optimize subvp and drr validation drm/amd/display: Account for DCC Meta pitch in DML MALL surface calculations drm/amd/display: Account for Subvp Phantoms in DML MALL surface calculations drm/amd/display: Use DML for MALL SS and Subvp allocation calculations drm/amd/display: cleanup function args in dml drm/amd/display: set active bit for desktop with VSDBv3 drm/amd/display: Remove DISPCLK dentist programming for dcn32 drm/amd/display: Account for MPO planes in dcn32 mall alloc calculations Dmytro Laktyushkin (1): drm/amd/display: fix multi edp panel instancing Martin Leung (1): Revert "drm/amd/display: Speed up DML fast_validate path" Mustapha Ghaddar (2): drm/amd/display: Update BW alloc after new DMUB logic drm/amd/display: Update dmub header to match DMUB Rodrigo Siqueira (1): drm/amd/display: Remove unused code Saaem Rizvi (2): drm/amd/display: Remove SubVp support if src/dst rect does not equal stream timing drm/amd/display: Add extra mblk for DCC Tony Tascioglu (2): drm/amd/display: Optimize link power-down when link powered externally drm/amd/display: Skip backlight control delay on external powered links Wenjing Liu (7): drm/amd/display: refactor hpd logic from dc_link to link_hpd drm/amd/display: refactor ddc logic from dc_link_ddc to link_ddc drm/amd/display: move dpcd logic from dc_link_dpcd to link_dpcd drm/amd/display: move dc_link_dpia logic to link_dp_dpia drm/amd/display: move dp link training logic to link_dp_training drm/amd/display: move dp phy related logic to link_dp_phy drm/amd/display: move dp capability related logic to link_dp_capability hersen wu (2): drm/amd/display: phase2 enable mst hd
RE: [PATCH 00/12] DC Patches November 28 2022
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Sapphire Pulse RX5700XT Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U]) (1920x1200 [6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 1ee359db35f2c487a063412168724d3a55b72123 -> drm/amdgpu: enable RAS poison for VCN 2.6) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Dhillon, Jasdeep Sent: November 24, 2022 4:14 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Dhillon, Jasdeep ; Wheeler, Daniel Subject: [PATCH 00/12] DC Patches November 28 2022 This DC patchset brings improvements in multiple areas. In summary, we have: * Program output transfer function when required * Fix arthmetic errror in MALL size caluclations for subvp * DCC Meta pitch used for MALL allocation * Debugfs entry to tell if connector is DPIA link * Use largest vready_offset in pipe group * Fixes race condition in DPIA Aux transfer Cc: Daniel Wheeler Alvin Lee (3): drm/amd/display: Retain phantom pipes when min transition into subvp drm/amd/display: Don't overwrite subvp pipe info in fast updates drm/amd/display: Fix DTBCLK disable requests and SRC_SEL programming Aric Cyr (1): drm/amd/display: 3.2.214 Dillon Varone (4): drm/amd/display: MALL SS calculations should iterate over all pipes for cursor drm/amd/display: Use DCC meta pitch for MALL allocation requirements drm/amd/display: Fix arithmetic error in MALL size calculations for subvp drm/amd/display: program output tf when required Dmytro Laktyushkin (1): drm/amd/display: set per pipe dppclk to 0 when dpp is off Stylon Wang (2): drm/amd/display: Fix race condition in DPIA AUX transfer drm/amd/display: Create debugfs to tell if connector is DPIA link Wesley Chalmers (1): drm/amd/display: Use the largest vready_offset in pipe group .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 151 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 17 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 23 ++- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 10 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 23 ++- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 11 ++ .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 30 +++- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 34 +++- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 6 +- .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 8 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 66 +--- .../drm/amd/display/dc/dcn32/dcn32_resource.h | 13 +- .../display/dc/dcn32/dcn32_resource_helpers.c | 15 +- .../amd/display/dc/dcn321/dcn321_resource.c | 2 + .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 3 + .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 9 +- .../gpu/drm/amd/display/dc/inc/core_types.h | 4 +- 19 files changed, 277 insertions(+), 152 deletions(-) -- 2.34.1 <>
RE: [PATCH 0/3] Update DC commit sequence
[Public] Hi all, I tested these patches as well, they were added to the most recent patchset. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Siqueira, Rodrigo Sent: October 11, 2022 2:12 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Wheeler, Daniel ; Kazlauskas, Nicholas ; Wentland, Harry Subject: [PATCH 0/3] Update DC commit sequence This patchset introduces the basic infrastructure to change our display commit sequence to make it more robust and flexible for handling some display features. Current, amdgpu_dm tries to commit a validation state directly into update_planes and commit_streams. However, we want to avoid committing the state directly into DC; instead, we only want to pass streams/plane pointers into DC and let it manage the commit state entirely. This behavior is more future-proof because it keeps the state manipulation inside DC, which can benefit some specific features that might want to play with the context state. Cc: Daniel Wheeler Cc: Nicholas Kazlauskas Cc: Harry Wentland Aurabindo Pillai (1): drm/amd/display: Move dc_state copy in commit_tail after dc_commit_state Rodrigo Siqueira (2): drm/amd/display: Add functions for new DC commit sequence drm/amd/display: Enable new commit sequence only for DCN32x .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 108 ++ .../gpu/drm/amd/display/dc/core/dc_resource.c | 204 +- drivers/gpu/drm/amd/display/dc/dc.h | 6 + drivers/gpu/drm/amd/display/dc/dc_stream.h| 11 +- 5 files changed, 333 insertions(+), 13 deletions(-) -- 2.35.1
RE: [PATCH 00/23] DC Patches October 17th, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - ) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Zhuo, Qingqing (Lillian) Sent: October 6, 2022 5:26 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/23] DC Patches October 17th, 2022 This DC patch-set brings improvements in multiple areas. In summary, we highlight: - PMFW z-state interface update - Cursor update refactor - Fixes to DSC validation, DCFCLK during Freesync, etc. - Code cleanup Cc: Daniel Wheeler --- Alvin Lee (2): drm/amd/display: Fix watermark calculation drm/amd/display: Don't return false if no stream Aric Cyr (1): drm/amd/display: 3.2.207 Aurabindo Pillai (1): drm/amd/display: Do not trigger timing sync for phantom pipes Dillon Varone (4): Revert "drm/amd/display: skip commit minimal transition state" drm/amd/display: Use correct pixel clock to program DTBCLK DTO's drm/amd/display: Acquire FCLK DPM levels on DCN32 drm/amd/display: Fix bug preventing FCLK Pstate allow message being sent Dmytro Laktyushkin (1): drm/amd/display: always allow pstate change when no dpps are active on dcn315 Fangzhi Zuo (1): drm/amd/display: Validate DSC After Enable All New CRTCs Josip Pavic (1): drm/amd/display: do not compare integers of different widths Jun Lei (1): drm/amd/display: Add a helper to map ODM/MPC/Multi-Plane resources Martin Leung (1): drm/amd/display: zeromem mypipe heap struct before using it Max Tseng (1): drm/amd/display: Use the same cursor info across features Meenakshikumar Somasundaram (1): drm/amd/display: Display does not light up after S4 resume Nicholas Kazlauskas (1): drm/amd/display: Update PMFW z-state interface for DCN314 Rodrigo Siqueira (5): drm/amd/display: Add a missing hook to DCN20 drm/amd/display: Clean some DCN32 macros drm/amd/display: Use set_vtotal_min_max to configure OTG VTOTAL drm/amd/display: Drop uncessary OTG lock check drm/amd/display: Remove wrong pipe control lock Vladimir Stempen (2): drm/amd/display: properly configure DCFCLK when enable/disable Freesync drm/amd/display: increase hardware status wait time .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +- .../display/dc/clk_mgr/dcn314/dcn314_smu.c| 11 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 45 +++-- drivers/gpu/drm/amd/display/dc/core/dc.c | 51 +++--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 49 - .../gpu/drm/amd/display/dc/core/dc_stream.c | 4 + drivers/gpu/drm/amd/display/dc/dc.h | 7 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 147 ++- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 + .../gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 1 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 167 +++--- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 29 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 30 .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 12 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 1 + .../gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c | 4 + .../gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.c | 1 - .../amd/display/dc/dcn314/dcn314_resource.c | 3
RE: [PATCH 00/36] DC Patches September 26, 2022
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 9ab6a2850b486e5883418544eb5dc4012343744b -> drm/amd/display: Refactor LTTPR mode selection) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Mahfooz, Hamza Sent: September 28, 2022 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Mahfooz, Hamza ; Wheeler, Daniel Subject: [PATCH 00/36] DC Patches September 26, 2022 This DC patch-set brings improvements in multiple areas. In summary, we highlight: * ILR improvements; * PSR fixes; * DCN315 fixes; * DCN32 fixes; * ODM fixes; * DSC fixes; * SubVP fixes. Cc: Daniel Wheeler Alvin Lee (3): drm/amd/display: Block SubVP if rotation being used drm/amd/display: Disable GSL when enabling phantom pipe drm/amd/display: For SubVP pipe split case use min transition into MPO Aric Cyr (3): Revert "drm/amd/display: correct hostvm flag" drm/amd/display: Fix vupdate and vline position calculation drm/amd/display: 3.2.206 Charlene Liu (1): drm/amd/display: prevent S4 test from failing Dillon Varone (4): drm/amd/display: Program SubVP in dc_commit_state_no_check drm/amd/display: Reorder FCLK P-state switch sequence for DCN32 drm/amd/display: Increase compbuf size prior to updating clocks drm/amd/display: Fix merging dynamic ODM+MPO configs on DCN32 Dmytro Laktyushkin (2): drm/amd/display: add dummy pstate workaround to dcn315 drm/amd/display: fix dcn315 dml detile overestimation Eric Bernstein (1): drm/amd/display: Fix disable DSC logic in ghe DIO code George Shen (1): drm/amd/display: Add missing SDP registers to DCN32 reglist Ian Chen (1): drm/amd/display: Refactor edp ILR caps codes Iswara Nagulendran (1): drm/amd/display: Allow PSR exit when panel is disconnected Leo (Hanghong) Ma (1): drm/amd/display: AUX tracing cleanup Leo Chen (1): drm/amd/display: Add log for LTTPR Leung, Martin (1): drm/amd/display: unblock mcm_luts Lewis Huang (1): drm/amd/display: Keep OTG on when Z10 is disable Martin Leung (1): drm/amd/display: block odd h_total timings from halving pixel rate Rodrigo Siqueira (10): drm/amd/display: Drop unused code for DCN32/321 drm/amd/display: Update DCN321 hook that deals with pipe aquire drm/amd/display: Fix SubVP control flow in the MPO context drm/amd/display: Remove OPTC lock check drm/amd/display: Adding missing HDMI ACP SEND register drm/amd/display: Add PState change high hook for DCN32 drm/amd/display: Enable 2 to 1 ODM policy if supported drm/amd/display: Disconnect DSC for unused pipes during ODM transition drm/amd/display: update DSC for DCN32 drm/amd/display: Minor code style change Wenjing Liu (3): drm/amd/display: fix integer overflow during MSA V_Freq calculation drm/amd/display: write all 4 bytes of FFE_PRESET dpcd value drm/amd/display: Add missing mask sh for SYM32_TP_SQ_PULSE register Zhikai Zhai (1): drm/amd/display: skip commit minimal transition state .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 44 - drivers/gpu/drm/amd/display/dc/core/dc.c | 91 ++- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 11 ++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 70 -- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 4 + drivers/gpu/drm/amd/display/dc/dce/dc
RE: [PATCH 00/31] DC Patches Sept 26, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 54065fc1526389eac66fd90abc51fa97b12c0186 -> drm/amdgpu: Fix amdgpu_vm_pt_free warning) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Dhillon, Jasdeep Sent: September 21, 2022 8:18 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Dhillon, Jasdeep ; Wheeler, Daniel Subject: [PATCH 00/31] DC Patches Sept 26, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: - LTTPR mode can be be dynamically changed - features able to use same interface to update cursor info - fixes for llvm compilation issues - Fixes DIO FIFO underflow and other FIFO errors - Partially valid EDIDs handled properly - Phatom pipes are skipped when checking pending flip - Fixed audio on display after unplugging Cc: Daniel Wheeler Alvin Lee (4): drm/amd/display: Update DCN32 to use new SR latencies drm/amd/display: Update MALL SS NumWays calculation drm/amd/display: Disable MALL when TMZ surface drm/amd/display: Fix CAB allocation calculation Aric Cyr (3): drm/amd/display: Remove interface for periodic interrupt 1 drm/amd/display: Fix audio on display after unplugging another drm/amd/display: 3.2.205 Aurabindo Pillai (2): drm/amd/display: skip phantom pipes when checking for pending flip drm/amd/display: fix a divide by zero error Brandon Syu (1): Add debug option for exiting idle optimizations on cursor updates Charlene Liu (1): drm/amd/display: add debug keys for override bios settings. Dillon Varone (1): drm/amd/display: Fix various dynamic ODM transitions on DCN32 Eric Bernstein (1): drm/amd/display: Remove assert for odm transition case Ian Chen (1): Add ABM control to panel_config struct. Ilya Bakoulin (1): drm/amd/display: Change EDID fallback condition Max Tseng (1): drm/amd/display: Cursor Info Update refactor Michael Strauss (1): drm/amd/display: Refactor LTTPR mode selection Nathan Chancellor (2): drm/amd/display: Reduce number of arguments of dml314's CalculateWatermarksAndDRAMSpeedChangeSupport() drm/amd/display: Reduce number of arguments of dml314's CalculateFlipSchedule() Nicholas Kazlauskas (3): drm/amd/display: Wrap OTG disable workaround with FIFO control drm/amd/display: Add explicit FIFO disable for DP blank drm/amd/display: Do DIO FIFO enable after DP video stream enable Samson Tam (1): drm/amd/display: fill in clock values when DPM is not enabled Taimur Hassan (3): drm/amd/display: Avoid avoid unnecessary pixel rate divider programming drm/amd/display: Fix typo in get_pixel_rate_div drm/amd/display: Avoid unnecessary pixel rate divider programming Tom Rix (3): drm/amd/display: remove redundant CalculateTWait's drm/amd/display: refactor CalculateWriteBackDelay to use vba_vars_st ptr drm/amd/display: remove redundant CalculateRemoteSurfaceFlipDelay's Wenjing Liu (2): drm/amd/display: add missing null check drm/amd/display: polling vid stream status in hpo dp blank .../drm/amd/display/dc/bios/bios_parser2.c| 21 +- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 11 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 14 + drivers/gpu/drm/amd/display/dc/core/dc.c | 127 +++-- .../gpu/drm/amd/display/dc/core/dc_link_ddc.c | 19 + .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 301 ++- .../drm/amd/display/dc/core/dc_link_dpi
RE: [PATCH 00/33] DC Patches August 27 ,2022
[Public] Hi all, This week this patchset was tested on the following systems: Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - afa4f339ec6175bdd2e9d12d771aef3cfedb5960) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of brichang Sent: August 26, 2022 6:27 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chang, Brian ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/33] DC Patches August 27 ,2022 This DC patchset brings improvements in multiple areas. In summary, we have: * Correct cursor position on horizontal mirror; * Fix black flash when switching from ODM2to1 to ODMBypass; * Fix plane and stream check; * Fix viewport after pipe merge; * Correct plane for CAB cursor; * Fix comment to correct visual confirm option; * Fix SubVP related regression; * Fix primary EDP link detection; * Fix wrong register access; * Fix cursor size allocation for DCN32/321; * Fix display fresh edge case from MALL for DCN321; * Add HPO instance; * Refactor EDP codes; * Add SubVP scaling case; * Add support for visual confirm color; * Fix PHY state update; * Cleanup PSR flag; * Fix cursor lag with PSR1 eDP; * Add DC debug optioon for LTTPR mode; * Add override flag for some dongle; * Fix SubVP state after pipe programming; * Remove assert from PHY state update; * Fix dig fifo read level before reset; * Add dcn35 basic suppoet; * Fix OTG H timming for dcn314; * Fix aux transaction; * Fix DCN32 DPSTREAMCLK_CNTL programming; * Fix SubVP scheduling issues; * Set ODM policy. Alvin Lee (3): drm/amd/display: Don't choose SubVP display if ActiveMargin > 0 drm/amd/display: Only commit SubVP state after pipe programming drm/amd/display: SubVP missing scaling case Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.132.0 Aric Cyr (1): drm/amd/display: 3.2.201 Aurabindo Pillai (5): drm/amd/display: Fix CAB cursor size allocation for DCN32/321 drm/amd/display: disable display fresh from MALL on an edge case for DCN321 drm/amd/display: use actual cursor size instead of max for CAB allocation drm/amd/display: Revert "program k1/k2 divider for virtual signal for DCN32" drm/amd/display: Use correct plane for CAB cursor size allocation Charlene Liu (2): drm/amd/display: add dcn35 basic support drm/amd/display: fix wrong register access Chen, Leo (1): drm/amd/display: add a override flag as wa for some specific dongle Duncan Ma (1): drm/amd/display: Fix OTG H timing reset for dcn314 Ethan Wellenreiter (2): drm/amd/display: Re-initialize viewport after pipe merge drm/amd/display: Fix check for stream and plane Gabe Teeger (2): drm/amd/display: Cursor lag with PSR1 eDP drm/amd/display: Cleanup PSR flag George Shen (1): drm/amd/display: Fix DCN32 DPSTREAMCLK_CNTL programming Ian Chen (2): drm/amd/display: Refactor edp dsc codes. drm/amd/display: Add comments. Iswara Nagulendran (1): drm/amd/display: Fix primary EDP link detection Leo (Hanghong) Ma (2): drm/amd/display: Add visual confirm color support for SubVP drm/amd/display: Add support for visual confirm color Leo Chen (1): drm/amd/display: Missing HPO instance added Lewis Huang (1): drm/amd/display: Refine aux transaction before retrieve caps Martin Tsai (1): drm/amd/display: Correct cursor position on horizontal mirror Michael Strauss (1): drm/amd/display: Add DC debug option to force LTTPR mode Taimur Hassan (3): drm/amd/display: Set ODM policy based on number of DSC slices drm/amd/display: Remove assert from PHY state update drm/amd/display: Allow PHY state
RE: [PATCH 00/14] DC Patches August 22, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 6339782c00f4e5dda276b1ecc5cb167c5789aa3a) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of brichang Sent: August 22, 2022 5:58 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chang, Brian ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/14] DC Patches August 22, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: * Remove redundant check in atomic_check. * Add log clock table for SMU. * Add SubVP scaling. * Add interface to track PHY state. * Free phantom plane after removing from the context. * Add k1/k2 driver for virtual signal for DCN32. * Fix cursor flicker when entering PSRSU. * Change reg offset for DCN321 and DCN32 during runtime initialization. * Change AUX NACK behavior. * Correct HDMI ODM combine policy. * Fix odm 2:1 policy in 4k144 mode. * Fix pipe split policy for RV2 Alvin Lee (2): drm/amd/display: Free phantom plane and stream properly drm/amd/display: Uncomment SubVP scaling case Aric Cyr (1): drm/amd/display: 3.2.199 Aurabindo Pillai (3): drm/amd/display: change to runtime initialization for reg offsets for DCN32 drm/amd/display: change to runtime initialization for reg offsets for DCN321 drm/amd/display: program k1/k2 divider for virtual signal for DCN32 Derek Lai (1): drm/amd/display: do not change pipe split policy for RV2 Ilya Bakoulin (1): drm/amd/display: Change AUX NACK behavior Leo Chen (1): drm/amd/display: Adding log clock table from SMU Robin Chen (1): drm/amd/display: Cursor flicker when entering PSRSU Roman Li (1): drm/amd/display: Remove redundant check in atomic_check Saaem Rizvi (1): drm/amd/display: HDMI ODM Combine Policy Correction Samson Tam (1): drm/amd/display: fix odm 2:1 policy not being applied consistently in 4k144 modes Taimur Hassan (1): drm/amd/display: Add interface to track PHY state .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 - .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 46 + .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 48 + .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 46 + drivers/gpu/drm/amd/display/dc/core/dc.c | 27 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 12 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 - drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 5 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 - drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 12 +- .../display/dc/dce110/dce110_hw_sequencer.c | 8 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 + .../drm/amd/display/dc/dcn10/dcn10_resource.c | 18 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 9 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 9 +- .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 34 +- .../drm/amd/display/dc/dcn32/dcn32_hwseq.h| 3 + .../gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 + .../drm/amd/display/dc/dcn32/dcn32_resource.c | 658 ++-- .../drm/amd/display/dc/dcn32/dcn32_resource.h | 997 ++ .../amd/display/dc/dcn321/dcn321_resource.c | 638 ++- .../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 32 +- .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 5 + .../gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 6 + .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 2 + 27
RE: [PATCH 00/32] DC Patches July 29 2022
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 83ace616212127dcf707897e39196f45f5bede29 -> drm/amd/display: 3.2.196) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Tom Chung Sent: August 5, 2022 1:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/32] DC Patches July 29 2022 This DC patchset brings along following fixes: - Move fpu file to dml folder - Fix CAB allocation for multiple displays - Add a variable to update FCLK - Fix TMDS 4K@60Hz YCbCr420 corruption issue - Fix MPC tree infinite loop in some case - Fix SubVP calculations - Fix HDMI VSIF V3 blank screen issue - Add some documentation to the code - Allow alternate prefetch modes in DML for DCN32 - Fix VPG instancing for dcn314 HPO - Check correct bounds for stream encoder instances for DCN303 - Enable SubVP by default on DCN32 & DCN321 - Fix DTBCLK not correct for dcn314 - Fix Compile-time warning - Fix the stereo mode hang issue - Fix display light up issue Alvin Lee (8): drm/amd/display: Revert "fix 32 bit compilation errors in dc_dmub_srv.c" drm/amd/display: Add a variable to update FCLK latency drm/amd/display: Refactor SubVP calculation to remove FPU drm/amd/display: Add 16 lines margin for SubVP drm/amd/display: Fix subvp calculations drm/amd/display: Revert "attempt to fix the logic in commit_planes_for_stream()" drm/amd/display: For stereo keep "FLIP_ANY_FRAME" drm/amd/display: Don't try to enter MALL SS if stereo3d Aric Cyr (1): drm/amd/display: 3.2.197 Aurabindo Pillai (3): drm/amd/display: fix CAB allocation for multiple displays drm/amd/display: Check correct bounds for stream encoder instances for DCN303 drm/amd/display: Enable SubVP by default on DCN32 & DCN321 Chiawen Huang (1): drm/amd/display: Device flash garbage before get in OS Daniel Miess (2): drm/amd/display: Use pixels per container logic for DCN314 DCCG dividers drm/amd/display: Fix TMDS 4K@60Hz YCbCr420 corruption issue David Galiffi (2): drm/amd/display: Allow alternate prefetch modes in DML for DCN32 drm/amd/display: Fix Compile-time Warning Duncan Ma (2): drm/amd/display: Fix VPG instancing for dcn314 HPO drm/amd/display: Correct DTBCLK for dcn314 Fudong Wang (1): drm/amd/display: clear optc underflow before turn off odm clock Josip Pavic (1): drm/amd/display: Avoid MPC infinite loop Leo Ma (1): drm/amd/display: Fix HDMI VSIF V3 incorrect issue Meenakshikumar Somasundaram (1): drm/amd/display: Fix TDR eDP and USB4 display light up issue Rodrigo Siqueira (9): drm/amd/display: Create FPU files for DCN314 drm/amd/display: Move populate dml pipes from DCN314 to dml drm/amd/display: Drop FPU flags from Makefile drm/amd/display: Add documentation to some of the cursor struct drm/amd/display: Add basic kernel doc to CRC code under DC drm/amd/display: Add some extra kernel doc to amdgpu_dm drm/amd/display: Document pipe split policy drm/amd/display: Expand documentation for timing drm/amd/display: Document some of the DML structs .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 46 ++- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c| 12 +- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.h| 2 +-
RE: [PATCH 00/31] DC Patches July 22, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, T -Original Message- From: Hung, Alex Sent: July 22, 2022 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel ; Broadworth, Mark ; Hung, Alex Subject: [PATCH 00/31] DC Patches July 22, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Copy crc_skip_count when duplicating CRTC state * Add debug option for idle optimizations on cursor updates * Disable MPC split for DCN32/321 * Add missing ODM 2:1 policy logic * Update DCN32 and DCN321 SR latencies * Add reinstate dram in the FPO logic * Add dc_ctx to link_enc_create() parameters * Cache cursor when cursor exceeds 64x64 * Add support for manual DMUB FAMS trigger * Fix dpstreamclk programming * Add missing AUDIO_DTO_SEL reg field * Add OTG/ODM functions * Use correct clock source constructor for DCN314 * Use correct DTO_SRC_SEL for 128b/132b encoding * Add pixel rate div calcs and programming * Remove FPU flags from DCN30 Makefile * Create patch bounding box function for isolate FPU * Move mclk calculation function to DML * Remove FPU operations from dcn201 resources * Fallback to SW cursor if SubVP + cursor too big * Drop unnecessary FPU flags on dcn302 files * Reboot while unplug hdcp enabled dp from mst hub * Reset pipe count when iterating for DET override * Calculate MALL cache lines based on Mblks required * Fix two MPO videos in single display ODM combine mode * Guard against zero memory channels * Updates SubVP + SubVP DRR cases updates * Fix OPTC function pointers for DCN314 * Add enable/disable FIFO callbacks to stream setup * Avoid MPC infinite loop Alvin Lee (6): drm/amd/display: Updates SubVP and SubVP DRR cases drm/amd/display: Calculate MALL cache lines based on Mblks required drm/amd/display: Fallback to SW cursor if SubVP + cursor too big drm/amd/display: Update DCN32 and DCN321 SR latencies drm/amd/display: Disable MPC split for DCN32/321 drm/amd/display: Add debug option for idle optimizations on cursor updates Anthony Koo (2): drm/amd/display: Add support for manual DMUB FAMS trigger drm/amd/display: 3.2.196 Aric Cyr (1): drm/amd/display: Avoid MPC infinite loop Aurabindo Pillai (1): drm/amd/display: Add dc_ctx to link_enc_create() parameters Chris Park (1): drm/amd/display: Cache cursor when cursor exceeds 64x64 Leo Li (1): drm/amd/display: Copy crc_skip_count when duplicating CRTC state Michael Strauss (6): drm/amd/display: Add pixel rate div calcs and programming drm/amd/display: Use correct DTO_SRC_SEL for 128b/132b encoding drm/amd/display: Use correct clock source constructor for DCN314 drm/amd/display: Add OTG/ODM functions drm/amd/display: Add missing AUDIO_DTO_SEL reg field drm/amd/display: Fix dpstreamclk programming Nicholas Kazlauskas (3): drm/amd/display: Add enable/disable FIFO callbacks to stream setup drm/amd/display: Fix OPTC function pointers for DCN314 drm/amd/display: Guard against zero memory channels Rodrigo Siqueira (6): drm/amd/display: Drop unnecessary FPU flags on dcn302 files drm/amd/display: Remove FPU operations from dcn201 resources drm/amd/display: Move mclk calculation function to DML drm/amd/display: Create patch bounding box function for isolate FPU drm/amd/display: Remove FPU flags from DCN30 Makefile drm/amd/display: Add
RE: [PATCH 00/31] DC Patches July 15, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 01a992129a037dee0834eabfd92e15eb376d185f) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Rodrigo Siqueira Sent: July 15, 2022 2:17 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/31] DC Patches July 15, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Isolate FPU operation for DCN32/321 under the DML folder - Create a specific file for CRTC and plane based on amdgpu_dm - Fix DSC issues - Updates tp DML logic Cc: Daniel Wheeler Thanks Siqueira Alvin Lee (2): drm/amd/display: Update in dml drm/amd/display: Don't set dram clock change requirement for SubVP Aric Cyr (1): drm/amd/display: 3.2.195 Chris Park (1): drm/amd/display: Update Cursor Attribute MALL cache Jun Lei (2): drm/amd/display: Remove unused variable drm/amd/display: Update DML logic for unbounded req handling Rodrigo Siqueira (16): drm/amd/display: Create a file dedicated to planes drm/amd/display: Create a file dedicated for CRTC drm/amd/display: Fix hard hang if DSC is disabled drm/amd/display: Drop FPU flags from dcn32_clk_mgr drm/amd/display: Move populate phaton function to dml drm/amd/display: Move predict pipe to dml fpu folder drm/amd/display: Move insert entry table to the FPU code drm/amd/display: Move phanton stream to FPU code drm/amd/display: Move SubVP functions to dcn32_fpu drm/amd/display: Move wm and dlg calculation to FPU code drm/amd/display: Move dlg params calculation drm/amd/display: Move ntuple to insert entry drm/amd/display: Move bounding box to FPU folder drm/amd/display: Drop FPU flags from dcn32 Makefile drm/amd/display: Create dcn321_fpu file drm/amd/display: Drop FPU code from dcn321 resource Taimur Hassan (2): drm/amd/display: Update de-tile override to anticipate pipe splitting drm/amd/display: Loop through all pipes for DET allocation Vladimir Stempen (1): drm/amd/display: Disable GPUVM in IP resource configuration Wayne Lin (5): drm/amd/display: Support vertical interrupt 0 for all dcn ASIC drm/amd/display: Expose function reset_cur_dp_mst_topology drm/amd/display: fix trigger_hotplug to support mst case drm/amd/display: Add is_mst_connector debugfs entry drm/amd/display: Add tags for indicating mst progress status Wenjing Liu (1): drm/amd/display: remove number of DSC slices override in DML .../gpu/drm/amd/display/amdgpu_dm/Makefile|8 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2557 +++-- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 20 + .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 463 +++ .../amd/display/amdgpu_dm/amdgpu_dm_crtc.h| 51 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 114 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 + .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1637 +++ .../amd/display/amdgpu_dm/amdgpu_dm_plane.h | 73 + .../gpu/drm/amd/display/dc/clk_mgr/Makefile | 25 - .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 81 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c |2 +- drivers/gpu/drm/amd/display/dc/dc.h |3 +- drivers/gpu/drm/amd/display/dc/dc_link.h |3 + drivers/gpu/drm/amd
RE: [PATCH 00/21] DC Patches July 11, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - fb4b180ff861b3734bab3a47456f40fbc4fa44ed) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Solomon Chiu Sent: July 8, 2022 12:35 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/21] DC Patches July 11, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fixes for MST, MPO, PSRSU, DP 2.0, Freesync and others - Add register offsets of NBI and DCN. - Improvement of ALPM - Removing assert statement for Linux DM - Re-implementing ARGB16161616 pixel format Aric Cyr (2): drm/amd/display: 3.2.193 drm/amd/display: 3.2.194 Aurabindo Pillai (1): drm/amd/display: Add NBIO reg offsets to DC Charlene Liu (1): drm/amd/display: add system info table log Chris Park (1): drm/amd/display: Reduce SCDC Status Flags Definition Fangzhi Zuo (1): drm/amd/display: Ignore First MST Sideband Message Return Error Harry Wentland (1): drm/amd/display: Add DCN reg offsets to DC Ilya Bakoulin (1): drm/amd/display: Fix black screen when disabling Freesync in OSD Lee, Alvin (1): drm/amd/display: Exit SubVP if MPO in use Lei, Jun (1): drm/amd/display: update DML1 logic for unbounded req handling Robin Chen (1): drm/amd/display: Disable PSRSU when DSC enabled on the specific sink Rodrigo Siqueira (1): drm/amd/display: Fix wrong reference Saaem Rizvi (1): drm/amd/display: Removing assert statements for Linux Samson Tam (2): drm/amd/display: Fix windowed MPO video with ODM combine for DCN32 drm/amd/display: Fix lag when moving windowed MPO across display using ODM 2:1 combine Wayne Lin (2): drm/amd/display: Clear edid when unplug mst connector drm/amd/display: Grab dc_lock before detecting link Wellenreiter, Ethan (1): drm/amd/display: Re-implementing ARGB16161616 pixel format as 22 Wenjing Liu (1): drm/amd/display: make enable link independent from verified link caps Wesley Chalmers (1): drm/amd/display: Check for DP2.0 when checking ODM combine muansari (1): drm/amd/display: Helper function for ALPM initialization .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 115 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 8 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 11 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 19 +++ .../drm/amd/display/dc/bios/bios_parser2.c| 30 .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 8 +- .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 7 +- .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 8 +- .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 8 +- .../display/dc/clk_mgr/dcn316/dcn316_smu.c| 8 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 136 ++- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 54 +++--- .../gpu/drm/amd/display/dc/core/dc_link_ddc.c | 7 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 45 ++--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 157 ++ drivers/gpu/drm/amd/display/dc/dc.h
RE: [PATCH 00/40] DC Patches Jun 30, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 14ce34dd0d7dc6fe5b030405bac074acf402e2e1) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Sr. Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Siqueira, Rodrigo Sent: June 30, 2022 3:13 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Zuo, Jerry ; Mahfooz, Hamza ; Wheeler, Daniel Subject: [PATCH 00/40] DC Patches Jun 30, 2022 This DC patchset is a large one that brings improvements in multiple areas. In summary, we highlight: - Program ACP-related registers - Fixes for DMUB, DPIA, PSR, and others - Improvements in the pipe split - Add SubVP code - Add basic setup for FAMS support - Improve BB capabilities Cc: Daniel Wheeler Thanks Siqueira Alan Liu (1): drm/amd/display: Program ACP related register Alvin Lee (5): drm/amd/display: Add SubVP required code drm/amd/display: Change DET policy for MPO cases drm/amd/display: Make OPTC3 function accessible to other DCN drm/amd/display: Don't set dram clock change requirement for SubVP drm/amd/display: Maintain old audio programming sequence Aric Cyr (1): drm/amd/display: 3.2.192 Chris Park (3): drm/amd/display: Switch to correct DTO on HDMI drm/amd/display: Indicate stream change on ODM change drm/amd/display: OVT Update on InfoFrame and Mode Management Dmytro Laktyushkin (2): drm/amd/display: disable timing sync b/w odm halves drm/amd/display: disable otg toggle w/a on boot Duncan Ma (1): drm/amd/display: Add flag to modify MST delay Eric Bernstein (3): drm/amd/display: Add function to set pixels per cycle drm/amd/display: Update gpuvm_max_page_table_levels IP param drm/amd/display: Fix null timing generator resource Evgenii Krasnikov (1): drm/amd/display: add an option to skip wait for HPD when powering on eDP panel Fangzhi Zuo (1): drm/amd/display: Fix dmub soft hang for PSR 1 Hamza Mahfooz (2): drm/amd/display: enable PCON SST support for newer ASICs drm/amd/display: rename hdmi_frl_pcon_support Harry Wentland (1): drm/amd/display: Move all linux includes into OS types Jimmy Kizito (3): drm/amd/display: Maintain consistent mode of operation during encoder assignment drm/amd/display: Disable TBT3 DSC work around by default. drm/amd/display: Fix uninitialized variable. Jun Lei (1): drm/amd/display: Extend soc BB capabilitiy Martin Leung (2): drm/amd/display: Prepare for new interfaces drm/amd/display: guard for virtual calling destroy_link_encoders Meenakshikumar Somasundaram (1): drm/amd/display: Remove configuration option for dpia hpd delay Michael Strauss (1): drm/amd/display: Initialize lt_settings on instantiation Nicholas Kazlauskas (4): drm/amd/display: Fix stream->link_enc unassigned during stream removal drm/amd/display: Guard against ddc_pin being NULL for AUX drm/amd/display: Remove incorrect ASSERT check for link_enc drm/amd/display: Guard against NULL link encoder in log hw state Rodrigo Siqueira (6): drm/amd/display: Add missing registers for ACP drm/amd/display: Use two pixel per container for k1/k2 div drm/amd/display: Add basic infrastructure for enabling FAMS drm/amd/display: Add SubVP control lock drm/amd/display: Add minimal pipe split transition state drm/amd/display: Fix refresh rate issue on Club 3D Samson Tam (1): drm/amd/display: Apply ODM 2:1 policy for single display configurat
RE: [PATCH 00/31] DC Patches June 17, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - daa21bfa14f16caef5b7d8f8938a1334c620aaf1) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Sent: June 17, 2022 3:35 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Zuo, Jerry ; Pillai, Aurabindo ; Mahfooz, Hamza ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/31] DC Patches June 17, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: - Remove unnecessary code; - Small fixes (compilation warnings, typos, etc); - Improvements in the DPMS code; - Fix eDP issues; - Improvements in the MST code. Thanks Siqueira Alvin Lee (2): drm/amd/display: Update DPPCLK programming sequence drm/amd/display: Update SW state correctly for FCLK Aric Cyr (2): drm/amd/display: Change initializer to single brace drm/amd/display: 3.2.191 Chaitanya Dhere (1): drm/amd/display: Implement a pme workaround function Cruise Hung (1): drm/amd/display: Remove compiler warning Dmytro Laktyushkin (1): drm/amd/display: Fix in dp link-training when updating payload allocation table George Shen (5): drm/amd/display: Fix in overriding DP drive settings drm/amd/display: Fix typo in override_lane_settings drm/amd/display: Handle downstream LTTPR with fixed VS sequence drm/amd/display: Remove unused vendor specific w/a drm/amd/display: Fix divide-by-zero in DPPCLK and DISPCLK calculation Ian Chen (1): drm/amd/display: Drop unnecessary detect link code JinZe.Xu (1): drm/amd/display: Change HDMI judgement condition. Nicholas Choi (1): drm/amd/display: refactor function transmitter_to_phy_id Qingqing Zhuo (1): drm/amd/display: Fix DC warning at driver load Rodrigo Siqueira (4): drm/amd/display: Check minimum disp_clk and dpp_clk debug option drm/amd/display: Get VCO frequency from registers drm/amd/display: Update hook dcn32_funcs drm/amd/display: Drop duplicate define Saaem Rizvi (1): drm/amd/display: Add SMU logging code Sung Joon Kim (2): drm/amd/display: Fix eDP not light up on resume drm/amd/display: Turn off internal backlight when plugging external monitor Wayne Lin (4): drm/amd/display: Revert "drm/amd/display: Add flag to detect dpms force off during HPD" drm/amd/display: Revert "drm/amd/display: turn DPMS off on connector unplug" drm/amd/display: Release remote dc_sink under mst scenario drm/amd/display: Take emulated dc_sink into account for HDCP Wenjing Liu (3): drm/amd/display: Enrich the log in MST payload update drm/amd/display: rename lane_settings to hw_lane_settings drm/amd/display: extract update stream allocation to link_hwss hersen wu (1): drm/amd/display: add mst port output bw check .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 57 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 5 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 8 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 1 + .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 70 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 4 + .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 12 + .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 12 + .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 8 + .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 2 +- .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 8 +
RE: [PATCH 00/23] DC Patches June 06, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - e426d449d8ce177c6dad562a1093332c738a56b3 -> drm/amd/amdgpu: Fix alignment issue) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: June 10, 2022 4:52 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Zuo, Jerry ; Pillai, Aurabindo ; Mahfooz, Hamza ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/23] DC Patches June 06, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: * DP fixes * Reduced frame size in the bouding boxes of a number of ASICs. * Exiting idle optimizations * General cleanup * Power management optimizations * HF-VSIF support * VTEM support * FVA timing improvements Ahmad Othman (2): drm/amd/display: Add support for HF-VSIF drm/amd/display: Adding VTEM to dc Aric Cyr (1): drm/amd/display: 3.2.190 Charlene Liu (1): drm/amd/display: FVA timing adjustment Felipe (2): drm/amd/display: Firmware assisted MCLK switch and FS drm/amd/display: Pass vrr mode to dcn Hamza Mahfooz (1): drm/amd/display: fix build when CONFIG_DRM_AMD_DC_DCN is not defined Harry VanZyllDeJong (1): drm/amd/display: Disables dynamic memory clock switching in games Ian Chen (1): drm/amd/display: DAL ACR, dc part, fix missing dcn30 Joshua Aberback (1): drm/amd/display: Blank for uclk OC in dm instead of dc Lee, Alvin (1): drm/amd/display: Add debug option for exiting idle optimizations on cursor updates Martin Leung (1): drm/amd/display: Add null check to dc_submit_i2c_oem Nicholas Kazlauskas (1): drm/amd/display: Copy hfvsif_infopacket when stream update Oliver Logush (1): drm/amd/display: Drop unused privacy_mask setters and getters Qingqing Zhuo (1): drm/amd/display: update topology_update_input_v3 struct Rodrigo Siqueira (4): drm/amd/display: Reduce frame size in the bouding box for DCN20 drm/amd/display: Reduce frame size in the bouding box for DCN301 drm/amd/display: Reduce frame size in the bouding box for DCN31/316 drm/amd/display: Reduce frame size in the bouding box for DCN21 Samson Tam (1): drm/amd/display: Fix comments Shah, Dharati (1): drm/amd/display: Fix monitor flash issue Wenjing Liu (1): drm/amd/display: lower lane count first when CR done partially fails in EQ hersen wu (1): drm/amd/display: dsc validate fail not pass to atomic check .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 2 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 43 .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 2 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 23 --- .../dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c | 11 ++- drivers/gpu/drm/amd/display/dc/core/dc.c | 66 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 ++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 13 ++-- .../gpu/drm/amd/display/dc/core/dc_resource.c | 27 +++- .../gpu/drm/amd/display/dc/core/dc_stream.c | 5 +- drivers/gpu/drm/amd/display/dc/dc.h | 13 ++-- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 + drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 9 ++- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 - .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 1 +
RE: [PATCH 00/16] DC Patches May 30, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit - 79d15ef553971d39ae0df0c3ccf35905e4e4f1bf -> drm/amd/display: Add DCN32/321 version identifiers) with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Hamza Mahfooz Sent: June 3, 2022 4:12 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Zuo, Jerry ; Pillai, Aurabindo ; Mahfooz, Hamza ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/16] DC Patches May 30, 2022 * DPP DTO fix * Transient encoder fix * Restrict the reading of LTTPR capabilities in LTTPR mode * Increase maximum stages for BB * Distinguish HDMI DTO from DP DTO * Optimized blank calculations * More robust DP MST hotplug support * eDP bug fix relating to ODM * Revert a patch that caused a regression with DP * min comp buffer size fix * Make DP easier to debug * Calculate the maximum OLED brightness correctly * 3 plane MPO. Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.119.0 Aric Cyr (2): drm/amd/display: 3.2.188 drm/amd/display: 3.2.189 Chris Park (1): drm/amd/display: Add HDMI member to DTO Duncan Ma (3): drm/amd/display: Blank eDP on enable drv if odm enabled drm/amd/display: Correct min comp buffer size drm/amd/display: Fix dpp dto for disabled pipes Gabe Teeger (1): drm/amd/display: Update optimized blank calc and programming Hansen Dsouza (1): drm/amd/display: Enable 3 plane MPO Jimmy Kizito (2): drm/amd/display: Fix entry into transient encoder assignment mode. drm/amd/display: Avoid reading LTTPR caps in non-LTTPR mode. Lei, Jun (1): drm/amd/display: Extend soc BB capabilitiy Nicholas Kazlauskas (1): Revert "drm/amd/display: Pass the new context into disable OTG WA" Roman Li (1): drm/amd/display: Cap OLED brightness per max frame-average luminance Wayne Lin (1): drm/amd/display: Detect dpcd_rev when hotplug mst monitor Wenjing Liu (1): drm/amd/display: add DP sanity checks during enable stream .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 38 - .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 8 +- .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 8 +- .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 8 +- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 21 + .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 77 +-- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 45 ++- drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 4 + .../display/dc/dcn31/dcn31_dio_link_encoder.c | 6 ++ .../gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 24 +-
RE: [PATCH 0/8] May 24, 2022
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the most recent amd-staging-drm-next (Head commit - da38a66ac46e334f198afcd1b4d4554b4ddca0df - drm/amdgpu: Ensure the DMA engine is deactivated during set ups) branch with a selection of patches added on top of it. This goes for both Ubuntu testing and Chrome OS testing. Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Jasdeep Dhillon Sent: May 24, 2022 1:47 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Dhillon, Jasdeep ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 0/8] May 24, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: *Changes to DP LT fallback behavior to more closely match the DP standard *Added new interfaces for lut pipeline *Restore ref_dtblck value when clk struct is cleared in init_clocks *Fixes DMUB outbox trace in S4 *Fixes lingering DIO FIFO errors when DIO no longer enabled *Reads Golden Settings Table from VBIOS Alvin (1): drm/amd/display: Don't clear ref_dtbclk value Aric Cyr (1): drm/amd/display: 3.2.187 Hung, Cruise (1): drm/amd/display: Fix DMUB outbox trace in S4 (#4465) Ilya (1): drm/amd/display: Fix possible infinite loop in DP LT fallback Leung, Martin (2): drm/amd/display: revert Blank eDP on disable/enable drv Prepare for new interfaces Nicholas Kazlauskas (1): drm/amd/display: Pass the new context into disable OTG WA hengzhou (1): drm/amd/display: Wait DMCUB to idle state before reset. .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 + .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 19 ++- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h | 2 + .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 13 +- .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 11 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 158 +- drivers/gpu/drm/amd/display/dc/dc.h | 6 +- .../display/dc/dce110/dce110_hw_sequencer.c | 23 ++- .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 79 - .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h | 2 +- .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h | 1 + drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 20 ++- drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 5 + .../amd/display/dc/inc/hw_sequencer_private.h | 2 + .../amd/display/dc/link/link_hwss_hpo_dp.c| 19 ++- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 11 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.h | 3 +- .../amd/display/include/ddc_service_types.h | 2 + 19 files changed, 233 insertions(+), 162 deletions(-) -- 2.25.1
RE: [PATCH v2 00/11] DC Patches May 16, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the branch amd-staging-drm-next (Head commit - da38a66ac46e334f198afcd1b4d4554b4ddca0df -> drm/amdgpu: Ensure the DMA engine is deactivated during set ups) with a selection of patches added on top of it. This goes for both Ubuntu testing and Chrome OS testing. Tested on Ubuntu 22.04 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Qingqing Zhuo Sent: May 13, 2022 5:17 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH v2 00/11] DC Patches May 16, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improvements in link training fallback * Adding individual edp hotplug support * Fixes in DPIA HPD status, display clock change hang, etc. * FPU isolation work for DCN30 --- Alvin Lee (1): drm/amd/display: Clean up code in dc Aric Cyr (1): drm/amd/display: 3.2.186 Bhawanpreet Lakha (1): drm/amd/display: Fic incorrect pipe being used for clk update David Galiffi (1): drm/amd/display: Check if modulo is 0 before dividing. Derek Lai (1): drm/amd/display: Allow individual control of eDP hotplug support Jasdeep Dhillon (1): drm/amd/display: Move FPU associated DCN30 code to DML folder Jimmy Kizito (2): drm/amd/display: Update link training fallback behaviour. drm/amd/display: Query DPIA HPD status. Michael Strauss (1): Revert "drm/amd/display: Refactor LTTPR cap retrieval" Nicholas Kazlauskas (1): drm/amd/display: Check zero planes for OTG disable W/A on clock change Paul Hsieh (1): drm/amd/display: clear request when release aux engine .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 3 +- .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 24 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 248 --- .../drm/amd/display/dc/core/dc_link_dpia.c| 19 + drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 2 - drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 3 +- .../drm/amd/display/dc/dce/dce_clock_source.c | 9 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - .../gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 10 + .../drm/amd/display/dc/dcn30/dcn30_resource.c | 516 ++- .../drm/amd/display/dc/dcn30/dcn30_resource.h | 5 + .../amd/display/dc/dcn301/dcn301_resource.c | 2 + .../amd/display/dc/dcn302/dcn302_resource.c | 2 + .../amd/display/dc/dcn303/dcn303_resource.c | 2 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 + drivers/gpu/drm/amd/display/dc/dml/Makefile | 3 +- .../drm/amd/display/dc/dml/dcn30/dcn30_fpu.c | 617 ++ .../drm/amd/display/dc/dml/dcn30/dcn30_fpu.h | 67 ++ .../gpu/drm/amd/display/dc/inc/core_types.h | 7 + .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 3 +- .../gpu/drm/amd/display/dc/inc/dc_link_dpia.h | 5 + .../amd/display/include/link_service_types.h | 6 - 26 files changed, 947 insertions(+), 633 deletions(-) create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.c create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn30/dcn30_fpu.h -- 2.25.1
RE: How are the DC patches tested?
[Public] Hi Paul, I've made some edits to my cover letter to hopefully make it clearer with what is being done. Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Sapphire Pulse RX5700XT Reference AMD RX6800 Engineering board with Ryzen 9 5900H These systems were tested on the following display types: eDP, (1080p 60hz [4500U, 5650U, 5900H]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the most recent amd-staging-drm-next branch with a selection of patches added on top of it. This goes for both Ubuntu testing and Chrome OS testing. Tested on Ubuntu 22.04 and Chrome OS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: Paul Menzel Sent: May 9, 2022 10:28 AM To: Siqueira, Rodrigo Cc: Wheeler, Daniel ; Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Li, Roman ; amd-gfx@lists.freedesktop.org; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: Re: How are the DC patches tested? Dear Rodrigo, Thank you for the quick response. Am 09.05.22 um 16:15 schrieb Rodrigo Siqueira Jordao: > On 2022-05-09 10:00, Paul Menzel wrote: >> Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: >> >> […] >> >>> This week this patchset was tested on the following systems: >>> >>> Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following >>> display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), >>> 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP >>> and then DP to DVI/VGA) >>> >>> Sapphire Pulse RX5700XT with the following display types: 4k 60hz >>> (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to >>> DVI/VGA) >>> >>> Reference AMD RX6800 with the following display types: 4k 60hz (via >>> DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and >>> USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) >>> >>> Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and >>> DSC via USB-C to DP DSC Hub with 3x 4k 60hz. >>> >>> Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS >> >> I am curious, what this means exactly? You clone the Ubuntu Linux >> 5.16 kernel source, and then apply your patches on top? (Do they even >> apply?) > > All of these "promotion" patches are tested by using > amd-staging-drm-next. In a few words: > > 1. We get the latest code from amd-staging-drm-next; 2. We apply these > weekly promotion patches on top of it; 3. We compile, run unit tests, > and run many manual tests (Daniel does that). > > If everything is alright with Daniel's tests, we feel confident to > merge these series on top amd-staging-drm-next (we are basically > trying to avoid regressions here). > > Anyway, maybe we can rephrase: > > Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS > > to > > Tested on Ubuntu 22.04 and ChromeOS with amd-staging-drm-next + > promotion patches. Yes, that’d be great. Maybe even reference the commit hash from the commit on top of *amd-staging-drm-next*. (Nit: ChromeOS → Chrome OS) >> The same for Chrome OS. Do you use Chrome OS Flex [1] with the >> systems you listed? If not, what Google Chromebooks/-boxes did you test with? >> The Linux kernel version is also tied for a device and Chrome OS >> release. Please mention those too. As written, the used Chrome OS version (and devices) would be helpful too. >> Is it documented somewhere, what tests you run exactly? > > We run IGT tests, some scripts that validate some specific areas, and > Daniel has an extensive set of manual tests. Kind regards, Paul
RE: [PATCH 00/15] DC Patches May 9, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16, and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Stylon Wang Sent: May 6, 2022 11:42 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/15] DC Patches May 9, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Refactor LTTPR code - Fix PSR after hibernate - Fix DC build errors - Fix IRQ unregister error when unloading amdgpu - Improve DP link training - Fix stutter - Remove redundant CONFIG_DRM_AMD_DC_DCN guards - Fix 2nd connected USB-C display not lighting up --- Alan Liu (1): drm/amd/display: do not disable an invalid irq source in hdp finish Alex Hung (7): drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dce drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in gpio drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in irq drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN for z10 drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in amdgpu_dm drm/amd/display: remove unnecessary else by CONFIG_DRM_AMD_DC_DCN Aric Cyr (1): drm/amd/display: 3.2.185 Evgenii Krasnikov (1): drm/amd/display: Reset cached PSR parameters after hibernate Josip Pavic (2): drm/amd/display: move definition of dc_flip_addrs struct drm/amd/display: do not wait for vblank during pipe programming Michael Strauss (1): drm/amd/display: Refactor LTTPR cap retrieval Stylon Wang (1): Revert "drm/amd/display: Fix DCN3 B0 DP Alt Mapping" Wenjing Liu (1): drm/amd/display: do not calculate DP2.0 SST payload when link is off .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 46 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 - .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 6 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 - .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 3 - .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 4 - drivers/gpu/drm/amd/display/dc/Makefile | 2 - .../display/dc/bios/command_table_helper2.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 41 +--- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 179 ++ .../drm/amd/display/dc/core/dc_link_dpia.c| 2 - .../gpu/drm/amd/display/dc/core/dc_resource.c | 25 +-- .../gpu/drm/amd/display/dc/core/dc_stream.c | 12 -- drivers/gpu/drm/amd/display/dc/dc.h | 51 + drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 16 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 2 + .../drm/amd/display/dc/dce/dce_clock_source.c | 15 +- .../drm/amd/display/dc/dce/dce_clock_source.h | 12 +- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 10 - .../amd/display/dc/dce/dce_stream_encoder.c | 21 +- .../display/dc/dce110/dce110_hw_sequencer.c | 2 - .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - .../drm/amd/display/dc/dcn31/dcn31_resource.c | 6 - drivers/gpu/drm/amd/display/dc/dm_helpers.h | 2 - drivers/gpu/drm/amd/display/dc/gpio/Makefile | 3 +- .../display/dc/gpio/dcn30/hw_factory_dcn30.c | 2 - .../display/dc/gpio/dcn30/hw_factory_dcn30.h | 2 - .../dc/gpio/dcn30/hw_translate_dcn30.c| 2 - .../dc/gpio/dcn30/hw_translate_dcn30.h| 2 - .../gpu/drm/amd/display/dc/gpio/hw_factory.c | 4 - .../drm/amd/display/dc/gpio/hw_translate.c| 4 - .../gpu/drm/amd/display/dc/inc/core_types.h |
RE: [PATCH 0/8] DC Patches April 27, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 22.04 with Kernel Version 5.16 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Wayne Lin Sent: April 26, 2022 10:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 0/8] DC Patches April 27, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Have optc3 function accessible to newer DCN * Add CM boot option for USB4 tunneling * Fix system hang issue when game resolution is changed * Remove outdated register for dcn3+ * Add new DSC interface to disconnect from pipe * Clean up pixel format types in enum surface_pixel_format --- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.115.0 Aric Cyr (2): drm/amd/display: Clean up pixel format types drm/amd/display: 3.2.184 Eric Bernstein (1): drm/amd/display: Add new DSC interface to disconnect from pipe Evgenii Krasnikov (1): Revert "drm/amd/display: Reset cached PSR parameters after hibernate" Jimmy Kizito (1): drm/amd/display: Add Connection Manager boot option. Lee, Alvin (1): drm/amd/display: Make OPTC3 function accessible to other DCN Tse, Kaitlyn (1): drm/amd/display: Remove outdated register for dcn3+ drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 +--- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 3 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 11 ++ .../gpu/drm/amd/display/dc/dcn30/dcn30_mpc.h | 5 --- .../gpu/drm/amd/display/dc/dcn30/dcn30_optc.h | 2 +- drivers/gpu/drm/amd/display/dc/inc/hw/dsc.h | 1 + drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 36 ++- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 1 + 10 files changed, 54 insertions(+), 15 deletions(-) -- 2.36.0
RE: [PATCH 00/13] DC Patches April 20 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 20.04.3 with Kernel Version 5.16 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -Original Message- From: amd-gfx On Behalf Of Tom Chung Sent: April 22, 2022 12:45 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chung, ChiaHsuan (Tom) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/13] DC Patches April 20 2022 This version brings along following fixes: - Keep tracking of DSC packed PPS for future use - Maintain current link settings in link loss interrupt - Remove DDC write and read size check - Read PSR-SU cap DPCD for specific panel - Don't pass HostVM by default on DCN3.1 - Reset cached PSR parameters after hibernate - Add audio readback registers - Update dcn315 clk table read - Fix HDCP QUERY Error for eDP and Tiled - Insert smu busy status before sending another request Aric Cyr (2): drm/amd/display: 3.2.182 drm/amd/display: 3.2.183 David Zhang (1): drm/amd/display: read PSR-SU cap DPCD for specific panel Dillon Varone (1): drm/amd/display: Remove unused integer Dmytro Laktyushkin (1): drm/amd/display: update dcn315 clk table read Evgenii Krasnikov (1): drm/amd/display: Reset cached PSR parameters after hibernate Gary Li (1): drm/amd/display: Maintain current link settings in link loss interrupt Ilya (2): drm/amd/display: Add Audio readback registers drm/amd/display: Keep track of DSC packed PPS Leo (Hanghong) Ma (1): drm/amd/display: Remove ddc write and read size checking Michael Strauss (1): drm/amd/display: Don't pass HostVM by default on DCN3.1 Mustapha Ghaddar (1): drm/amd/display: Fix HDCP QUERY Error for eDP and Tiled Oliver Logush (1): drm/amd/display: Insert smu busy status before sending another request .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 2 + .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 114 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15 +- .../gpu/drm/amd/display/dc/core/dc_link_ddc.c | 6 - .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 15 ++ drivers/gpu/drm/amd/display/dc/dc.h | 10 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 +- .../display/dc/dcn10/dcn10_stream_encoder.c | 1 + .../display/dc/dcn10/dcn10_stream_encoder.h | 8 + .../dc/dcn30/dcn30_dio_stream_encoder.h | 4 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 9 +- .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 145 -- .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h | 1 + .../amd/display/include/ddc_service_types.h | 2 + 14 files changed, 172 insertions(+), 162 deletions(-) -- 2.25.1
RE: DC Patches Apri 6, 2022
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz and DSC via USB-C to DP DSC Hub with 3x 4k 60hz. Tested on Ubuntu 20.04.3 with Kernel Version 5.16 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Pavle Kotarac Sent: April 8, 2022 1:19 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: DC Patches Apri 6, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: *Disabling Z10 on DCN31 *Fix issue breaking 32bit Linux build *Fix inconsistent timestamp type *Add DCN30 support FEC init *Fix crash on setting VRR with no display connected *Disable FEC if DSC not supported for EDP *Add odm seamless boot support *Select correct DTO source *Power down hardware if timer not trigger AMD\syerizvi (1): drm/amd/display: Disabling Z10 on DCN31 Angus Wang (1): drm/amd/display: Fix inconsistent timestamp type Aric Cyr (1): drm/amd/display: 3.2.181 Charlene Liu (1): drm/amd/display: remove dtbclk_ss compensation for dcn316 David Zhang (1): drm/amd/display: implement shared PSR-SU sink validation helper Dillon Varone (2): drm/amd/display: Add dtb clock to dc_clocks drm/amd/display: Select correct DTO source Duncan Ma (1): drm/amd/display: Add odm seamless boot support Eric Yang (1): drm/amd/display: undo clearing of z10 related function pointers Evgenii Krasnikov (1): drm/amd/display: ensure PSR force_static flag can always be set Harry VanZyllDeJong (1): drm/amd/display: Fix crash on setting VRR with no display connected Hayden Goodfellow (1): drm/amd/display: Fix issue breaking 32bit Linux build Iswara Nagulendran (1): drm/amd/display: Disable FEC if DSC not supported for EDP Jingwen Zhu (1): drm/amd/display: add DCN30 support FEC init Josip Pavic (1): drm/amd/display: do not wait for mpc idle if tg is disabled Max Erenberg (1): drm/amd/display: Disallow entering PSR when panel is disconnected Oliver Logush (2): drm/amd/display: Insert pulling smu busy status before sending another request drm/amd/display: Always update DPPCLK_DTO when clock increase Paul Hsieh (1): drm/amd/display: Power down hardware if timer not trigger hersen wu (1): drm/amd/display: expose skip_detection_link_training to debugfs .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 37 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 9 +- .../display/dc/clk_mgr/dce100/dce_clk_mgr.c | 2 +- .../dc/clk_mgr/dcn201/dcn201_clk_mgr.c| 3 +- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 17 +++- .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 3 + .../display/dc/clk_mgr/dcn301/vg_clk_mgr.c| 3 +- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 26 +- .../dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 +++ drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 +++- .../gpu/drm/amd/display/dc/core/dc_resource.c | 82 --- drivers/gpu/drm/amd/display/dc/dc.h | 6 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 1 + .../drm/amd/display/dc/dce/dce_clock_source.c | 2 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 40 +++-- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 6 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 5 -- .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.c | 21 + .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.h | 2 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 1 + .../amd/display/dc/inc/hw/timing_generator.h | 2 + .../amd/display/modules/freesync/freesync.c | 5 +-
RE: [PATCH] drm/amdgpu/display: change pipe policy for DCN 2.1
[Public]
I never saw the hang with my testing, not sure if anyone else happened to see
it. I'm not opposed to including the line.
Thank you,
Dan Wheeler
Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook | Twitter | amd.com
-Original Message-
From: Alex Deucher
Sent: March 25, 2022 2:11 PM
To: Benjamin Marty ; Siqueira, Rodrigo
; Wheeler, Daniel
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu/display: change pipe policy for DCN 2.1
@Wheeler, Daniel
@Siqueira, Rodrigo were you able to repro this? Any ideas? Any downsides to
picking this up for now?
Alex
On Wed, Mar 23, 2022 at 5:18 PM Benjamin Marty wrote:
>
> Fixes crash on MST Hub disconnect.
>
> Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> ab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1849data=04%7C01%7C
> Daniel.Wheeler%40amd.com%7C21ed4881f6604db48b0208da0e8ae079%7C3dd8961f
> e4884e608e11a82d994e183d%7C0%7C0%7C637838286884708200%7CUnknown%7CTWFp
> bGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C3000sdata=9cpmXVrAtmDeAe2VMzcgT7%2B%2BYwmwEOb40fLuY7%2F5dJ
> o%3Dreserved=0
> Fixes: ee2698cf79cc ("drm/amd/display: Changed pipe split policy to
> allow for multi-display pipe split")
> Signed-off-by: Benjamin Marty
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index e5cc6bf45743..ca1bbc942fd4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -873,7 +873,7 @@ static const struct dc_debug_options debug_defaults_drv =
> {
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> .min_disp_clk_khz = 10,
> - .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> + .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> --
> 2.35.1
>
RE: [PATCH 00/12] DC Patches March 10, 2022
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.16 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Agustin Gutierrez Sent: March 10, 2022 5:21 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/12] DC Patches March 10, 2022 This DC patchset brings improvements in multiple areas. In summary: * Fixes on lane status, zstate, engine ddc, debugfx entry. * Enhancements for Pollock, EDID status. * Amongst other. Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.108.0 Aric Cyr (1): drm/amd/display: 3.2.177 Becle Lee (1): drm/amd/display: Wait for hubp read line for Pollock Charlene Liu (1): drm/amd/display: Add save/restore PANEL_PWRSEQ_REF_DIV2 Dale Zhao (1): drm/amd/display: Add new enum for EDID status Eric Yang (1): drm/amd/display: Block zstate when more than one plane enabled JinZe.Xu (1): drm/amd/display: Add I2C escape to support query device exist. Jing Zhou (2): drm/amd/display: Update engine ddc drm/amd/display: Add null pointer filter Leo (Hanghong) Ma (1): drm/amd/display: Add function to get the pipe from the stream context Wayne Lin (2): drm/amd/display: Fix a few parts in debugfs entry drm/amd/display: Retry when fail reading lane status during LT .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 10 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 +++ drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 + .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 30 +++--- .../gpu/drm/amd/display/dc/core/dc_stream.c | 14 +++ drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 5 + drivers/gpu/drm/amd/display/dc/dc_stream.h| 2 + drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 1 + drivers/gpu/drm/amd/display/dc/dce/dce_i2c.c | 26 ++ drivers/gpu/drm/amd/display/dc/dce/dce_i2c.h | 6 ++ .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 15 +++ .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 4 + .../drm/amd/display/dc/dcn10/dcn10_resource.c | 15 +++ .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 10 ++ .../amd/display/dc/dcn31/dcn31_panel_cntl.c | 5 +- .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 16 ++-- .../drm/amd/display/dc/gpio/gpio_service.c| 6 +- drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h | 1 + .../drm/amd/display/dc/inc/hw/panel_cntl.h| 1 + .../amd/display/dc/inc/hw_sequencer_private.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 92 ++- 23 files changed, 253 insertions(+), 26 deletions(-) -- 2.35.1
RE: [PATCH 00/21] DC Patches Mar 7, 2022
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.4 with Kernel Version 5.16 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Alan Liu Sent: March 7, 2022 3:59 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Liu, HaoPing (Alan) ; Cyr, Aric ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/21] DC Patches Mar 7, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: * Remove FPU-related code from dcn20/21/303 to dml folder; * Fixes related to clock_source_create; * Several enhancements in DC/DMUB; This version brings along following fixes: - move FPU operations from dcn21 to dml/dcn20 folder - move FPU-related code from dcn20 to dml folder - Fix compile error from TO_CLK_MGR_INTERNAL - Fix double free during GPU reset on DC streams - Add NULL check - [FW Promotion] Release 0.0.107.0 - enable dcn315/316 s0i2 support - handle DP2.0 RX with UHBR20 but not UHBR13.5 support - disable HPD SW timer for passive dongle type 1 only - add gamut coefficient set A and B - merge two duplicated clock_source_create - Add link dp trace support - move FPU associated DCN303 code to DML folder - Release AUX engine after failed acquire - Add minimal pipe split transition state - Clean up fixed VS PHY test w/a function - fix the clock source contruct for dcn315 - cleaning up smu_if to add future flexibility - fix deep color ratio - add debug option to bypass ssinfo from bios for dcn315 Acked-by: Alan Liu Signed-off-by: Aric Cyr Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.107.0 Aric Cyr (1): drm/amd/display: 3.2.176 Charlene Liu (3): drm/amd/display: fix the clock source contruct for dcn315 drm/amd/display: merge two duplicated clock_source_create drm/amd/display: enable dcn315/316 s0i2 support Chris Park (1): drm/amd/display: Add NULL check Dhillon, Jasdeep (1): drm/amd/display: move FPU associated DCN303 code to DML folder Dillon Varone (1): drm/amd/display: Add minimal pipe split transition state George Shen (1): drm/amd/display: Clean up fixed VS PHY test w/a function Hansen Dsouza (1): drm/amd/display: fix deep color ratio Jingwen Zhu (1): drm/amd/display: add gamut coefficient set A and B Leo (Hanghong) Ma (1): drm/amd/display: Add link dp trace support Leo Li (1): drm/amd/display: Fix compile error from TO_CLK_MGR_INTERNAL Leung, Martin (1): drm/amd/display: cleaning up smu_if to add future flexibility Melissa Wen (2): drm/amd/display: move FPU operations from dcn21 to dml/dcn20 folder drm/amd/display: move FPU code from dcn10 to dml/dcn10 folder Melissa·Wen· (1): drm/amd/display: move FPU-related code from dcn20 to dml folder Nicholas Kazlauskas (1): drm/amd/display: Fix double free during GPU reset on DC streams Sung Joon Kim (1): drm/amd/display: disable HPD SW timer for passive dongle type 1 only Wenjing Liu (1): drm/amd/display: handle DP2.0 RX with UHBR20 but not UHBR13.5 support Wyatt Wood (1): drm/amd/display: Release AUX engine after failed acquire .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |9 +- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 13 +- .../dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.c |9 +- .../dc/clk_mgr/dcn30/dcn30_clk_mgr_smu_msg.h | 67 +- .../dc/clk_mgr/dcn30/dcn30_smu11_driver_if.h | 74 + .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c|2 +-
RE: [PATCH 00/14] DC Patches Feburary 26, 2022
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Alan Liu Sent: February 26, 2022 6:41 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Liu, HaoPing (Alan) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/14] DC Patches Feburary 26, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: * Removing legacy invalid code. * Fixes in DC, DCE110. * Enhancements in DMUB. * Improvements on DCN10, DCN31. * Firmware promotion. drm/amd/display: 3.2.175 This version brings along following fixes: - Remove invalid RDPCS Programming in DAL - Make functional resource functions non-static - Reset VIC if HDMI_VIC is present - Add frame alternate 3D & restrict HW packed on dongles - Reg to turn on/off PSR Power seq in FSM - Modify plane removal sequence to avoid hangs - Pass HostVM enable flag into DCN3.1 DML - DC Validation failures - Program OPP before ODM - Refactor fixed VS w/a for PHY tests - Pass deep sleep disabled allow info to dmub fw - Refine the EDID override - [FW Promotion] Release 0.0.106.0 - Add verify_link_cap back for hdmi Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.106.0 Aric Cyr (1): drm/amd/display: 3.2.175 Charlene Liu (1): drm/amd/display: add verify_link_cap back for hdmi Chris Park (1): drm/amd/display: Reset VIC if HDMI_VIC is present Dillon Varone (2): drm/amd/display: Add frame alternate 3D & restrict HW packed on dongles drm/amd/display: Modify plane removal sequence to avoid hangs. Hansen Dsouza (1): drm/amd/display: Remove invalid RDPCS Programming in DAL Michael Strauss (1): drm/amd/display: Pass HostVM enable flag into DCN3.1 DML Nicholas Kazlauskas (1): drm/amd/display: Make functional resource functions non-static Robin Chen (1): drm/amd/display: Pass deep sleep disabled allow info to dmub fw Shah, Dharati (1): drm/amd/display: Adding a dc_debug option and dmub setting to use PHY FSM for PSR Shen, George (1): drm/amd/display: Refactor fixed VS w/a for PHY tests Wesley Chalmers (1): drm/amd/display: Program OPP before ODM jinzh (1): drm/amd/display: refine the EDID override drivers/gpu/drm/amd/display/dc/core/dc_link.c | 14 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 16 -- .../gpu/drm/amd/display/dc/core/dc_resource.c | 2 + drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 1 + .../display/dc/dce110/dce110_hw_sequencer.c | 49 ++- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 5 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 21 ++-- .../display/dc/dcn31/dcn31_dio_link_encoder.c | 9 .../drm/amd/display/dc/dcn31/dcn31_resource.c | 5 +- .../drm/amd/display/dc/dcn31/dcn31_resource.h | 5 ++ .../amd/display/dc/dcn315/dcn315_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dm_helpers.h | 3 ++ .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 12 +++-- 14 files changed, 83 insertions(+), 64 deletions(-) -- 2.25.1
RE: [PATCH 00/11] DC Patches Feburary 14, 2022
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -Original Message- From: amd-gfx On Behalf Of Jasdeep Dhillon Sent: February 11, 2022 4:52 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Dhillon, Jasdeep ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/11] DC Patches Feburary 14, 2022 This DC patchset brings improvements in multiple areas. In summary, we highlight: -Fixes bugs for dsc mst hub -Enables Z9 denial interface by default -Fixes dmub outbox notification Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.104.0 Aric Cyr (1): drm/amd/display: 3.2.173 Charlene Liu (1): drm/amd/display: make sure pipe power gating reach requested hw state Eric Yang (1): drm/amd/display: enable z9 denial interface by default Hersen Wu (2): drm/amd/display: dsc mst re-compute pbn for changes on hub drm/amd/display: add dsc mst stream pbn log for debug Meenakshikumar Somasundaram (1): drm/amd/display: Fix for dmub outbox notification enable Oliver Logush (1): drm/amd/display: extend dcn201 support Roman Li (2): drm/amd/display: Add affected crtcs to atomic state for dsc mst unplug drm/amd/display: Add dsc pre-validation in atomic check Sung Joon Kim (1): drm/amd/display: reset lane settings after each PHY repeater LT .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 13 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 257 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 4 + drivers/gpu/drm/amd/display/dc/core/dc.c | 66 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 20 ++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 15 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 4 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 16 ++ drivers/gpu/drm/amd/display/dc/dc.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 1 + .../gpu/drm/amd/display/dc/dce/dmub_outbox.c | 25 +- .../gpu/drm/amd/display/dc/dce/dmub_outbox.h | 4 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 4 - .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 23 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- .../gpu/drm/amd/display/include/dal_asic_id.h | 1 + 18 files changed, 429 insertions(+), 53 deletions(-) -- 2.25.1
RE: [PATCH 00/14] DC Patchset, Feb 7 2022 v2
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Jasdeep Dhillon Sent: February 4, 2022 8:50 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Dhillon, Jasdeep ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/14] DC Patchset, Feb 7 2022 v2 This DC patchset brings improvements in multiple areas. In summary, we have: -fix for build failure uninitalized error -Bug fix for DP2 using uncertified cable -limit unbounded request to 5k -fix DP LT sequence on EQ fail -Bug fixes for S3/S4 Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.103.0 Aric Cyr (1): drm/amd/display: 3.2.172 Dmytro Laktyushkin (2): drm/amd/display: limit unbounded requesting to 5k drm/amd/display: fix yellow carp wm clamping Eric Bernstein (2): drm/amd/display: Fix for variable may be used uninitialized error drm/amd/display: remove static from optc31_set_drr Guo, Bing (1): dc: do blocked MST topology discovery at resume from S3/S4 Ilya (1): drm/amd/display: Fix DP LT sequence on EQ fail Martin Tsai (1): drm/amd/display: handle null link encoder Nicholas Kazlauskas (1): drm/amd/display: Fix stream->link_enc unassigned during stream removal Oliver Logush (2): drm/amd/display: Basic support with device ID SWDEV-321758 - dc: Code clean Paul Hsieh (1): drm/amd/display: change fastboot timing validation Zhan Liu (1): drm/amd/display: keep eDP Vdd on when eDP stream is already enabled .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 +++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 27 ++-- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 8 +-- drivers/gpu/drm/amd/display/dc/dc.h | 4 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + .../display/dc/dce110/dce110_hw_sequencer.c | 27 +++- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 11 +--- .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 61 ++- .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.c | 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.h | 2 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 3 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- .../gpu/drm/amd/display/include/dal_asic_id.h | 3 +- 17 files changed, 104 insertions(+), 83 deletions(-) -- 2.25.1
RE: [PATCH 00/24] DC Patches Jan 23, 2022
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Sent: January 23, 2022 1:20 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/24] DC Patches Jan 23, 2022 This DC patchset brings improvements in multiple areas. In summary, we have: - Z9 improvements - Clocks management adjustments - Code cleanup - Improve DSC and MST code Thanks Siqueira Alvin Lee (1): drm/amd/display: Driver support for MCLK query tool Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.101.0 Aric Cyr (2): drm/amd/display: 3.2.170 drm/amd/display: Remove unnecessary function definition David Galiffi (2): drm/amd/display: Fix disabling dccg clocks drm/amd/display: Disable physym clock Eric Yang (2): drm/amd/display: fix zstate allow interface to PMFW drm/amd/display: add debug option for z9 disable interface Fangzhi Zuo (3): drm/amd/display: Add Synaptics Fifo Reset Workaround drm/amd/display: Retrieve MST Downstream Port Status drm/amd/display: Add DSC Enable for Synaptics Hub Ian Chen (1): drm/amd/display: Change return type of dm_helpers_dp_mst_stop_top_mgr Josip Pavic (1): drm/amd/display: do not compare integers of different widths Martin Tsai (1): drm/amd/display: add protection in link encoder matching logic Nicholas Kazlauskas (2): drm/amd/display: Only set PSR version when valid drm/amd/display: Use PSR version selected during set_psr_caps Oliver Logush (1): drm/amd/display: Basic support with device ID Reza Amini (1): drm/amd/display: Update VSC HDR infoPacket on TF change Roy Chan (1): drm/amd/display: Support synchronized indirect reg access Shen, George (1): drm/amd/display: Add Cable ID support for native DP Sung Joon Kim (1): drm/amd/display: remove PHY repeater count check for LTTPR mode Varone (1): drm/amd/display: Change error to warning when hpd remains low for eDP Wayne Lin (1): drm/amd/display: Reset preferred training settings immediately Wenjing Liu (1): drm/amd/display: allow set dp drive setting when stream is not present .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 205 -- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 25 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 10 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 6 +- .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 64 +++--- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 128 +-- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 23 +- .../drm/amd/display/dc/core/dc_link_hwss.c| 22 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 +- drivers/gpu/drm/amd/display/dc/dc.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 16 ++ drivers/gpu/drm/amd/display/dc/dc_helper.c| 60 + drivers/gpu/drm/amd/display/dc/dc_link.h | 10 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 4 + .../display/dc/dce110/dce110_hw_sequencer.c | 2 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 15 +- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 5 - .../drm/amd/display/dc/dcn30/dcn30_hwseq.h| 3 - .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.c | 106 ++--- .../gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h |
RE: [PATCH 0/6] DC Patches December 22, 2021
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Siqueira, Rodrigo Sent: December 22, 2021 5:05 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Lipski, Mikita ; Li, Roman ; anson.ja...@amd.com; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 0/6] DC Patches December 22, 2021 Hi, This is the last DC upstream of this year. As a result, it is a very tiny one with a few bug fixes. Just for curiosity, I decided to calculate how many patches we upstream via this weekly process in 2021, and it was approximately 740 patches where Daniel Wheeler tested each patchset. Thanks to everybody for helping with this process, and special thanks to Daniel that validate each patchset :) Cc: Daniel Wheeler Best Regards Siqueira Charlene Liu (1): drm/amd/display: Add check for forced_clocks debug option Mikita Lipski (1): drm/amd/display: introduce mpo detection flags Nicholas Kazlauskas (2): drm/amd/display: Don't reinitialize DMCUB on s0ix resume drm/amd/display: Add version check before using DP alt query interface Wenjing Liu (1): drm/amd/display: unhard code link to phy idx mapping in dc link and clean up Yi-Ling Chen (1): drm/amd/display: Fix underflow for fused display pipes case .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 40 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 145 +++--- .../gpu/drm/amd/display/dc/core/dc_resource.c | 33 .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 +- .../display/dc/dcn31/dcn31_dio_link_encoder.c | 114 +++--- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dm_cp_psp.h| 4 +- drivers/gpu/drm/amd/display/dc/inc/resource.h | 1 + .../drm/amd/display/modules/inc/mod_hdcp.h| 2 +- 10 files changed, 234 insertions(+), 116 deletions(-) -- 2.25.1
RE: [PATCH 00/19] DC Patches December 17, 2021
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Siqueira, Rodrigo Sent: December 17, 2021 4:24 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Lipski, Mikita ; Li, Roman ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel Subject: [PATCH 00/19] DC Patches December 17, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fixes and improvements in the LTTPR code - Improve z-state - Fix null pointer check - Improve communication with s0i2 - Update multiple-display split policy - Add missing registers Cc: Daniel Wheeler Thanks Siqueira Alvin Lee (1): drm/amd/display: Fix check for null function ptr Angus Wang (1): drm/amd/display: Changed pipe split policy to allow for multi-display pipe split Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.98 Aric Cyr (1): drm/amd/display: 3.2.167 Charlene Liu (1): drm/amd/display: fix B0 TMDS deepcolor no dislay issue George Shen (2): drm/amd/display: Limit max link cap with LTTPR caps drm/amd/display: Remove CR AUX RD Interval limit for LTTPR Lai, Derek (1): drm/amd/display: Added power down for DCN10 Martin Leung (1): drm/amd/display: Undo ODM combine Nicholas Kazlauskas (3): drm/amd/display: Block z-states when stutter period exceeds criteria drm/amd/display: Send s0i2_rdy in stream_count == 0 optimization drm/amd/display: Set optimize_pwr_state for DCN31 Shen, George (1): drm/amd/display: Refactor vendor specific link training sequence Wenjing Liu (5): drm/amd/display: define link res and make it accessible to all link interfaces drm/amd/display: populate link res in both detection and validation drm/amd/display: access hpo dp link encoder only through link resource drm/amd/display: support dynamic HPO DP link encoder allocation drm/amd/display: get and restore link res map Wesley Chalmers (1): drm/amd/display: Add reg defs for DCN303 .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 1 + drivers/gpu/drm/amd/display/dc/core/dc.c | 18 - .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 234 +--- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 501 +++--- .../drm/amd/display/dc/core/dc_link_dpia.c| 48 +- .../drm/amd/display/dc/core/dc_link_hwss.c| 63 ++- .../gpu/drm/amd/display/dc/core/dc_resource.c | 199 --- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 15 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 14 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_init.c | 1 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 2 +- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 5 +- .../amd/display/dc/dcn201/dcn201_resource.c | 2 +- .../drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 13 +- .../amd/display/dc/dcn301/dcn301_resource.c | 2 +- .../amd/display/dc/dcn302/dcn302_resource.c | 2 +- .../drm/amd/display/dc/dcn303/dcn303_dccg.h | 20 +- .../amd/display/dc/dcn303/dcn303_resource.c | 2 +- .../dc/dcn31/dcn31_hpo_dp_link_encoder.c | 6 +- .../dc/dcn31/dcn31_hpo_dp_link_encoder.h | 3 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 1 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 27 +- .../drm/amd/display/dc/dcn31/dcn31_resource.h | 31 ++ .../gpu/drm/amd/display/dc/dml/dml_wrapper.c | 2 +- .../gpu/drm/amd/display/dc/inc/core_status.h | 2 + .../gpu/drm/amd/display/dc/inc/core_types.h | 17 + .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 15
RE: DC Patches January 10, 2020
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Kotarac, Pavle Sent: December 10, 2021 6:04 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing (Lillian) ; Lipski, Mikita ; Li, Roman ; anson.ja...@amd.com; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Kotarac, Pavle ; Wheeler, Daniel Subject: DC Patches January 10, 2020 This new DC version brings improvements in the following areas: - FW promotion to 0.0.97 - DSC fixes for supported Docks - Fixes eDP display issue - Vendor LTTR workarounds - Fixes Tiled display audio issue Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.97 Aric Cyr (1): drm/amd/display: 3.2.166 Eric Bernstein (1): drm/amd/display: ODM + MPO window on only one half of ODM Martin Leung (1): drm/amd/display: implement dc_mode_memclk Michael Strauss (1): drm/amd/display: Force det buf size to 192KB with 3+ streams and upscaling Mikita Lipski (1): drm/amd/display: parse and check PSR SU caps Nicholas Kazlauskas (2): drm/amd/display: Set exit_optimized_pwr_state for DCN31 drm/amd/display: Reset DMCUB before HW init Solomon Chiu (1): drm/amd/display: Add src/ext ID info for dummy service Wayne Lin (1): drm/amd/display: Add debugfs entry for ILR .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 134 ++ .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 101 +++-- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 44 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 92 .../gpu/drm/amd/display/dc/core/dc_resource.c | 81 --- drivers/gpu/drm/amd/display/dc/dc.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 9 ++ drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 14 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.h | 1 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 10 ++ .../drm/amd/display/dc/dcn20/dcn20_hwseq.h| 4 + .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c | 1 + .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 11 ++ .../drm/amd/display/dc/dcn30/dcn30_hwseq.h| 5 +- .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 1 + .../drm/amd/display/dc/dcn30/dcn30_resource.c | 11 ++ .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 1 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 8 ++ .../gpu/drm/amd/display/dc/inc/hw/clk_mgr.h | 7 + drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h | 1 + .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 1 + .../dc/irq/dce110/irq_service_dce110.c| 10 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- 25 files changed, 514 insertions(+), 48 deletions(-) -- 2.32.0 Cc: Daniel Wheeler
RE: DC Patches January 10, 2020 3.2.165
[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -Original Message- From: amd-gfx On Behalf Of Pavle Kotarac Sent: December 3, 2021 5:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Jacob, Anson ; Pillai, Aurabindo ; Lin, Wayne ; Lipski, Mikita ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: DC Patches January 10, 2020 3.2.165 This new DC version brings improvements in the following areas: - Improvements for USB4; - Isolate FPU code for DCN20, DCN301, and DSC; - Fixes on Linking training; - Refactoring some parts of the code, such as PSR;
RE: [PATCH 00/16] DC Patches Nov 26, 2021
Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Bhawanpreet Lakha Sent: November 26, 2021 2:49 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Jacob, Anson ; Pillai, Aurabindo ; Lin, Wayne ; Lipski, Mikita ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/16] DC Patches Nov 26, 2021 This DC patchset brings improvements in multiple areas. In summary, we have: - FW promotion to 0.0.95 - DSC fixes for supported Docks - Fixes eDP display issue - Vendor LTTR workarounds - Fixes Tiled display audio issue Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.95 Aric Cyr (1): drm/amd/display: 3.2.164 Brandon Syu (1): drm/amd/display: Fix dual eDP abnormal display issue Dale Zhao (1): drm/amd/display: add hdmi disable debug check Evgenii Krasnikov (1): drm/amd/display: add function for eDP and backlight power on George Shen (3): drm/amd/display: Add vendor specific LTTPR workarounds for DCN31 drm/amd/display: Skip vendor specific LTTPR w/a outside link training drm/amd/display: Add 16ms AUX RD interval W/A for specific LTTPR Jimmy Kizito (1): drm/amd/display: Add work around for tunneled MST. Meenakshikumar Somasundaram (1): drm/amd/display: Fix for otg synchronization logic Michael Strauss (1): drm/amd/display: Add force detile buffer size debug flag Mikita Lipski (1): drm/amd/display: PSR panel capability debugfs Mustapha Ghaddar (1): drm/amd/display: Fix for the no Audio bug with Tiled Displays Nicholas Kazlauskas (1): drm/amd/display: Allow DSC on supported MST branch devices Shen, George (1): drm/amd/display: Clear DPCD lane settings after repeater training Stylon Wang (1): drm/amd/display: Enable P010 for DCN3x ASICs .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 44 .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 20 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 35 +-- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 16 ++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 227 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 78 +- drivers/gpu/drm/amd/display/dc/dc.h | 19 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 6 + .../drm/amd/display/dc/dce/dce_link_encoder.c | 5 +- .../display/dc/dce110/dce110_hw_sequencer.c | 16 +- .../amd/display/dc/dcn10/dcn10_link_encoder.c | 5 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- .../amd/display/dc/dcn301/dcn301_resource.c | 2 +- .../amd/display/dc/dcn302/dcn302_resource.c | 2 +- .../amd/display/dc/dcn303/dcn303_resource.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 9 +- .../gpu/drm/amd/display/dc/inc/core_types.h | 1 + .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 1 + drivers/gpu/drm/amd/display/dc/inc/resource.h | 11 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- 20 files changed, 457 insertions(+), 48 deletions(-) -- 2.25.1
RE: [PATCH 00/16] DC Patches November 22nd, 2021
[AMD Official Use Only] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Qingqing Zhuo Sent: November 19, 2021 2:43 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing (Lillian) ; Siqueira, Rodrigo ; Li, Roman ; Jacob, Anson ; Pillai, Aurabindo ; Lin, Wayne ; Lipski, Mikita ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/16] DC Patches November 22nd, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: - DC 3.2.163 - FW promotion to 0.0.94 - Enable seamless boot for DCN301 - Improvements in bandwidth validation - Fixes in flags update, link encoder assignments, DSC, ODM combine and more Thank you, Lillian --- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.94 Aric Cyr (1): drm/amd/display: 3.2.163 Charlene Liu (1): drm/amd/display: based on flag reset z10 function pointer Guo, Bing (1): drm/amd/display: fixed an error related to 4:2:0/4:2:2 DSC Martin Leung (1): drm/amd/display: add else to avoid double destroy clk_mgr Mikita Lipski (1): drm/amd/display: fix accidental casting enum to bool Nevenko Stupar (1): drm/amd/display: Display object info table changes Nicholas Kazlauskas (4): drm/amd/display: Fix DPIA outbox timeout after GPU reset drm/amd/display: Run full global validation in dc_commit_state drm/amd/display: Set plane update flags for all planes in reset drm/amd/display: Reset link encoder assignments for GPU reset Sung Joon Kim (1): drm/amd/display: retain/release at proper places in link_enc assignment Yi-Ling Chen (1): drm/amd/display: Fixed DSC would not PG after removing DSC stream Zhan Liu (2): drm/amd/display: enable seamless boot for DCN301 drm/amd/display: Rename dcn_validate_bandwidth to dcn10_validate_bandwidth sungwang (1): drm/amd/display: Fix ODM combine issue with fast boot .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 66 +-- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- .../drm/amd/display/dc/bios/bios_parser2.c| 6 +- .../gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 2 +- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 3 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 17 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 6 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 1 - drivers/gpu/drm/amd/display/dc/dc.h | 2 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 +- .../drm/amd/display/dc/dcn10/dcn10_resource.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 2 +- .../amd/display/dc/dcn301/dcn301_resource.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 5 ++ .../drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 31 - .../drm/amd/display/dc/dml/dsc/rc_calc_fpu.h | 4 -- drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c | 28 drivers/gpu/drm/amd/display/dc/dsc/rc_calc.h | 1 - .../gpu/drm/amd/display/dc/dsc/rc_calc_dpi.c | 5 +- .../gpu/drm/amd/display/dc/inc/dcn_calcs.h| 2 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 11 +--- 24 files changed, 99 insertions(+), 113 deletions(-) -- 2.25.1
RE: [PATCH 00/14] DC Patches November 12, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Wayne Lin Sent: November 11, 2021 7:54 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Li, Roman ; Chiu, Solomon ; Pillai, Aurabindo ; Lin, Wayne ; Lipski, Mikita ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/14] DC Patches November 12, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fix issue that secondary display goes blank on Non DCN31. - Adjust flushing data in DMCUB - Revert patches which cause regression in hadnling MPO/Link encoder assignment - Correct the setting within MSA of DP2.0 - Adjustment for DML isolation - Fix FIFO erro in fast boot sequence - Enable DSC over eDP - Adjust the DSC power off sequence --- Ahmad Othman (1): drm/amd/display: Secondary display goes blank on Non DCN31 Angus Wang (1): drm/amd/display: Revert changes for MPO underflow Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.92 drm/amd/display: [FW Promotion] Release 0.0.93 Aric Cyr (1): drm/amd/display: 3.2.162 Brandon Syu (1): drm/amd/display: Fix eDP will flash when boot to OS Jun Lei (1): drm/amd/display: Code change for DML isolation Mikita Lipski (1): drm/amd/display: Enable DSC over eDP Nicholas Kazlauskas (1): drm/amd/display: Only flush delta from last command execution Sung Joon Kim (1): drm/amd/display: Revert "retain/release stream pointer in link enc table" Wenjing Liu (1): drm/amd/display: set MSA vsp/hsp to 0 for positive polarity for DP 128b/132b Xu, Jinze (1): drm/amd/display: Reset fifo after enable otg Yi-Ling Chen (1): drm/amd/display: fixed the DSC power off sequence during Driver PnP hvanzyll (1): drm/amd/display: Visual Confirm Bar Height Adjust .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 73 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |2 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c |5 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 167 +- .../drm/amd/display/dc/core/dc_link_enc_cfg.c |2 - drivers/gpu/drm/amd/display/dc/dc.h |7 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c |1 + .../display/dc/dce110/dce110_hw_sequencer.c |7 +- .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 14 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 37 + .../display/dc/dcn10/dcn10_stream_encoder.c | 15 + .../display/dc/dcn10/dcn10_stream_encoder.h |3 + .../gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c |2 + .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 14 + .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.h |3 + .../drm/amd/display/dc/dcn20/dcn20_resource.c |2 +- .../display/dc/dcn20/dcn20_stream_encoder.c |2 + .../dc/dcn30/dcn30_dio_stream_encoder.c |2 + .../gpu/drm/amd/display/dc/dcn30/dcn30_optc.c |1 + .../drm/amd/display/dc/dcn30/dcn30_resource.c |2 +- .../amd/display/dc/dcn302/dcn302_resource.c |2 +- .../amd/display/dc/dcn303/dcn303_resource.c |2 +- .../dc/dcn31/dcn31_hpo_dp_stream_encoder.c|4 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c|5 - .../gpu/drm/amd/display/dc/dcn31/dcn31_optc.c |1 + .../drm/amd/display/dc/dcn31/dcn31_resource.c |1 + .../drm/amd/display/dc/dml/display_mode_lib.h |1 + .../gpu/drm/amd/display/dc/dml/dml_wrapper.c | 1889 + .../display/dc/dml/dml_wrapper_translation.c | 284 +++ drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c |8 +
RE: [PATCH 00/22] DC Patches Nov 4, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Anson Jacob Sent: November 4, 2021 4:52 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Li, Roman ; Jacob, Anson ; Pillai, Aurabindo ; Lin, Wayne ; Lipski, Mikita ; Lakha, Bhawanpreet ; Gutierrez, Agustin ; Kotarac, Pavle Subject: [PATCH 00/22] DC Patches Nov 4, 2021 This DC patchset brings improvements in multiple areas. In summary, we have: * Improvements to INBOX0 HW Lock * Add support for sending TPS3 pattern * Fix Coverity Issues * Fixes for DMUB * Fix RGB MPO underflow with multiple displays * WS fixes and code restructure Alvin Lee (1): drm/amd/display: Wait for ACK for INBOX0 HW Lock Angus Wang (1): drm/amd/display: Fix RGB MPO underflow with multiple displays Anson Jacob (1): drm/amd/display: Add comment where CONFIG_DRM_AMD_DC_DCN macro ends Aric Cyr (1): drm/amd/display: 3.2.161 Charlene Liu (3): drm/amd/display: remove dmcub_support cap dependency drm/amd/display: clean up some formats and log. drm/amd/display: Adjust code indentation Chris Park (1): drm/amd/display: Fix Coverity Issues Dmytro Laktyushkin (1): drm/amd/display: bring dcn31 clk mgr in line with other version style Huang, ChiaWen (1): drm/amd/display: use link_rate_set above DPCD 1.3 (#1527) Jimmy Kizito (3): drm/amd/display: Use link_enc_cfg API for queries. drm/amd/display: Query all entries in assignment table during updates. drm/amd/display: Initialise encoder assignment when initialising dc_state. Leo (Hanghong) Ma (1): drm/amd/display: Add helper for blanking all dp displays Meenakshikumar Somasundaram (1): drm/amd/display: Add hpd pending flag to indicate detection of new hpd. Mikita Lipski (1): drm/amd/display: Pass panel inst to a PSR command Nicholas Kazlauskas (3): drm/amd/display: Fix detection of aligned DMUB firmware meta info drm/amd/display: Don't lock connection_mutex for DMUB HPD drm/amd/display: Add callbacks for DMUB HPD IRQ notifications Robin Chen (1): drm/amd/display: To support sending TPS3 pattern when restoring link Roy Chan (1): drm/amd/display: fix stale info in link encoder assignment Sung Joon Kim (1): drm/amd/display: retain/release stream pointer in link enc table .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 --- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 8 +- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h | 7 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 17 ++-- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 78 ++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- .../drm/amd/display/dc/core/dc_link_dpia.c| 20 ++--- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 51 ++-- .../gpu/drm/amd/display/dc/core/dc_resource.c | 3 + drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 37 - drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 2 + drivers/gpu/drm/amd/display/dc/dc_link.h | 7 +- .../gpu/drm/amd/display/dc/dce/dce_audio.c| 6 -- .../gpu/drm/amd/display/dc/dce/dce_audio.h| 2 + .../drm/amd/display/dc/dce/dmub_hw_lock_mgr.c | 3 + drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 13 +++- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h | 2 +- .../display/dc/dce110/dce110_hw_sequencer.c | 22 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 41 +- .../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 39 +-
RE: [PATCH 00/14] DC patches for Nov 1, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested on Ubuntu 20.04.3 with Kernel Version 5.13 and ChromeOS Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Aurabindo Pillai Sent: October 29, 2021 11:15 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin Subject: [PATCH 00/14] DC patches for Nov 1, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC release version 3.2.160 * DMUB fw version 0.0.91 and bug fixes * DSC related fixes * Minor power optimization improvements * Bug fixes and improvements in display pipeline --- Anson Jacob (1): drm/amd/display: Fix dcn10_log_hubp_states printf format string Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.91 Aric Cyr (1): drm/amd/display: 3.2.160 Aurabindo Pillai (1): drm/amd/display: add condition check for dmub notification Bing Guo (1): drm/amd/display: Fix bpc calculation for specific encodings Felipe Clark (1): drm/amd/display: Fix dummy p-state hang on monitors with extreme timing Hersen Wu (1): drm/amd/display: dsc engine not disabled after unplug dsc mst hub Jake Wang (3): drm/amd/display: Added HPO HW control shutdown support drm/amd/display: Add MPC meory shutdown support drm/amd/display: Added new DMUB boot option for power optimization Jimmy Kizito (1): drm/amd/display: Clear encoder assignments when state cleared. Roman Li (1): drm/amd/display: Force disable planes on any pipe split change Wenjing Liu (1): drm/amd/display: fix register write sequence for LINK_SQUARE_PATTERN Yu-ting Shen (1): drm/amd/display: avoid link loss short pulse stuck the system .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 31 ++-- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 150 ++ drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 + .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 + .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 22 +++ drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 3 + .../gpu/drm/amd/display/dc/dce/dce_hwseq.h| 4 +- .../display/dc/dce110/dce110_hw_sequencer.c | 6 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 3 + .../gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c | 7 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 7 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 78 + .../drm/amd/display/dc/dcn31/dcn31_hwseq.h| 1 + .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 1 + .../drm/amd/display/dc/dcn31/dcn31_resource.c | 6 +- .../dc/dml/dcn30/display_mode_vba_30.c| 13 +- .../dc/dml/dcn31/display_mode_vba_31.c| 14 +- drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 1 + .../amd/display/dc/inc/hw_sequencer_private.h | 1 + drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 1 + 25 files changed, 271 insertions(+), 106 deletions(-) -- 2.30.2
RE: [PATCH 00/33] DC Patches October 24, 2020
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Also tested DSC via USB-C to DP DSC Hub with 3x 4k 60hz on Ryzen 9 5900h and Ryzen 5 4500u. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Sent: October 24, 2021 9:31 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin Subject: [PATCH 00/33] DC Patches October 24, 2020 This new DC version brings improvements in the following areas: - Improvements for USB4; - Isolate FPU code for DCN20, DCN301, and DSC; - Fixes on Linking training; - Refactoring some parts of the code, such as PSR; Thanks Ahmad Othman (2): drm/amd/display: Add support for USB4 on C20 PHY for DCN3.1 drm/amd/display: fix a crash on USB4 over C20 PHY Anson Jacob (2): drm/amd/display: dcn20_resource_construct reduce scope of FPU enabled drm/amd/display: Remove unused macros Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.89 drm/amd/display: [FW Promotion] Release 0.0.90 Aric Cyr (4): drm/amd/display: Handle I2C-over-AUX write channel status update drm/amd/display: 3.2.158 drm/amd/display: Fix 3DLUT skipped programming drm/amd/display: 3.2.159 Dmytro Laktyushkin (3): drm/amd/display: clean up dcn31 revision check drm/amd/display: restyle dcn31 resource header inline with other asics drm/amd/display: allow windowed mpo + odm George Shen (2): drm/amd/display: Implement fixed DP drive settings drm/amd/display: Add comment for preferred_training_settings Guo, Bing (2): drm/amd/display: Get ceiling for v_total calc drm/amd/display: set Layout properly for 8ch audio at timing validation Hansen (1): drm/amd/display: Set phy_mux_sel bit in dmub scratch register Jimmy Kizito (1): drm/amd/display: Add workaround flag for EDID read on certain docks Lewis Huang (1): drm/amd/display: Align bw context with hw config when system resume Martin Leung (1): drm/amd/display: Manually adjust strobe for DCN303 Meenakshikumar Somasundaram (2): drm/amd/display: FEC configuration for dpia links drm/amd/display: FEC configuration for dpia links in MST mode Michael Strauss (2): drm/amd/display: Set i2c memory to light sleep during hw init drm/amd/display: Defer GAMCOR and DSCL power down sequence to vupdate Qingqing Zhuo (2): drm/amd/display: move FPU associated DSC code to DML folder drm/amd/display: move FPU associated DCN301 code to DML folder Robin Chen (1): drm/amd/display: dc_link_set_psr_allow_active refactoring Wenjing Liu (5): drm/amd/display: adopt DP2.0 LT SCR revision 8 drm/amd/display: implement decide lane settings drm/amd/display: decouple hw_lane_settings from dpcd_lane_settings drm/amd/display: add two lane settings training options drm/amd/display: fix link training regression for 1 or 2 lane .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 10 +- .../drm/amd/display/dc/bios/bios_parser2.c| 2 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 16 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 17 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 118 - .../gpu/drm/amd/display/dc/core/dc_link_ddc.c | 15 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 498 +++--- .../drm/amd/display/dc/core/dc_link_dpia.c| 57 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 14 +- drivers/gpu/drm/amd/display/dc/dc.h | 23 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 5 - drivers/gpu/drm/amd/display/dc/dc_link.h | 13 +-
RE: [PATCH 00/27] DC Patchset for October 15
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Gutierrez, Agustin Sent: October 15, 2021 2:43 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon ; Kotarac, Pavle ; Gutierrez, Agustin ; Wheeler, Daniel ; Broadworth, Mark Subject: [PATCH 00/27] DC Patchset for October 15 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Fix some issues such as DP2 problem, prefetch bandwidth calculation for DCN3.1 and others. * Increased Z9 latency and removed z10 save after dsc disable. * Revert a couple of bad changes. * Added missing PSR state patch. Cc: Daniel Wheeler Cc: Mark Broadworth Agustin Gutierrez (2): Revert "drm/amd/display: Fix error in dmesg at boot" Revert "drm/amd/display: Add helper for blanking all dp displays" Anthony Koo (2): drm/amd/display: Change initializer to single brace drm/amd/display: [FW Promotion] Release 0.0.88 Aric Cyr (2): drm/amd/display: Validate plane rects before use drm/amd/display: 3.2.157 Eric Yang (1): drm/amd/display: increase Z9 latency to workaround underflow in Z9 Hansen (1): drm/amd/display: Fix DP2 SE and LE SYMCLK selection for B0 PHY Jake Wang (6): drm/amd/display: Disable dpp root clock when not being used drm/amd/display: Disable dsc root clock when not being used drm/amd/display: Disable dpstreamclk, symclk32_se, and symclk32_le drm/amd/display: Removed z10 save after dsc disable drm/amd/display: Moved dccg init to after bios golden init drm/amd/display: Disable hdmistream and hdmichar clocks Jimmy Kizito (2): drm/amd/display: Clear encoder assignment for copied streams drm/amd/display: Do not skip link training on DP quick hot plug Josip Pavic (1): drm/amd/display: do not compare integers of different widths Lai, Derek (1): drm/amd/display: Removed power down on boot from DCN31 Michael Strauss (1): drm/amd/display: Clean Up VPG Low Mem Power Mikita Lipski (1): drm/amd/display: Add missing PSR state Nevenko Stupar (1): drm/amd/display: Add bios parser support for latest firmware_info Nicholas Kazlauskas (2): drm/amd/display: Fix prefetch bandwidth calculation for DCN3.1 drm/amd/display: Require immediate flip support for DCN3.1 planes Nikola Cornij (2): drm/amd/display: Limit display scaling to up to true 4k for DCN 3.1 drm/amd/display: Increase watermark latencies for DCN3.1 Wenjing Liu (2): drm/amd/display: add DP2.0 debug option to set MST_EN for SST stream drm/amd/display: correct apg audio channel enable golden value .../drm/amd/display/dc/bios/bios_parser2.c| 90 ++- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 21 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 - drivers/gpu/drm/amd/display/dc/core/dc_link.c | 63 + .../gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 32 +-- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 9 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 + .../gpu/drm/amd/display/dc/core/dc_stream.c | 4 + drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 - drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 + .../display/dc/dce110/dce110_hw_sequencer.c | 24 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 49 +++- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 34 ++- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 4 +- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 39 ++- .../gpu/drm/amd/display/
RE: [PATCH 00/14] DC Patches October 1, 2021
[Public]
Hi all,
This week this patchset was tested on the following systems:
HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p
60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI),
1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA)
AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz
(via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via
USB-C to DP and then DP to DVI/VGA)
Sapphire Pulse RX5700XT with the following display types:
4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to
DVI/VGA)
Reference AMD RX6800 with the following display types:
4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI
and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA)
Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p
60hz on all systems.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
Facebook | Twitter | amd.com
-Original Message-
From: amd-gfx On Behalf Of Solomon Chiu
Sent: October 1, 2021 10:36 AM
To: amd-gfx@lists.freedesktop.org
Cc: Wentland, Harry ; Li, Sun peng (Leo)
; Lakha, Bhawanpreet ; Siqueira,
Rodrigo ; Pillai, Aurabindo
; Zhuo, Qingqing ; Lipski,
Mikita ; Li, Roman ; Jacob, Anson
; Lin, Wayne ; Wang, Chao-kai (Stylon)
; Chiu, Solomon
Subject: [PATCH 00/14] DC Patches October 1, 2021
This DC patchset brings improvements in multiple areas. In summary, we
highlight:
- New firmware version
- Fix DMUB problems on stress test.
- Improve link training by skip overrride for preferred link
- Refinement of FPU code structure for DCN2
- Fix 3DLUT skipped programming
- Fix detection of 4 lane for DPALT
- Fix dcn3 failure due to dmcbu_abm not created
- Limit display scaling to up to 4k for DCN 3.1
- Add helper for blanking all dp displays
Anthony Koo (1):
drm/amd/display: [FW Promotion] Release 0.0.87
Aric Cyr (2):
drm/amd/display: Fix 3DLUT skipped programming
drm/amd/display: 3.2.156
Charlene Liu (2):
drm/amd/display: update irq_service and other required change part 2.
drm/amd/display: dcn3 failed due to dmcbu_abm not created
George Shen (1):
drm/amd/display: Skip override for preferred link settings during link
training
Hansen (1):
drm/amd/display: Fix detection of 4 lane for DPALT
Jake Wang (1):
drm/amd/display: Added root clock optimization flags
Jimmy Kizito (1):
drm/amd/display: Fix concurrent dynamic encoder assignment.
Leo (Hanghong) Ma (2):
drm/amd/display: Add helper for blanking all dp displays
drm/amd/display: Fix error in dmesg at boot
Nikola Cornij (1):
drm/amd/display: Limit display scaling to up to 4k for DCN 3.1
Qingqing Zhuo (1):
drm/amd/display: Re-arrange FPU code structure for dcn2x
Wyatt Wood (1):
drm/amd/display: Prevent using DMUB rptr that is out-of-bounds
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 2 +-
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 45 +++
.../gpu/drm/amd/display/dc/core/dc_link_dp.c | 6 ---
drivers/gpu/drm/amd/display/dc/dc.h | 21 -
drivers/gpu/drm/amd/display/dc/dc_link.h | 1 +
.../gpu/drm/amd/display/dc/dce/dce_hwseq.h| 9 ++--
drivers/gpu/drm/amd/display/dc/dce/dce_opp.h | 1 +
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 17 ---
.../display/dc/dce110/dce110_hw_sequencer.c | 24 ++
.../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 41 ++---
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +-
.../amd/display/dc/dcn201/dcn201_resource.c | 2 +-
.../drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
.../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 39 ++--
.../display/dc/dcn31/dcn31_dio_link_encoder.c | 33 +-
.../display/dc/dcn31/dcn31_dio_link_encoder.h | 3 ++
.../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 39 ++--
.../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +-
drivers/gpu/drm/amd/display/dc/dml/Makefile | 4 +-
.../dml/{dcn2x/dcn2x.c => dcn20/dcn20_fpu.c} | 2 +- .../dml/{dcn2x/dcn2x.h
=> dcn20/dcn20_fpu.h} | 6 +--
drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 +
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +-
.../gpu/drm/amd/display/dmub/src/dmub_srv.c | 10 -
25 files changed, 156 insertions(+), 164 deletions(-) rename
drivers/gpu/drm/amd/display/dc/dml/{dcn2x/dcn2x.c => dcn20/dcn20_fpu.c} (99%)
rename drivers/gpu/drm/amd/display/dc/dml/{dcn2x/dcn2x.h => dcn20/dcn20_fpu.h}
(94%)
--
2.25.1
RE: [PATCH 00/24] DC Patches Sep 24, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Anson Jacob Sent: September 24, 2021 3:09 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon Subject: [PATCH 00/24] DC Patches Sep 24, 2021 This DC patchset brings improvements in multiple areas. In summary, we have: - Fixes to backlight, LUT, PPS, MST - Use correct vpg for 128b/132b encoding - Improved logging for VCP - Replace referral of dal with dc Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.85 drm/amd/display: [FW Promotion] Release 0.0.86 Aric Cyr (1): drm/amd/display: 3.2.155 Charlene Liu (1): drm/amd/display: Pass PCI deviceid into DC David Galiffi (1): drm/amd/display: Add debug support to override the Minimum DRAM Clock Eric Yang (1): drm/amd/display: add vsync notify to dmub for abm pause George Shen (2): drm/amd/display: Handle Y carry-over in VCP X.Y calculation drm/amd/display: Update VCP X.Y logging to improve usefulness Ilya (1): drm/amd/display: Add PPS immediate update flag for DCN2 Jimmy Kizito (1): drm/amd/display: Fix MST link encoder availability check. Josip Pavic (1): drm/amd/display: initialize backlight_ramping_override to false Meenakshikumar Somasundaram (1): drm/amd/display: Fix for link encoder access for MST. Michael Strauss (2): drm/amd/display: Don't enable AFMT for DP audio stream drm/amd/display: Defer LUT memory powerdown until LUT bypass latches Oliver Logush (1): drm/amd/display: Add an extra check for dcn10 OPTC data format Qingqing Zhuo (1): drm/amd/display: Replace referral of dal with dc Wenjing Liu (8): drm/amd/display: use correct vpg instance for 128b/132b encoding drm/amd/display: update cur_lane_setting to an array one for each lane drm/amd/display: add function to convert hw to dpcd lane settings drm/amd/display: implement decide lane settings drm/amd/display: rename lane_settings to hw_lane_settings drm/amd/display: decouple hw_lane_settings from dpcd_lane_settings drm/amd/display: add two lane settings training options drm/amd/display: make verified link cap not exceeding max link cap .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 14 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 2 +- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 73 +++ drivers/gpu/drm/amd/display/dc/core/dc_link.c | 73 ++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 591 +++--- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 23 +- .../drm/amd/display/dc/core/dc_link_hwss.c| 5 +- drivers/gpu/drm/amd/display/dc/dc.h | 5 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 5 - drivers/gpu/drm/amd/display/dc/dc_link.h | 2 +- .../drm/amd/display/dc/dce/dce_link_encoder.c | 6 +- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 21 + .../gpu/drm/amd/display/dc/dcn10/dcn10_ipp.h | 6 - .../amd/display/dc/dcn10/dcn10_link_encoder.c | 6 +- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 2 +- .../display/dc/dcn10/dcn10_stream_encoder.c | 11 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 5 + .../drm/amd/display/dc/dcn20/dcn20_resource.c | 4 + .../display/dc/dcn20/dcn20_stream_encoder.c | 9 +- .../dc/dcn30/dcn30_dio_stream_encoder.c | 2 - .../gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c | 59 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 21 +-
RE: [PATCH 00/33] DC Patches September 08, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Mikita Lipski Sent: September 8, 2021 10:54 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson ; Lin, Wayne ; Wang, Chao-kai (Stylon) ; Chiu, Solomon Subject: [PATCH 00/33] DC Patches September 08, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * bandwidth optimizations on following fast updates * fixes and code improvements of DP connector blanking * add thread to offload work of MST HPD IRQ function * fix gamma coefficients * provide backlight support for APUs without DMUB support * coverity memory leak and warning fixes * DSC MST bandwidth calculation fixes * DMUB enhances Anson Jacob (3): drm/amd/display: Fix false BAD_FREE warning from Coverity drm/amd/display: Fix multiple memory leaks reported by coverity drm/amd/display: Revert "Directly retrain link from debugfs" Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.81 drm/amd/display: [FW Promotion] Release 0.0.82 Aric Cyr (2): drm/amd/display: 3.2.151 drm/amd/display: 3.2.152 Aurabindo Pillai (1): drm/amd/display: Add flag to detect dpms force off during HPD Dale Zhao (1): drm/amd/display: Refine condition of cursor visibility for pipe-split Eric Yang (1): drm/amd/display: Add periodic detection when zstate is enabled Harry Wentland (1): drm/amd/display: Get backlight from PWM if DMCU is not initialized Hersen Wu (1): drm/amd/display: dsc mst 2 4K displays go dark with 2 lane HBR3 Ian Chen (1): drm/amd/display: remove force_enable_edp_fec param. Jaehyun Chung (3): drm/amd/display: Add regamma/degamma coefficients and set sRGB when TF is BT709 drm/amd/display: Correct degamma coefficients drm/amd/display: Revert adding degamma coefficients Jimmy Kizito (1): drm/amd/display: Fix dynamic link encoder access. Josip Pavic (1): drm/amd/display: unblock abm when odm is enabled only on configs that support it Leo (Hanghong) Ma (3): drm/amd/display: Add DPCD writes at key points drm/amd/display: Fix system hang at boot drm/amd/display: Add helper for blanking all dp displays Meenakshikumar Somasundaram (2): drm/amd/display: Fix for null pointer access for ddc pin and aux engine. drm/amd/display: Link training retry fix for abort case Michael Strauss (2): drm/amd/display: Add VPG and AFMT low power support for DCN3.1 drm/amd/display: Enable mem low power control for DCN3.1 sub-IP blocks Nicholas Kazlauskas (1): drm/amd/display: Optimize bandwidth on following fast update Qingqing Zhuo (3): drm/amd/display: Revert "dc: w/a for hard hang on HPD on native DP" drm/amd/display: Apply w/a for hard hang on HPD drm/amd/display: Fix unstable HPCP compliance on Chrome Barcelo Wayne Lin (2): drm/amd/display: Add option to defer works of hpd_rx_irq drm/amd/display: Fork thread to offload work of hpd_rx_irq Wenjing Liu (2): drm/amd/display: move bpp range decision in decide dsc bw range function drm/amd/display: update conditions to do dfp cap ext validation .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 266 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 51 +++- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 16 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 18 +- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 11 +- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 16 +- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c
RE: [PATCH 00/19] DC Patches August 23, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Mikita Lipski Sent: August 27, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Jacob, Anson Subject: [PATCH 00/19] DC Patches August 23, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Memory leak fixes and false positive warnings removed caught by coverity * Backlight fix for Carrizo/Stoney laptops * Unblocking ABM when ODM is enabled on DCN31 and up * Fork thread to offload work of hpd_rx_irq to avoid deadlocks * Expose DSC overhead bw parameter to DM Angus Wang (1): drm/amd/display: cleanup idents after a revert Anson Jacob (3): drm/amd/display: Fix false BAD_FREE warning from Coverity drm/amd/display: Fix multiple memory leaks reported by coverity drm/amd/display: Revert "Directly retrain link from debugfs" Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.81 Aric Cyr (1): drm/amd/display: 3.2.151 Aurabindo Pillai (1): drm/amd/display: Add flag to detect dpms force off during HPD Harry Wentland (1): drm/amd/display: Get backlight from PWM if DMCU is not initialized Jaehyun Chung (1): drm/amd/display: Add regamma/degamma coefficients and set sRGB when TF is BT709 Josip Pavic (1): drm/amd/display: unblock abm when odm is enabled only on configs that support it Leo (Hanghong) Ma (2): drm/amd/display: Add DPCD writes at key points drm/amd/display: Fix system hang at boot Meenakshikumar Somasundaram (1): drm/amd/display: Fix for null pointer access for ddc pin and aux engine. Michael Strauss (1): drm/amd/display: Initialize lt_settings on instantiation Oliver Logush (1): drm/amd/display: Drop unused privacy_mask setters and getters Wayne Lin (2): drm/amd/display: Add option to defer works of hpd_rx_irq drm/amd/display: Fork thread to offload work of hpd_rx_irq Wenjing Liu (2): drm/amd/display: expose dsc overhead bw in dc dsc header drm/amd/display: move bpp range decision in decide dsc bw range function .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 222 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 51 +++- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 16 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 23 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 98 +--- .../drm/amd/display/dc/core/dc_link_dpcd.c| 11 +- .../drm/amd/display/dc/core/dc_link_hwss.c| 13 +- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 11 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 9 +- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 12 +- .../drm/amd/display/dc/dce/dce_panel_cntl.c | 10 - .../amd/display/dc/dce/dce_stream_encoder.c | 2 + .../display/dc/dce110/dce110_hw_sequencer.c | 46 +++- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 4 +- .../display/dc/dcn10/dcn10_stream_encoder.c | 10 + .../display/dc/dcn10/dcn10_stream_encoder.h | 2 + .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 10 +- .../display/dc/dcn20/dcn20_stream_encoder.c | 5 + .../display/dc/dcn20/dcn20_stream_encoder.h | 1 + .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 2 +- .../gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 1 + .../drm/amd/display/dc/dcn30/dcn30_resource.c | 6 +- .../amd/display/dc/dcn301/dcn301_resource.c | 6 +- .../amd/display/dc/dcn302/dcn302_resource.c | 6 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 17 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 1 -
RE: [PATCH 00/10] DC Patches Aug 23, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Qingqing Zhuo Sent: August 20, 2021 6:53 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; Lipski, Mikita ; Li, Roman ; Jacob, Anson Subject: [PATCH 00/10] DC Patches Aug 23, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: - DC version 3.2.150 - FW promotion 0.0.80 - Add missing ABM register offsets - Fix in swizzle mode mapping - Emulated sink support for freesync - Improvoments in max target bpp --- Alvin Lee (1): drm/amd/display: Update swizzle mode enums Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.80 Aric Cyr (1): drm/amd/display: 3.2.150 Aurabindo Pillai (1): drm/amd/display: Add emulated sink support for updating FS Josip Pavic (1): drm/amd/display: add missing ABM register offsets Jude Shih (1): drm/amd/display: Support for DMUB HPD interrupt handling Michael Strauss (1): drm/amd/display: Set min dcfclk if pipe count is 0 Roman Li (2): drm/amd/display: Use max target bpp override option drm/amd/display: Limit max DSC target bpp for specific monitors Wyatt Wood (1): drm/amd/display: Initialize GSP1 SDP header .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 199 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 40 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 35 +++ .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dce_abm.h | 16 ++ .../display/dc/dcn10/dcn10_stream_encoder.c | 10 + .../drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_resource.h | 7 + .../amd/display/dc/dcn302/dcn302_resource.c | 2 +- .../amd/display/dc/dcn303/dcn303_resource.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 65 +- .../amd/display/dc/dml/display_mode_enums.h | 4 +- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 29 ++- 15 files changed, 382 insertions(+), 39 deletions(-) -- 2.25.1
RE: [PATCH 0/7] DC Patches Aug 13, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Wayne Lin Sent: August 13, 2021 2:16 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; R, Bindu ; Jacob, Anson ; Lin, Wayne Subject: [PATCH 0/7] DC Patches Aug 13, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Ensure DCN save init registers after VM setup * Fix multi-display support for idle opt workqueue * Use vblank control events for PSR enable/disable * Create default dc_sink when fail reading EDID under MST --- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.79 Aric Cyr (1): drm/amd/display: 3.2.149 Jake Wang (1): drm/amd/display: Ensure DCN save after VM setup Nicholas Kazlauskas (3): drm/amd/display: Fix multi-display support for idle opt workqueue drm/amd/display: Use vblank control events for PSR enable/disable drm/amd/display: Guard vblank wq flush with DCN guards Wayne Lin (1): drm/amd/display: Create dc_sink when EDID fail .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 112 +++--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 23 ++-- .../display/amdgpu_dm/amdgpu_dm_irq_params.h | 1 + .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 23 drivers/gpu/drm/amd/display/dc/core/dc.c | 6 + .../drm/amd/display/dc/core/dc_vm_helper.c| 3 + drivers/gpu/drm/amd/display/dc/dc.h | 3 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 12 ++ .../drm/amd/display/dc/dcn31/dcn31_hwseq.h| 1 + .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 1 + .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 1 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 19 ++- 12 files changed, 148 insertions(+), 57 deletions(-) -- 2.25.1
RE: [PATCH 00/13] DC Patches Aug 6, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Anson Jacob Sent: August 6, 2021 12:35 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; eryk.b...@amd.com; R, Bindu ; Jacob, Anson Subject: [PATCH 00/13] DC Patches Aug 6, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fix memory allocation in dm IRQ context to use GFP_ATOMIC - Increase timeout threshold for DMCUB reset - Clear GPINT after DMCUB has reset - Add AUX I2C tracing - Fix code commenting style - Some refactoring - Remove invalid assert for ODM + MPC case Anson Jacob (1): drm/amd/display: use GFP_ATOMIC in amdgpu_dm_irq_schedule_work Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.78 drm/amd/display: 3.2.148 Ashley Thomas (1): drm/amd/display: Add AUX I2C tracing. Eric Bernstein (1): drm/amd/display: Remove invalid assert for ODM + MPC case Nicholas Kazlauskas (2): drm/amd/display: Clear GPINT after DMCUB has reset drm/amd/display: Increase timeout threshold for DMCUB reset Roy Chan (5): drm/amd/display: fix missing writeback disablement if plane is removed drm/amd/display: refactor the codes to centralize the stream/pipe checking logic drm/amd/display: refactor the cursor programing codes drm/amd/display: fix incorrect CM/TF programming sequence in dwb drm/amd/display: Correct comment style Wenjing Liu (1): drm/amd/display: add authentication_complete in hdcp output .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 62 -- .../gpu/drm/amd/display/dc/core/dc_stream.c | 106 ++ drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 192 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 14 +- .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c | 90 +--- .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 12 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 1 - .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 6 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 18 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 5 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 8 + .../display/modules/hdcp/hdcp1_transition.c | 8 +- .../display/modules/hdcp/hdcp2_transition.c | 4 +- .../drm/amd/display/modules/hdcp/hdcp_log.c | 74 +++ .../drm/amd/display/modules/hdcp/hdcp_log.h | 72 --- .../drm/amd/display/modules/inc/mod_hdcp.h| 1 + 18 files changed, 479 insertions(+), 198 deletions(-) -- 2.25.1
RE: [PATCH 0/9] DC Patches for August 2, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Aurabindo Pillai Sent: July 29, 2021 4:06 PM To: amd-gfx@lists.freedesktop.org Cc: eryk.b...@amd.com; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 0/9] DC Patches for August 2, 2021 This DC patchset brings improvements in multiple areas. In summary, we have: * DC version 3.2.147 * DMUB FW release 0.0.77 * LTTPR, MPO improvements * General bug fixes and stability improvements -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.77 Aric Cyr (1): drm/amd/display: 3.2.147 Chung (1): drm/amd/display: Add check for validating unsupported ODM plus MPO case Guo, Bing (2): drm/amd/display: Fix Dynamic bpp issue with 8K30 with Navi 1X drm/amd/display: Increase stutter watermark for dcn303 Jude Shih (1): drm/amd/display: Fix resetting DCN3.1 HW when resuming from S4 Qingqing Zhuo (1): drm/amd/display: workaround for hard hang on HPD on native DP Roman Li (1): drm/amd/display: Remove redundant vblank workqueues in DM Wesley Chalmers (1): drm/amd/display: Assume LTTPR interop for DCN31+ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 4 +++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 21 ++- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 + drivers/gpu/drm/amd/display/dc/dc.h | 4 +++- .../gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 2 +- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 20 ++ .../amd/display/dc/dcn303/dcn303_resource.c | 4 ++-- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 16 ++ .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 8 --- 11 files changed, 61 insertions(+), 35 deletions(-) -- 2.32.0 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=04%7C01%7Cdaniel.wheeler%40amd.com%7Cd897a79ebeb244afd03408d952cc5fd9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637631860013972704%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=tf%2BFzw1oQ3Uijba3S0TeNFYoKbNwFqqnh7j2E4jftY8%3Dreserved=0
RE: [PATCH 00/14] DC Patches July 26, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Solomon Chiu Sent: July 23, 2021 11:50 PM To: amd-gfx@lists.freedesktop.org Cc: Chiu, Solomon ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 00/14] DC Patches July 26, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * Guard DST_Y_PREFETCH register overflow in DCN21 * Add missing DCN21 IP parameter * Fix PSR command version * Add ETW logging for AUX failures * Add ETW log to dmub_psr_get_state * Fixed EdidUtility build errors * Fix missing reg offset for the dmcub test debug registers * Adding update authentication interface * Remove unused functions of opm state query support * Always wait for update lock status * Refactor riommu invalidation wa * Ensure dentist display clock update finished in DCN20 Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.76 Aric Cyr (1): drm/amd/display: 3.2.146 Dale Zhao (1): drm/amd/display: ensure dentist display clock update finished in DCN20 Eric Bernstein (1): drm/amd/display: Always wait for update lock status Eric Yang (2): drm/amd/display: fix missing reg offset drm/amd/display: refactor riommu invalidation wa Mark Morra (1): drm/amd/display: Fixed EdidUtility build errors Mikita Lipski (1): drm/amd/display: Fix PSR command version Victor Lu (2): drm/amd/display: Guard DST_Y_PREFETCH register overflow in DCN21 drm/amd/display: Add missing DCN21 IP parameter Wenjing Liu (2): drm/amd/display: add update authentication interface drm/amd/display: remove unused functions Wyatt Wood (2): drm/amd/display: Add ETW logging for AUX failures drm/amd/display: Add ETW log to dmub_psr_get_state .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 4 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 108 +++-- drivers/gpu/drm/amd/display/dc/dc.h | 120 +++--- drivers/gpu/drm/amd/display/dc/dc_types.h | 81 ++-- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 8 + drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 21 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 6 - .../drm/amd/display/dc/dcn21/dcn21_resource.c | 1 + .../gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 8 +- .../drm/amd/display/dc/dcn31/dcn31_hubbub.c | 48 ++- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 17 - .../gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 2 +- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 1 - .../dc/dml/dcn21/display_mode_vba_21.c| 3 + drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 393 ++ .../gpu/drm/amd/display/dc/inc/hw/dchubbub.h | 3 - .../amd/display/dc/inc/hw_sequencer_private.h | 1 - .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 5 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 70 +++- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 2 - .../display/modules/hdcp/hdcp1_execution.c| 6 - .../display/modules/hdcp/hdcp2_execution.c| 3 - .../drm/amd/display/modules/hdcp/hdcp_psp.c | 53 +-- .../drm/amd/display/modules/inc/mod_hdcp.h| 12 +- 26 files changed, 538 insertions(+), 444 deletions(-) -- 2.25.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org
RE: [PATCH 00/32] DC Patches July 18, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: Siqueira, Rodrigo Sent: July 18, 2021 10:06 AM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Pillai, Aurabindo ; Zhuo, Qingqing ; R, Bindu ; Jacob, Anson ; Wheeler, Daniel Subject: [PATCH 00/32] DC Patches July 18, 2021 DC version 3.2.144 brings improvements in multiple areas. In summary, we highlight: - Code improvements for passive - Cursor manipulation enhancements - Expand debug in some areas - Fix problems in DML - Other minor code refactors Cc: Daniel Wheeler Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.73 drm/amd/display: [FW Promotion] Release 0.0.75 Aric Cyr (3): drm/amd/display: 3.2.143 drm/amd/display: 3.2.144 drm/amd/display: 3.2.145 Aurabindo Pillai (1): drm/amd/display: add debug print for DCC validation failure Bindu Ramamurthy (2): drm/amd/display: Populate socclk entries for dcn3.02/3.03 drm/amd/display: Populate dtbclk entries for dcn3.02/3.03 Camille Cho (1): drm/amd/display: Only set default brightness for OLED Charlene Liu (1): drm/amd/display: reset dpcd_cap.dpcd_rev for passive dongle. Dmytro Laktyushkin (1): drm/amd/display: remove compbuf size wait Eric Yang (3): drm/amd/display: implement workaround for riommu related hang drm/amd/display: add workaround for riommu invalidation request hang drm/amd/display: change zstate allow msg condition Ian Chen (1): drm/amd/display: Extend dmub_cmd_psr_copy_settings_data struct Jake Wang (1): drm/amd/display: Fixed hardware power down bypass during headless boot Josip Pavic (1): drm/amd/display: log additional register state for debug Krunoslav Kovac (2): drm/amd/display: Assume active upper layer owns the HW cursor drm/amd/display: Refine condition for cursor visibility Michael Strauss (1): drm/amd/display: Enable eDP ILR on DCN2.1 Mikita Lipski (2): drm/amd/display: Prevent Diags from entering S2 drm/amd/display: Remove MALL function from DCN3.1 Nevenko Stupar (1): drm/amd/display: Line Buffer changes Nicholas Kazlauskas (3): drm/amd/display: Fix max vstartup calculation for modes with borders drm/amd/display: Query VCO frequency from register for DCN3.1 drm/amd/display: Update bounding box for DCN3.1 Oliver Logush (1): drm/amd/display: Fix timer_per_pixel unit error Stylon Wang (1): drm/amd/display: Re-enable "Guard ASSR with internal display flag" Victor Lu (1): drm/amd/display: Fix comparison error in dcn21 DML Wesley Chalmers (1): drm/amd/display: Add copyright notice to new files Zhan Liu (1): drm/amd/display: Reduce delay when sink device not able to ACK 00340h write sunglee (1): drm/amd/display: DCN2X Prefer ODM over bottom pipe to find second pipe .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 4 ++ .../display/dc/clk_mgr/dcn301/vg_clk_mgr.c| 2 +- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 59 --- .../display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h | 54 -- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 +++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 72 +-- .../drm/amd/display/dc/core/dc_link_dpcd.c| 25 +++ drivers/gpu/drm/amd/display/dc/dc.h | 12 ++-- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 1 + .../gpu/drm/amd/display/dc/dce/dce_hwseq.h| 4 +- .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 7 +- .../drm/amd/display/dc/dcn10/dcn10_hubbub.h | 19 - .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 29 .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.h | 4 ++ .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 42 ++- .../gpu/drm/amd/
RE: [PATCH 00/12] DC Patches June 29, 2021
[Public] Hi all and sorry for the delay, This patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Sent: June 29, 2021 11:54 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 00/12] DC Patches June 29, 2021 DC version 3.2.142 brings improvements in multiple areas. In summary, we highlight: - Freesync improvements - Remove unnecessary assert - Firmware release 0.0.72 - Improve the EDID manipulation and DML calculations Alvin Lee (1): drm/amd/display: Adjust types and formatting for future development Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.72 Aric Cyr (3): drm/amd/display: 3.2.142 drm/amd/display: Round KHz up when calculating clock requests drm/amd/display: increase max EDID size to 2k Chun-Liang Chang (1): drm/amd/display: DMUB Outbound Interrupt Process-X86 Dmytro Laktyushkin (1): drm/amd/display: remove faulty assert Nicholas Kazlauskas (1): drm/amd/display: Fix updating infoframe for DCN3.1 eDP Stylon Wang (1): drm/amd/display: Add Freesync HDMI support to DM with DMUB Wang (1): drm/amd/display: Add null checks Wenjing Liu (1): drm/amd/display: isolate link training setting override to its own function Wesley Chalmers (1): Revert "drm/amd/display: Always write repeater mode regardless of LTTPR" .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 95 +- .../display/dc/clk_mgr/dcn10/rv1_clk_mgr.c| 12 +- .../dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 4 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 12 +- .../dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c | 16 +-- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 25 ++-- .../display/dc/clk_mgr/dcn301/dcn301_smu.c| 10 +- .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 10 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 121 +- drivers/gpu/drm/amd/display/dc/core/dc_stat.c | 24 .../gpu/drm/amd/display/dc/core/dc_stream.c | 3 + drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dc_stat.h | 1 + drivers/gpu/drm/amd/display/dc/dc_types.h | 2 +- .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 2 +- .../dc/dml/dcn21/display_mode_vba_21.c| 11 +- .../dc/dml/dcn30/display_mode_vba_30.c| 18 +-- .../dc/dml/dcn31/display_mode_vba_31.c| 15 ++- .../amd/display/dc/dml/display_mode_enums.h | 4 +- .../drm/amd/display/dc/dml/display_mode_vba.c | 12 +- .../drm/amd/display/dc/dml/display_mode_vba.h | 4 +- .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 1 - .../amd/display/dc/inc/hw/clk_mgr_internal.h | 5 + drivers/gpu/drm/amd/display/dc/irq_types.h| 2 +- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 18 +++ .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 11 +- .../gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 15 +++ .../gpu/drm/amd/display/dmub/src/dmub_dcn31.h | 13 +- .../gpu/drm/amd/display/dmub/src/dmub_srv.c | 17 +++ .../include/asic_reg/dcn/dcn_3_1_2_sh_mask.h | 4 + 30 files changed, 338 insertions(+), 151 deletions(-) -- 2.25.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=04%7C01%7Cdaniel.wheeler%40amd.com%7C277feeb3b4624c5460fc08d93b163dc9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637605788987674214%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=j6iE3LOdDB2kUkSApf2WIiNWIFStAZwvnvknpiZvbFg%3Dreserved=0 ___
RE: [PATCH 00/12] June, 21, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Bindu Ramamurthy Sent: June 18, 2021 1:35 PM To: amd-gfx@lists.freedesktop.org Cc: Brol, Eryk ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 00/12] June, 21, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC 3.2.141 * Firmware release 0.0.71 * Improvements across LTTPR, edp initialization, DML calculations, VBIOS for dcn302 and dcn303 etc. Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.71 Aric Cyr (2): drm/amd/display: Multiplane cursor position incorrect when plane rotated drm/amd/display: 3.2.141 This version brings along following fixes: - FW release 0.0.71. - get socBB from VBIOS for dcn302 and dcn303. - refclk from MICROSECOND_TIME_BASE_DIV HW register. - Clear lane settings after LTTPRs have been trained. - Clamp VStartup value at DML calculations. Aurabindo Pillai (1): drm/amd/display: get socBB from VBIOS for dcn302 and dcn303 Charlene Liu (1): drm/amd/display: get refclk from MICROSECOND_TIME_BASE_DIV HW register Josip Pavic (1): drm/amd/display: do not compare integers of different widths Martin Tsai (1): drm/amd/display: Clear lane settings after LTTPRs have been trained Nikola Cornij (1): drm/amd/display: Clamp VStartup value at DML calculations time Roman Li (1): drm/amd/display: Delay PSR entry Stylon Wang (1): drm/amd/display: Revert "Guard ASSR with internal display flag" Wesley Chalmers (1): drm/amd/display: Fix incorrect variable name ollogush (1): drm/amd/display: Fix edp_bootup_bl_level initialization issue .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.h | 3 + .../drm/amd/display/dc/bios/bios_parser2.c| 2 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 66 +- .../drm/amd/display/dc/core/dc_link_dpcd.c| 2 +- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- .../gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 13 ++- .../gpu/drm/amd/display/dc/dce/dce_i2c_hw.h | 3 + .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 15 +++- .../amd/display/dc/dcn302/dcn302_resource.c | 20 + .../amd/display/dc/dcn303/dcn303_resource.c | 20 + .../dc/dml/dcn31/display_mode_vba_31.c| 4 + .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 90 ++- 15 files changed, 197 insertions(+), 57 deletions(-) -- 2.25.1 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfxdata=04%7C01%7Cdaniel.wheeler%40amd.com%7Ca309462e10d641ec36f308d9327f79a4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637596345349689067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=qX9J3g2j%2B%2FzJ8ZTp8Z7cY57N49S2S3KI5NRw7RMYXkM%3Dreserved=0 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
RE: [PATCH 00/24] DC Patches June 10, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Anson Jacob Sent: June 10, 2021 12:28 PM To: amd-gfx@lists.freedesktop.org Cc: Brol, Eryk ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Li, Roman ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 00/24] DC Patches June 10, 2021 This DC patchset brings improvements in multiple areas. In summary, we have: * LTTPR improvements * Backlight improvements * eDP hotplug detection *** BLURB HERE *** Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.70 Aric Cyr (1): drm/amd/display: 3.2.140 Ashley Thomas (1): drm/amd/display: add DMUB registers to crash dump diagnostic data. David Galiffi (1): drm/amd/display: Updated variable name. Dmytro Laktyushkin (1): drm/amd/display: Remove unnecessary blank lines Josip Pavic (1): drm/amd/display: tune backlight ramping profiles Po-Ting Chen (1): drm/amd/display: Change swizzle visual confirm reference pipe Roman Li (1): drm/amd/display: move psr dm interface to separate files Wenjing Liu (1): drm/amd/display: dp mst detection code refactor Wesley Chalmers (14): drm/amd/display: Read LTTPR caps first on hotplug drm/amd/display: Move LTTPR cap read into its own function drm/amd/display: Read LTTPR caps first on bootup drm/amd/display: Set LTTPR Transparent Mode after read link cap drm/amd/display: Always write repeater mode regardless of LTTPR drm/amd/display: Improve logic for is_lttpr_present drm/amd/display: Enforce DPCD Address ranges drm/amd/display: Rename constant drm/amd/display: 7 retries + 50 ms timeout on AUX DEFER drm/amd/display: Do not count I2C DEFERs with AUX DEFERs drm/amd/display: Partition DPCD address space and break up transactions drm/amd/display: Add interface to get Calibrated Avg Level from FIFO drm/amd/display: Cover edge-case when changing DISPCLK WDIVIDER drm/amd/display: Extend AUX timeout for DP initial reads Yi-Ling Chen (1): drm/amd/display: add config option for eDP hotplug detection .../gpu/drm/amd/display/amdgpu_dm/Makefile| 2 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 137 +-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 166 + .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.h | 37 +++ drivers/gpu/drm/amd/display/dc/Makefile | 2 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 68 +- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.h | 3 +- .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 4 +- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 10 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 167 ++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 170 +++--- .../drm/amd/display/dc/core/dc_link_dpcd.c| 218 ++ .../drm/amd/display/dc/core/dc_link_hwss.c| 31 +-- drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 100 +++- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 4 + drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 23 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 5 + .../display/dc/dcn10/dcn10_stream_encoder.h | 24 ++ .../display/dc/dcn20/dcn20_stream_encoder.c | 12 + .../display/dc/dcn20/dcn20_stream_encoder.h | 3 + .../dc/dcn30/dcn30_dio_stream_encoder.c | 2 + .../dc/dcn30/dcn30_dio_stream_encoder.h | 12 + .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 4 + .../drm/amd/display/dc/dcn31/dcn31_hwseq.c| 1 + .../drm/amd/display/dc/dml/display_mode_vba.c | 2 - .../gpu/drm/amd/display/dc/hdcp/hdcp_msg.c| 1 + .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 11 +- .../amd/display/dc/inc/hw/stream_encoder.h| 3 +
RE: [PATCH 00/30] DC Patches June, 7, 2021
[Public] Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) AMD Ryzen 9 5900H, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI), 1680*1050 60hz (via USB-C to DP and then DP to DVI/VGA) Sapphire Pulse RX5700XT with the following display types: 4k 60hz (via DP/HDMI), 1440p 144hz (via DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Reference AMD RX6800 with the following display types: 4k 60hz (via DP/HDMI and USB-C to DP/HDMI), 1440p 144hz (via USB-C to DP/HDMI and USB-C to DP/HDMI), 1680*1050 60hz (via DP to DVI/VGA) Included testing using a Startech DP 1.4 MST hub at 2x 4k 60hz, and 3x 1080p 60hz on all systems. Tested-by: Daniel Wheeler Thank you, Dan Wheeler Technologist | AMD SW Display -- 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 Facebook | Twitter | amd.com -Original Message- From: amd-gfx On Behalf Of Stylon Wang Sent: June 7, 2021 12:47 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Brol, Eryk ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Jacob, Anson ; Pillai, Aurabindo ; Lakha, Bhawanpreet ; R, Bindu Subject: [PATCH 00/30] DC Patches June, 7, 2021 This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.139 * FW v0.0.69 * Improvements across DP, eDP, DMUB, MPO, etc -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.68 Aric Cyr (4): drm/amd/display: Change default policy for MPO with multidisplay drm/amd/display: 3.2.138 drm/amd/display: Fix crash during MPO + ODM combine mode recalculation drm/amd/display: 3.2.139 Dingchen (David) Zhang (1): drm/amd/display: force CP to DESIRED when removing display Eric Bernstein (1): drm/amd/display: Updates for ODM Transition Test Evgenii Krasnikov (1): drm/amd/display: add visual confirm colors to differentiate layer_index > 0 Fangzhi Zuo (1): drm/amd/display: Add debugfs entry for dsc passthrough Ilya Bakoulin (1): drm/amd/display: Revert "Fix clock table filling logic" Jake Wang (1): drm/amd/display: Trigger full update after DCC on/off Jayendran Ramani (1): drm/amd/display: Return last used DRR VTOTAL from DC Jimmy Kizito (2): drm/amd/display: Expand DP module equalization API. drm/amd/display: Support mappable encoders when transmitting training patterns. JinZe.Xu (1): drm/amd/display: Control power gating by driver. Meenakshikumar Somasundaram (1): drm/amd/display: Remove unused definition of DMUB SET_CONFIG Mikita Lipski (2): drm/amd/display: Enabling PSR support for multiple panels drm/amd/display: Enable PSR Residency for multiple panels Nikola Cornij (1): drm/amd/display: Fix DCN 3.01 DSCCLK validation Po-Ting Chen (1): drm/amd/display: Add swizzle visual confirm mode Roman Li (1): drm/amd/display: Update scaling settings on modeset Roy Chan (1): drm/amd/display: Revert "Disconnect non-DP with no EDID" Vladimir Stempen (1): drm/amd/display: Release MST resources on switch from MST to SST Wenjing Liu (1): drm/amd/display: delay 100ms before restart after failing to read CP_IRQ Wesley Chalmers (4): drm/amd/display: Add Interface to set FIFO ERRDET SW Override drm/amd/display: Add interface for ADD & DROP PIXEL Registers drm/amd/display: Set DISPCLK_MAX_ERRDET_CYCLES to 7 drm/amd/display: Fix off-by-one error in DML Wyatt Wood (2): drm/amd/display: Refactor visual confirm drm/amd/display: [FW Promotion] Release 0.0.69 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 50 ++- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 15 +- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 22 ++- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 78 -- drivers/gpu/drm/amd/display/dc/core/dc.c | 60 +++- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 133 ++ drivers/gpu/drm/amd/display/dc/core/dc_link.c | 47 +++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 24 ++-- .../drm/amd/display/dc/core/dc_link_hwss.c| 11 +- .../gpu/drm/amd/display/dc/core/dc_resource.c | 5 + drivers/gpu/drm/amd/display/dc/dc.h | 3 +- drivers/gpu/drm/amd/display/dc/dc_stream.h| 4 + drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 41 -- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h | 17 ++- .../display/dc/dce110/dce110_hw_sequencer.c | 35 - .../dc/dce110/dce110_timing_generator.c | 1 + .../dc/dce120/dce120_timing_generator.c | 1
