Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
[AMD Official Use Only]
Thank you very much for your suggestion, but I have already submitted.
Regards,
Rico
From: Chen, Guchun
Sent: Monday, March 28, 2022 10:17
To: Chen, Guchun ; Yin, Tianci (Rico)
; amd-gfx@lists.freedesktop.org
Cc: Wang, Yu (Charlie) ; Zhu, James ; Yin,
Tianci (Rico)
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Hi Tianci,
I think we shall improve the subject a bit like "drm/amdgpu: fix incorrect
instance id passing when stopping dpg mode". How do you think?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Monday, March 28, 2022 9:26 AM
To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org
Cc: Wang, Yu (Charlie) ; Zhu, James ; Yin,
Tianci (Rico)
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Tianci Yin
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhu, James ; Wang,
Yu (Charlie) ; Yin, Tianci (Rico)
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Hi Tianci,
I think we shall improve the subject a bit like "drm/amdgpu: fix incorrect
instance id passing when stopping dpg mode". How do you think?
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Monday, March 28, 2022 9:26 AM
To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org
Cc: Wang, Yu (Charlie) ; Zhu, James ; Yin,
Tianci (Rico)
Subject: RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Tianci Yin
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhu, James ; Wang,
Yu (Charlie) ; Yin, Tianci (Rico)
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
RE: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Tianci Yin
Sent: Sunday, March 27, 2022 7:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhu, James ; Wang,
Yu (Charlie) ; Yin, Tianci (Rico)
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
[AMD Official Use Only]
Thank you James!
Rico
From: Zhu, James
Sent: Sunday, March 27, 2022 21:47
To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Wang, Yu (Charlie)
Subject: Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
[AMD Official Use Only]
This patch is Reviewed-by: James Zhu
From: Tianci Yin
Sent: Sunday, March 27, 2022 7:18 AM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhu, James ; Wang,
Yu (Charlie) ; Yin, Tianci (Rico)
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
[AMD Official Use Only]
This patch is Reviewed-by: James Zhu
From: Tianci Yin
Sent: Sunday, March 27, 2022 7:18 AM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Guchun ; Zhu, James ; Wang,
Yu (Charlie) ; Yin, Tianci (Rico)
Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
[PATCH] drm/amd/vcn: fix an error msg on vcn 3.0
From: tiancyin
Some video card has more than one vcn instance, passing 0 to
vcn_v3_0_pause_dpg_mode is incorrect.
Error msg:
Register(1) [mmUVD_POWER_STATUS] failed to reach value
0x0001 != 0x0002
Signed-off-by: tiancyin
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
index e1cca0a10653..cb5f0a12333f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
@@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE};
uint32_t tmp;
- vcn_v3_0_pause_dpg_mode(adev, 0, );
+ vcn_v3_0_pause_dpg_mode(adev, inst_idx, );
/* Wait for power status to be 1 */
SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1,
--
2.25.1
