Re: [android-building] Some questions on Android.bp files

['Dan Willemsen' via Android Building]

>
> And for me visibility property is not working, Is this available only on Q?


visibility is actually only available on master -- it was recently
implemented, and didn't make it into Q. That only lets you limit visibility
though, which it doesn't sound like what you're looking for.

Are there any alternative to access "previous folder" header files in
> current .bp
>
> Something like ../app/include giving me Path Outside the Directory, and
> using visibility dont work
>

No, there's no way to allow "../" to work in Android.bp files. Move the
definition up a level if you're the only one using those files, or use a
filegroup to expose those as a set of files. Since you mention "include" --
if this is for C/C++ headers, you may want to read the best practices
,
and see if you should be exporting the header directories from a library
instead of referencing paths directly. (A cc_library_headers may also work
in your situation, but I highly suggest that those should only be used for
truly header-only libraries).

- Dan

On Fri, Aug 2, 2019 at 9:22 AM jyoti kulkarni  wrote:

> Hello Dan,
>
> Thanks for your inputs.
> Currently I m still on Android P version.
>
> And for me visibility property is not working, Is this available only on Q?
> Are there any alternative to access "previous folder" header files in
> current .bp
>
> Something like ../app/include giving me Path Outside the Directory, and
> using visibility dont work
>
> Thanks
> Jyoti
>
> On Wednesday, July 31, 2019 at 7:44:42 AM UTC+5:30, Dan Willemsen wrote:
>>
>> 1. Which version of Android are you building against? host_required is
>> only supported on AOSP master. Unknown properties are errors, as they're
>> often typos.
>>
>> 2. Including Android.mk files from Android.bp files doesn't make sense,
>> what are you trying to do?
>>
>> We do forbid all path references that use ".." to escape the current
>> directory however -- you either need to use a filegroup and a module
>> reference ":filegroup_name", or move the contents of the Android.bp up a
>> level. We saw this a lot in applications that had:
>>
>>foo/res/...
>>foo/src/...
>>foo/test/...
>>
>> And had Android.mk files in the src and test directories that were using
>> "../" to access the other dirs. The better way to handle that is to move
>> those definitions up to a foo/Android.bp file.
>>
>> There's some internal reasons why forbidding ".." helps a lot, but we
>> also wanted it very obvious where to look to figure out who was using a
>> particular file -- it may only be referenced by an Android.bp directly
>> upwards in the tree. `mma` can work better this way, and we've implemented
>> the concept of visibility so that modules can control who can use their
>> files/outputs.
>>
>> - Dan
>>
>> On Tue, Jul 30, 2019 at 7:10 AM jyoti kulkarni 
>> wrote:
>>
>>> Hello Sir/madam,
>>>
>>> Im trying to convert some of the .mk files to .bp
>>> I am using androidmk tool for initial conversion.
>>>
>>> But later I m trying to change the converted files to add some more
>>> properties and some conditional statement.
>>>
>>> I have below questions:
>>> 1. Any new property added is giving an error "unrecognized property"
>>> for eg: unrecognized property "host_required"
>>>
>>> 2. If I'am trying to include other .mk file in .bp its giving "Path
>>> Outside directory"
>>> Iam trying to do something like this:
>>> srcs: ["../Android.mk"]
>>>
>>> Please help in addressing these questions.
>>>
>>> Thanks
>>>
>>> --
>>> --
>>> You received this message because you are subscribed to the "Android
>>> Building" mailing list.
>>> To post to this group, send email to android-...@googlegroups.com
>>> To unsubscribe from this group, send email to
>>> android-...@googlegroups.com
>>> For more options, visit this group at
>>> http://groups.google.com/group/android-building?hl=en
>>>
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Android Building" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to android-...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/android-building/8bbaf348-6e27-49c3-942e-67fc13b40330%40googlegroups.com
>>> 
>>> .
>>>
>> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe 

Re: [android-building] Some questions on Android.bp files

[jyoti kulkarni]

Hello Dan,

Thanks for your inputs.
Currently I m still on Android P version.

And for me visibility property is not working, Is this available only on Q?
Are there any alternative to access "previous folder" header files in 
current .bp

Something like ../app/include giving me Path Outside the Directory, and 
using visibility dont work

Thanks
Jyoti 

On Wednesday, July 31, 2019 at 7:44:42 AM UTC+5:30, Dan Willemsen wrote:
>
> 1. Which version of Android are you building against? host_required is 
> only supported on AOSP master. Unknown properties are errors, as they're 
> often typos.
>
> 2. Including Android.mk files from Android.bp files doesn't make sense, 
> what are you trying to do?
>
> We do forbid all path references that use ".." to escape the current 
> directory however -- you either need to use a filegroup and a module 
> reference ":filegroup_name", or move the contents of the Android.bp up a 
> level. We saw this a lot in applications that had:
>
>foo/res/...
>foo/src/...
>foo/test/...
>
> And had Android.mk files in the src and test directories that were using 
> "../" to access the other dirs. The better way to handle that is to move 
> those definitions up to a foo/Android.bp file.
>
> There's some internal reasons why forbidding ".." helps a lot, but we also 
> wanted it very obvious where to look to figure out who was using a 
> particular file -- it may only be referenced by an Android.bp directly 
> upwards in the tree. `mma` can work better this way, and we've implemented 
> the concept of visibility so that modules can control who can use their 
> files/outputs.
>
> - Dan
>
> On Tue, Jul 30, 2019 at 7:10 AM jyoti kulkarni  > wrote:
>
>> Hello Sir/madam,
>>
>> Im trying to convert some of the .mk files to .bp 
>> I am using androidmk tool for initial conversion.
>>
>> But later I m trying to change the converted files to add some more 
>> properties and some conditional statement.
>>
>> I have below questions:
>> 1. Any new property added is giving an error "unrecognized property" 
>> for eg: unrecognized property "host_required"
>>
>> 2. If I'am trying to include other .mk file in .bp its giving "Path 
>> Outside directory"
>> Iam trying to do something like this:
>> srcs: ["../Android.mk"]
>>
>> Please help in addressing these questions.
>>
>> Thanks
>>
>> -- 
>> -- 
>> You received this message because you are subscribed to the "Android 
>> Building" mailing list.
>> To post to this group, send email to android-...@googlegroups.com 
>> 
>> To unsubscribe from this group, send email to
>> android-...@googlegroups.com 
>> For more options, visit this group at
>> http://groups.google.com/group/android-building?hl=en
>>
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Android Building" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to android-...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/android-building/8bbaf348-6e27-49c3-942e-67fc13b40330%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/a8e5b45d-2de7-4420-a0d5-f297b9e0f00e%40googlegroups.com.

Re: [android-building] Some questions on Android.bp files

['Dan Willemsen' via Android Building]

1. Which version of Android are you building against? host_required is only
supported on AOSP master. Unknown properties are errors, as they're often
typos.

2. Including Android.mk files from Android.bp files doesn't make sense,
what are you trying to do?

We do forbid all path references that use ".." to escape the current
directory however -- you either need to use a filegroup and a module
reference ":filegroup_name", or move the contents of the Android.bp up a
level. We saw this a lot in applications that had:

   foo/res/...
   foo/src/...
   foo/test/...

And had Android.mk files in the src and test directories that were using
"../" to access the other dirs. The better way to handle that is to move
those definitions up to a foo/Android.bp file.

There's some internal reasons why forbidding ".." helps a lot, but we also
wanted it very obvious where to look to figure out who was using a
particular file -- it may only be referenced by an Android.bp directly
upwards in the tree. `mma` can work better this way, and we've implemented
the concept of visibility so that modules can control who can use their
files/outputs.

- Dan

On Tue, Jul 30, 2019 at 7:10 AM jyoti kulkarni  wrote:

> Hello Sir/madam,
>
> Im trying to convert some of the .mk files to .bp
> I am using androidmk tool for initial conversion.
>
> But later I m trying to change the converted files to add some more
> properties and some conditional statement.
>
> I have below questions:
> 1. Any new property added is giving an error "unrecognized property"
> for eg: unrecognized property "host_required"
>
> 2. If I'am trying to include other .mk file in .bp its giving "Path
> Outside directory"
> Iam trying to do something like this:
> srcs: ["../Android.mk"]
>
> Please help in addressing these questions.
>
> Thanks
>
> --
> --
> You received this message because you are subscribed to the "Android
> Building" mailing list.
> To post to this group, send email to android-building@googlegroups.com
> To unsubscribe from this group, send email to
> android-building+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to android-building+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/android-building/8bbaf348-6e27-49c3-942e-67fc13b40330%40googlegroups.com
> 
> .
>

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/CALQgHdnV4gUYvBdZQJ28H0ZpWAy7DVGS%3DzMOzYdfuStG%2BVgmKA%40mail.gmail.com.

[android-building] Some questions on Android.bp files

[jyoti kulkarni]

Hello Sir/madam,

Im trying to convert some of the .mk files to .bp 
I am using androidmk tool for initial conversion.

But later I m trying to change the converted files to add some more 
properties and some conditional statement.

I have below questions:
1. Any new property added is giving an error "unrecognized property" 
for eg: unrecognized property "host_required"

2. If I'am trying to include other .mk file in .bp its giving "Path Outside 
directory"
Iam trying to do something like this:
srcs: ["../Android.mk"]

Please help in addressing these questions.

Thanks

-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to android-building@googlegroups.com
To unsubscribe from this group, send email to
android-building+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to android-building+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/8bbaf348-6e27-49c3-942e-67fc13b40330%40googlegroups.com.