[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 5: Code-Review+1 Used grep, found a few tests that were still using parameters with the new macro. Fixed them. Also verified with grep that no references to the old macro exist. -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 5 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: No -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello George Joseph, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#5). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Joshua Colp has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 5: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 5 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-Reviewer: Joshua Colp jc...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: No -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c File cel/cel_radius.c: Line 36: ASTERISK_REGISTER_FILE(__FILE__, $Rev$) cel_radius.c:36:41: error: macro ASTERISK_REGISTER_FILE passed 2 argument TIL: I don't have libradius installed. -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: Yes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: The ModuleCheck Action's Version key will now always return the Asterisk version. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M channels/chan_oss.c M channels/chan_phone.c M channels/chan_pjsip.c M channels/chan_rtp.c M channels/chan_sip.c M channels/chan_skinny.c M channels/chan_unistim.c M channels/console_board.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello George Joseph, Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 4: Code-Review+1 Compile succeeded. -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 4 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: No -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review-1 (1 comment) Compile fails. https://gerrit.asterisk.org/#/c/58/1/cel/cel_radius.c File cel/cel_radius.c: Line 36: ASTERISK_REGISTER_FILE(__FILE__, $Rev$) cel_radius.c:36:41: error: macro ASTERISK_REGISTER_FILE passed 2 arguments, but takes just 0 ASTERISK_REGISTER_FILE(__FILE__, $Rev$) -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: George Joseph george.jos...@fairview5.com Gerrit-HasComments: Yes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Corey Farrell has posted comments on this change.
Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG
Commit Message:
Line 22: Other facilities other
Remove one of the other's.
https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h
File include/asterisk.h:
Line 164: void ast_register_file(const char *file);
Given that this is meant for use through a macro only, shouldn't it be
__ast_register_file? Ditto for ast_unregister_file.
Line 203: * ASTERISK_REGISTER_FILE(__FILE__, \$Revision\$)
Update parameters.
Line 206: * \note The dollar signs above have been protected with backslashes
to keep
: * SVN from modifying them in this file; under normal circumstances
they would
: * not be present and SVN would expand the Revision keyword into the
file's
: * revision number.
No longer applies.
Line 213: #define ASTERISK_REGISTER_FILE(file) \
Couldn't we drop the 'file' parameter too, just use __FILE__ inside the macro?
https://gerrit.asterisk.org/#/c/54/3/main/manager.c
File main/manager.c:
Line 5998: snprintf(cut, (sizeof(filename) - strlen(filename)) - 1, .c);
: ast_debug(1, ModuleCheck .c file %s\n, filename);
Since we're no longer checking the source file registration I think this should
be removed. Also it's the wrong filename for C++ modules (like chan_vpb.cc).
https://gerrit.asterisk.org/#/c/54/3/utils/check_expr.c
File utils/check_expr.c:
Line 155: //void ast_register_file(const char *file, const char *version);
: //void ast_unregister_file(const char *file);
Delete..
Line 164: void ast_register_file(const char *file, const char *version);
Tailing whitespace
Line 167: int ast_add_profile(const char *x, uint64_t scale) { return 0;}
Tailing whitespace
--
To view, visit https://gerrit.asterisk.org/54
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan mjor...@digium.com
Gerrit-Reviewer: Corey Farrell g...@cfware.com
Gerrit-Reviewer: Matt Jordan mjor...@digium.com
Gerrit-HasComments: Yes
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#5). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/54 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: (3 comments) https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h File include/asterisk.h: Line 164: void ast_register_file(const char *file); Given that this is meant for use through a macro only, shouldn't it be __as Works for me. https://gerrit.asterisk.org/#/c/54/3/main/manager.c File main/manager.c: Line 5998: snprintf(cut, (sizeof(filename) - strlen(filename)) - 1, .c); : ast_debug(1, ModuleCheck .c file %s\n, filename); Since we're no longer checking the source file registration I think this sh Good point - removed. https://gerrit.asterisk.org/#/c/54/3/utils/check_expr.c File utils/check_expr.c: Line 155: //void ast_register_file(const char *file, const char *version); : //void ast_unregister_file(const char *file); Delete.. I look forward to the day when we can delete all of the utils/ directory :-P -- To view, visit https://gerrit.asterisk.org/54 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 Gerrit-PatchSet: 3 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: Yes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Corey Farrell has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/58 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Corey Farrell g...@cfware.com Gerrit-HasComments: No -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities other than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M channels/chan_oss.c M channels/chan_phone.c M channels/chan_pjsip.c M channels/chan_rtp.c M
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Note for reviewers: This patch will break ABI, and can't be backported as-is. Once approved, cherry-picked versions will be put up for the rest of the branches in Asterisk that still receive releases. In those cases, ABI will be maintained and we'll simply not bother printing out the bogus Version string. -- To view, visit https://gerrit.asterisk.org/54 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 Gerrit-PatchSet: 3 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan mjor...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com Gerrit-HasComments: No -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro
Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and remove passing the version in with the macro. Other facilities other than 'core show file version' make use of the file names, such as setting a debug level only on a specific file. As such, the act of registering source files with the Asterisk core still has use. The macro rename now reflects the new macro purpose. * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the core show file version CLI command. Without the file version, it is no longer useful. - Remove the ast_file_version_find function. The file version is no longer tracked. - Rename ast_register_file_version/ast_unregister_file_version to ast_register_file/ast_unregister_file, respectively. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the core show file version CLI command Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 --- M UPGRADE.txt M addons/cdr_mysql.c M addons/chan_mobile.c M addons/format_mp3.c M addons/ooh323c/src/ooSocket.c M addons/res_config_mysql.c M apps/app_adsiprog.c M apps/app_agent_pool.c M apps/app_alarmreceiver.c M apps/app_amd.c M apps/app_authenticate.c M apps/app_bridgewait.c M apps/app_cdr.c M apps/app_celgenuserevent.c M apps/app_chanisavail.c M apps/app_channelredirect.c M apps/app_chanspy.c M apps/app_confbridge.c M apps/app_controlplayback.c M apps/app_dahdiras.c M apps/app_db.c M apps/app_dial.c M apps/app_dictate.c M apps/app_directed_pickup.c M apps/app_directory.c M apps/app_disa.c M apps/app_dumpchan.c M apps/app_echo.c M apps/app_exec.c M apps/app_externalivr.c M apps/app_fax.c M apps/app_festival.c M apps/app_flash.c M apps/app_followme.c M apps/app_forkcdr.c M apps/app_getcpeid.c M apps/app_ices.c M apps/app_image.c M apps/app_ivrdemo.c M apps/app_jack.c M apps/app_macro.c M apps/app_meetme.c M apps/app_milliwatt.c M apps/app_minivm.c M apps/app_mixmonitor.c M apps/app_morsecode.c M apps/app_mp3.c M apps/app_nbscat.c M apps/app_originate.c M apps/app_osplookup.c M apps/app_page.c M apps/app_playback.c M apps/app_playtones.c M apps/app_privacy.c M apps/app_queue.c M apps/app_read.c M apps/app_readexten.c M apps/app_record.c M apps/app_saycounted.c M apps/app_sayunixtime.c M apps/app_senddtmf.c M apps/app_sendtext.c M apps/app_setcallerid.c M apps/app_skel.c M apps/app_sms.c M apps/app_softhangup.c M apps/app_speech_utils.c M apps/app_stack.c M apps/app_stasis.c M apps/app_system.c M apps/app_talkdetect.c M apps/app_test.c M apps/app_transfer.c M apps/app_url.c M apps/app_userevent.c M apps/app_verbose.c M apps/app_voicemail.c M apps/app_waitforring.c M apps/app_waitforsilence.c M apps/app_waituntil.c M apps/app_while.c M apps/app_zapateller.c M apps/confbridge/conf_chan_announce.c M apps/confbridge/conf_chan_record.c M apps/confbridge/conf_config_parser.c M apps/confbridge/confbridge_manager.c M bridges/bridge_builtin_features.c M bridges/bridge_builtin_interval_features.c M bridges/bridge_holding.c M bridges/bridge_native_rtp.c M bridges/bridge_simple.c M bridges/bridge_softmix.c M cdr/cdr_adaptive_odbc.c M cdr/cdr_csv.c M cdr/cdr_custom.c M cdr/cdr_manager.c M cdr/cdr_odbc.c M cdr/cdr_pgsql.c M cdr/cdr_radius.c M cdr/cdr_sqlite.c M cdr/cdr_sqlite3_custom.c M cdr/cdr_syslog.c M cdr/cdr_tds.c M cel/cel_custom.c M cel/cel_manager.c M cel/cel_odbc.c M cel/cel_pgsql.c M cel/cel_radius.c M cel/cel_sqlite3_custom.c M cel/cel_tds.c M channels/chan_alsa.c M channels/chan_bridge_media.c M channels/chan_console.c M channels/chan_dahdi.c M channels/chan_iax2.c M channels/chan_mgcp.c M channels/chan_misdn.c M channels/chan_motif.c M channels/chan_nbs.c M channels/chan_oss.c M channels/chan_phone.c M channels/chan_pjsip.c M channels/chan_rtp.c M
