[PATCH net-next 0/2] net: Constify static qmi structs
Constify a couple of static qmi_ops and qmi_msg_handler structs that are never modified. Rikard Falkeborn (2): soc: qcom: ipa: Constify static qmi structs ath10k: Constify static qmi structs drivers/net/ipa/ipa_qmi.c | 8 drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.29.2 ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
These are only used as input arguments to qmi_handle_init() which
accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
const to allow the compiler to put them in read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/ipa/ipa_qmi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
index 5090f0f923ad..d2c3f273c233 100644
--- a/drivers/net/ipa/ipa_qmi.c
+++ b/drivers/net/ipa/ipa_qmi.c
@@ -168,7 +168,7 @@ static void ipa_server_bye(struct qmi_handle *qmi, unsigned
int node)
ipa_qmi->indication_sent = false;
}
-static struct qmi_ops ipa_server_ops = {
+static const struct qmi_ops ipa_server_ops = {
.bye= ipa_server_bye,
};
@@ -234,7 +234,7 @@ static void ipa_server_driver_init_complete(struct
qmi_handle *qmi,
}
/* The server handles two request message types sent by the modem. */
-static struct qmi_msg_handler ipa_server_msg_handlers[] = {
+static const struct qmi_msg_handler ipa_server_msg_handlers[] = {
{
.type = QMI_REQUEST,
.msg_id = IPA_QMI_INDICATION_REGISTER,
@@ -261,7 +261,7 @@ static void ipa_client_init_driver(struct qmi_handle *qmi,
}
/* The client handles one response message type sent by the modem. */
-static struct qmi_msg_handler ipa_client_msg_handlers[] = {
+static const struct qmi_msg_handler ipa_client_msg_handlers[] = {
{
.type = QMI_RESPONSE,
.msg_id = IPA_QMI_INIT_DRIVER,
@@ -463,7 +463,7 @@ ipa_client_new_server(struct qmi_handle *qmi, struct
qmi_service *svc)
return 0;
}
-static struct qmi_ops ipa_client_ops = {
+static const struct qmi_ops ipa_client_ops = {
.new_server = ipa_client_new_server,
};
--
2.29.2
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH net-next 2/2] ath10k: Constify static qmi structs
qmi_msg_handler[] and ath10k_qmi_ops are only used as input arguments
to qmi_handle_init() which accepts const pointers to both qmi_ops and
qmi_msg_handler. Make them const to allow the compiler to put them in
read-only memory.
Signed-off-by: Rikard Falkeborn
---
drivers/net/wireless/ath/ath10k/qmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c
b/drivers/net/wireless/ath/ath10k/qmi.c
index ae6b1f402adf..07e478f9a808 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -917,7 +917,7 @@ static void ath10k_qmi_msa_ready_ind(struct qmi_handle
*qmi_hdl,
ath10k_qmi_driver_event_post(qmi, ATH10K_QMI_EVENT_MSA_READY_IND, NULL);
}
-static struct qmi_msg_handler qmi_msg_handler[] = {
+static const struct qmi_msg_handler qmi_msg_handler[] = {
{
.type = QMI_INDICATION,
.msg_id = QMI_WLFW_FW_READY_IND_V01,
@@ -981,7 +981,7 @@ static void ath10k_qmi_del_server(struct qmi_handle
*qmi_hdl,
NULL);
}
-static struct qmi_ops ath10k_qmi_ops = {
+static const struct qmi_ops ath10k_qmi_ops = {
.new_server = ath10k_qmi_new_server,
.del_server = ath10k_qmi_del_server,
};
--
2.29.2
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH 1/2] ath10k: Fix an error handling path
If 'ath10k_usb_create()' fails, we should release some resources and report
an error instead of silently continuing.
Fixes: 4db66499df91 ("ath10k: add initial USB support")
Signed-off-by: Christophe JAILLET
---
drivers/net/wireless/ath/ath10k/usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/usb.c
b/drivers/net/wireless/ath/ath10k/usb.c
index 05a620ff6fe2..0b47c3a09794 100644
--- a/drivers/net/wireless/ath/ath10k/usb.c
+++ b/drivers/net/wireless/ath/ath10k/usb.c
@@ -997,6 +997,8 @@ static int ath10k_usb_probe(struct usb_interface *interface,
ar_usb = ath10k_usb_priv(ar);
ret = ath10k_usb_create(ar, interface);
+ if (ret)
+ goto err;
ar_usb->ar = ar;
ar->dev_id = product_id;
--
2.27.0
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ath10k-firmware: QCA9888 hw2.0: Add Plasma Cloud PA2200 specific BDFs
Hi, The support for this device is currently prepared for OpenWrt. This AP requires three special BDFs to get the Wi-Fi PHYs working (correctly). Now to the questions from the wiki page [1]: * description for what hardware this is: - it is a IPQ4019 based board - one QCA40xx radio is used as 2.4GHz radio - one QCA9888 radio is used as 5GHz radio (channel 36-64) - one QCA40xx radio is used as 5GHz radio (channel 100-165) * origin of the board file (did you create it yourself or where you downloaded) - was provided by vendor in patch send to me for the OpenWrt support (Sun, 27 Jan 2019 22:23:37 +0800) * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k) - BoardNames[0]: 'bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=PlasmaCloud-PA2200' BoardLength[0]: 12064 BoardCRC32[0]: b5855151 BoardMD5[0]: 271e88642c141a58e115819de756994d * attach the actual board file (board.bin) - The name of the files are equal to the id string in the board-2.bin (minus the ".bin") Kind regards, Sven [1] https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=PlasmaCloud-PA2200.bin Description: Binary data signature.asc Description: This is a digitally signed message part. ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
ath10k-firmware: QCA4019 hw1.0: Add Plasma Cloud PA1200 specific BDFs
Hi, The support for this device is currently prepared for OpenWrt. This AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). Now to the questions from the wiki page [1]: * description for what hardware this is: - it is a IPQ4019 based board - one QCA40xx radio is used as 2.4GHz radio - one QCA40xx radio is used as 5GHz radio * origin of the board file (did you create it yourself or where you downloaded) - was provided by vendor in patch send to me for the OpenWrt support (Sun, 27 Jan 2019 22:23:37 +0800) * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k) - BoardNames[0]: 'bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=PlasmaCloud-PA1200' BoardLength[0]: 12064 BoardCRC32[0]: 4993061f BoardMD5[0]: f8727ab647005b96d83a0ab62fddb3e1 - BoardNames[1]: 'bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=PlasmaCloud-PA1200' BoardLength[1]: 12064 BoardCRC32[1]: d88f99d8 BoardMD5[1]: be3e4787cc41754c54a8aa5e76576855 * attach the actual board file (board.bin) - The name of the files are equal to the id string in the board-2.bin (minus the ".bin") Kind regards, Sven [1] https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=PlasmaCloud-PA1200.bin Description: Binary data bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=PlasmaCloud-PA1200.bin Description: Binary data signature.asc Description: This is a digitally signed message part. ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
ath10k-firmware: QCA4019 hw1.0: Add Plasma Cloud PA2200 specific BDFs
Hi, The support for this device is currently prepared for OpenWrt. This AP requires three special BDFs to get the Wi-Fi PHYs working (correctly). Now to the questions from the wiki page [1]: * description for what hardware this is: - it is a IPQ4019 based board - one QCA40xx radio is used as 2.4GHz radio - one QCA9888 radio is used as 5GHz radio (channel 36-64) - one QCA40xx radio is used as 5GHz radio (channel 100-165) * origin of the board file (did you create it yourself or where you downloaded) - was provided by vendor in patch send to me for the OpenWrt support (Sun, 27 Jan 2019 22:23:37 +0800) * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k) - BoardNames[0]: 'bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=PlasmaCloud-PA2200' BoardLength[0]: 12064 BoardCRC32[0]: eee32a50 BoardMD5[0]: e7610d866e32b9a40e5b75d885cc22a0 - BoardNames[1]: 'bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=PlasmaCloud-PA2200' BoardLength[1]: 12064 BoardCRC32[1]: a3a9dc35 BoardMD5[1]: 5c3698ba55965df0dd8bbdca7706eb5d * attach the actual board file (board.bin) - The name of the files are equal to the id string in the board-2.bin (minus the ".bin") Kind regards, Sven [1] https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=PlasmaCloud-PA2200.bin Description: Binary data bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=PlasmaCloud-PA2200.bin Description: Binary data signature.asc Description: This is a digitally signed message part. ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
