[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

Follow-up Comment #5, bug #31873 (project avr-libc):

>> 1) PR_AES_bm is missing in the power_all_enable()/disable for xmegaA
series

Yes. This was something I planned to ask in the ML and forgot. Infact the line
was commented earlier. I thought there might be a reason for not including
AES_bm.  Going by the history log, I think changes were not done to the
methods after the initial revision.

>> 2) Xmega D series doesn't have DAC bit in PR_PA and PR_PB registers, so
power_dac_enable()/disable() should be removed from power.h
>> 3)Xmega D series doesn't have USART1 bit in PR_PC, PR_PD, PR_PE and PR_PF
registers, so power_usart1_enable()/disable() should be removed from power.h
>> 4) These changes should also be reflected in power_all
_enable()/disable() for Xmega D series 


Thanks Usha!! 

I made the necessary changes (even to AES_bm). Built and verified. The changes
are present in revison 2213.

http://svn.sv.gnu.org/viewvc/?view=rev&root=avr-libc&revision=2213



___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Usha]

Follow-up Comment #4, bug #31873 (project avr-libc):

I went through the patch (file #22684).Please consider the following changes
w.r.t the patch.

1) PR_AES_bm is missing in the power_all_enable()/disable for xmegaA series
2) Xmega D series doesn't have DAC bit in PR_PA and PR_PB registers, so
power_dac_enable()/disable() should be removed from power.h
3)Xmega D series doesn't have USART1 bit in PR_PC, PR_PD, PR_PE and PR_PF
registers, so power_usart1_enable()/disable() should be removed from power.h
4) These changes should also be reflected in  power_all
_enable()/disable() for Xmega D series 

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

Follow-up Comment #3, bug #31873 (project avr-libc):

svn diff attached for future reference. Build verified.

(file #22684)
___

Additional Item Attachment:

File name: bug31873.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

Follow-up Comment #2, bug #31873 (project avr-libc):

Power management for Xmega devices is not correct. Changes made are:

1. PR_PR does not exist. It is replaced with PR_PRGEN

2. Only A series has AES, EBI and DMA bit defined. Functions to
enable/disable these are separated

3. Part Description File of ATXmega256D3 does not define Power Reduction
registers. This could be a bug with XML file. Since header files should match
XML files, support for power reduction has been removed for ATXmega256D3. When
the XML gets fixed, the corresponding support will be added in power.h

4. power_all_enable()/disable() function changes for A and D series.

5. Documentation changes for power_all_enable/disable functions. Xmegas were
not included before.

Please review.


(file #22655)
___

Additional Item Attachment:

File name: bug31873.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

Update of bug #31873 (project avr-libc):

  Status:None => In Progress
 Assigned to:None => aboyapati  


___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

Follow-up Comment #1, bug #31873 (project avr-libc):

Also, I think there is no member like PR_PR. It should be PRGEN going by
PR_struct

All related references (for xmega devices) to PR_PR should be changed to
PR_PRGEN

___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev

[avr-libc-dev] [bug #31873] power_aes_enable/disable() are commented in power.h for xmega devices

[Anitha Boyapati]

URL:
  

 Summary: power_aes_enable/disable() are commented in power.h
for xmega devices
 Project: AVR C Runtime Library
Submitted by: aboyapati
Submitted on: Tue 14 Dec 2010 06:53:21 AM GMT
Category: Header
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Header files
  Status: None
Percent Complete: 0%
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.7.0
   Fixed Release: None

___

Details:


For all Xmega devices, support for power_aes_enable() and power_aes_disable()
were commented in power.h.

#if defined(__AVR_ATxmega16A4__) \
|| defined(__AVR_ATxmega16D4__) \
...
|| defined(__AVR_ATxmega256A3__) \
|| defined(__AVR_ATxmega256A3B__)

/*
#define power_aes_enable()  (PR_PR &= (uint8_t)~(PR_AES_bm))
#define power_aes_disable() (PR_PR |= (uint8_t)PR_AES_bm)
*/


Xmega A reference manual (Section 8.6) clearly defines Power Reduction
Registers and AES bit.

http://www.atmel.com/dyn/resources/prod_documents/doc8077.pdf





___

Reply to this item at:

  

___
  Message sent via/by Savannah
  http://savannah.nongnu.org/


___
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/avr-libc-dev