[avrdude-dev] To all committers: some stylistic things
Thanks to everybody for improving the AVRDUDE code base. I see there were a number of commits within the past months. I'm not very religious about stylistic issues. After all, I basically inherited the maintenance of that project from Brian Dean, and a lot of the code present in AVRDUDE today has been contributed by a large number of people in the past, so the overall style is not very uniform. Just a few things I'm asking for. . For new files, please take care to have at least the svn:eol-style set to native, and svn:keywords to (at least) Id. Add $Id$ lines to each file so the file's version can be tracked in the field. Preferrably, do also set svn:mime-type (usually to text/plain). The easiest way to do this is to activate the line enable-auto-props = yes in your ~/.subversion/config file (or wherever this file lives in your environment), and add suitable auto-props patterns. For reference, I'm appending the patterns I've been collecting in my SVN era so far below. . If possible, avoid non-ASCII characters (there have been a few UTF-8 long dashes in some file, where simple ASCII dashes would do fine). . When using hard TABs, the remainder of the AVRDUDE code uses them with a tab stop each 8 columns, as is the historical DEC VTxx (and Unix) standard. If you don't like this, then better don't use TABs but simple spaces everywhere. . Try avoiding trailing white space behind the printable characters of each line (even though the historic AVRDUDE code suffers a lot from that still, and I hesitate to force commits for code that has otherwise not been touched sometimes for years). Thanks again for all your contributions! [auto-props] Makefile* = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.1 = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.a = svn:mime-type=application/octet-stream *.am = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.aps = svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords=Author Id Date *.asm = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.bat = svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords=Author Id Date *.bpl = svn:mime-type=application/octet-stream *.c = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.cdr = svn:mime-type=application/octet-stream *.cfg = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.cmake = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.cpp = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.css = svn:mime-type=text/xml;svn:eol-style=native;svn:keywords=Author Id Date *.csv = svn:mime-type=text/csv;svn:eol-style=native *.cvsignore = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.ddp = svn:mime-type=application/octet-stream *.de = svn:mime-type=application/octet-stream *.dep = svn:mime-type=application/xml *.dfm = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.diff = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.dll = svn:mime-type=application/octet-stream *.doc = svn:mime-type=application/msword *.dot = svn:mime-type=application/msword *.dox = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.gif = svn:mime-type=image/gif *.eps = svn:mime-type=application/postscript;svn:eol-style=native;svn:keywords=Author Id Date *.ewd = svn:mime-type=application/xml *.ewp = svn:mime-type=application/xml *.eww = svn:mime-type=application/xml *.exe = svn:mime-type=application/octet-stream *.gz = svn:mime-type=application/octet-stream *.h = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.hex = svn:mime-type=text/plain;svn:eol-style=CRLF *.html = svn:mime-type=text/html;svn:eol-style=native;svn:keywords=Author Id Date *.i = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.in = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.inc = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.info = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.jpg = svn:mime-type=image/jpeg *.js = svn:mime-type=text/javascript;svn:eol-style=native;svn:keywords=Author Id Date *.kdevelop = svn:mime-type=text/xml;svn:eol-style=native;svn:keywords=Author Id Date *.l = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.local = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.mk = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.mpp = svn:mime-type=application/vnd.ms-project *.odg = svn:mime-type=application/octet-stream *.odp = svn:mime-type=application/octet-stream *.patch = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Author Id Date *.pdf =
RE: [avrdude-dev] To all committers: some stylistic things
Hi Joerg, Is there anyway that your email could make it into the documentation somewhere? I'm afraid I'll lose track of the email if, and when, I finally get around to doing any commits in the future. Thanks, Eric -Original Message- From: avrdude-dev-bounces+eric.weddington=atmel@nongnu.org [mailto:avrdude-dev-bounces+eric.weddington=atmel@nongnu.o rg] On Behalf Of Joerg Wunsch Sent: Thursday, January 07, 2010 6:44 AM To: avrdude-dev@nongnu.org Subject: [avrdude-dev] To all committers: some stylistic things Thanks to everybody for improving the AVRDUDE code base. I see there were a number of commits within the past months. I'm not very religious about stylistic issues. After all, I basically inherited the maintenance of that project from Brian Dean, and a lot of the code present in AVRDUDE today has been contributed by a large number of people in the past, so the overall style is not very uniform. Just a few things I'm asking for. . For new files, please take care to have at least the svn:eol-style set to native, and svn:keywords to (at least) Id. Add $Id$ lines to each file so the file's version can be tracked in the field. Preferrably, do also set svn:mime-type (usually to text/plain). The easiest way to do this is to activate the line enable-auto-props = yes in your ~/.subversion/config file (or wherever this file lives in your environment), and add suitable auto-props patterns. For reference, I'm appending the patterns I've been collecting in my SVN era so far below. . If possible, avoid non-ASCII characters (there have been a few UTF-8 long dashes in some file, where simple ASCII dashes would do fine). . When using hard TABs, the remainder of the AVRDUDE code uses them with a tab stop each 8 columns, as is the historical DEC VTxx (and Unix) standard. If you don't like this, then better don't use TABs but simple spaces everywhere. . Try avoiding trailing white space behind the printable characters of each line (even though the historic AVRDUDE code suffers a lot from that still, and I hesitate to force commits for code that has otherwise not been touched sometimes for years). Thanks again for all your contributions! [auto-props] Makefile* = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.1 = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.a = svn:mime-type=application/octet-stream *.am = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.aps = svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords=Auth or Id Date *.asm = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.bat = svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords=Auth or Id Date *.bpl = svn:mime-type=application/octet-stream *.c = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.cdr = svn:mime-type=application/octet-stream *.cfg = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.cmake = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.cpp = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.css = svn:mime-type=text/xml;svn:eol-style=native;svn:keywords=Auth or Id Date *.csv = svn:mime-type=text/csv;svn:eol-style=native *.cvsignore = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.ddp = svn:mime-type=application/octet-stream *.de = svn:mime-type=application/octet-stream *.dep = svn:mime-type=application/xml *.dfm = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.diff = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.dll = svn:mime-type=application/octet-stream *.doc = svn:mime-type=application/msword *.dot = svn:mime-type=application/msword *.dox = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.gif = svn:mime-type=image/gif *.eps = svn:mime-type=application/postscript;svn:eol-style=native;svn: keywords=Author Id Date *.ewd = svn:mime-type=application/xml *.ewp = svn:mime-type=application/xml *.eww = svn:mime-type=application/xml *.exe = svn:mime-type=application/octet-stream *.gz = svn:mime-type=application/octet-stream *.h = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.hex = svn:mime-type=text/plain;svn:eol-style=CRLF *.html = svn:mime-type=text/html;svn:eol-style=native;svn:keywords=Aut hor Id Date *.i = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.in = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.inc = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.info = svn:mime-type=text/plain;svn:eol-style=native;svn:keywords=Au thor Id Date *.jpg =
[avrdude-dev] [bug #28458] Buffer line is incorrectly released for PP programmers
Update of bug #28458 (project avrdude): Status:None = Fixed Assigned to:None = joerg_wunsch Open/Closed:Open = Closed ___ Follow-up Comment #1: You are absolutely correct, thanks! ___ Reply to this item at: http://savannah.nongnu.org/bugs/?28458 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] [bug #27551] Compile error ylwrap I think
Update of bug #27551 (project avrdude): Status: Need Info = Duplicate Open/Closed:Open = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?27551 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] [bug #27501] [Feature Request]: Support AVR32
Update of bug #27501 (project avrdude): Status:None = Need Info ___ Follow-up Comment #1: David, can you please update this tracker item? ___ Reply to this item at: http://savannah.nongnu.org/bugs/?27501 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] [bug #26976] AVRDUDE fails with strange message if parallel port not available
Update of bug #26976 (project avrdude): Open/Closed:Open = Closed ___ Reply to this item at: http://savannah.nongnu.org/bugs/?26976 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] [bug #28344] chip_erase_delay too short for ATmega324P, 644, 644P, and 1284P
Update of bug #28344 (project avrdude): Status:None = Need Info Assigned to:None = joerg_wunsch ___ Follow-up Comment #2: I verified the most recent datasheet, and it still says the chip erase delay being 9.0 ms for all the mentioned devices. I'd kindly ask you to open a ticket at avr -at- atmel.com to clarify what the correct chip erase value is. ___ Reply to this item at: http://savannah.nongnu.org/bugs/?28344 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] [bug #28516] Linux/Dragon: Error message on exit
URL: http://savannah.nongnu.org/bugs/?28516 Summary: Linux/Dragon: Error message on exit Project: AVR Downloader/UploaDEr Submitted by: markus_b Submitted on: Thu 07 Jan 2010 07:57:43 PM CET Category: None Severity: 3 - Normal Priority: 5 - Normal Item Group: None Status: None Privacy: Public Assigned to: None Originator Name: Markus Baertschi Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Applies to the current svn version (889). Avrdude displays an error message when exiting: bad response to GO command: RSP_ILLEGAL_EMULATOR_MODE After looking at the source it looks to me like avrdude thinks it is in JTAG mode and issues a GO command when shutting down to avoid blocking the MCU. Here an example run: $ avrdude -p ATTINY861 -c dragon_isp -P usb avrdude: AVR device initialized and ready to accept instructions Reading | ## | 100% 0.15s avrdude: Device signature = 0x1e930d avrdude: safemode: Fuses OK avrdude: jtagmkII_close(): bad response to GO command: RSP_ILLEGAL_EMULATOR_MODE avrdude done. Thank you. Here the same run with high verbosity (-vvv): $ avrdude -p ATTINY861 -c dragon_isp -P usb -vvv ... avrdude: jtagmkII_close() avrdude: jtagmkII_close(): Sending GO command: avrdude: jtagmkII_send(): sending 1 bytes avrdude: jtagmkII_recv(): avrdude: jtagmkII_recv(): CRC OK avrdude: jtagmkII_recv(): Got message seqno 0 (command_sequence == 0) Illegal emulator mode avrdude: jtagmkII_close(): bad response to GO command: RSP_ILLEGAL_EMULATOR_MODE avrdude: jtagmkII_close(): Sending sign-off command: avrdude: jtagmkII_send(): sending 1 bytes avrdude: jtagmkII_recv(): avrdude: jtagmkII_recv(): CRC OK avrdude: jtagmkII_recv(): Got message seqno 1 (command_sequence == 1) ___ Reply to this item at: http://savannah.nongnu.org/bugs/?28516 ___ Message sent via/by Savannah http://savannah.nongnu.org/ ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
Re: [avrdude-dev] To all committers: some stylistic things
As Weddington, Eric wrote: Is there anyway that your email could make it into the documentation somewhere? I'm afraid I'll lose track of the email if, and when, I finally get around to doing any commits in the future. The problem I'm seeing is that we currently don't have any kind of developer documentation for AVRDUDE. I could probably start something like a developer's corner in the WWW repository. I think all developers do have CVS access to the WWW repository, so they could even change things there. -- cheers, Jorg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
[avrdude-dev] Addition of mega325p support in avrdude
the AVR mega325p is the same as the mega325, and only requires an entry in avrdude.conf with the signature corrected so that the last byte is 0d. -Martin ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
RE: [avrdude-dev] To all committers: some stylistic things
-Original Message- From: avrdude-dev-bounces+eric.weddington=atmel@nongnu.org [mailto:avrdude-dev-bounces+eric.weddington=atmel@nongnu.o rg] On Behalf Of Joerg Wunsch Sent: Thursday, January 07, 2010 1:32 PM To: avrdude-dev@nongnu.org Subject: Re: [avrdude-dev] To all committers: some stylistic things As Weddington, Eric wrote: Is there anyway that your email could make it into the documentation somewhere? I'm afraid I'll lose track of the email if, and when, I finally get around to doing any commits in the future. The problem I'm seeing is that we currently don't have any kind of developer documentation for AVRDUDE. Well, why not have a separate developers' chapter in the user manual? ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
RE: [avrdude-dev] Addition of mega325p support in avrdude
-Original Message- From: avrdude-dev-bounces+eric.weddington=atmel@nongnu.org [mailto:avrdude-dev-bounces+eric.weddington=atmel@nongnu.o rg] On Behalf Of Martin Bogomolni Sent: Thursday, January 07, 2010 2:56 PM To: avrdude-dev@nongnu.org Subject: [avrdude-dev] Addition of mega325p support in avrdude the AVR mega325p is the same as the mega325, and only requires an entry in avrdude.conf with the signature corrected so that the last byte is 0d. A patch is also appreciated. ;-) ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
RE: [avrdude-dev] Addition of mega325p support in avrdude
-Original Message- From: Martin Bogomolni [mailto:martinb...@gmail.com] Sent: Thursday, January 07, 2010 7:47 PM To: Weddington, Eric Cc: avrdude-dev@nongnu.org Subject: Re: [avrdude-dev] Addition of mega325p support in avrdude Okay, will do. Patch should be against 5.8? Patch should be against whatever is in the current repository. ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
Re: [avrdude-dev] Addition of mega325p support in avrdude
As Martin Bogomolni wrote: Okay, will do. Patch should be against 5.8? Against the SVN version would be best, but 5.8 is OK as well. patch(1) can handle it. ;-) -- cheers, Jorg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
Re: [avrdude-dev] To all committers: some stylistic things
As Weddington, Eric wrote: The problem I'm seeing is that we currently don't have any kind of developer documentation for AVRDUDE. Well, why not have a separate developers' chapter in the user manual? Because someone would ultimately have to write something for it. If the manual has a chapter for developers, I'd expect it to explain a little more than just consisting of a single random note about stylistic things. -- cheers, Jorg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
RE: [avrdude-dev] To all committers: some stylistic things
-Original Message- From: avrdude-dev-bounces+eric.weddington=atmel@nongnu.org [mailto:avrdude-dev-bounces+eric.weddington=atmel@nongnu.o rg] On Behalf Of Joerg Wunsch Sent: Thursday, January 07, 2010 10:10 PM To: avrdude-dev@nongnu.org Subject: Re: [avrdude-dev] To all committers: some stylistic things As Weddington, Eric wrote: The problem I'm seeing is that we currently don't have any kind of developer documentation for AVRDUDE. Well, why not have a separate developers' chapter in the user manual? Because someone would ultimately have to write something for it. If the manual has a chapter for developers, I'd expect it to explain a little more than just consisting of a single random note about stylistic things. Well, it would be a start wouldn't it? And it's the easiest path, isn't it? And you know that I've already forgotten all the stylistic rules you just laid out. So can't we put the docs *somewhere*? ;-) ___ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev
