Re: [blfs-dev] icu68 breakage
On Fri, Oct 30, 2020 at 07:10:40PM -0500, Marty Jack via blfs-dev wrote: > > > The fix is simple: replace TRUE by true and FALSE by false wherever it is > needed. > The requirement is pervasive. I have 3 packages that needed changes. The > qtwebengine touches a lot of files. > The one I had to give up on is libreoffice because there were changes needed > in the external tarballs. Agreed, for my own build (a bit different from what is in the book) it broke on libe-book. > I went with --without-system-icu for that and expect it to be needed for a > long time until everyone catches up. > I really wish upstreams would consider the amount of work they cause for > everyone. > There is one in particular that has made numerous incremental API changes and > does not seem to understand the reason why an soname needs to be bumped. > I can provide the patch files on request, but be warned they aren't done in a > way that preserves building with older versions of ICU. Was libxml2 one of your three packages ? If not, what was the third one ? A patch (headed, including attribution) for qtwebengine would be handy (I'm some way away from getting to that). ĸen -- Brave Sir Nigel ran away! When reality reared its ugly head, Sir Nigel turned his tail and fled. Brave brave brave Sir Nigel. -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On Sat, Oct 31, 2020 at 12:47:54AM +, Ken Moffat via blfs-dev wrote:
> On Fri, Oct 30, 2020 at 06:56:19PM -0500, Douglas R. Reno via blfs-dev wrote:
> >
> > On 10/30/20 6:15 PM, Ken Moffat via blfs-dev wrote:
> > >
> > > This comes from encoding.c
> > >
> > > #ifdef LIBXML_ICU_ENABLED
> > > else if (handler->uconv_out != NULL) {
> > > ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in,
> > > inlen,
> > >TRUE);
> > > }
> > > #endif /* LIBXML_ICU_ENABLED */
> > >
> > > For the moment I can't see anything online (it looks like we are on
> > > the bleeding edge using icu68) so I'll just work around it by
> > > omitting --with-icu for the moment so I can get on with looking at
> > > the consequences of python2 using altinstall (more on that when I've
> > > got more things built).
> > >
> > > ĸen
> >
> > Hi Ken,
> >
> > I don't have the ability to test this at the moment (running Samba tests),
> > but try substituting TRUE with true. In ICU-68.1, the FALSE and TRUE macros
> > that were exported by ICU were removed. Check out this link for more
> > details:
> >
> > http://site.icu-project.org/download/68
> >
> Thanks, I'll try it later.
>
In this case, only that one line is affected. Fixed in r23856.
Cheers.
ĸen
--
The people next door oppress me all night long. I tell them: I work
all day, a man's got to have some time to learn to play the tuba.
That's oppression, that is.[ Guards! Guards! ]
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On Fri, Oct 30, 2020 at 07:10:40PM -0500, Marty Jack via blfs-dev wrote: > > > The fix is simple: replace TRUE by true and FALSE by false wherever it is > needed. > The requirement is pervasive. I have 3 packages that needed changes. The > qtwebengine touches a lot of files. > The one I had to give up on is libreoffice because there were changes needed > in the external tarballs. > I went with --without-system-icu for that and expect it to be needed for a > long time until everyone catches up. > I really wish upstreams would consider the amount of work they cause for > everyone. > There is one in particular that has made numerous incremental API changes and > does not seem to understand the reason why an soname needs to be bumped. > I can provide the patch files on request, but be warned they aren't done in a > way that preserves building with older versions of ICU. Thanks. I'm double-plus not looking forward to this if it hits anything written in rust. Grumpy about libreoffice (if I get that far), but as this is an experimental build I might put up with that in the short term. Totally agree with your comments. ĸen -- The people next door oppress me all night long. I tell them: I work all day, a man's got to have some time to learn to play the tuba. That's oppression, that is.[ Guards! Guards! ] -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On Fri, Oct 30, 2020 at 06:56:19PM -0500, Douglas R. Reno via blfs-dev wrote:
>
> On 10/30/20 6:15 PM, Ken Moffat via blfs-dev wrote:
> > I see we've already had one set of fixes for changes in icu68, I
> > hope it is not going to trash a lot of things.
> >
> > I've been building libxml2 --with-icu for some time, that breaks:
> >
> > /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
> > -I./include -I./include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith
> > -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
> > -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls
> > -Wno-long-long -Wno-format-extra-args -D_REENTRANT -O3 -march=native
> > -fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
> > encoding.lo -MD -MP -MF .deps/encoding.Tpo -c -o encoding.lo encoding.c
> > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./include
> > -pedantic -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align
> > -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
> > -Wnested-externs -Winline -Wredundant-decls -Wno-long-long
> > -Wno-format-extra-args -D_REENTRANT -O3 -march=native
> > -fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
> > encoding.lo -MD -MP -MF .deps/encoding.Tpo -c encoding.c -fPIC -DPIC -o
> > .libs/encoding.o
> > encoding.c: In function 'xmlEncOutputChunk':
> > encoding.c:1961:31: error: 'TRUE' undeclared (first use in this function)
> > 1961 | TRUE);
> >| ^~~~
> > encoding.c:1961:31: note: each undeclared identifier is reported only once
> > for each function it appears in
> > make[2]: *** [Makefile:1287: encoding.lo] Error 1
> >
> > This comes from encoding.c
> >
> > #ifdef LIBXML_ICU_ENABLED
> > else if (handler->uconv_out != NULL) {
> > ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in,
> > inlen,
> >TRUE);
> > }
> > #endif /* LIBXML_ICU_ENABLED */
> >
> > For the moment I can't see anything online (it looks like we are on
> > the bleeding edge using icu68) so I'll just work around it by
> > omitting --with-icu for the moment so I can get on with looking at
> > the consequences of python2 using altinstall (more on that when I've
> > got more things built).
> >
> > ĸen
>
> Hi Ken,
>
> I don't have the ability to test this at the moment (running Samba tests),
> but try substituting TRUE with true. In ICU-68.1, the FALSE and TRUE macros
> that were exported by ICU were removed. Check out this link for more
> details:
>
> http://site.icu-project.org/download/68
>
Thanks, I'll try it later.
ĸen
--
The people next door oppress me all night long. I tell them: I work
all day, a man's got to have some time to learn to play the tuba.
That's oppression, that is.[ Guards! Guards! ]
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On Fri, 30 Oct 2020 18:15:49 -0500 Ken Moffat via blfs-dev wrote:
> I see we've already had one set of fixes for changes in icu68, I
> hope it is not going to trash a lot of things.
>
> I've been building libxml2 --with-icu for some time, that breaks:
>
> /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
> -I./include -I./include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith
> -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
> -Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls
> -Wno-long-long -Wno-format-extra-args -D_REENTRANT -O3 -march=native
> -fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
> encoding.lo -MD -MP -MF .deps/encoding.Tpo -c -o encoding.lo encoding.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./include -pedantic
> -Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
> -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
> -Winline -Wredundant-decls -Wno-long-long -Wno-format-extra-args -D_REENTRANT
> -O3 -march=native -fstack-clash-protection -D_FORTIFY_SOURCE=2
> -fstack-protector-strong -MT encoding.lo -MD -MP -MF .deps/encoding.Tpo -c
> encoding.c -fPIC -DPIC -o .libs/encoding.o
> encoding.c: In function 'xmlEncOutputChunk':
> encoding.c:1961:31: error: 'TRUE' undeclared (first use in this function)
> 1961 | TRUE);
> | ^~~~
> encoding.c:1961:31: note: each undeclared identifier is reported only once
> for each function it appears in
> make[2]: *** [Makefile:1287: encoding.lo] Error 1
>
> This comes from encoding.c
>
> #ifdef LIBXML_ICU_ENABLED
> else if (handler->uconv_out != NULL) {
> ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in, inlen,
> TRUE);
> }
> #endif /* LIBXML_ICU_ENABLED */
>
> For the moment I can't see anything online (it looks like we are on
> the bleeding edge using icu68) so I'll just work around it by
> omitting --with-icu for the moment so I can get on with looking at
> the consequences of python2 using altinstall (more on that when I've
> got more things built).
>
> ĸen
> --
> The people next door oppress me all night long. I tell them: I work
> all day, a man's got to have some time to learn to play the tuba.
> That's oppression, that is.[ Guards! Guards! ]
> --
> http://lists.linuxfromscratch.org/listinfo/blfs-dev
> FAQ: http://www.linuxfromscratch.org/blfs/faq.html
> Unsubscribe: See the above information page
The fix is simple: replace TRUE by true and FALSE by false wherever it is
needed.
The requirement is pervasive. I have 3 packages that needed changes. The
qtwebengine touches a lot of files.
The one I had to give up on is libreoffice because there were changes needed in
the external tarballs.
I went with --without-system-icu for that and expect it to be needed for a long
time until everyone catches up.
I really wish upstreams would consider the amount of work they cause for
everyone.
There is one in particular that has made numerous incremental API changes and
does not seem to understand the reason why an soname needs to be bumped.
I can provide the patch files on request, but be warned they aren't done in a
way that preserves building with older versions of ICU.
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On 10/30/20 6:15 PM, Ken Moffat via blfs-dev wrote:
I see we've already had one set of fixes for changes in icu68, I
hope it is not going to trash a lot of things.
I've been building libxml2 --with-icu for some time, that breaks:
/bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I./include -I./include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith
-Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
-Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls -Wno-long-long
-Wno-format-extra-args -D_REENTRANT -O3 -march=native
-fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
encoding.lo -MD -MP -MF .deps/encoding.Tpo -c -o encoding.lo encoding.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./include -pedantic
-Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
-Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Winline -Wredundant-decls -Wno-long-long -Wno-format-extra-args -D_REENTRANT
-O3 -march=native -fstack-clash-protection -D_FORTIFY_SOURCE=2
-fstack-protector-strong -MT encoding.lo -MD -MP -MF .deps/encoding.Tpo -c
encoding.c -fPIC -DPIC -o .libs/encoding.o
encoding.c: In function 'xmlEncOutputChunk':
encoding.c:1961:31: error: 'TRUE' undeclared (first use in this function)
1961 | TRUE);
| ^~~~
encoding.c:1961:31: note: each undeclared identifier is reported only once for
each function it appears in
make[2]: *** [Makefile:1287: encoding.lo] Error 1
This comes from encoding.c
#ifdef LIBXML_ICU_ENABLED
else if (handler->uconv_out != NULL) {
ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in, inlen,
TRUE);
}
#endif /* LIBXML_ICU_ENABLED */
For the moment I can't see anything online (it looks like we are on
the bleeding edge using icu68) so I'll just work around it by
omitting --with-icu for the moment so I can get on with looking at
the consequences of python2 using altinstall (more on that when I've
got more things built).
ĸen
Hi Ken,
I don't have the ability to test this at the moment (running Samba
tests), but try substituting TRUE with true. In ICU-68.1, the FALSE and
TRUE macros that were exported by ICU were removed. Check out this link
for more details:
http://site.icu-project.org/download/68
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
Re: [blfs-dev] icu68 breakage
On 10/30/20 6:15 PM, Ken Moffat via blfs-dev wrote:
I see we've already had one set of fixes for changes in icu68, I
hope it is not going to trash a lot of things.
I've been building libxml2 --with-icu for some time, that breaks:
/bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I./include -I./include -pedantic -Wall -Wextra -Wshadow -Wpointer-arith
-Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
-Wmissing-prototypes -Wnested-externs -Winline -Wredundant-decls -Wno-long-long
-Wno-format-extra-args -D_REENTRANT -O3 -march=native
-fstack-clash-protection -D_FORTIFY_SOURCE=2 -fstack-protector-strong -MT
encoding.lo -MD -MP -MF .deps/encoding.Tpo -c -o encoding.lo encoding.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./include -pedantic
-Wall -Wextra -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
-Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Winline -Wredundant-decls -Wno-long-long -Wno-format-extra-args -D_REENTRANT
-O3 -march=native -fstack-clash-protection -D_FORTIFY_SOURCE=2
-fstack-protector-strong -MT encoding.lo -MD -MP -MF .deps/encoding.Tpo -c
encoding.c -fPIC -DPIC -o .libs/encoding.o
encoding.c: In function 'xmlEncOutputChunk':
encoding.c:1961:31: error: 'TRUE' undeclared (first use in this function)
1961 | TRUE);
| ^~~~
encoding.c:1961:31: note: each undeclared identifier is reported only once for
each function it appears in
make[2]: *** [Makefile:1287: encoding.lo] Error 1
This comes from encoding.c
#ifdef LIBXML_ICU_ENABLED
else if (handler->uconv_out != NULL) {
ret = xmlUconvWrapper(handler->uconv_out, 0, out, outlen, in, inlen,
TRUE);
}
#endif /* LIBXML_ICU_ENABLED */
For the moment I can't see anything online (it looks like we are on
the bleeding edge using icu68) so I'll just work around it by
omitting --with-icu for the moment so I can get on with looking at
the consequences of python2 using altinstall (more on that when I've
got more things built).
ĸen
Hi Ken,
Try changing 'TRUE' to 'true' in encoding.c (line 1961). I don't have
the ability to test that at the moment, but I think that might work.
Check out this link for more details on what has changed in ICU-68, the
most important thing being the removal of the FALSE and TRUE macros:
http://site.icu-project.org/download/68
- Doug
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
