Re: [Bug-wget] RESEND1: wget-1.20-win32
On 18.05.19 11:33, Darshit Shah wrote:
> Thanks!
>
> I'll try and see if I can reproduce this for a test.
>
> * Jernej Simončič [190513 09:27]:
>> On Sunday, May 12, 2019, 17:45:31, Darshit Shah wrote:
>>
>>> Could you please let us know which sites?
>>
>> It happens everywhere, as long as the filename is long enough to
>> require scrolling. I received a patch from Bykov Alexey
>> that supposedly fixes this a few days ago, but
>> haven't had time to test it yet:
>>
>> diff --git a/src/progress.c b/src/progress.c
>> index 8e5709c7..6a69b4e2 100644
>> --- a/src/progress.c
>> +++ b/src/progress.c
>> @@ -845,8 +845,8 @@ static int count_cols (const char *mbs) { return (int)
>> strlen(mbs); }
>> static int
>> cols_to_bytes (const char *mbs _GL_UNUSED, const int cols, int *ncols)
>> {
>> - *ncols = cols;
>> - return cols;
>> + *ncols = min(strlen(mbs),cols);
>> + return *ncols;
>> }
>> #endif
mbs sounds like 'Multi Byte Sequence' aka UTF-8 (pretty sure UTF-16
isn't used in wget code). If this is true, using strlen() to figure out
the number of columns seems absolutely wrong. wcwidth() would be the
function to use... just my thoughts.
Regards, Tim
signature.asc
Description: OpenPGP digital signature
Re: [Bug-wget] RESEND1: wget-1.20-win32
Thanks!
I'll try and see if I can reproduce this for a test.
* Jernej Simončič [190513 09:27]:
> On Sunday, May 12, 2019, 17:45:31, Darshit Shah wrote:
>
> > Could you please let us know which sites?
>
> It happens everywhere, as long as the filename is long enough to
> require scrolling. I received a patch from Bykov Alexey
> that supposedly fixes this a few days ago, but
> haven't had time to test it yet:
>
> diff --git a/src/progress.c b/src/progress.c
> index 8e5709c7..6a69b4e2 100644
> --- a/src/progress.c
> +++ b/src/progress.c
> @@ -845,8 +845,8 @@ static int count_cols (const char *mbs) { return (int)
> strlen(mbs); }
> static int
> cols_to_bytes (const char *mbs _GL_UNUSED, const int cols, int *ncols)
> {
> - *ncols = cols;
> - return cols;
> + *ncols = min(strlen(mbs),cols);
> + return *ncols;
> }
> #endif
>
>
>
> --
> < Jernej Simončič ><><><><>< https://eternallybored.org/ >
>
> Needs are a function of what other people have.
>-- Jones's Principle
>
>
>
--
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
signature.asc
Description: PGP signature
Re: [Bug-wget] RESEND1: wget-1.20-win32
On Sunday, May 12, 2019, 17:45:31, Darshit Shah wrote:
> Could you please let us know which sites?
It happens everywhere, as long as the filename is long enough to
require scrolling. I received a patch from Bykov Alexey
that supposedly fixes this a few days ago, but
haven't had time to test it yet:
diff --git a/src/progress.c b/src/progress.c
index 8e5709c7..6a69b4e2 100644
--- a/src/progress.c
+++ b/src/progress.c
@@ -845,8 +845,8 @@ static int count_cols (const char *mbs) { return (int)
strlen(mbs); }
static int
cols_to_bytes (const char *mbs _GL_UNUSED, const int cols, int *ncols)
{
- *ncols = cols;
- return cols;
+ *ncols = min(strlen(mbs),cols);
+ return *ncols;
}
#endif
--
< Jernej Simončič ><><><><>< https://eternallybored.org/ >
Needs are a function of what other people have.
-- Jones's Principle
Re: [Bug-wget] RESEND1: wget-1.20-win32
*1.20.3 : * *1.20: *** ** *Please see also what I wrote and the picture in my original mail (below)* Thanks Walter On 12/05/2019 17:45, Darshit Shah wrote: Could you please let us know which sites? * WQ [190512 17:41]: See below ! FYI: The updated 1.20.3 still gives problems with some sites Forwarded Message Subject:wget-1.20-win32 Date: Wed, 17 Apr 2019 01:18:01 +0200 From: WQ To: bug-wget@gnu.org Hi, I'm using wget-1.20-win32 (not wget-1.20.3-win32 because there is a problem). During download, there is a problem with the "scrolling" name, the last character character of the name is repeated some time : Kind regards Walter
Re: [Bug-wget] RESEND1: wget-1.20-win32
Could you please let us know which sites? * WQ [190512 17:41]: > See below ! > FYI: The updated 1.20.3 still gives problems with some sites > > > Forwarded Message > Subject: wget-1.20-win32 > Date: Wed, 17 Apr 2019 01:18:01 +0200 > From: WQ > To: bug-wget@gnu.org > > > > Hi, > > I'm using wget-1.20-win32 (not wget-1.20.3-win32 because there is a > problem). > > During download, there is a problem with the "scrolling" name, the last > character character of the name is repeated some time : > > > > Kind regards > > Walter > -- Thanking You, Darshit Shah PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6 signature.asc Description: PGP signature
