Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

[John Paul Adrian Glaubitz]

On 12/16/19 10:08 PM, Mikael Vidstedt wrote:
> 
> I’m not actually sure, but just to be on the safe side I’d prefer to add the 
> grouping.

Okay, will do.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

[Mikael Vidstedt]

I’m not actually sure, but just to be on the safe side I’d prefer to add the 
grouping.

Cheers,
Mikael

> On Dec 16, 2019, at 11:45 AM, John Paul Adrian Glaubitz 
>  wrote:
> 
> On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote:
>> Hi Mikael!
>> 
>> On 12/16/19 8:38 PM, Mikael Vidstedt wrote:
>>> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. 
>>> The suggested change will incorrectly *not* produce a warning for 
>>> solaris/*/zero.
>>> 
>>> Something like this should do the trick:
>>> 
>>>if test "x$OPENJDK_TARGET_OS" = xsolaris || (test 
>>> "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != 
>>> xzero); then
>> 
>> 
>> Thanks for the review. As far as I remember correctly, Zero is not 
>> supported, is it?
> "Zero is not supported on Solaris", I meant. Sorry.
> 
> -- 
> .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaub...@debian.org 
> `. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de 
> 
>  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

[John Paul Adrian Glaubitz]

On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote:
> Hi Mikael!
> 
> On 12/16/19 8:38 PM, Mikael Vidstedt wrote:
>> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. 
>> The suggested change will incorrectly *not* produce a warning for 
>> solaris/*/zero.
>>
>> Something like this should do the trick:
>>
>> if test "x$OPENJDK_TARGET_OS" = xsolaris || (test 
>> "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != 
>> xzero); then
> 
> 
> Thanks for the review. As far as I remember correctly, Zero is not supported, 
> is it?
"Zero is not supported on Solaris", I meant. Sorry.

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

[John Paul Adrian Glaubitz]

Hi Mikael!

On 12/16/19 8:38 PM, Mikael Vidstedt wrote:
> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. 
> The suggested change will incorrectly *not* produce a warning for 
> solaris/*/zero.
> 
> Something like this should do the trick:
> 
> if test "x$OPENJDK_TARGET_OS" = xsolaris || (test 
> "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != xzero); 
> then


Thanks for the review. As far as I remember correctly, Zero is not supported, 
is it?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

[Mikael Vidstedt]

You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. The 
suggested change will incorrectly *not* produce a warning for solaris/*/zero.

Something like this should do the trick:

if test "x$OPENJDK_TARGET_OS" = xsolaris || (test 
"x$OPENJDK_TARGET_CPU_ARCH" = xsparc && test "x$with_jvm_variants" != xzero); 
then

Cheers,
Mikael

> On Dec 15, 2019, at 3:20 AM, John Paul Adrian Glaubitz 
>  wrote:
> 
> Hi!
> 
> JDK-8234370 introduced a deprecation warning for ports that are going to be 
> removed
> in the future. The change in question checks for the target architecture and 
> operating
> system but does however does not account for the Zero variant which doesn't 
> need support
> for a specific target besides a few autonconf definitions and some #ifdef 
> magic.
> 
> This change extends the change from JDK-8234370 to additionally test whether 
> we're building
> the Zero variant. With this change, I can configure OpenJDK Zero on a 
> Linux/SPARC target
> again without getting a deprecation message.
> 
> Please review.
> 
> Thanks,
> Adrian
> 
>> [1] http://cr.openjdk.java.net/~glaubitz/8235960/webrev.00/
> 
> -- 
> .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaub...@debian.org
> `. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
>  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

RFR: 8235997: JMH test runner should quote VM_OPTIONS and JAVA_OPTIONS sent to -jvmArgs

[Claes Redestad]

Hi,

please review this patch[1] which makes the JMH behave more
in line with expectations when adding multiple flags using
the VM_OPTIONS and JAVA_OPTIONS control variables.

E.g., these fail before the patch:

make test TEST=... MICRO="VM_OPTIONS=-Xmx4g -Xms4g"
make test TEST=... MICRO="JAVA_OPTIONS=-Xmx4g -Xms4g"

Current workaround is to escape the spaces, which will fail with
the proposed patch. Substituting escaped spaces with normal
spaces seems out of scope, though.

Thanks!

/Claes

[1]

diff -r 075c1d68ae8c make/RunTests.gmk
--- a/make/RunTests.gmk Mon Dec 16 10:49:36 2019 +0100
+++ b/make/RunTests.gmk Mon Dec 16 13:32:03 2019 +0100
@@ -701,7 +701,8 @@
   endif

   ifneq ($$(MICRO_VM_OPTIONS)$$(MICRO_JAVA_OPTIONS), )
-$1_MICRO_VM_OPTIONS := -jvmArgs $$(MICRO_VM_OPTIONS) 
$$(MICRO_JAVA_OPTIONS)

+JMH_JVM_ARGS := $$(MICRO_VM_OPTIONS) $$(MICRO_JAVA_OPTIONS)
+$1_MICRO_VM_OPTIONS := -jvmArgs $(call ShellQuote,$$(JMH_JVM_ARGS))
   endif

   ifneq ($$(MICRO_ITER), )