Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]
On Fri, 24 Sep 2021 06:12:20 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Another minor touchup
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
Another minor touchup
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5615/files
- new: https://git.openjdk.java.net/jdk/pull/5615/files/efd28804..94496373
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=05
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=04-05
Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/5615.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Fri, 24 Sep 2021 05:58:09 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.html line 80: > >> 78: >> 79: tier1: This is the lowest test tier. Multiple >> developers run these tests every day. Because of the widespread use, the >> tests in tier1 are carefully selected and optimized to run >> fast, and to run in the most stable manner. The test failures in >> tier1 are usually followed up on quickly, either with fixes, or >> adding relevant tests to problem list. GitHub Actions workflows, if enabled, >> run tier1 tests. >> 80: tier2: This test group covers even more ground. >> These contain, among other things, tests that either run for too long to be >> at tier1, or may require special configuration, or tests that >> are less stable, or cover the broader range of less critical JVM and JDK >> features/components (for example, jaxp). > > Thanks for the updates, I think it reads much better now. > A small suggestion is to change "less critical" to "non-core", and "jaxp" to > "XML" as I don't expect too many people know what JAXP is. All right, changed. I'll be integrating this version soon. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by alanb (Reviewer).
doc/testing.html line 80:
> 78:
> 79: tier1: This is the lowest test tier. Multiple
> developers run these tests every day. Because of the widespread use, the
> tests in tier1 are carefully selected and optimized to run fast,
> and to run in the most stable manner. The test failures in tier1
> are usually followed up on quickly, either with fixes, or adding relevant
> tests to problem list. GitHub Actions workflows, if enabled, run
> tier1 tests.
> 80: tier2: This test group covers even more ground. These
> contain, among other things, tests that either run for too long to be at
> tier1, or may require special configuration, or tests that are
> less stable, or cover the broader range of less critical JVM and JDK
> features/components (for example, jaxp).
Thanks for the updates, I think it reads much better now.
A small suggestion is to change "less critical" to "non-core", and "jaxp" to
"XML" as I don't expect too many people know what JAXP is.
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by jiefu (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Marked as reviewed by dholmes (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution
Please review this small change that adds hook for custom makefiles to augment parameters for jtreg test execution. - Commit messages: - Initial change Changes: https://git.openjdk.java.net/jdk/pull/5666/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5666&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274170 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5666.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5666/head:pull/5666 PR: https://git.openjdk.java.net/jdk/pull/5666
Re: RFR: JDK-8274170: Add hooks for custom makefiles to augment jtreg test execution
On Thu, 23 Sep 2021 22:02:07 GMT, Mikhailo Seledtsov wrote: > Please review this small change that adds hook for custom makefiles to > augment parameters for jtreg test execution. Testing: - tested with custom make file to make sure the feature works - ran a variety of test framework combinations via make to ensure no negative side effects are introduced into this change (jtreg, jtreg with params, jtreg+gtest, jtreg+micros). See comments in RFE for details. - PR: https://git.openjdk.java.net/jdk/pull/5666
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
On Thu, 23 Sep 2021 12:53:23 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
Change looks good to me, thank you.
-
Marked as reviewed by mseledtsov (Committer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8267636: Bump minimum boot jdk to JDK 17
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639
Re: RFR: 8267636: Bump minimum boot jdk to JDK 17
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639
Re: RFR: 8267636: Bump minimum boot jdk to JDK 17
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639
RFR: 8267636: Bump minimum boot jdk to JDK 17
With the JDK 17 GA out it's time to bump the minimum boot JDK version for mainline/JDK 18. Testing: tier1-5, GHA builds - Commit messages: - 8267636: Bump minimum boot jdk to JDK 17 Changes: https://git.openjdk.java.net/jdk/pull/5639/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5639&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267636 Stats: 23 lines in 3 files changed: 0 ins; 9 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/5639.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5639/head:pull/5639 PR: https://git.openjdk.java.net/jdk/pull/5639
Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide
On 2021-09-23 15:38, David Holmes wrote: Okay but I think we need to change that for the Hotspot Style Guide. :) Sure. Open a Skara bug and specify which hotspot list should be the recipient and I can fix it. /Magnus
Integrated: 8274169: HotSpot Style Guide has stale link to chromium style guide
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote: > Update links to the chromium style guide in the HotSpot Style Guide. This pull request has now been integrated. Changeset: 1b7f4b7d Author:Liam Miller-Cushon URL: https://git.openjdk.java.net/jdk/commit/1b7f4b7dd8a6070d290875a95099780c9f060139 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8274169: HotSpot Style Guide has stale link to chromium style guide Reviewed-by: dholmes, ihse - PR: https://git.openjdk.java.net/jdk/pull/5641
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On 23/09/2021 8:33 pm, Thomas Stuefe wrote:
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
mention them in `testing.md`.
Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
I like this. Thanks for doing this (and for the actual definition of the
tiers). This hopefully makes communicating about test coverage much easier.
As I understood, tier1-3 are the same as Oracle tier1-3?
Not exactly no. Our tier definitions are tuples of (tests, platforms,
flags). The sets of tests will be close but not exactly the same.
David
-
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide
On 23/09/2021 8:53 pm, Magnus Ihse Bursie wrote: On Thu, 23 Sep 2021 02:56:05 GMT, David Holmes wrote: Update links to the chromium style guide in the HotSpot Style Guide. Update looks good and trivial. Aside: no idea why changes to these files mapped to build-dev ?? Thanks, David @dholmes-ora The build team has traditionally been shepherding the "misc" parts of the source tree, like the "docs" directory, that no other group claims responsibility for. (Also, most of the docs are related to building and testing anyway.) Okay but I think we need to change that for the Hotspot Style Guide. :) Cheers, David - PR: https://git.openjdk.java.net/jdk/pull/5641
Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]
On Thu, 23 Sep 2021 11:58:02 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 79: > >> 77: >> 78: tier1: This is the lowest test tier. Multiple >> developers run these tests every day. Normally, at least this tier should be >> clean before integration. Because of the widespread use, the tests in >> tier1 are carefully selected and optimized to run fast, and to >> run in the most stable manner. The test failures in tier1 are >> usually followed up on quickly, either with fixes, or adding relevant tests >> to problem list. GitHub Actions workflows, if enabled, run >> tier1 tests. >> 79: tier2: This test group covers even more ground. >> These contain, among other things, tests that either run for too long to be >> at tier1, tests for less stable and/or experimental features, >> tests for less essential JDK components (for example, jaxp). > > I think this a bit unfair on tier2. Tests in tier2 need be run by anyone > making changes in the security area, I/O, networking and many other core > APIs. In general I think anyone changing code in the libraries area needs to > look at TEST.groups to get some idea which tier or finer test group to run. > > I'm not sure about words like "less stable" and "experimental features". Do > we have tests for hotspot experimental features in hotspot_tier2? See new commit. > Tests in tier2 need be run by anyone making changes in the security area, > I/O, networking and many other core APIs. In general I think anyone changing > code in the libraries area needs to look at TEST.groups to get some idea > which tier or finer test group to run. True. That is why the text says that component tests come first, and then you run first N tiers to capture anything else. If any component test is not in the component test group, and only in `tier2`, I'd say that is a test grouping bug, and the test should be in component test group to begin with. In other words, `tier2` testing does not replace the component group testing, and thus the requirement to run `tier2` if particular areas are changed would feel awkward to me. > Do we have tests for hotspot experimental features in hotspot_tier2? We do move deprecating things out of `tier1` (see e.g. recent JDK-8272838). - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v5]
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5615/files
- new: https://git.openjdk.java.net/jdk/pull/5615/files/32e9b5b4..efd28804
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=03-04
Stats: 21 lines in 2 files changed: 4 ins; 2 del; 15 mod
Patch: https://git.openjdk.java.net/jdk/pull/5615.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]
On Thu, 23 Sep 2021 11:54:06 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 72: > >> 70: The test specifications given in TEST is parsed into >> fully qualified test descriptors, which clearly and unambigously show which >> tests will be run. As an example, :tier1 will expand to >> jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 >> jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1 >> jtreg:$(TOPDIR)/test/nashorn:tier1 jtreg:$(TOPDIR)/test/jaxp:tier1. >> You can always submit a list of fully qualified test descriptors in the >> TEST variable if you want to shortcut the parser. >> 71: Common Test Groups >> 72: In the ideal world, contributors would be advised to run all the >> tests for every change. But in real world, one could only be expected to run >> as many tests as practical, while being mindful of the scope for the change, >> the testing resources available, etc. > > A suggestion here is to start with something like "Ideally, all tests are run > for every change but this may not be practical. Contributors are expected to > at least run tier1 (see below) and the tests for the areas that are changed." Added a version of that, thanks. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]
On Thu, 23 Sep 2021 11:30:20 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Drop GH link
doc/testing.html line 72:
> 70: The test specifications given in TEST is parsed into
> fully qualified test descriptors, which clearly and unambigously show which
> tests will be run. As an example, :tier1 will expand to
> jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1
> jtreg:$(TOPDIR)/test/langtools:tier1 jtreg:$(TOPDIR)/test/nashorn:tier1
> jtreg:$(TOPDIR)/test/jaxp:tier1. You can always submit a list of fully
> qualified test descriptors in the TEST variable if you want to
> shortcut the parser.
> 71: Common Test Groups
> 72: In the ideal world, contributors would be advised to run all the tests
> for every change. But in real world, one could only be expected to run as
> many tests as practical, while being mindful of the scope for the change, the
> testing resources available, etc.
A suggestion here is to start with something like "Ideally, all tests are run
for every change but this may not be practical. Contributors are expected to at
least run tier1 (see below) and the tests for the areas that are changed."
doc/testing.html line 79:
> 77:
> 78: tier1: This is the lowest test tier. Multiple
> developers run these tests every day. Normally, at least this tier should be
> clean before integration. Because of the widespread use, the tests in
> tier1 are carefully selected and optimized to run fast, and to
> run in the most stable manner. The test failures in tier1 are
> usually followed up on quickly, either with fixes, or adding relevant tests
> to problem list. GitHub Actions workflows, if enabled, run tier1
> tests.
> 79: tier2: This test group covers even more ground. These
> contain, among other things, tests that either run for too long to be at
> tier1, tests for less stable and/or experimental features, tests
> for less essential JDK components (for example, jaxp).
I think this a bit unfair on tier2. Tests in tier2 need be run by anyone making
changes in the security area, I/O, networking and many other core APIs. In
general I think anyone changing code in the libraries area needs to look at
TEST.groups to get some idea which tier or finer test group to run.
I'm not sure about words like "less stable" and "experimental features". Do we
have tests for hotspot experimental features in hotspot_tier2?
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]
On Thu, 23 Sep 2021 11:30:20 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Drop GH link
Marked as reviewed by ihse (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v4]
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
Drop GH link
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5615/files
- new: https://git.openjdk.java.net/jdk/pull/5615/files/cf2bda57..32e9b5b4
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=02-03
Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/5615.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 10:56:02 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 95: > >> 93: the tests in `tier1` are carefully selected and optimized to run fast, >> and to run in the >> 94: most stable manner. The test failures in `tier1` are usually followed up >> on quickly, either >> 95: with fixes, or adding relevant tests to problem list. [GitHub Actions >> workflows](../.github/workflows/), > > I don't think the link to the `.github` directory makes sense here. If there > should be a link at all, it should point to information on how GHA works and > how to enable these. And frankly I'm not sure if any such comprehensive > documentation exists. :-( Perhaps in the Skara wiki? Otherwise the link is > just distracting. Sure, I actually put the link there very optimistically :) Dropped it in the new commit. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
I think this looks overall good. Just do something about that GHA link and I'm
perfectly happy! :)
doc/testing.md line 95:
> 93: the tests in `tier1` are carefully selected and optimized to run fast,
> and to run in the
> 94: most stable manner. The test failures in `tier1` are usually followed up
> on quickly, either
> 95: with fixes, or adding relevant tests to problem list. [GitHub Actions
> workflows](../.github/workflows/),
I don't think the link to the `.github` directory makes sense here. If there
should be a link at all, it should point to information on how GHA works and
how to enable these. And frankly I'm not sure if any such comprehensive
documentation exists. :-( Perhaps in the Skara wiki? Otherwise the link is just
distracting.
-
Changes requested by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide
On Wed, 22 Sep 2021 20:48:11 GMT, Liam Miller-Cushon wrote: > Update links to the chromium style guide in the HotSpot Style Guide. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5641
Re: RFR: 8274169: HotSpot Style Guide has stale link to chromium style guide
On Thu, 23 Sep 2021 02:56:05 GMT, David Holmes wrote: >> Update links to the chromium style guide in the HotSpot Style Guide. > > Update looks good and trivial. > > Aside: no idea why changes to these files mapped to build-dev ?? > > Thanks, > David @dholmes-ora The build team has traditionally been shepherding the "misc" parts of the source tree, like the "docs" directory, that no other group claims responsibility for. (Also, most of the docs are related to building and testing anyway.) - PR: https://git.openjdk.java.net/jdk/pull/5641
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
I like this. Thanks for doing this (and for the actual definition of the
tiers). This hopefully makes communicating about test coverage much easier.
As I understood, tier1-3 are the same as Oracle tier1-3?
-
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]
On Wed, 15 Sep 2021 19:43:45 GMT, Andrew John Hughes wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux > > You mention that "too many systems have to old a version of harfbuzz". > Is the required version defined somewhere? There's no check in configure for > either a version or a required symbol: > https://github.com/openjdk/jdk/blob/cbffecc61e4a9ac1172926ef4f20d918d73adde9/make/autoconf/lib-bundled.m4#L291 > > With undefined symbols also being left to runtime (hence why JDK-8272332 > doesn't show up during build), it seems this could lead to sporadic runtime > failures if OpenJDK is unknowingly built against a harfbuzz that is too old. @gnu-andrew Maybe I'm misunderstanding here, but if symbol lookup is done at runtime, then the failure would occur if the JDK is *run* on a system with a too old harfbuzz, not if it is *built* on it. So it seems you want runtime checks, not build-time checks, right? - PR: https://git.openjdk.java.net/jdk/pull/2982
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:37:49 GMT, Aleksey Shipilev wrote: > No, I think "every other X" puts "X" in singular form: > https://www.merriam-webster.com/dictionary/every%20other. Okay, I agree. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
LGTM.
Thanks for this kind of doc update.
-
Marked as reviewed by jiefu (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:28:29 GMT, Jie Fu wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More fixes > > doc/testing.md line 107: > >> 105: (`JTREG_KEYWORDS=\!headful`), or both. >> 106: >> 107: - `tier4`: This test group includes every other test not covered by >> previous tiers. It includes, > > `other test` => `other tests` No, I think "every other X" puts "X" in singular form: https://www.merriam-webster.com/dictionary/every%20other. - PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
On Thu, 23 Sep 2021 09:19:42 GMT, Aleksey Shipilev wrote:
>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions,
>> let's mention them in `testing.md`.
>>
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> More fixes
doc/testing.md line 107:
> 105: (`JTREG_KEYWORDS=\!headful`), or both.
> 106:
> 107: - `tier4`: This test group includes every other test not covered by
> previous tiers. It includes,
`other test` => `other tests`
-
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v3]
> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's
> mention them in `testing.md`.
>
> Current patch is my braindump, I am open for suggestions :)
Aleksey Shipilev has updated the pull request incrementally with one additional
commit since the last revision:
More fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5615/files
- new: https://git.openjdk.java.net/jdk/pull/5615/files/86cbd115..cf2bda57
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5615&range=01-02
Stats: 7 lines in 2 files changed: 1 ins; 0 del; 6 mod
Patch: https://git.openjdk.java.net/jdk/pull/5615.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5615/head:pull/5615
PR: https://git.openjdk.java.net/jdk/pull/5615
Re: RFR: 8274083: Update testing docs to mention tiered testing [v2]
On Thu, 23 Sep 2021 05:44:57 GMT, David Holmes wrote: >> Aleksey Shipilev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert accidental edit >> - More discussion > > doc/testing.html line 73: > >> 71: Common Test Groups >> 72: In the ideal world, contributors would be advised to run all the >> tests for every change. But in real world, one could only be expected to run >> as many tests as practical, while being mindful of the scope for the change, >> the testing resources available, etc. >> 73: The source tree currently defines a few common test groups in the >> relevant TEST.groups files. The test groups are either covering >> a specific component, for example hotspot_gc. It is a good idea >> to look into TEST.groups files to get a sense what tests are >> relevant to a particular JDK component. > > You state "The test groups are either ..." but there is no "or ..." in that > sentence. Thanks, see new commit. - PR: https://git.openjdk.java.net/jdk/pull/5615
Integrated: 8274048 IGV: Replace usages of Collections.sort with List.sort call
On Mon, 23 Aug 2021 20:52:22 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. This pull request has now been integrated. Changeset: 8b833bbe Author:Andrey Turbanov Committer: Christian Hagedorn URL: https://git.openjdk.java.net/jdk/commit/8b833bbea84829664f23d17c7f94c0379b48f365 Stats: 24 lines in 8 files changed: 0 ins; 2 del; 22 mod 8274048: IGV: Replace usages of Collections.sort with List.sort call Reviewed-by: chagedorn - PR: https://git.openjdk.java.net/jdk/pull/5228
