RE: jdk/jdk (+jdk12) Build failure on OSX 10.11

[Baesken, Matthias]

Hello,  it comes  from the  MacOSX SDK,  the value

NSWindow.h:61:NSWindowStyleMaskDocModalWindow   = 1 << 6,

can be found  in   MacOSX10.12.sdk   andMacOSX10.13.sdk  .
From the info I found here :

https://en.wikipedia.org/wiki/Xcode#Xcode_7.0_-_11.x_(since_Free_On-Device_Development)

XCode 8 and higher   come with at least   MacOSX  SDK   10.12  .
So checking for  the Xcode version might make more sense .


Best regards, Matthias


> -Original Message-
> From: Erik Joelsson 
> Sent: Mittwoch, 19. Juni 2019 19:30
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' 
> Cc: Schuenemann, Rene 
> Subject: Re: jdk/jdk (+jdk12) Build failure on OSX 10.11
> 
> Are you sure it's 10.11 that is the problem and not the version of Xcode?
> 
> /Erik
> 
> On 2019-06-19 00:51, Baesken, Matthias wrote:
> > Hello,  I noticed that we fail  on OSX 10.11  in the build   .  Reason is  
> > that
> NSWindowStyleMaskDocModalWindow  is used since :
> >
> > https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189
> >
> > 8208543: [macos] Support for apple.awt.documentModalSheet incomplete
> >
> > Which is 10.12+ functionality . See
> >
> >
> https://developer.apple.com/documentation/appkit/nswindowstylemask/n
> swindowstylemaskdocmodalwindow?language=objc
> >
> > NSWindowStyleMaskDocModalWindow
> > The window is a document-modal panel (or a subclass of
> NSPanel<https://developer.apple.com/documentation/appkit/nspanel?lang
> uage=objc>).
> > macOS 10.12+
> >
> >
> >
> > I would prefer to test for  minimum  10.12  already  in  configure  , what 
> > do
> you think ?
> >
> > Best regards, Matthias
> >

Re: jdk/jdk (+jdk12) Build failure on OSX 10.11

[Erik Joelsson]

Are you sure it's 10.11 that is the problem and not the version of Xcode?

/Erik

On 2019-06-19 00:51, Baesken, Matthias wrote:

Hello,  I noticed that we fail  on OSX 10.11  in the build   .  Reason is  that 
  NSWindowStyleMaskDocModalWindow  is used since :

https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189

8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Which is 10.12+ functionality . See

https://developer.apple.com/documentation/appkit/nswindowstylemask/nswindowstylemaskdocmodalwindow?language=objc

NSWindowStyleMaskDocModalWindow
The window is a document-modal panel (or a subclass of 
NSPanel).
macOS 10.12+



I would prefer to test for  minimum  10.12  already  in  configure  , what do 
you think ?

Best regards, Matthias

RE: jdk/jdk (+jdk12) Build failure on OSX 10.11

[Baesken, Matthias]

We could add a check  for  the existing OS_VERSION_MAJOR  variable   ,   this 
shows the kernel version but from my understanding the  kernel  to OSX mapping 
is pretty stable
e.g.  something like :


diff -r 7cf925f385fe make/autoconf/toolchain.m4
--- a/make/autoconf/toolchain.m4Wed Jun 19 08:43:23 2019 +0200
+++ b/make/autoconf/toolchain.m4Wed Jun 19 13:28:37 2019 +0200
@@ -224,6 +224,11 @@
   VALID_TOOLCHAINS=${!toolchain_var_name}
   if test "x$OPENJDK_TARGET_OS" = xmacosx; then
+# check for min. OSX 10.12 (kernel version 16.X from uname)
+if test $OS_VERSION_MAJOR -lt 16; then
+  AC_MSG_ERROR([OSX version 10.12 / kernel version 16 or higher is 
required])
+fi
+
 if test -n "$XCODEBUILD"; then
   # On Mac OS X, default toolchain to clang after Xcode 5
   XCODE_VERSION_OUTPUT=`"$XCODEBUILD" -version 2>&1 | $HEAD -n 1`


(  or  use  the  sw_vers command  and check the output

sw_vers -productVersion
10.12.6

)

What do you think ?


Best regards, Matthias


From: Baesken, Matthias
Sent: Mittwoch, 19. Juni 2019 09:51
To: 'build-dev@openjdk.java.net' 
Cc: Schuenemann, Rene 
Subject: jdk/jdk (+jdk12) Build failure on OSX 10.11

Hello,  I noticed that we fail  on OSX 10.11  in the build   .  Reason is  that 
  NSWindowStyleMaskDocModalWindow  is used since :

https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189

8208543: [macos] Support for apple.awt.documentModalSheet incomplete

Which is 10.12+ functionality . See

https://developer.apple.com/documentation/appkit/nswindowstylemask/nswindowstylemaskdocmodalwindow?language=objc

NSWindowStyleMaskDocModalWindow
The window is a document-modal panel (or a subclass of 
NSPanel).
macOS 10.12+



I would prefer to test for  minimum  10.12  already  in  configure  , what do 
you think ?

Best regards, Matthias