Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-06-07 Thread Leonid Mesnik 

Thank you for review.

Leonid

On 07.06.2016 12:32, David Holmes wrote:

On 7/06/2016 7:03 PM, Leonid Mesnik wrote:

Hi

The testset hotspot is not affected by this change. It run c2 only on
windows/linux-x86.


Right -sorry - I forgot we already ripped out client testing in 8153071.

All good.

Thanks,
David


I verified that default target and pit has same results and similar time
as before my fix.

Leonid

On 27.05.2016 01:09, David Holmes wrote:

Hi Leonid,

On 27/05/2016 5:00 AM, Leonid Mesnik wrote:

Dear All

Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/

http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/

The client jvm is removed from linux-x86 and windows-x86 profiles. The
linux-x86 currently includes minimal and server VM.  The server VM is
used by default.
The test targets has been updated to test server for this profiles.


The changes look to do what they intended.

However I have a couple of concerns.

In places we are now testing with C2 on 32-bit rather than C1 - do we
know how that might affect the test runs in terms of execution time
and resource usage? I don't want to see a swag of new OOM failures or
timeouts.

I'm doubly concerned by the windows changes as we previously only
focussed on client for 32-bit, and now we only do server.

Thanks,
David


Leonid

On 21.04.2016 09:23, Leonid Mesnik wrote:

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html 



 





Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html 



 





213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace
it with c2? (Same for line 298)

Leonid

hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/ 





Incremental webrevs (from webrev.01):

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/ 




hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using
client also?

http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties 





line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM
from the default JIB build profile on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/ 






When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At 
some
point in the future we may choose to output a warning and/or 
refuse

to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client
VM on windows-x86. Since -client will fall back on -server that is
no longer true, so the test needs to be updated. I added an 
@ignore

and filed the following issue to track fixing the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist 
helped
me run the runtime nightly tests and apart from the above 
mentioned

test all tests were successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-06-07 Thread David Holmes 

On 7/06/2016 7:03 PM, Leonid Mesnik wrote:

Hi

The testset hotspot is not affected by this change. It run c2 only on
windows/linux-x86.


Right -sorry - I forgot we already ripped out client testing in 8153071.

All good.

Thanks,
David


I verified that default target and pit has same results and similar time
as before my fix.

Leonid

On 27.05.2016 01:09, David Holmes wrote:

Hi Leonid,

On 27/05/2016 5:00 AM, Leonid Mesnik wrote:

Dear All

Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/

http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/

The client jvm is removed from linux-x86 and windows-x86 profiles. The
linux-x86 currently includes minimal and server VM.  The server VM is
used by default.
The test targets has been updated to test server for this profiles.


The changes look to do what they intended.

However I have a couple of concerns.

In places we are now testing with C2 on 32-bit rather than C1 - do we
know how that might affect the test runs in terms of execution time
and resource usage? I don't want to see a swag of new OOM failures or
timeouts.

I'm doubly concerned by the windows changes as we previously only
focussed on client for 32-bit, and now we only do server.

Thanks,
David


Leonid

On 21.04.2016 09:23, Leonid Mesnik wrote:

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html





Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html





213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace
it with c2? (Same for line 298)

Leonid

hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/



Incremental webrevs (from webrev.01):

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/


hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using
client also?

http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties



line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM
from the default JIB build profile on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/




When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At some
point in the future we may choose to output a warning and/or refuse
to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client
VM on windows-x86. Since -client will fall back on -server that is
no longer true, so the test needs to be updated. I added an @ignore
and filed the following issue to track fixing the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped
me run the runtime nightly tests and apart from the above mentioned
test all tests were successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-06-07 Thread Leonid Mesnik 

Hi

The testset hotspot is not affected by this change. It run c2 only on 
windows/linux-x86.


I verified that default target and pit has same results and similar time 
as before my fix.


Leonid

On 27.05.2016 01:09, David Holmes wrote:

Hi Leonid,

On 27/05/2016 5:00 AM, Leonid Mesnik wrote:

Dear All

Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/

http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/

The client jvm is removed from linux-x86 and windows-x86 profiles. The
linux-x86 currently includes minimal and server VM.  The server VM is
used by default.
The test targets has been updated to test server for this profiles.


The changes look to do what they intended.

However I have a couple of concerns.

In places we are now testing with C2 on 32-bit rather than C1 - do we 
know how that might affect the test runs in terms of execution time 
and resource usage? I don't want to see a swag of new OOM failures or 
timeouts.


I'm doubly concerned by the windows changes as we previously only 
focussed on client for 32-bit, and now we only do server.


Thanks,
David


Leonid

On 21.04.2016 09:23, Leonid Mesnik wrote:

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html 

 




Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html 

 




213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace
it with c2? (Same for line 298)

Leonid

hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/ 




Incremental webrevs (from webrev.01):

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/ 



hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using
client also?

http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties 




line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM
from the default JIB build profile on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/ 





When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At some
point in the future we may choose to output a warning and/or refuse
to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client
VM on windows-x86. Since -client will fall back on -server that is
no longer true, so the test needs to be updated. I added an @ignore
and filed the following issue to track fixing the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped
me run the runtime nightly tests and apart from the above mentioned
test all tests were successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-05-26 Thread David Holmes 

Hi Leonid,

On 27/05/2016 5:00 AM, Leonid Mesnik wrote:

Dear All

Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/

http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/

The client jvm is removed from linux-x86 and windows-x86 profiles. The
linux-x86 currently includes minimal and server VM.  The server VM is
used by default.
The test targets has been updated to test server for this profiles.


The changes look to do what they intended.

However I have a couple of concerns.

In places we are now testing with C2 on 32-bit rather than C1 - do we 
know how that might affect the test runs in terms of execution time and 
resource usage? I don't want to see a swag of new OOM failures or timeouts.


I'm doubly concerned by the windows changes as we previously only 
focussed on client for 32-bit, and now we only do server.


Thanks,
David


Leonid

On 21.04.2016 09:23, Leonid Mesnik wrote:

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html



Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html



213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace
it with c2? (Same for line 298)

Leonid

hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/


Incremental webrevs (from webrev.01):

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/

hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using
client also?

http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties


line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM
from the default JIB build profile on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At some
point in the future we may choose to output a warning and/or refuse
to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client
VM on windows-x86. Since -client will fall back on -server that is
no longer true, so the test needs to be updated. I added an @ignore
and filed the following issue to track fixing the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped
me run the runtime nightly tests and apart from the above mentioned
test all tests were successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-05-26 Thread Leonid Mesnik 

Dear All

Please find updated webrev for this fix here:
http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/hotspot/ 


http://cr.openjdk.java.net/~lmesnik/8154209/webrev.00/root/

The client jvm is removed from linux-x86 and windows-x86 profiles. The 
linux-x86 currently includes minimal and server VM.  The server VM is 
used by default.

The test targets has been updated to test server for this profiles.

Leonid

On 21.04.2016 09:23, Leonid Mesnik wrote:

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html 
 



Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html 
 



213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace 
it with c2? (Same for line 298)


Leonid
hotspot: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/


Incremental webrevs (from webrev.01):

top: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/

hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using 
client also?


http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties 



line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM 
from the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically 
creates a jvm.cfg which makes -client an alias for -server. At some 
point in the future we may choose to output a warning and/or refuse 
to start up if -client is specified, but at least for now silently 
falling back on the -server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client 
VM on windows-x86. Since -client will fall back on -server that is 
no longer true, so the test needs to be updated. I added an @ignore 
and filed the following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped 
me run the runtime nightly tests and apart from the above mentioned 
test all tests were successful.


Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-21 Thread David Holmes 

On 21/04/2016 7:41 AM, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top: http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/


Minor nit - jib-profiles.js:

! configure_args_32bit: ["--with-target-bits=32", 
"--with-jvm-variants=server"],


I think server is the default for jvm_variant - hence no configure_args 
for 64-bit - so this can be elided.



jprt.properties: I agree with Leonid that the c1 testing should be 
converted to c2 testing, not just removed. Of course we then need to see 
if those test sets run reliably with server on the 32-bit platforms.



hotspot:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/


Ignoring is simplest option for now.

David



Incremental webrevs (from webrev.01):

top:
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/
hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using
client also?

http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties

line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM from
the default JIB build profile on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot):
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically
creates a jvm.cfg which makes -client an alias for -server. At some
point in the future we may choose to output a warning and/or refuse
to start up if -client is specified, but at least for now silently
falling back on the -server VM seems appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
assumes that CDS is always compiled in and enabled in the -client VM
on windows-x86. Since -client will fall back on -server that is no
longer true, so the test needs to be updated. I added an @ignore and
filed the following issue to track fixing the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped
me run the runtime nightly tests and apart from the above mentioned
test all tests were successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-21 Thread Leonid Mesnik 

Mikael

On 21.04.2016 00:41, Mikael Vidstedt wrote:


Good catch. Updated webrevs here:

top: http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/common/conf/jib-profiles.js.udiff.html 



Couldn't be

*"--with-jvm-variants=client,server"*

just completely removed now as for all 64bit profiles?

http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/make/jprt.properties.sdiff.html 



213 windows_i586_6.3-product-c1-TESTNAME, \

I see that you just remove C1 testing. Wouldn't be better to replace it 
with c2? (Same for line 298)


Leonid
hotspot: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/


Incremental webrevs (from webrev.01):

top: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/

hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using 
client also?


http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties

line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM 
from the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically 
creates a jvm.cfg which makes -client an alias for -server. At some 
point in the future we may choose to output a warning and/or refuse 
to start up if -client is specified, but at least for now silently 
falling back on the -server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client VM 
on windows-x86. Since -client will fall back on -server that is no 
longer true, so the test needs to be updated. I added an @ignore and 
filed the following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped 
me run the runtime nightly tests and apart from the above mentioned 
test all tests were successful.


Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-20 Thread Mikael Vidstedt 


Good catch. Updated webrevs here:

top: http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/webrev/
hotspot: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/


Incremental webrevs (from webrev.01):

top: 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/

hotspot: N/A (same as webrev.01)

Cheers,
Mikael

On 4/18/2016 12:52 AM, Leonid Mesnik wrote:

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using 
client also?


http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties

line 206 - 214
# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME

and
line 294-299
# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE

Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM from 
the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically 
creates a jvm.cfg which makes -client an alias for -server. At some 
point in the future we may choose to output a warning and/or refuse 
to start up if -client is specified, but at least for now silently 
falling back on the -server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client VM 
on windows-x86. Since -client will fall back on -server that is no 
longer true, so the test needs to be updated. I added an @ignore and 
filed the following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped 
me run the runtime nightly tests and apart from the above mentioned 
test all tests were successful.


Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-20 Thread Leonid Mesnik 

Hi


Shouldn't be jprt targets in jprt.properties updates to stop using 
client also?


http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties

line 206 - 214


# Test target list (no fastdebug & limited c2 testing)
my.test.target.set= \
solaris_sparcv9_5.11-product-c2-TESTNAME, \
solaris_x64_5.11-product-c2-TESTNAME, \
linux_i586_3.8-product-{c1|c2}-TESTNAME, \
linux_x64_3.8-product-c2-TESTNAME, \
macosx_x64_10.9-product-c2-TESTNAME, \
windows_i586_6.3-product-c1-TESTNAME, \
windows_x64_6.3-product-c2-TESTNAME


and
line 294-299


# JCK test targets in test/Makefile (no windows)
my.test.target.set.jck= \
solaris_sparcv9_5.11-product-c2-JCK7TESTRULE, \
solaris_x64_5.11-product-c2-JCK7TESTRULE, \
linux_i586_3.8-product-c1-JCK7TESTRULE, \
linux_x64_3.8-product-c2-JCK7TESTRULE


Leonid

On 14.04.2016 19:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM from 
the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically 
creates a jvm.cfg which makes -client an alias for -server. At some 
point in the future we may choose to output a warning and/or refuse to 
start up if -client is specified, but at least for now silently 
falling back on the -server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client VM 
on windows-x86. Since -client will fall back on -server that is no 
longer true, so the test needs to be updated. I added an @ignore and 
filed the following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped me 
run the runtime nightly tests and apart from the above mentioned test 
all tests were successful.


Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-15 Thread Erik Joelsson 



On 2016-04-14 19:20, Christian Thalinger wrote:

On Apr 14, 2016, at 6:41 AM, Mikael Vidstedt  wrote:


Please review the following change which removes the "client" VM from the 
default JIB build profile

Is there some public documentation about JIB?  A quick search only showed a few 
JBS bugs that mention JIB.
No, Jib is an Oracle internal tool, just like JPRT. But, just as we need 
a JPRT configuration in the open repo, we also need a Jib configuration 
in the open repo. Otherwise we cannot build and test open only forests 
internally.


/Erik

on windows-x86 and linux-x86:

Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/


When not including the client VM, the build system automatically creates a 
jvm.cfg which makes -client an alias for -server. At some point in the future 
we may choose to output a warning and/or refuse to start up if -client is 
specified, but at least for now silently falling back on the -server VM seems 
appropriate.

The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test assumes that 
CDS is always compiled in and enabled in the -client VM on windows-x86. Since 
-client will fall back on -server that is no longer true, so the test needs to 
be updated. I added an @ignore and filed the following issue to track fixing 
the test:

https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped me run the 
runtime nightly tests and apart from the above mentioned test all tests were 
successful.

Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-15 Thread Erik Joelsson 

Looks good to me.

/Erik

On 2016-04-14 18:41, Mikael Vidstedt wrote:


Please review the following change which removes the "client" VM from 
the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically 
creates a jvm.cfg which makes -client an alias for -server. At some 
point in the future we may choose to output a warning and/or refuse to 
start up if -client is specified, but at least for now silently 
falling back on the -server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client VM 
on windows-x86. Since -client will fall back on -server that is no 
longer true, so the test needs to be updated. I added an @ignore and 
filed the following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped me 
run the runtime nightly tests and apart from the above mentioned test 
all tests were successful.


Cheers,
Mikael

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-14 Thread Christian Thalinger 

> On Apr 14, 2016, at 6:41 AM, Mikael Vidstedt  
> wrote:
> 
> 
> Please review the following change which removes the "client" VM from the 
> default JIB build profile

Is there some public documentation about JIB?  A quick search only showed a few 
JBS bugs that mention JIB.

> on windows-x86 and linux-x86:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
> Webrev (top): http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
> Webrev (hotspot): 
> http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/
> 
> 
> When not including the client VM, the build system automatically creates a 
> jvm.cfg which makes -client an alias for -server. At some point in the future 
> we may choose to output a warning and/or refuse to start up if -client is 
> specified, but at least for now silently falling back on the -server VM seems 
> appropriate.
> 
> The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test assumes 
> that CDS is always compiled in and enabled in the -client VM on windows-x86. 
> Since -client will fall back on -server that is no longer true, so the test 
> needs to be updated. I added an @ignore and filed the following issue to 
> track fixing the test:
> 
> https://bugs.openjdk.java.net/browse/JDK-8154204
> 
> 
> Testing:
> 
> In addition to a standard JPRT push job, Christian Tornqvist helped me run 
> the runtime nightly tests and apart from the above mentioned test all tests 
> were successful.
> 
> Cheers,
> Mikael
>

RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

2016-04-14 Thread Mikael Vidstedt 


Please review the following change which removes the "client" VM from 
the default JIB build profile on windows-x86 and linux-x86:


Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
Webrev (top): http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/
Webrev (hotspot): 
http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.01/hotspot/webrev/



When not including the client VM, the build system automatically creates 
a jvm.cfg which makes -client an alias for -server. At some point in the 
future we may choose to output a warning and/or refuse to start up if 
-client is specified, but at least for now silently falling back on the 
-server VM seems appropriate.


The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test 
assumes that CDS is always compiled in and enabled in the -client VM on 
windows-x86. Since -client will fall back on -server that is no longer 
true, so the test needs to be updated. I added an @ignore and filed the 
following issue to track fixing the test:


https://bugs.openjdk.java.net/browse/JDK-8154204


Testing:

In addition to a standard JPRT push job, Christian Tornqvist helped me 
run the runtime nightly tests and apart from the above mentioned test 
all tests were successful.


Cheers,
Mikael