Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-17 Thread John Paul Adrian Glaubitz
Hi Magnus!

On 04/10/2018 10:01 PM, Magnus Ihse Bursie wrote:
> The regression you noted was not caused by JDK-8201236, but by JDK-8198862 
> "Stop doing funky compilation stuff for dtrace". In fact, JDK-8201236 (which 
> is
> pushed to jdk/jdk but not yet integrated into jdk/hs, apparently) will once 
> again remove EXTRA_FILES from the SetupNativeCompilation, making zero work 
> again.
> 
> So if you just wait until JDK-8201236 moves into jdk/hs, this will be fixed. 
> Otherwise, you're just creating a merge conflict for the integrator. :(

Since the jdk/jdk and jdk/hs merge was finished today, I gave Zero on 
linux-sparc
another shot and lo and behold, it builds fine again :-).

Will update the bug report accordingly.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz

Hi Magnus!

On 04/10/2018 10:01 PM, Magnus Ihse Bursie wrote:

The regression you noted was not caused by JDK-8201236, but by JDK-8198862 "Stop 
doing funky compilation stuff for dtrace". In fact, JDK-8201236 (which is pushed to 
jdk/jdk but not yet integrated into jdk/hs, apparently) will once again remove 
EXTRA_FILES from the SetupNativeCompilation, making zero work again.


Ok, so I will update the bug report title accordingly.


So if you just wait until JDK-8201236 moves into jdk/hs, this will be fixed. 
Otherwise, you're just creating a merge conflict for the integrator. :(


Ah, even better. I don't mind waiting then and in the meantime continue
investigating on the other SPARC stuff.

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Magnus Ihse Bursie

On 2018-04-10 20:22, John Paul Adrian Glaubitz wrote:

Hi!

Please review this minor change which fixes the Zero build on linux-sparc
which got broken after "JDK-8201236 Straighten out dtrace build logic".
While I agree that the fix solves your problems, maybe you could delay 
pushing this for a while?


The regression you noted was not caused by JDK-8201236, but by 
JDK-8198862 "Stop doing funky compilation stuff for dtrace". In fact, 
JDK-8201236 (which is pushed to jdk/jdk but not yet integrated into 
jdk/hs, apparently) will once again remove EXTRA_FILES from the 
SetupNativeCompilation, making zero work again.


So if you just wait until JDK-8201236 moves into jdk/hs, this will be 
fixed. Otherwise, you're just creating a merge conflict for the 
integrator. :(


/Magnus

The change affects the Zero build on linux-sparc only since SPARC has its
own implementation of memset_with_concurrent_readers() in memset_with_\
concurrent_readers_sparc.cpp which needs to be added to $(EXTRA_FILES)
by adding $(BUILD_LIBJVM_EXTRA_FILES) to $(EXTRA_FILES).

Thanks,
Adrian


[1] http://cr.openjdk.java.net/~glaubitz/8201360/webrev.00/






Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz

On 04/10/2018 08:51 PM, Gary Adams wrote:

Is any update needed for EXTRA_OBJECT_FILES?


No. I just made the single change Erik suggested and it builds fine for me.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Gary Adams

Is any update needed for EXTRA_OBJECT_FILES?

On 4/10/18, 2:32 PM, Erik Joelsson wrote:

Looks good.

/Erik


On 2018-04-10 11:22, John Paul Adrian Glaubitz wrote:

Hi!

Please review this minor change which fixes the Zero build on 
linux-sparc

which got broken after "JDK-8201236 Straighten out dtrace build logic".

The change affects the Zero build on linux-sparc only since SPARC has 
its

own implementation of memset_with_concurrent_readers() in memset_with_\
concurrent_readers_sparc.cpp which needs to be added to $(EXTRA_FILES)
by adding $(BUILD_LIBJVM_EXTRA_FILES) to $(EXTRA_FILES).

Thanks,
Adrian


[1] http://cr.openjdk.java.net/~glaubitz/8201360/webrev.00/








Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Erik Joelsson

Looks good.

/Erik


On 2018-04-10 11:22, John Paul Adrian Glaubitz wrote:

Hi!

Please review this minor change which fixes the Zero build on linux-sparc
which got broken after "JDK-8201236 Straighten out dtrace build logic".

The change affects the Zero build on linux-sparc only since SPARC has its
own implementation of memset_with_concurrent_readers() in memset_with_\
concurrent_readers_sparc.cpp which needs to be added to $(EXTRA_FILES)
by adding $(BUILD_LIBJVM_EXTRA_FILES) to $(EXTRA_FILES).

Thanks,
Adrian


[1] http://cr.openjdk.java.net/~glaubitz/8201360/webrev.00/






RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz

Hi!

Please review this minor change which fixes the Zero build on linux-sparc
which got broken after "JDK-8201236 Straighten out dtrace build logic".

The change affects the Zero build on linux-sparc only since SPARC has its
own implementation of memset_with_concurrent_readers() in memset_with_\
concurrent_readers_sparc.cpp which needs to be added to $(EXTRA_FILES)
by adding $(BUILD_LIBJVM_EXTRA_FILES) to $(EXTRA_FILES).

Thanks,
Adrian


[1] http://cr.openjdk.java.net/~glaubitz/8201360/webrev.00/


--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913