Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Hi, Whatever the name you come up, could you please also update stringDedup.inline.hpp to use the same names? Thomas Schatzl pointed out the inconsistent, I made change to use S and Q, but apparently, I messed up in final patch. Otherwise, looks good to me too. -Zhengyu On 06/15/2018 06:36 AM, Thomas Stüfe wrote: Hi Matthias, Good catch. Patch for me is good if you guys agree on a good uncommon name. Gruß Thomas On Fri, Jun 15, 2018, 09:48 Baesken, Matthias wrote: Please review this small change that fixes the AIX build after "8203641: Refactor String Deduplication into shared". We are getting this compilation error : /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected. Looks like the name of the second template parameter (STAT) template static void initialize_impl(); is clashing with defines from the AIX system headers (where I find #define STAT 1 ) . Renaming STAT to something else fixes the build on AIX . Webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ Bug : https://bugs.openjdk.java.net/browse/JDK-8205091 Thanks, Matthias
Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Hi Matthias, the name SI seems also quite "common" and may result in other naming clashes in the future. Maybe something more readable like STAT_IMPL? Please also change the name in the comment: // STAT: String Dedup Stat implementation Regards, Rene On Fri, Jun 15, 2018 at 9:47 AM, Baesken, Matthias wrote: > Please review this small change that fixes the AIX build after "8203641: > Refactor String Deduplication into shared". > > We are getting this compilation error : > /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", > line 107.38: 1540-0063 (S) The text "1" is unexpected. > > > Looks like the name of the second template parameter (STAT) > > template > static void initialize_impl(); > > is clashing with defines from the AIX system headers (where I find #define > STAT 1 ) . > Renaming STAT to something else fixes the build on AIX . > > Webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8205091 > > > Thanks, Matthias
Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Hi Matthias, Good catch. Patch for me is good if you guys agree on a good uncommon name. Gruß Thomas On Fri, Jun 15, 2018, 09:48 Baesken, Matthias wrote: > Please review this small change that fixes the AIX build after > "8203641: Refactor String Deduplication into shared". > > We are getting this compilation error : > /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", > line 107.38: 1540-0063 (S) The text "1" is unexpected. > > > Looks like the name of the second template parameter (STAT) > > template > static void initialize_impl(); > > is clashing with defines from the AIX system headers (where I find > #define STAT 1 ) . > Renaming STAT to something else fixes the build on AIX . > > Webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8205091 > > > Thanks, Matthias >
RE: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Hi , thanks for looking into it. I think I will use STAT_IMPL . Best regards, Matthias > -Original Message- > From: René Schünemann [mailto:rene.schuenem...@gmail.com] > Sent: Freitag, 15. Juni 2018 11:08 > To: Baesken, Matthias > Cc: build-dev@openjdk.java.net; hotspot-...@openjdk.java.net > Subject: Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: > Refactor > String Deduplication into shared > > Hi Matthias, > > the name SI seems also quite "common" and may result in other naming > clashes in the future. > Maybe something more readable like STAT_IMPL? > > Please also change the name in the comment: > > // STAT: String Dedup Stat implementation > > Regards, > Rene > > On Fri, Jun 15, 2018 at 9:47 AM, Baesken, Matthias > wrote: > > Please review this small change that fixes the AIX build after "8203641: > Refactor String Deduplication into shared". > > > > We are getting this compilation error : > > > /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stri > ngDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected. > > > > > > Looks like the name of the second template parameter (STAT) > > > > template > > static void initialize_impl(); > > > > is clashing with defines from the AIX system headers (where I find #define > STAT 1 ) . > > Renaming STAT to something else fixes the build on AIX . > > > > Webrev : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ > > > > Bug : > > > > https://bugs.openjdk.java.net/browse/JDK-8205091 > > > > > > Thanks, Matthias
Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Hi Mattias, the change looks good. Could you please also update the comment in the line above which still reads "STAT". Also, maybe "STATI" would be a better name choice (longer is better :) because the probability of a clash is lower (and it would nicely align with QUEUE in the comments :) But I leave that up to you... Regards, Volker On Fri, Jun 15, 2018 at 9:47 AM, Baesken, Matthias wrote: > Please review this small change that fixes the AIX build after "8203641: > Refactor String Deduplication into shared". > > We are getting this compilation error : > /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", > line 107.38: 1540-0063 (S) The text "1" is unexpected. > > > Looks like the name of the second template parameter (STAT) > > template > static void initialize_impl(); > > is clashing with defines from the AIX system headers (where I find #define > STAT 1 ) . > Renaming STAT to something else fixes the build on AIX . > > Webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ > > Bug : > > https://bugs.openjdk.java.net/browse/JDK-8205091 > > > Thanks, Matthias
RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared
Please review this small change that fixes the AIX build after "8203641: Refactor String Deduplication into shared". We are getting this compilation error : /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected. Looks like the name of the second template parameter (STAT) template static void initialize_impl(); is clashing with defines from the AIX system headers (where I find #define STAT 1 ) . Renaming STAT to something else fixes the build on AIX . Webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/ Bug : https://bugs.openjdk.java.net/browse/JDK-8205091 Thanks, Matthias
